139826 2014-12-19 12:03:03 -0800 REGRESSION (177368): Some tests started to immediately time out 2014-12-19 15:28:15 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=96741 P2 Normal --- 1 ap ap cdumez dbates koivisto oldest_to_newest 1057126 0 ap 2014-12-19 12:03:03 -0800 fast/repaint/no-animation-outside-viewport-subframe.html has started to frequently fail on December 16. It's not a true failure, but a problem anyway. For some reason, waitUntilDone watchdog timer fires almost immediately - logs say that the test timed out, but also that it only took 0.1 second! https://build.webkit.org/builders/Apple%20Mavericks%20Release%20WK2%20(Tests)/builds/10221/steps/layout-test/logs/stdio 11:28:23.653 74860 Tests that timed out or crashed: ... 11:28:23.654 74860 fast/repaint/no-animation-outside-viewport-subframe.html took 0.1 seconds 1057130 1 cdumez 2014-12-19 12:13:11 -0800 Antti wrote this test, maybe he has an idea. 1057132 2 ap 2014-12-19 12:14:52 -0800 This looks like a problem with deeper WebCore or DumpRenderTree machinery, like DOM timers being broken. 1057140 3 ap 2014-12-19 12:46:23 -0800 This happens on other tests too, just happened for the first time on fast/text/international/lang-sensitive-fonts-xml.xhtml. So far, looks like WebKit2 only. 1057165 4 ap 2014-12-19 13:45:59 -0800 My theory is that this is some deficiency in WebKitTestRunner watchdog timer behavior, we might leak it across tests. Looking into this. 1057177 5 ap 2014-12-19 14:40:54 -0800 The reason why this regressed is that I unskipped a test that breaks a consequent test 30 seconds later! 1057181 6 243579 ap 2014-12-19 14:50:37 -0800 Created attachment 243579 proposed fix 1057182 7 243579 dbates 2014-12-19 14:54:07 -0800 Comment on attachment 243579 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=243579&action=review > Tools/WebKitTestRunner/InjectedBundle/TestRunner.cpp:165 > + // than to let webkitpy do that, becasue WebKitTestRunner will dump partial results. Nit: ", because" => because 1057183 8 dbates 2014-12-19 14:57:13 -0800 Do we need something similar for DumpRenderTree? 1057190 9 ap 2014-12-19 15:25:06 -0800 > Do we need something similar for DumpRenderTree? I'm checking that. It looks like the bug exists there too, but it's much less of a problem due to the timer being a global. 1057193 10 ap 2014-12-19 15:26:06 -0800 Committed <http://trac.webkit.org/r177598>. 1057195 11 ap 2014-12-19 15:28:15 -0800 Actually, DumpRenderTree seems fine, we always go through dumpTestResults() there. 243579 2014-12-19 14:50:37 -0800 2014-12-19 14:54:07 -0800 proposed fix ImmediateTimeout.txt text/plain 4644 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzU5NykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE4IEBACisyMDE0LTEyLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIFJFR1JFU1NJT04gKDE3NzM2OCk6IFNvbWUgdGVzdHMgc3RhcnRlZCB0byBp bW1lZGlhdGVseSB0aW1lIG91dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM5ODI2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBXZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVjdGVkQnVu ZGxlLmNwcDogKFdUUjo6SW5qZWN0ZWRCdW5kbGU6OmRvbmUpOgorICAgICAgICAqIFdlYktpdFRl c3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdlLmNwcDogKFdUUjo6SW5q ZWN0ZWRCdW5kbGVQYWdlOjpkdW1wKToKKyAgICAgICAgTW92ZSBpbnZhbGlkYXRlV2FpdFRvRHVt cFdhdGNoZG9nVGltZXIoKSBjYWxsIGZyb20gZHVtcCgpIHRvIGRvbmUoKS4gV2hlbiBhIHRlc3QK KyAgICAgICAgZW5kcyBpbiBhIGxvYWQgZmFpbHVyZSwgd2UgZG9uJ3QgZHVtcCwgc28gd2UgdXNl ZCB0byBsZWFrIHRoZSB0aW1lci4KKyAgICAgICAgCisgICAgICAgICogV2ViS2l0VGVzdFJ1bm5l ci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcDogKFdUUjo6VGVzdFJ1bm5lcjo6bm90aWZ5 RG9uZSk6CisgICAgICAgIEFkZGVkIGEgY29tbWVudC4KKwogMjAxNC0xMi0xOSAgQnJlbnQgRnVs Z2hhbSAgPGJmdWxnaGFtQGFwcGxlLmNvbT4KIAogICAgICAgICBbV2luXSBBZGQgYWNjZXNzb3Ig Zm9yIHNlcmlhbGl6aW5nIEhUVFAgbG9hZHMKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIv SW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL1dl YktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGUuY3BwCShyZXZpc2lv biAxNzc1ODkpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL0luamVj dGVkQnVuZGxlLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjg5LDYgKzI4OSw4IEBAIHZvaWQgSW5q ZWN0ZWRCdW5kbGU6OmRvbmUoKQogICAgIHBhZ2UoKS0+c3RvcExvYWRpbmcoKTsKICAgICBzZXRU b3BMb2FkaW5nRnJhbWUoMCk7CiAKKyAgICBtX3Rlc3RSdW5uZXItPmludmFsaWRhdGVXYWl0VG9E dW1wV2F0Y2hkb2dUaW1lcigpOworCiAgICAgbV9hY2Nlc3NpYmlsaXR5Q29udHJvbGxlci0+cmVz ZXRUb0NvbnNpc3RlbnRTdGF0ZSgpOwogCiAgICAgV0tSZXRhaW5QdHI8V0tTdHJpbmdSZWY+IGRv bmVNZXNzYWdlTmFtZShBZG9wdFdLLCBXS1N0cmluZ0NyZWF0ZVdpdGhVVEY4Q1N0cmluZygiRG9u ZSIpKTsKSW5kZXg6IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0 ZWRCdW5kbGVQYWdlLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0lu amVjdGVkQnVuZGxlL0luamVjdGVkQnVuZGxlUGFnZS5jcHAJKHJldmlzaW9uIDE3NzU4OSkKKysr IFRvb2xzL1dlYktpdFRlc3RSdW5uZXIvSW5qZWN0ZWRCdW5kbGUvSW5qZWN0ZWRCdW5kbGVQYWdl LmNwcAkod29ya2luZyBjb3B5KQpAQCAtODM2LDggKzgzNiw2IEBAIHZvaWQgSW5qZWN0ZWRCdW5k bGVQYWdlOjpkdW1wKCkKIHsKICAgICBBU1NFUlQoSW5qZWN0ZWRCdW5kbGU6OnNoYXJlZCgpLmlz VGVzdFJ1bm5pbmcoKSk7CiAKLSAgICBJbmplY3RlZEJ1bmRsZTo6c2hhcmVkKCkudGVzdFJ1bm5l cigpLT5pbnZhbGlkYXRlV2FpdFRvRHVtcFdhdGNoZG9nVGltZXIoKTsKLQogICAgIC8vIEZvcmNl IGEgcGFpbnQgYmVmb3JlIGR1bXBpbmcuIFRoaXMgbWF0Y2hlcyBEdW1wUmVuZGVyVHJlZSBvbiBX aW5kb3dzLiAoRHVtcFJlbmRlclRyZWUgb24gTWFjCiAgICAgLy8gZG9lcyB0aGlzIGF0IGEgc2xp Z2h0bHkgZGlmZmVyZW50IHRpbWUuKSBTZWUgPGh0dHA6Ly93ZWJraXQub3JnL2IvNTU0Njk+IGZv ciBkZXRhaWxzLgogICAgIFdLQnVuZGxlUGFnZUZvcmNlUmVwYWludChtX3BhZ2UpOwpJbmRleDog VG9vbHMvV2ViS2l0VGVzdFJ1bm5lci9JbmplY3RlZEJ1bmRsZS9UZXN0UnVubmVyLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVjdGVkQnVuZGxlL1Rlc3RSdW5u ZXIuY3BwCShyZXZpc2lvbiAxNzc1ODkpCisrKyBUb29scy9XZWJLaXRUZXN0UnVubmVyL0luamVj dGVkQnVuZGxlL1Rlc3RSdW5uZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0xNjAsNiArMTYwLDEw IEBAIHZvaWQgVGVzdFJ1bm5lcjo6bm90aWZ5RG9uZSgpCiAgICAgaWYgKG1fd2FpdFRvRHVtcCAm JiAhSW5qZWN0ZWRCdW5kbGU6OnNoYXJlZCgpLnRvcExvYWRpbmdGcmFtZSgpKQogICAgICAgICBJ bmplY3RlZEJ1bmRsZTo6c2hhcmVkKCkucGFnZSgpLT5kdW1wKCk7CiAKKyAgICAvLyBXZSBkb24n dCBjYWxsIGludmFsaWRhdGVXYWl0VG9EdW1wV2F0Y2hkb2dUaW1lcigpIGhlcmUsIGV2ZW4gaWYg d2UgY29udGludWUgdG8gd2FpdCBmb3IgYSBsb2FkIHRvIGZpbmlzaC4KKyAgICAvLyBUaGUgdGVz dCBpcyBzdGlsbCBzdWJqZWN0IHRvIHRpbWVvdXQgY2hlY2tpbmcgLSBpdCBpcyBiZXR0ZXIgdG8g ZGV0ZWN0IGFuIGFzeW5jIHRpbWVvdXQgaW5zaWRlIFdlYktpdFRlc3RSdW5uZXIKKyAgICAvLyB0 aGFuIHRvIGxldCB3ZWJraXRweSBkbyB0aGF0LCBiZWNhc3VlIFdlYktpdFRlc3RSdW5uZXIgd2ls bCBkdW1wIHBhcnRpYWwgcmVzdWx0cy4KKwogICAgIG1fd2FpdFRvRHVtcCA9IGZhbHNlOwogfQog CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCShyZXZpc2lvbiAxNzc1OTcpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdv cmtpbmcgY29weSkKQEAgLTEsMyArMSwxMyBAQAorMjAxNC0xMi0xOSAgQWxleGV5IFByb3NrdXJ5 YWtvdiAgPGFwQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OICgxNzczNjgpOiBTb21l IHRlc3RzIHN0YXJ0ZWQgdG8gaW1tZWRpYXRlbHkgdGltZSBvdXQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTgyNgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3Rh dGlvbnM6IFRoZSBjdWxwcml0IHdhcyB0aGlzIHRlc3QgdGhhdCBJIHVuc2tpcHBlZCB0byBzZWUK KyAgICAgICAgd2hldGhlciBpdCBwYXNzZXMuIEl0IGluIGZhY3QgZG9lcyBwYXNzLCBzbyBsZXQn cyByZW1vdmUgdGhlIGV4cGVjdGF0aW9uIGVudGlyZWx5LgorCiAyMDE0LTEyLTE5ICBCcmVudCBG dWxnaGFtICA8YmZ1bGdoYW1AYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIFVucmV2aWV3ZWQg Z2FyZGVuaW5nLgpJbmRleDogTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlv bnMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvcGxhdGZvcm0vd2syL1Rlc3RFeHBlY3RhdGlv bnMJKHJldmlzaW9uIDE3NzU4OSkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL3drMi9UZXN0RXhw ZWN0YXRpb25zCSh3b3JraW5nIGNvcHkpCkBAIC03Niw5ICs3Niw2IEBAIHdlYmtpdC5vcmcvYi84 MjY2NSBodHRwL3Rlc3RzL3dlYmFyY2hpdmUKIHdlYmtpdC5vcmcvYi84MjY2NSB3ZWJhcmNoaXZl L3Rlc3QtY3NzLXVybC1yZXNvdXJjZXMtaW4tc3R5bGVzaGVldHMuaHRtbCBbIFNraXAgXQogd2Vi a2l0Lm9yZy9iLzgyNjY1IHdlYmFyY2hpdmUvdGVzdC1jc3MtdXJsLXJlc291cmNlcy1pbmxpbmUt c3R5bGVzLmh0bWwgWyBTa2lwIF0KIAotIyBUaGlzIHRlc3QgaGFzIGJlZW4gc2tpcHBlZCBmb3Ig YSBsb25nIHRpbWUuIFRlbXBvcmFyaWx5IG1hcmtpbmcgYXMgZmxha3kgdG8gc2VlIHdoYXQgYm90 cyB0aGluay4KLXdlYmtpdC5vcmcvYi85Njc0MSBmYXN0L2xvYWRlci9yZWN1cnNpdmUtYmVmb3Jl LXVubG9hZC1jcmFzaC5odG1sIFsgUGFzcyBGYWlsdXJlIF0KLQogIyBXZWJLaXRUZXN0UnVubmVy IG5lZWRzIHRleHRJbnB1dENvbnRyb2xsZXIKICMgPGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD00MjMzNz4KIGVkaXRpbmcvaW5wdXQvc2V0dGluZy1pbnB1dC12YWx1ZS1j YW5jZWwtaW1lLWNvbXBvc2l0aW9uLmh0bWwK