139818 2014-12-19 09:42:26 -0800 Clean up a fix for performance test bot failing to build 2014-12-19 09:59:06 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=139811 https://bugs.webkit.org/show_bug.cgi?id=139786 P2 Normal --- 1 ap ap clopez lforschler ossy rniwa oldest_to_newest 1057039 0 ap 2014-12-19 09:42:26 -0800 Alexey Proskuryakov 2014-12-19 00:34:28 PST I now think that the cleanest fix would be to set is_clean in these two before calling Factory.__init__. With this, CleanBuildIfScheduled would clean the directory at the right time. Comment 5 Ryosuke Niwa 2014-12-19 00:37:43 PST Or pass in --no-build to run-perf-tests... 1057042 1 243554 ap 2014-12-19 09:45:12 -0800 Created attachment 243554 proposed patch 1057043 2 243554 ossy 2014-12-19 09:50:21 -0800 Comment on attachment 243554 proposed patch View in context: https://bugs.webkit.org/attachment.cgi?id=243554&action=review > Tools/BuildSlaveSupport/build.webkit.org-config/master.cfg:711 > + # FIXME: Can all ports use --no-build? Everything appears to be either downloaded > + # or built locally before running this step. > + if platform == 'mac': > + self.setCommand(self.command + ['--no-build']) We can do it unconditionally, EFL and GTK build everything it one shot, build-webkittestrunner simply returns 0 without doing anything. 1057044 3 243554 ossy 2014-12-19 09:53:21 -0800 Comment on attachment 243554 proposed patch r=me with the change suggested. 1057045 4 ap 2014-12-19 09:59:06 -0800 Committed <http://trac.webkit.org/r177575>. We'll need to see if this affects what happens when builds are broken in any strange ways. Seems like it shouldn't though. 243554 2014-12-19 09:45:12 -0800 2014-12-19 09:53:21 -0800 proposed patch PerfTests2.txt text/plain 3570 ap SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzU3NCkKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDIwIEBACisyMDE0LTEyLTE5ICBBbGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29t PgorCisgICAgICAgIENsZWFuIHVwIGEgZml4IGZvciBwZXJmb3JtYW5jZSB0ZXN0IGJvdCBmYWls aW5nIHRvIGJ1aWxkCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0xMzk4MTgKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICBUaGUgIl8xIiBpbiBzdGVwIG5hbWUgd2FzIGFubm95aW5nLgorCisgICAgICAgICogQnVp bGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZzoKKyAgICAg ICAgKENsZWFuQnVpbGRJZlNjaGVkdWxlZC5zdGFydCk6CisgICAgICAgIChSdW5BbmRVcGxvYWRQ ZXJmVGVzdHMpOgorICAgICAgICAoRG93bmxvYWRBbmRQZXJmVGVzdEZhY3RvcnkuX19pbml0X18p OgorICAgICAgICAoRG93bmxvYWRBbmRQZXJmVGVzdFdlYktpdDJGYWN0b3J5Ll9faW5pdF9fKToK KyAgICAgICAgKENsZWFuQnVpbGRVbmNvbmRpdGlvbmFsbHkpOiBEZWxldGVkLgorICAgICAgICAo Q2xlYW5CdWlsZFVuY29uZGl0aW9uYWxseS5zdGFydCk6IERlbGV0ZWQuCisKIDIwMTQtMTItMTkg IENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9yZz4KIAogICAgICAgICBSRUdSRVNT SU9OKHIxNzc1MzUpOiBJdCBicm9rZSB0aGUgR1RLIHBlcmZvcm1hbmNlIGJvdApJbmRleDogVG9v bHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNmZwo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBUb29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNv bmZpZy9tYXN0ZXIuY2ZnCShyZXZpc2lvbiAxNzc1NzQpCisrKyBUb29scy9CdWlsZFNsYXZlU3Vw cG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnCSh3b3JraW5nIGNvcHkpCkBA IC0xNjEsMTUgKzE2MSw2IEBAIGNsYXNzIENsZWFuQnVpbGRJZlNjaGVkdWxlZChzaGVsbC5Db21w aWwKICAgICAgICAgICAgIHJldHVybiBTS0lQUEVECiAgICAgICAgIHJldHVybiBzaGVsbC5Db21w aWxlLnN0YXJ0KHNlbGYpCiAKLWNsYXNzIENsZWFuQnVpbGRVbmNvbmRpdGlvbmFsbHkoc2hlbGwu Q29tcGlsZSk6Ci0gICAgbmFtZSA9ICJkZWxldGUgV2ViS2l0QnVpbGQgZGlyZWN0b3J5IgotICAg IGRlc2NyaXB0aW9uID0gWyJkZWxldGluZyBXZWJLaXRCdWlsZCBkaXJlY3RvcnkiXQotICAgIGRl c2NyaXB0aW9uRG9uZSA9IFsiZGVsZXRlZCBXZWJLaXRCdWlsZCBkaXJlY3RvcnkiXQotICAgIGNv bW1hbmQgPSBbInB5dGhvbiIsICIuL1Rvb2xzL0J1aWxkU2xhdmVTdXBwb3J0L2NsZWFuLWJ1aWxk IiwgV2l0aFByb3BlcnRpZXMoIi0tcGxhdGZvcm09JShmdWxsUGxhdGZvcm0pcyIpLCBXaXRoUHJv cGVydGllcygiLS0lKGNvbmZpZ3VyYXRpb24pcyIpXQotCi0gICAgZGVmIHN0YXJ0KHNlbGYpOgot ICAgICAgICByZXR1cm4gc2hlbGwuQ29tcGlsZS5zdGFydChzZWxmKQotCiBjbGFzcyBEZWxldGVT dGFsZUJ1aWxkRmlsZXMoc2hlbGwuQ29tcGlsZSk6CiAgICAgbmFtZSA9ICJkZWxldGUgc3RhbGUg YnVpbGQgZmlsZXMiCiAgICAgZGVzY3JpcHRpb24gPSBbImRlbGV0aW5nIHN0YWxlIGJ1aWxkIGZp bGVzIl0KQEAgLTcxNCw2ICs3MDUsMTAgQEAgY2xhc3MgUnVuQW5kVXBsb2FkUGVyZlRlc3RzKHNo ZWxsLlRlc3QpOgogICAgICAgICAgICAgICAgIi0tYnVpbGQtbnVtYmVyIiwgV2l0aFByb3BlcnRp ZXMoIiUoYnVpbGRudW1iZXIpcyIpLAogICAgICAgICAgICAgICAgIi0tcGxhdGZvcm0iLCBXaXRo UHJvcGVydGllcygiJShmdWxsUGxhdGZvcm0pcyIpLAogICAgICAgICAgICAgICAgV2l0aFByb3Bl cnRpZXMoIi0tJShjb25maWd1cmF0aW9uKXMiKV0KKyAgICAjIEZJWE1FOiBDYW4gYWxsIHBvcnRz IHVzZSAtLW5vLWJ1aWxkPyBFdmVyeXRoaW5nIGFwcGVhcnMgdG8gYmUgZWl0aGVyIGRvd25sb2Fk ZWQKKyAgICAjIG9yIGJ1aWx0IGxvY2FsbHkgYmVmb3JlIHJ1bm5pbmcgdGhpcyBzdGVwLgorICAg IGlmIHBsYXRmb3JtID09ICdtYWMnOgorICAgICAgICBzZWxmLnNldENvbW1hbmQoc2VsZi5jb21t YW5kICsgWyctLW5vLWJ1aWxkJ10pCiAKICAgICBkZWYgc3RhcnQoc2VsZik6CiAgICAgICAgIHNl bGYuc2V0Q29tbWFuZChzZWxmLmNvbW1hbmQpCkBAIC05MzEsOCArOTI2LDYgQEAgY2xhc3MgQnVp bGRBbmRQZXJmVGVzdFdlYktpdDJGYWN0b3J5KEZhYwogY2xhc3MgRG93bmxvYWRBbmRQZXJmVGVz dEZhY3RvcnkoRmFjdG9yeSk6CiAgICAgZGVmIF9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25m aWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBhZGRpdGlvbmFsQXJndW1lbnRzPU5vbmUsIFNWTk1p cnJvcj1Ob25lLCAqKmt3YXJncyk6CiAgICAgICAgIEZhY3RvcnkuX19pbml0X18oc2VsZiwgcGxh dGZvcm0sIGNvbmZpZ3VyYXRpb24sIGFyY2hpdGVjdHVyZXMsIEZhbHNlLCBhZGRpdGlvbmFsQXJn dW1lbnRzLCBTVk5NaXJyb3IsICoqa3dhcmdzKQotICAgICAgICBpZiBwbGF0Zm9ybSA9PSAnbWFj JzoKLSAgICAgICAgICAgIHNlbGYuYWRkU3RlcChDbGVhbkJ1aWxkVW5jb25kaXRpb25hbGx5KCkp CiAgICAgICAgIHNlbGYuYWRkU3RlcChEb3dubG9hZEJ1aWx0UHJvZHVjdCgpKQogICAgICAgICBz ZWxmLmFkZFN0ZXAoRXh0cmFjdEJ1aWx0UHJvZHVjdCgpKQogICAgICAgICBzZWxmLmFkZFN0ZXAo UnVuQW5kVXBsb2FkUGVyZlRlc3RzKCkpCkBAIC05NDAsOCArOTMzLDYgQEAgY2xhc3MgRG93bmxv YWRBbmRQZXJmVGVzdEZhY3RvcnkoRmFjdG9yeQogY2xhc3MgRG93bmxvYWRBbmRQZXJmVGVzdFdl YktpdDJGYWN0b3J5KEZhY3RvcnkpOgogICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwg Y29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0dXJlcywgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCBT Vk5NaXJyb3I9Tm9uZSwgKiprd2FyZ3MpOgogICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYs IHBsYXRmb3JtLCBjb25maWd1cmF0aW9uLCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25h bEFyZ3VtZW50cywgU1ZOTWlycm9yLCAqKmt3YXJncykKLSAgICAgICAgaWYgcGxhdGZvcm0gPT0g J21hYyc6Ci0gICAgICAgICAgICBzZWxmLmFkZFN0ZXAoQ2xlYW5CdWlsZFVuY29uZGl0aW9uYWxs eSgpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoRG93bmxvYWRCdWlsdFByb2R1Y3QoKSkKICAgICAg ICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RCdWlsdFByb2R1Y3QoKSkKICAgICAgICAgc2VsZi5hZGRT dGVwKFJ1bkFuZFVwbG9hZFBlcmZUZXN0c1dlYktpdDIoKSkK