139811 2014-12-19 00:10:44 -0800 REGRESSION(r177535): It broke the GTK performance bot 2014-12-20 19:40:08 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=139818 P1 Blocker --- 139786 1 ossy ossy ap cgarcia clopez lforschler ossy rniwa oldest_to_newest 1057010 0 ossy 2014-12-19 00:10:44 -0800 After http://trac.webkit.org/r177535 performance bots remove WebKitBuild directory unconditionally. It was a workaround to fix a Mac only issue, but it broke the GTK bot: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Perf%29/builds/1522 5.) jhbuild updated gtk dependencies 6.) delete WebKitBuild directory_1 deleted WebKitBuild directory --> It removes the necessary dependencies built by step 5.) This clean build is incorrect and unnecessary on the GTK bot. 1057011 1 243547 ossy 2014-12-19 00:15:51 -0800 Created attachment 243547 Patch 1057012 2 243547 ossy 2014-12-19 00:24:21 -0800 Comment on attachment 243547 Patch Clearing flags on attachment: 243547 Committed r177569: <http://trac.webkit.org/changeset/177569> 1057013 3 ossy 2014-12-19 00:24:28 -0800 All reviewed patches have been landed. Closing bug. 1057014 4 ap 2014-12-19 00:34:28 -0800 I now think that the cleanest fix would be to set is_clean in these two before calling Factory.__init__. With this, CleanBuildIfScheduled would clean the directory at the right time. 1057017 5 rniwa 2014-12-19 00:37:43 -0800 Or pass in --no-build to run-perf-tests... 1057018 6 ossy 2014-12-19 00:44:45 -0800 (In reply to comment #2) > Comment on attachment 243547 [details] > Patch > > Clearing flags on attachment: 243547 > > Committed r177569: <http://trac.webkit.org/changeset/177569> Lucas or Ryosuke, could you possibly push this change to buildmaster and then restart to fix the GTK performance bot? Thanks. 1057033 7 lforschler 2014-12-19 08:02:14 -0800 I've restarted the master, let me know if things don't look correct. 1057035 8 ossy 2014-12-19 08:25:03 -0800 (In reply to comment #7) > I've restarted the master, let me know if things don't look correct. Thanks, the GTK performance bot is happy now. :) 1057298 9 243547 darin 2014-12-20 19:39:00 -0800 Comment on attachment 243547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243547&action=review > Tools/ChangeLog:8 > + Trigger clean build only on mac platform. Why? If the problem is on GTK, then why isn’t the condition here about GTK, rather than Mac? 1057299 10 243547 darin 2014-12-20 19:40:08 -0800 Comment on attachment 243547 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243547&action=review >> Tools/ChangeLog:8 >> + Trigger clean build only on mac platform. > > Why? If the problem is on GTK, then why isn’t the condition here about GTK, rather than Mac? I guess it’s not an important question; looks like Alexey removed this code a few commits later. 243547 2014-12-19 00:15:51 -0800 2014-12-19 00:24:21 -0800 Patch bug-139811-20141219001550.patch text/plain 2400 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NTY4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggZGY3MjE1ZDc1ZWIwYzliMDQzN2Y1MDI4Mjc3NTIxM2Fh ZjJiYjU1My4uNGJlZDI0YjEzOTkxNzQyNGRlOWE4MjFhZjFlMWY2YjFlNjU5OTFlZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTEyLTE5ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisK KyAgICAgICAgUkVHUkVTU0lPTihyMTc3NTM1KTogSXQgYnJva2UgdGhlIEdUSyBwZXJmb3JtYW5j ZSBib3QKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz OTgxMQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRy aWdnZXIgY2xlYW4gYnVpbGQgb25seSBvbiBtYWMgcGxhdGZvcm0uCisKKyAgICAgICAgKiBCdWls ZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIuY2ZnOgorICAgICAg ICAoRG93bmxvYWRBbmRQZXJmVGVzdEZhY3RvcnkuX19pbml0X18pOgorICAgICAgICAoRG93bmxv YWRBbmRQZXJmVGVzdFdlYktpdDJGYWN0b3J5Ll9faW5pdF9fKToKKwogMjAxNC0xMi0xOCAgS3dh bmdIeXVrIEtpbSAgPGh5dWtpLmtpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBVbnJldmlld2Vk LCBtb3ZlZCBteXNlbGYgdG8gdGhlIGxpc3Qgb2YgY29tbWl0dGVycy4KZGlmZiAtLWdpdCBhL1Rv b2xzL0J1aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcg Yi9Ub29scy9CdWlsZFNsYXZlU3VwcG9ydC9idWlsZC53ZWJraXQub3JnLWNvbmZpZy9tYXN0ZXIu Y2ZnCmluZGV4IGM0N2YxZTZlMTZkZGRmMDY3YjYxNTM3ODIxYjA0NWRhMTlmMDFiNDQuLjliZWMx NDQ4ZDJlZDBhYmJlMDRlZmI1YWM1YTY2NDI4ZDE1NTk5Y2MgMTAwNjQ0Ci0tLSBhL1Rvb2xzL0J1 aWxkU2xhdmVTdXBwb3J0L2J1aWxkLndlYmtpdC5vcmctY29uZmlnL21hc3Rlci5jZmcKKysrIGIv VG9vbHMvQnVpbGRTbGF2ZVN1cHBvcnQvYnVpbGQud2Via2l0Lm9yZy1jb25maWcvbWFzdGVyLmNm ZwpAQCAtOTMxLDcgKzkzMSw4IEBAIGNsYXNzIEJ1aWxkQW5kUGVyZlRlc3RXZWJLaXQyRmFjdG9y eShGYWN0b3J5KToKIGNsYXNzIERvd25sb2FkQW5kUGVyZlRlc3RGYWN0b3J5KEZhY3RvcnkpOgog ICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0 dXJlcywgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCBTVk5NaXJyb3I9Tm9uZSwgKiprd2FyZ3Mp OgogICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9u LCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cywgU1ZOTWlycm9yLCAq Kmt3YXJncykKLSAgICAgICAgc2VsZi5hZGRTdGVwKENsZWFuQnVpbGRVbmNvbmRpdGlvbmFsbHko KSkKKyAgICAgICAgaWYgcGxhdGZvcm0gPT0gJ21hYyc6CisgICAgICAgICAgICBzZWxmLmFkZFN0 ZXAoQ2xlYW5CdWlsZFVuY29uZGl0aW9uYWxseSgpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoRG93 bmxvYWRCdWlsdFByb2R1Y3QoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RCdWlsdFBy b2R1Y3QoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkFuZFVwbG9hZFBlcmZUZXN0cygpKQpA QCAtOTM5LDcgKzk0MCw4IEBAIGNsYXNzIERvd25sb2FkQW5kUGVyZlRlc3RGYWN0b3J5KEZhY3Rv cnkpOgogY2xhc3MgRG93bmxvYWRBbmRQZXJmVGVzdFdlYktpdDJGYWN0b3J5KEZhY3RvcnkpOgog ICAgIGRlZiBfX2luaXRfXyhzZWxmLCBwbGF0Zm9ybSwgY29uZmlndXJhdGlvbiwgYXJjaGl0ZWN0 dXJlcywgYWRkaXRpb25hbEFyZ3VtZW50cz1Ob25lLCBTVk5NaXJyb3I9Tm9uZSwgKiprd2FyZ3Mp OgogICAgICAgICBGYWN0b3J5Ll9faW5pdF9fKHNlbGYsIHBsYXRmb3JtLCBjb25maWd1cmF0aW9u LCBhcmNoaXRlY3R1cmVzLCBGYWxzZSwgYWRkaXRpb25hbEFyZ3VtZW50cywgU1ZOTWlycm9yLCAq Kmt3YXJncykKLSAgICAgICAgc2VsZi5hZGRTdGVwKENsZWFuQnVpbGRVbmNvbmRpdGlvbmFsbHko KSkKKyAgICAgICAgaWYgcGxhdGZvcm0gPT0gJ21hYyc6CisgICAgICAgICAgICBzZWxmLmFkZFN0 ZXAoQ2xlYW5CdWlsZFVuY29uZGl0aW9uYWxseSgpKQogICAgICAgICBzZWxmLmFkZFN0ZXAoRG93 bmxvYWRCdWlsdFByb2R1Y3QoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKEV4dHJhY3RCdWlsdFBy b2R1Y3QoKSkKICAgICAgICAgc2VsZi5hZGRTdGVwKFJ1bkFuZFVwbG9hZFBlcmZUZXN0c1dlYktp dDIoKSkK