139805 2014-12-18 19:47:28 -0800 Fix build break on EFL and GTK since r177523 2014-12-19 08:55:52 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139790 1 gyuyoung.kim gyuyoung.kim andersca benjamin cmarcelo commit-queue oldest_to_newest 1056981 0 gyuyoung.kim 2014-12-18 19:47:28 -0800 r177523 made build break on EFL and GTK ports. 1056982 1 243537 gyuyoung.kim 2014-12-18 19:48:14 -0800 Created attachment 243537 Patch 1056988 2 243537 andersca 2014-12-18 21:35:55 -0800 Comment on attachment 243537 Patch This isn't the right fix - the right fix is t make sure that the definition in wtf/StdLibExtras.h is used on versions less than 4.9.0! 1056995 3 243543 gyuyoung.kim 2014-12-18 22:32:04 -0800 Created attachment 243543 Patch 1056996 4 gyuyoung.kim 2014-12-18 22:33:42 -0800 (In reply to comment #2) > Comment on attachment 243537 [details] > Patch > > This isn't the right fix - the right fix is t make sure that the definition > in wtf/StdLibExtras.h is used on versions less than 4.9.0! Anders, Ref.h seems to need to include <wtf/StdLibExtras.h> explicitly. EFL and GTK port don't recognize std::exchange() defined in wtf/StdLibExtras.h. 1057001 5 243543 ossy 2014-12-18 23:12:24 -0800 Comment on attachment 243543 Patch rs=me 1057002 6 243543 commit-queue 2014-12-18 23:45:29 -0800 Comment on attachment 243543 Patch Clearing flags on attachment: 243543 Committed r177568: <http://trac.webkit.org/changeset/177568> 1057003 7 commit-queue 2014-12-18 23:45:33 -0800 All reviewed patches have been landed. Closing bug. 1057037 8 andersca 2014-12-19 08:55:52 -0800 Ah, sorry about that. Thanks for fixing! 243537 2014-12-18 19:48:14 -0800 2014-12-18 22:31:58 -0800 Patch bug-139805-20141219124813.patch text/plain 2091 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ1YmRhNDAwY2ZlOGUxNjc5NDRhOWQx ZjQ0YzVjODNlYjI5MGEyZmYuLmJjZjI2OGVlODFmMzg5NGI4Yjc3YWQzZDc0NGYyM2YyYzE5Zjhh NjEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTItMTggIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgYnJlYWsgb24gRUZMIGFu ZCBHVEsgc2luY2UgcjE3NzUyMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM5ODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgcjE3NzUyMyBhZGRlZCBzdGQ6OmV4Y2hhbmdlKCkgd2hpY2ggaXMgc3VwcG9y dGVkIGJ5IEdDQyA0LjkgdmVyLiBhdCBsZWFzdC4gSG93ZXZlciBFRkwgYW5kIEdUSyBwb3J0cyBh cmUgc3RpbGwgdXNpbmcgbG93ZXIgR0NDIHZlci4gVG8gZml4IHRoaXMgYnJlYWssIHRoaXMgcGF0 Y2ggYWRkcyBHQ0NfVkVSU0lPTl9BVF9MRUFTVCg0LCA5LCAwKSB0byBzdGQ6OmV4Y2hhbmdlKCkg dW50aWwgRUZMIGFuZCBHVEsgcG9ydHMgdXNlcyA0LjkgdmVyLgorCisgICAgICAgICogd3RmL1Bh c3NSZWZQdHIuaDoKKyAgICAgICAgKFdURjo6UGFzc1JlZlB0cjxUPjo6bGVha1JlZik6CisgICAg ICAgICogd3RmL1JlZi5oOgorCiAyMDE0LTEyLTE4ICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJh Y2xvdWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBBZGQgc3Ryb25nIHR5cGluZyB0byBSZWZDb3Vu dGVyIGludGVyZmFjZSwgcmV0dXJuIHZhbHVlIGFzIGEgYm9vbC4KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XVEYvd3RmL1Bhc3NSZWZQdHIuaCBiL1NvdXJjZS9XVEYvd3RmL1Bhc3NSZWZQdHIuaAppbmRl eCBkNTk3NmM2NGM1Mzk1OTYxMDU3N2VlN2NlMjdlYzI1Y2JlYmY3NjE4Li5jMjJmNzFhN2U5NDcz OWQ0MGI3NjcyMjExOTU2YTI1ODEwNTNmM2ZhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Q YXNzUmVmUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvUGFzc1JlZlB0ci5oCkBAIC05Myw3ICs5 MywxMyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGlu ZSBUKiBQYXNzUmVmUHRyPFQ+OjpsZWFrUmVmKCkgY29uc3QKICAgICB7CisjaWYgR0NDX1ZFUlNJ T05fQVRfTEVBU1QoNCwgOSwgMCkKICAgICAgICAgcmV0dXJuIHN0ZDo6ZXhjaGFuZ2UobV9wdHIs IG51bGxwdHIpOworI2Vsc2UKKyAgICAgICAgVCogcHRyID0gbV9wdHI7CisgICAgICAgIG1fcHRy ID0gbnVsbHB0cjsKKyAgICAgICAgcmV0dXJuIHB0cjsKKyNlbmRpZgogICAgIH0KIAogICAgIHRl bXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFU+IGlubGluZSBib29sIG9wZXJhdG9yPT0oY29u c3QgUGFzc1JlZlB0cjxUPiYgYSwgY29uc3QgUGFzc1JlZlB0cjxVPiYgYikgCmRpZmYgLS1naXQg YS9Tb3VyY2UvV1RGL3d0Zi9SZWYuaCBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCmluZGV4IDc0MDNl MWU4NTgxNGIyODQzYzJjNTEzMmYzZmM5ZDQzOGQ4YzA1YmUuLmEyZDdhYjliOTRjZmFiNDc1ZGFj YTJlMWMyYWYwOTc5MTI1NzQ3ZTEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1JlZi5oCisr KyBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCkBAIC0xMTEsOCArMTExLDEzIEBAIHB1YmxpYzoKICAg ICBUJiBsZWFrUmVmKCkgV0FSTl9VTlVTRURfUkVUVVJOCiAgICAgewogICAgICAgICBBU1NFUlQo bV9wdHIpOwotCisjaWYgR0NDX1ZFUlNJT05fQVRfTEVBU1QoNCwgOSwgMCkKICAgICAgICAgcmV0 dXJuICpzdGQ6OmV4Y2hhbmdlKG1fcHRyLCBudWxscHRyKTsKKyNlbHNlCisgICAgICAgIFQqIG1v dmVkUHRyID0gbV9wdHI7CisgICAgICAgIG1fcHRyID0gbnVsbHB0cjsKKyAgICAgICAgcmV0dXJu ICptb3ZlZFB0cjsKKyNlbmRpZgogICAgIH0KIAogcHJpdmF0ZToK 243543 2014-12-18 22:32:04 -0800 2014-12-18 23:45:29 -0800 Patch bug-139805-20141219153203.patch text/plain 1031 gyuyoung.kim U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NTUzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGQ1YmRhNDAwY2ZlOGUxNjc5NDRhOWQx ZjQ0YzVjODNlYjI5MGEyZmYuLjBjZmEzNzI3NWM4YjJmMzg4OTRhODZmM2E2MzIzZTAxZDAwMDMz MTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTQtMTItMTggIEd5dXlvdW5nIEtpbSAgPGd5dXlv dW5nLmtpbUBzYW1zdW5nLmNvbT4KKworICAgICAgICBGaXggYnVpbGQgYnJlYWsgb24gRUZMIGFu ZCBHVEsgc2luY2UgcjE3NzUyMworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM5ODA1CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiB3dGYvUmVmLmg6IEluY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4gdG8g dXNlIHN0ZDo6ZXhjaGFuZ2UoKS4KKwogMjAxNC0xMi0xOCAgR2F2aW4gQmFycmFjbG91Z2ggIDxi YXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgQWRkIHN0cm9uZyB0eXBpbmcgdG8gUmVm Q291bnRlciBpbnRlcmZhY2UsIHJldHVybiB2YWx1ZSBhcyBhIGJvb2wuCmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9SZWYuaCBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCmluZGV4IDc0MDNlMWU4 NTgxNGIyODQzYzJjNTEzMmYzZmM5ZDQzOGQ4YzA1YmUuLjg4NGEyNjVlODgwMWQ5ZmMwNmZhNjVj ZTUxMGMzYTkzNDg1MmY5YzIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1JlZi5oCisrKyBi L1NvdXJjZS9XVEYvd3RmL1JlZi5oCkBAIC0yOSw2ICsyOSw3IEBACiAjaW5jbHVkZSA8d3RmL0Fz c2VydGlvbnMuaD4KICNpbmNsdWRlIDx3dGYvR2V0UHRyLmg+CiAjaW5jbHVkZSA8d3RmL05vbmNv cHlhYmxlLmg+CisjaW5jbHVkZSA8d3RmL1N0ZExpYkV4dHJhcy5oPgogCiBuYW1lc3BhY2UgV1RG IHsKIAo=