139801 2014-12-18 16:49:19 -0800 [Win] Endless compiler warnings created by DFGEdge.h 2014-12-19 11:26:44 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 bfulgham mark.lam bfulgham commit-queue mark.lam msaboff oldest_to_newest 1056956 0 bfulgham 2014-12-18 16:49:19 -0800 Recent changes have introduced tons of compiler warnings: 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCSEPhase.cpp) 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGClobberize.cpp) 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGClobberSet.cpp) 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCommon.cpp) 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCommonData.cpp) 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGCriticalEdgeBreakingPhase.cpp) 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGConstantFoldingPhase.cpp) 10>c:\projects\webkit\opensource\source\javascriptcore\dfg\DFGEdge.h(210): warning C4805: '|' : unsafe mix of type 'uintptr_t' and type 'bool' in operation (..\dfg\DFGDCEPhase.cpp) 1056957 1 bfulgham 2014-12-18 16:50:14 -0800 Also: 10>..\runtime\BasicBlockLocation.cpp(55): warning C4245: 'initializing' : conversion from 'int' to 'unsigned int', signed/unsigned mismatch 1056958 2 bfulgham 2014-12-18 16:50:41 -0800 Note: Many of these warnings are being generated by 32-bit builds. 1057086 3 243558 mark.lam 2014-12-19 11:04:07 -0800 Created attachment 243558 the patch. 1057088 4 243558 bfulgham 2014-12-19 11:06:02 -0800 Comment on attachment 243558 the patch. Looks good to me! r=me. 1057103 5 243558 commit-queue 2014-12-19 11:26:41 -0800 Comment on attachment 243558 the patch. Clearing flags on attachment: 243558 Committed r177582: <http://trac.webkit.org/changeset/177582> 1057104 6 commit-queue 2014-12-19 11:26:44 -0800 All reviewed patches have been landed. Closing bug. 243558 2014-12-19 11:04:07 -0800 2014-12-19 11:26:41 -0800 the patch. bug-139801.patch text/plain 1409 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc3NTc5KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBA CisyMDE0LTEyLTE5ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBb V2luXSBFbmRsZXNzIGNvbXBpbGVyIHdhcm5pbmdzIGNyZWF0ZWQgYnkgREZHRWRnZS5oLgorICAg ICAgICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM5ODAxPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEFkZCBhIGNhc3QgdG8gZml4IHRoZSB0eXBlIGp1 c3QgdGhlIHdheSB0aGUgNjQtYml0IHZlcnNpb24gZG9lcy4KKworICAgICAgICAqIGRmZy9ERkdF ZGdlLmg6CisgICAgICAgIChKU0M6OkRGRzo6RWRnZTo6bWFrZVdvcmQpOgorCiAyMDE0LTEyLTE5 ICBNaWNoYWVsIFNhYm9mZiAgPG1zYWJvZmZAYXBwbGUuY29tPgogCiAgICAgICAgIFJFR1JFU1NJ T04oMTc0MjI2KTogQ2FwdHVyZWQgYXJndW1lbnRzIGluIGEgdXNpbmcgZnVuY3Rpb24gY29tcGls ZWQgYnkgdGhlIERGRyBoYXZlIHRoZSBpbml0aWFsIHZhbHVlIHdoZW4gdGhlIGNsb3N1cmUgd2Fz IGludm9rZWQKSW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRWRnZS5oCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcvREZHRWRnZS5oCShyZXZpc2lvbiAx Nzc1NzgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0VkZ2UuaAkod29ya2luZyBj b3B5KQpAQCAtMjA3LDcgKzIwNyw3IEBAIHByaXZhdGU6CiAjZWxzZQogICAgIHN0YXRpYyB1aW50 cHRyX3QgbWFrZVdvcmQoVXNlS2luZCB1c2VLaW5kLCBQcm9vZlN0YXR1cyBwcm9vZlN0YXR1cywg S2lsbFN0YXR1cyBraWxsU3RhdHVzKQogICAgIHsKLSAgICAgICAgcmV0dXJuIChzdGF0aWNfY2Fz dDx1aW50cHRyX3Q+KHVzZUtpbmQpIDw8IDIpIHwgKERGRzo6ZG9lc0tpbGwoa2lsbFN0YXR1cykg PDwgMSkgfCBERkc6OmlzUHJvdmVkKHByb29mU3RhdHVzKTsKKyAgICAgICAgcmV0dXJuIChzdGF0 aWNfY2FzdDx1aW50cHRyX3Q+KHVzZUtpbmQpIDw8IDIpIHwgKERGRzo6ZG9lc0tpbGwoa2lsbFN0 YXR1cykgPDwgMSkgfCBzdGF0aWNfY2FzdDx1aW50cHRyX3Q+KERGRzo6aXNQcm92ZWQocHJvb2ZT dGF0dXMpKTsKICAgICB9CiAgICAgCiAgICAgTm9kZSogbV9ub2RlOwo=