139790 2014-12-18 13:44:05 -0800 Simplify smart pointer classes by using std::exchange 2014-12-18 19:48:36 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139805 1 andersca andersca benjamin cmarcelo commit-queue gyuyoung.kim oldest_to_newest 1056880 0 andersca 2014-12-18 13:44:05 -0800 Simplify smart pointer classes by using std::exchange 1056881 1 243515 andersca 2014-12-18 13:45:01 -0800 Created attachment 243515 Patch 1056896 2 andersca 2014-12-18 14:27:29 -0800 Committed r177523: <http://trac.webkit.org/changeset/177523> 1056980 3 gyuyoung.kim 2014-12-18 19:23:48 -0800 EFL and GTK ports have been broken since this commit. I think EFL and GTK ports don't use latest GCC version(4.9 probably). So they can't support std::exchange() yet. 243515 2014-12-18 13:45:01 -0800 2014-12-18 14:06:03 -0800 Patch bug-139790-20141218134501.patch text/plain 6647 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NTIxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IDdmMmExZWMwZWM1OWE0ZTYwNzlhNGMx NGMzMTU0YTg1ZWU0MGI0YTQuLjg3YzM5MzA3NWNjNTZiNWZkYTU5NWNiNTNjOTQ1MWIyNDFlMDg2 YjcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMzAgQEAKIDIwMTQtMTItMTggIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBTaW1wbGlmeSBzbWFydCBwb2ludGVyIGNsYXNz ZXMgYnkgdXNpbmcgc3RkOjpleGNoYW5nZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NzkwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgKiB3dGYvTWFsbG9jUHRyLmg6CisgICAgICAgICogd3RmL09TT2Jq ZWN0UHRyLmg6CisgICAgICAgICogd3RmL093blB0ci5oOgorICAgICAgICAoV1RGOjpPd25QdHI8 VD46OmNsZWFyKToKKyAgICAgICAgKFdURjo6T3duUHRyPFQ+OjpyZWxlYXNlKToKKyAgICAgICAg KFdURjo6T3duUHRyPFQ+OjpsZWFrUHRyKToKKyAgICAgICAgKFdURjo6PSk6CisgICAgICAgICog d3RmL1Bhc3NPd25QdHIuaDoKKyAgICAgICAgKFdURjo6UGFzc093blB0cjxUPjo6bGVha1B0cik6 CisgICAgICAgICogd3RmL1Bhc3NSZWZQdHIuaDoKKyAgICAgICAgKFdURjo6UGFzc1JlZlB0cjxU Pjo6bGVha1JlZik6CisgICAgICAgICogd3RmL1JlZi5oOgorICAgICAgICAqIHd0Zi9SZWZQdHIu aDoKKyAgICAgICAgKFdURjo6UmVmUHRyPFQ+OjpjbGVhcik6CisgICAgICAgIChXVEY6OlJlZlB0 cjxUPjo6bGVha1JlZik6CisgICAgICAgICogd3RmL1JldGFpblB0ci5oOgorICAgICAgICAoV1RG OjpSZXRhaW5QdHI8VD46OmxlYWtSZWYpOgorCisyMDE0LTEyLTE4ICBBbmRlcnMgQ2FybHNzb24g IDxhbmRlcnNjYUBhcHBsZS5jb20+CisKICAgICAgICAgQ2xlYW4gdXAgTWFjaFNlbmRSaWdodCBh bmQgYWRkIGEgY29weVNlbmRSaWdodCBtZW1iZXIgZnVuY3Rpb24KICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTc4OAogCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV1RGL3d0Zi9NYWxsb2NQdHIuaCBiL1NvdXJjZS9XVEYvd3RmL01hbGxvY1B0ci5oCmluZGV4 IDBmNDAyNGRlYzg4YjBlM2UwZGY4ZWEzYjRjNmJlMGNjMzU3NGIwNzEuLjU1YjgzYmI4MmFkZDFj ZTliZDdlMjNmMWYzZGM0YmY3YzIxOGUyYmIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL01h bGxvY1B0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL01hbGxvY1B0ci5oCkBAIC02MSw5ICs2MSw3 IEBAIHB1YmxpYzoKIAogICAgIFQgKmxlYWtQdHIoKSBXQVJOX1VOVVNFRF9SRVRVUk4KICAgICB7 Ci0gICAgICAgIFQqIHB0ciA9IG1fcHRyOwotICAgICAgICBtX3B0ciA9IG51bGxwdHI7Ci0gICAg ICAgIHJldHVybiBwdHI7CisgICAgICAgIHJldHVybiBzdGQ6OmV4Y2hhbmdlKG1fcHRyLCBudWxs cHRyKTsKICAgICB9CiAKICAgICBib29sIG9wZXJhdG9yISgpIGNvbnN0CmRpZmYgLS1naXQgYS9T b3VyY2UvV1RGL3d0Zi9PU09iamVjdFB0ci5oIGIvU291cmNlL1dURi93dGYvT1NPYmplY3RQdHIu aAppbmRleCA1NzZkODNmMzBhODk1MmUwYmYyYjA0NmNmNzE5MjA2MDNmNGRiN2Q1Li5iOGJhYmYz NjZmOTIxNWU3YmJiYTNmMDk5ODg3ZjVlZWM1NTlkZWY1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RG L3d0Zi9PU09iamVjdFB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL09TT2JqZWN0UHRyLmgKQEAg LTE0Myw5ICsxNDMsNyBAQCBwdWJsaWM6CiAKICAgICBUIGxlYWtSZWYoKSBXQVJOX1VOVVNFRF9S RVRVUk4KICAgICB7Ci0gICAgICAgIFQgcHRyID0gbV9wdHI7Ci0gICAgICAgIG1fcHRyID0gbnVs bHB0cjsKLSAgICAgICAgcmV0dXJuIHB0cjsKKyAgICAgICAgcmV0dXJuIHN0ZDo6ZXhjaGFuZ2Uo bV9wdHIsIG51bGxwdHIpOwogICAgIH0KIAogICAgIGZyaWVuZCBPU09iamVjdFB0ciBhZG9wdE9T T2JqZWN0PFQ+KFQpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dURi93dGYvT3duUHRyLmggYi9Tb3Vy Y2UvV1RGL3d0Zi9Pd25QdHIuaAppbmRleCBjMWE0NThhYjVhMmMxMWQ2YTEzNjFiYTc0ZWUzNzhi NjljZTNhYTlmLi4yMTcwMWE0OGI1Yjc1M2I5MjA5YmE2ZDlhZDBkOWU2YWU1ZjQwN2MxIDEwMDY0 NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9Pd25QdHIuaAorKysgYi9Tb3VyY2UvV1RGL3d0Zi9Pd25Q dHIuaApAQCAtMTEzLDI5ICsxMTMsMjIgQEAgbmFtZXNwYWNlIFdURiB7CiAKICAgICB0ZW1wbGF0 ZTx0eXBlbmFtZSBUPiBpbmxpbmUgdm9pZCBPd25QdHI8VD46OmNsZWFyKCkKICAgICB7Ci0gICAg ICAgIFB0clR5cGUgcHRyID0gbV9wdHI7Ci0gICAgICAgIG1fcHRyID0gMDsKLSAgICAgICAgZGVs ZXRlT3duZWRQdHIocHRyKTsKKyAgICAgICAgZGVsZXRlT3duZWRQdHIoc3RkOjpleGNoYW5nZSht X3B0ciwgbnVsbHB0cikpOwogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGlu ZSBQYXNzT3duUHRyPFQ+IE93blB0cjxUPjo6cmVsZWFzZSgpCiAgICAgewotICAgICAgICBQdHJU eXBlIHB0ciA9IG1fcHRyOwotICAgICAgICBtX3B0ciA9IDA7Ci0gICAgICAgIHJldHVybiBhZG9w dFB0cihwdHIpOworICAgICAgICByZXR1cm4gYWRvcHRQdHIoc3RkOjpleGNoYW5nZShtX3B0ciwg bnVsbHB0cikpOwogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSB0eXBl bmFtZSBPd25QdHI8VD46OlB0clR5cGUgT3duUHRyPFQ+OjpsZWFrUHRyKCkKICAgICB7Ci0gICAg ICAgIFB0clR5cGUgcHRyID0gbV9wdHI7Ci0gICAgICAgIG1fcHRyID0gMDsKLSAgICAgICAgcmV0 dXJuIHB0cjsKKyAgICAgICAgcmV0dXJuIHN0ZDo6ZXhjaGFuZ2UobV9wdHIsIG51bGxwdHIpOwog ICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IGlubGluZSBPd25QdHI8VD4mIE93blB0 cjxUPjo6b3BlcmF0b3I9KGNvbnN0IFBhc3NPd25QdHI8VD4mIG8pCiAgICAgewotICAgICAgICBQ dHJUeXBlIHB0ciA9IG1fcHRyOwotICAgICAgICBtX3B0ciA9IG8ubGVha1B0cigpOworICAgICAg ICBQdHJUeXBlIHB0ciA9IHN0ZDo6ZXhjaGFuZ2UobV9wdHIsIG8ubGVha1B0cigpKTsKICAgICAg ICAgQVNTRVJUKCFwdHIgfHwgbV9wdHIgIT0gcHRyKTsKICAgICAgICAgZGVsZXRlT3duZWRQdHIo cHRyKTsKICAgICAgICAgcmV0dXJuICp0aGlzOwpAQCAtMTQzLDggKzEzNiw3IEBAIG5hbWVzcGFj ZSBXVEYgewogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gdGVtcGxhdGU8dHlwZW5hbWUgVT4g aW5saW5lIE93blB0cjxUPiYgT3duUHRyPFQ+OjpvcGVyYXRvcj0oY29uc3QgUGFzc093blB0cjxV PiYgbykKICAgICB7Ci0gICAgICAgIFB0clR5cGUgcHRyID0gbV9wdHI7Ci0gICAgICAgIG1fcHRy ID0gby5sZWFrUHRyKCk7CisgICAgICAgIFB0clR5cGUgcHRyID0gc3RkOjpleGNoYW5nZShtX3B0 ciwgby5sZWFrUHRyKCkpOwogICAgICAgICBBU1NFUlQoIXB0ciB8fCBtX3B0ciAhPSBwdHIpOwog ICAgICAgICBkZWxldGVPd25lZFB0cihwdHIpOwogICAgICAgICByZXR1cm4gKnRoaXM7CmRpZmYg LS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9QYXNzT3duUHRyLmggYi9Tb3VyY2UvV1RGL3d0Zi9QYXNz T3duUHRyLmgKaW5kZXggZGE4MTY1OThmOTRlMzRmNDkzM2YxYTVlMjRhZDY0MmZiN2FjMDI0YS4u M2M1ZWZiNjk5MmNjOTExNGRlZWQxNGRlZjA4ODBjMDk3YTdhMmVhYiAxMDA2NDQKLS0tIGEvU291 cmNlL1dURi93dGYvUGFzc093blB0ci5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1Bhc3NPd25QdHIu aApAQCAtODksOSArODksNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogICAgIHRlbXBsYXRlPHR5cGVu YW1lIFQ+IGlubGluZSB0eXBlbmFtZSBQYXNzT3duUHRyPFQ+OjpQdHJUeXBlIFBhc3NPd25QdHI8 VD46OmxlYWtQdHIoKSBjb25zdAogICAgIHsKLSAgICAgICAgUHRyVHlwZSBwdHIgPSBtX3B0cjsK LSAgICAgICAgbV9wdHIgPSAwOwotICAgICAgICByZXR1cm4gcHRyOworICAgICAgICByZXR1cm4g c3RkOjpleGNoYW5nZShtX3B0ciwgbnVsbHB0cik7CiAgICAgfQogCiAgICAgdGVtcGxhdGU8dHlw ZW5hbWUgVCwgdHlwZW5hbWUgVT4gaW5saW5lIGJvb2wgb3BlcmF0b3I9PShjb25zdCBQYXNzT3du UHRyPFQ+JiBhLCBjb25zdCBQYXNzT3duUHRyPFU+JiBiKSAKZGlmZiAtLWdpdCBhL1NvdXJjZS9X VEYvd3RmL1Bhc3NSZWZQdHIuaCBiL1NvdXJjZS9XVEYvd3RmL1Bhc3NSZWZQdHIuaAppbmRleCBk ZDM3OGUwYzdiMTg0M2FjZjJhN2U1N2EwZjgxYjhlM2I1NTRhZGE2Li5kNTk3NmM2NGM1Mzk1OTYx MDU3N2VlN2NlMjdlYzI1Y2JlYmY3NjE4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV1RGL3d0Zi9QYXNz UmVmUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvUGFzc1JlZlB0ci5oCkBAIC05Myw5ICs5Myw3 IEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFQq IFBhc3NSZWZQdHI8VD46OmxlYWtSZWYoKSBjb25zdAogICAgIHsKLSAgICAgICAgVCogcHRyID0g bV9wdHI7Ci0gICAgICAgIG1fcHRyID0gbnVsbHB0cjsKLSAgICAgICAgcmV0dXJuIHB0cjsKKyAg ICAgICAgcmV0dXJuIHN0ZDo6ZXhjaGFuZ2UobV9wdHIsIG51bGxwdHIpOwogICAgIH0KIAogICAg IHRlbXBsYXRlPHR5cGVuYW1lIFQsIHR5cGVuYW1lIFU+IGlubGluZSBib29sIG9wZXJhdG9yPT0o Y29uc3QgUGFzc1JlZlB0cjxUPiYgYSwgY29uc3QgUGFzc1JlZlB0cjxVPiYgYikgCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV1RGL3d0Zi9SZWYuaCBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCmluZGV4IDRm NDc1NThhNzMyYzFhYjQ2YjJiZTQxYWY4ZGYyZDIwNzFiMjk5MDkuLjc0MDNlMWU4NTgxNGIyODQz YzJjNTEzMmYzZmM5ZDQzOGQ4YzA1YmUgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1JlZi5o CisrKyBiL1NvdXJjZS9XVEYvd3RmL1JlZi5oCkBAIC0xMTEsOSArMTExLDggQEAgcHVibGljOgog ICAgIFQmIGxlYWtSZWYoKSBXQVJOX1VOVVNFRF9SRVRVUk4KICAgICB7CiAgICAgICAgIEFTU0VS VChtX3B0cik7Ci0gICAgICAgIFQqIG1vdmVkUHRyID0gbV9wdHI7Ci0gICAgICAgIG1fcHRyID0g bnVsbHB0cjsKLSAgICAgICAgcmV0dXJuICptb3ZlZFB0cjsKKworICAgICAgICByZXR1cm4gKnN0 ZDo6ZXhjaGFuZ2UobV9wdHIsIG51bGxwdHIpOwogICAgIH0KIAogcHJpdmF0ZToKZGlmZiAtLWdp dCBhL1NvdXJjZS9XVEYvd3RmL1JlZlB0ci5oIGIvU291cmNlL1dURi93dGYvUmVmUHRyLmgKaW5k ZXggNTc2OGM3NWY3ODM4MWRlYWZhNDNkM2ZkODAyMGJjMDA0MTRiZDQ5Ny4uZjhmN2U1MDNlNTAz NWQzMjNlYzU3MThhYzc2YTljOGJlZWY3ZmM4NiAxMDA2NDQKLS0tIGEvU291cmNlL1dURi93dGYv UmVmUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvUmVmUHRyLmgKQEAgLTExMSwxOCArMTExLDEz IEBAIG5hbWVzcGFjZSBXVEYgewogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIHZv aWQgUmVmUHRyPFQ+OjpjbGVhcigpCiAgICAgewotICAgICAgICBUKiBwdHIgPSBtX3B0cjsKLSAg ICAgICAgbV9wdHIgPSBudWxscHRyOwotICAgICAgICBkZXJlZklmTm90TnVsbChwdHIpOworICAg ICAgICBkZXJlZklmTm90TnVsbChzdGQ6OmV4Y2hhbmdlKG1fcHRyLCBudWxscHRyKSk7CiAgICAg fQogCiAgICAgdGVtcGxhdGU8dHlwZW5hbWUgVD4KICAgICBpbmxpbmUgVCogUmVmUHRyPFQ+Ojps ZWFrUmVmKCkKICAgICB7Ci0gICAgICAgIFQqIHB0ciA9IG1fcHRyOwotICAgICAgICBtX3B0ciA9 IG51bGxwdHI7Ci0KLSAgICAgICAgcmV0dXJuIHB0cjsKKyAgICAgICAgcmV0dXJuIHN0ZDo6ZXhj aGFuZ2UobV9wdHIsIG51bGxwdHIpOwogICAgIH0KIAogICAgIHRlbXBsYXRlPHR5cGVuYW1lIFQ+ IGlubGluZSBSZWZQdHI8VD4mIFJlZlB0cjxUPjo6b3BlcmF0b3I9KGNvbnN0IFJlZlB0ciYgbykK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1JldGFpblB0ci5oIGIvU291cmNlL1dURi93dGYv UmV0YWluUHRyLmgKaW5kZXggM2RmZGQzYjZmZTgwNDZkNGUyOGM3NDVkNWJmNTliZThhODFlNGQ3 NS4uNjhiZDBmMTUzZDY2NGE2MjQ1ZWZmYTVlYWY5NzU1NGYxMTEzNTFhMSAxMDA2NDQKLS0tIGEv U291cmNlL1dURi93dGYvUmV0YWluUHRyLmgKKysrIGIvU291cmNlL1dURi93dGYvUmV0YWluUHRy LmgKQEAgLTE1NSw5ICsxNTUsNyBAQCBuYW1lc3BhY2UgV1RGIHsKIAogICAgIHRlbXBsYXRlPHR5 cGVuYW1lIFQ+IGlubGluZSB0eXBlbmFtZSBSZXRhaW5QdHI8VD46OlB0clR5cGUgUmV0YWluUHRy PFQ+OjpsZWFrUmVmKCkKICAgICB7Ci0gICAgICAgIFB0clR5cGUgcHRyID0gZnJvbVN0b3JhZ2VU eXBlKG1fcHRyKTsKLSAgICAgICAgbV9wdHIgPSBudWxscHRyOwotICAgICAgICByZXR1cm4gcHRy OworICAgICAgICByZXR1cm4gZnJvbVN0b3JhZ2VUeXBlKHN0ZDo6ZXhjaGFuZ2UobV9wdHIsIG51 bGxwdHIpKTsKICAgICB9CiAKICNpZmRlZiBfX09CSkNfXwo=