139788 2014-12-18 13:24:37 -0800 Clean up MachSendRight and add a copySendRight member function 2014-12-18 13:31:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca benjamin cmarcelo commit-queue oldest_to_newest 1056874 0 andersca 2014-12-18 13:24:37 -0800 Clean up MachSendRight and add a copySendRight member function 1056875 1 243514 andersca 2014-12-18 13:26:11 -0800 Created attachment 243514 Patch 1056877 2 commit-queue 2014-12-18 13:27:54 -0800 Attachment 243514 did not pass style-queue: ERROR: Source/WTF/wtf/StdLibExtras.h:374: Use 'WTF::move()' instead of 'std::move()'. [runtime/wtf_move] [4] Total errors found: 1 in 5 files If any of these errors are false positives, please file a bug against check-webkit-style. 1056879 3 andersca 2014-12-18 13:31:06 -0800 Committed r177521: <http://trac.webkit.org/changeset/177521> 243514 2014-12-18 13:26:11 -0800 2014-12-18 13:29:18 -0800 Patch bug-139788-20141218132610.patch text/plain 4751 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NTE2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL0NoYW5n ZUxvZyBiL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCmluZGV4IGIyOGI2ZWQ0M2Q0MzQ2ZGZmMDMyNWNl MmJiNzc0YzY5OTJjY2Y3NjcuLmQyM2ZmMmNkMzNlNzM4ZjM1YjQyMWNlMWVkNGNlMDE1MGVlOGFk ODMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XVEYvQ2hh bmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTQtMTItMTggIEFuZGVycyBDYXJsc3NvbiAgPGFu ZGVyc2NhQGFwcGxlLmNvbT4KKworICAgICAgICBDbGVhbiB1cCBNYWNoU2VuZFJpZ2h0IGFuZCBh ZGQgYSBjb3B5U2VuZFJpZ2h0IG1lbWJlciBmdW5jdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5Nzg4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiB3dGYvU3RkTGliRXh0cmFzLmg6CisgICAgICAg IChzdGQ6OmV4Y2hhbmdlKToKKyAgICAgICAgQWRkIGFuIGltcGxlbWVudGF0aW9uIG9mIHN0ZDo6 ZXhjaGFuZ2UuCisKIDIwMTQtMTItMTcgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4K IAogICAgICAgICBbaU9TXSBNYWtlIGl0IHBvc3NpYmxlIHRvIHRvZ2dsZSBGZWF0dXJlQ291bnRl ciBzdXBwb3J0IGF0IHJ1bnRpbWUKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBiM2IxM2YwNTRkMTUzNTk4Y2YwYjgw NzQ2NjUyNTMyNjc5ZDYzYjczLi41NGIxODdjYzI4MDZjOGM0NTNiYjc0YTM0YTcxZDgxM2Q0NDJi NzA5IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl YkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjUgQEAKIDIwMTQtMTItMTggIEFuZGVycyBDYXJs c3NvbiAgPGFuZGVyc2NhQGFwcGxlLmNvbT4KIAorICAgICAgICBDbGVhbiB1cCBNYWNoU2VuZFJp Z2h0IGFuZCBhZGQgYSBjb3B5U2VuZFJpZ2h0IG1lbWJlciBmdW5jdGlvbgorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5Nzg4CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9NYWNo U2VuZFJpZ2h0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OnJldGFpblNlbmRSaWdodCk6CisgICAg ICAgIChXZWJDb3JlOjpyZWxlYXNlU2VuZFJpZ2h0KToKKyAgICAgICAgVXNlIG1hY2hfZXJyb3Jf c3RyaW5nLgorCisgICAgICAgIChXZWJDb3JlOjpNYWNoU2VuZFJpZ2h0Ojpjb3B5U2VuZFJpZ2h0 KToKKyAgICAgICAgQ3JlYXRlIGEgbmV3IHNlbmQgcmlnaHQgd2l0aCB0aGUgZ2l2ZW4gbWFjaCBw b3J0LgorCisgICAgICAgIChXZWJDb3JlOjpNYWNoU2VuZFJpZ2h0OjpsZWFrU2VuZFJpZ2h0KToK KyAgICAgICAgVXNlIHN0ZDo6ZXhjaGFuZ2UuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9jb2NvYS9N YWNoU2VuZFJpZ2h0Lmg6CisKKzIwMTQtMTItMTggIEFuZGVycyBDYXJsc3NvbiAgPGFuZGVyc2Nh QGFwcGxlLmNvbT4KKwogICAgICAgICBBZGQgYSBNYWNoU2VuZFJpZ2h0IGNsYXNzIHRvIFdlYkNv cmUgYW5kIHVzZSBpdCBpbiBJT1N1cmZhY2UKICAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzOTc4NwogCmRpZmYgLS1naXQgYS9Tb3VyY2UvV1RGL3d0Zi9T dGRMaWJFeHRyYXMuaCBiL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCmluZGV4IGEwMTg3 MjMzMTNjZTJlN2Y1YTJhYjQ1MDI2YzRkMTliNDAzMjAwYWQuLmJhZTc4ODQwMmEzNzg4ZDc3NmQw YTE2ZjQwMmFjNTk0YTVlNTQ0YmEgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4 dHJhcy5oCisrKyBiL1NvdXJjZS9XVEYvd3RmL1N0ZExpYkV4dHJhcy5oCkBAIC0zNjcsNiArMzY3 LDE2IEBAIHRlbXBsYXRlPHNpemVfdCBjdXJyZW50SW5kZXgsIHNpemVfdC4uLmluZGV4ZXM+IHN0 cnVjdCBtYWtlX2luZGV4X3NlcXVlbmNlX2hlbHBlCiAKIHRlbXBsYXRlPHNpemVfdCBsZW5ndGg+ IHN0cnVjdCBtYWtlX2luZGV4X3NlcXVlbmNlIDogcHVibGljIG1ha2VfaW5kZXhfc2VxdWVuY2Vf aGVscGVyPGxlbmd0aD46OnR5cGUgeyB9OwogCisvLyBzdGQ6OmV4Y2hhbmdlCit0ZW1wbGF0ZTxj bGFzcyBULCBjbGFzcyBVID0gVD4KK1QgZXhjaGFuZ2UoVCYgdCwgVSYmIG5ld1ZhbHVlKQorewor ICAgIFQgb2xkVmFsdWUgPSBzdGQ6Om1vdmUodCk7CisgICAgdCA9IHN0ZDo6Zm9yd2FyZDxVPihu ZXdWYWx1ZSk7CisKKyAgICByZXR1cm4gb2xkVmFsdWU7Cit9CisKICNpZiBDT01QSUxFUl9TVVBQ T1JUUyhDWFhfVVNFUl9MSVRFUkFMUykKIC8vIFRoZXNlIGxpdGVyYWxzIGFyZSBhdmFpbGFibGUg aW4gQysrMTQsIHNvIG9uY2Ugd2UgcmVxdWlyZSBDKysxNCBjb21waWxlcnMgd2UgY2FuIGdldCBy aWQgb2YgdGhlbSBoZXJlLgogLy8gKFVzZXItbGl0ZXJhbHMgbmVlZCB0byBoYXZlIGEgbGVhZGlu ZyB1bmRlcnNjb3JlIHNvIHdlIGFkZCBpdCBoZXJlIC0gdGhlICJyZWFsIiBsaXRlcmFscyBkb24n dCBoYXZlIHVuZGVyc2NvcmVzKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3Jt L2NvY29hL01hY2hTZW5kUmlnaHQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2Ev TWFjaFNlbmRSaWdodC5jcHAKaW5kZXggZWI5YmYwMDM5ZDUxNTA4ZTcyMWZlMDNhMzlkYjNiZGMw MDZiZGVlNy4uYzEyZmI3MjA3NWM1ZTk5ZGUwZDViZTRiNTFlYzhjMTBkZDg2OGUwMiAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvTWFjaFNlbmRSaWdodC5jcHAKKysr IGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvTWFjaFNlbmRSaWdodC5jcHAKQEAgLTI2 LDYgKzI2LDcgQEAKICNpbmNsdWRlICJjb25maWcuaCIKICNpbmNsdWRlICJNYWNoU2VuZFJpZ2h0 LmgiCiAKKyNpbmNsdWRlIDxtYWNoL21hY2hfZXJyb3IuaD4KICNpbmNsdWRlIDx1dGlsaXR5Pgog CiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC0zNyw3ICszOCw3IEBAIHN0YXRpYyB2b2lkIHJldGFp blNlbmRSaWdodChtYWNoX3BvcnRfdCBwb3J0KQogCiAgICAgYXV0byBrciA9IG1hY2hfcG9ydF9t b2RfcmVmcyhtYWNoX3Rhc2tfc2VsZigpLCBwb3J0LCBNQUNIX1BPUlRfUklHSFRfU0VORCwgMSk7 CiAgICAgaWYgKGtyICE9IEtFUk5fU1VDQ0VTUykKLSAgICAgICAgTE9HX0VSUk9SKCJtYWNoX3Bv cnRfbW9kX3JlZnMgZXJyb3I6ICV4Iiwga3IpOworICAgICAgICBMT0dfRVJST1IoIm1hY2hfcG9y dF9tb2RfcmVmcyBlcnJvcjogJXMgKCV4KSIsIG1hY2hfZXJyb3Jfc3RyaW5nKGtyKSwga3IpOwog fQogCiBzdGF0aWMgdm9pZCByZWxlYXNlU2VuZFJpZ2h0KG1hY2hfcG9ydF90IHBvcnQpCkBAIC00 Nyw3ICs0OCw3IEBAIHN0YXRpYyB2b2lkIHJlbGVhc2VTZW5kUmlnaHQobWFjaF9wb3J0X3QgcG9y dCkKIAogICAgIGF1dG8ga3IgPSBtYWNoX3BvcnRfZGVhbGxvY2F0ZShtYWNoX3Rhc2tfc2VsZigp LCBwb3J0KTsKICAgICBpZiAoa3IgIT0gS0VSTl9TVUNDRVNTKQotICAgICAgICBMT0dfRVJST1Io Im1hY2hfcG9ydF9kZWFsbG9jYXRlIGVycm9yOiAleCIsIGtyKTsKKyAgICAgICAgTE9HX0VSUk9S KCJtYWNoX3BvcnRfZGVhbGxvY2F0ZSBlcnJvcjogJXMgKCV4KSIsIG1hY2hfZXJyb3Jfc3RyaW5n KGtyKSwga3IpOwogfQogCiBNYWNoU2VuZFJpZ2h0IE1hY2hTZW5kUmlnaHQ6OmFkb3B0KG1hY2hf cG9ydF90IHBvcnQpCkBAIC04NywxMiArODgsMTQgQEAgTWFjaFNlbmRSaWdodCYgTWFjaFNlbmRS aWdodDo6b3BlcmF0b3I9KE1hY2hTZW5kUmlnaHQmJiBvdGhlcikKICAgICByZXR1cm4gKnRoaXM7 CiB9CiAKLW1hY2hfcG9ydF90IE1hY2hTZW5kUmlnaHQ6OmxlYWtTZW5kUmlnaHQoKQorTWFjaFNl bmRSaWdodCBNYWNoU2VuZFJpZ2h0Ojpjb3B5U2VuZFJpZ2h0KCkgY29uc3QKIHsKLSAgICBtYWNo X3BvcnRfdCBwb3J0ID0gbV9wb3J0OwotICAgIG1fcG9ydCA9IE1BQ0hfUE9SVF9OVUxMOworICAg IHJldHVybiBjcmVhdGUobV9wb3J0KTsKK30KIAotICAgIHJldHVybiBwb3J0OworbWFjaF9wb3J0 X3QgTWFjaFNlbmRSaWdodDo6bGVha1NlbmRSaWdodCgpCit7CisgICAgcmV0dXJuIHN0ZDo6ZXhj aGFuZ2UobV9wb3J0LCBNQUNIX1BPUlRfTlVMTCk7CiB9CiAKIH0KZGlmZiAtLWdpdCBhL1NvdXJj ZS9XZWJDb3JlL3BsYXRmb3JtL2NvY29hL01hY2hTZW5kUmlnaHQuaCBiL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2NvY29hL01hY2hTZW5kUmlnaHQuaAppbmRleCA2MGQyMGNlM2QzMjNhYWVjNmU1 NGEzZmFmNGRlNzk4ZTk2Mjg0MGQzLi4zYmRkZDdlZGU2YjhhODMyODFkZTcxZTg0NzcxZDc3ZGVm MjI2MzlhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9jb2NvYS9NYWNoU2Vu ZFJpZ2h0LmgKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vY29jb2EvTWFjaFNlbmRSaWdo dC5oCkBAIC00MCw2ICs0MCw4IEBAIHB1YmxpYzoKIAogICAgIE1hY2hTZW5kUmlnaHQmIG9wZXJh dG9yPShNYWNoU2VuZFJpZ2h0JiYpOwogCisgICAgTWFjaFNlbmRSaWdodCBjb3B5U2VuZFJpZ2h0 KCkgY29uc3Q7CisKICAgICBtYWNoX3BvcnRfdCBsZWFrU2VuZFJpZ2h0KCkgV0FSTl9VTlVTRURf UkVUVVJOOwogCiBwcml2YXRlOgo=