139783 2014-12-18 11:21:28 -0800 Web Inspector: ASSERT seen closing/opening multiple inspectors 2014-12-18 12:45:28 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1056829 0 joepeck 2014-12-18 11:21:28 -0800 * SUMMARY I occasionally see this assert in Inspector code when opening/closing multiple inspectors repeatedly in Debug builds. Deprecated::ScriptValue InjectedScript::findObjectById(const String& objectId) const { ASSERT(!hasNoValue()); ... } We can safely avoid calling findObjectById if we have an empty InjectedScript. 1056830 1 webkit-bug-importer 2014-12-18 11:22:06 -0800 <rdar://problem/19296999> 1056831 2 243504 joepeck 2014-12-18 11:22:19 -0800 Created attachment 243504 [PATCH] Proposed Fix 1056870 3 243504 commit-queue 2014-12-18 12:45:24 -0800 Comment on attachment 243504 [PATCH] Proposed Fix Clearing flags on attachment: 243504 Committed r177518: <http://trac.webkit.org/changeset/177518> 1056871 4 commit-queue 2014-12-18 12:45:28 -0800 All reviewed patches have been landed. Closing bug. 243504 2014-12-18 11:22:19 -0800 2014-12-18 12:45:24 -0800 [PATCH] Proposed Fix assert-no-value.patch text/plain 1316 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBmMWZiNjRkLi40MjUxOTRjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTQtMTItMTggIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBBU1NFUlQgc2VlbiBjbG9zaW5nL29wZW5pbmcgbXVsdGlw bGUgaW5zcGVjdG9ycworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM5NzgzCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SW5zcGVjdG9yRE9NQWdlbnQ6Om5vZGVGb3JPYmplY3RJZCk6CisKIDIwMTQtMTItMTcgIHBl YXZvQG91dGxvb2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW0N1cmxdIENv bXBpbGUgZXJyb3IsIHNldFdhc0NhY2hlZCBtZXRob2QgaGFzIGJlZW4gcmVtb3ZlZC4KZGlmZiAt LWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01BZ2VudC5jcHAgYi9T b3VyY2UvV2ViQ29yZS9pbnNwZWN0b3IvSW5zcGVjdG9yRE9NQWdlbnQuY3BwCmluZGV4IDhiYzRj ZDcuLjExNTgwODggMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0 b3JET01BZ2VudC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRP TUFnZW50LmNwcApAQCAtMTk1Miw2ICsxOTUyLDkgQEAgTm9kZSogSW5zcGVjdG9yRE9NQWdlbnQ6 Om5vZGVGb3JQYXRoKGNvbnN0IFN0cmluZyYgcGF0aCkKIE5vZGUqIEluc3BlY3RvckRPTUFnZW50 Ojpub2RlRm9yT2JqZWN0SWQoY29uc3QgU3RyaW5nJiBvYmplY3RJZCkKIHsKICAgICBJbmplY3Rl ZFNjcmlwdCBpbmplY3RlZFNjcmlwdCA9IG1faW5qZWN0ZWRTY3JpcHRNYW5hZ2VyLT5pbmplY3Rl ZFNjcmlwdEZvck9iamVjdElkKG9iamVjdElkKTsKKyAgICBpZiAoaW5qZWN0ZWRTY3JpcHQuaGFz Tm9WYWx1ZSgpKQorICAgICAgICByZXR1cm4gbnVsbHB0cjsKKwogICAgIERlcHJlY2F0ZWQ6OlNj cmlwdFZhbHVlIHZhbHVlID0gaW5qZWN0ZWRTY3JpcHQuZmluZE9iamVjdEJ5SWQob2JqZWN0SWQp OwogICAgIHJldHVybiBJbnNwZWN0b3JET01BZ2VudDo6c2NyaXB0VmFsdWVBc05vZGUodmFsdWUp OwogfQo=