139782 2014-12-18 11:01:11 -0800 [WinCairo] Compile error in code for creating GL context. 2014-12-19 11:43:25 -0800 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen bfulgham commit-queue oldest_to_newest 1056826 0 peavo 2014-12-18 11:01:11 -0800 The GLContext::createContextForWindow method has changed return type to std::unique_ptr. 1056827 1 243503 peavo 2014-12-18 11:07:15 -0800 Created attachment 243503 Patch 1056975 2 243503 alex.christensen 2014-12-18 18:28:37 -0800 Comment on attachment 243503 Patch Thanks for keeping up with this. I'm working on some other urgent things right now, but I'll try to get a WinCairo build bot up soon so everybody can see and fix these simple compile problems. 1056976 3 243503 commit-queue 2014-12-18 19:04:59 -0800 Comment on attachment 243503 Patch Clearing flags on attachment: 243503 Committed r177558: <http://trac.webkit.org/changeset/177558> 1056977 4 commit-queue 2014-12-18 19:05:05 -0800 All reviewed patches have been landed. Closing bug. 1057116 5 peavo 2014-12-19 11:43:25 -0800 (In reply to comment #2) > Comment on attachment 243503 [details] > Patch > > Thanks for keeping up with this. I'm working on some other urgent things > right now, but I'll try to get a WinCairo build bot up soon so everybody can > see and fix these simple compile problems. That would be very nice, thanks for reviewing :) 243503 2014-12-18 11:07:15 -0800 2014-12-18 19:04:59 -0800 Patch bug-139782-20141218200657.patch text/plain 1328 peavo SW5kZXg6IFNvdXJjZS9XZWJLaXQvd2luL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2Uv V2ViS2l0L3dpbi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzUwNSkKKysrIFNvdXJjZS9XZWJLaXQv d2luL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEyLTE4 ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5D YWlyb10gQ29tcGlsZSBlcnJvciBpbiBjb2RlIGZvciBjcmVhdGluZyBHTCBjb250ZXh0LgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NzgyCisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIEdMQ29udGV4 dDo6Y3JlYXRlQ29udGV4dEZvcldpbmRvdyBtZXRob2QgaGFzIGNoYW5nZWQgcmV0dXJuIHR5cGUg dG8gc3RkOjp1bmlxdWVfcHRyLgorCisgICAgICAgICogV2ViQ29yZVN1cHBvcnQvQWNjZWxlcmF0 ZWRDb21wb3NpdGluZ0NvbnRleHQuaDoKKwogMjAxNC0xMi0xNyAgQW5kZXJzIENhcmxzc29uICA8 YW5kZXJzY2FAYXBwbGUuY29tPgogCiAgICAgICAgIEdldCByaWQgb2YgRnJhbWVMb2FkZXI6OmRl ZmF1bHRPYmplY3RDb250ZW50VHlwZQpJbmRleDogU291cmNlL1dlYktpdC93aW4vV2ViQ29yZVN1 cHBvcnQvQWNjZWxlcmF0ZWRDb21wb3NpdGluZ0NvbnRleHQuaAo9PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3Vy Y2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4 dC5oCShyZXZpc2lvbiAxNzc1MDEpCisrKyBTb3VyY2UvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9y dC9BY2NlbGVyYXRlZENvbXBvc2l0aW5nQ29udGV4dC5oCSh3b3JraW5nIGNvcHkpCkBAIC02Nyw3 ICs2Nyw3IEBAIHB1YmxpYzoKIAogcHJpdmF0ZToKICAgICBXZWJWaWV3JiBtX3dlYlZpZXc7Ci0g ICAgT3duUHRyPFdlYkNvcmU6OkdMQ29udGV4dD4gbV9jb250ZXh0OworICAgIHN0ZDo6dW5pcXVl X3B0cjxXZWJDb3JlOjpHTENvbnRleHQ+IG1fY29udGV4dDsKICAgICBIV05EIG1fd2luZG93Owog ICAgIHN0ZDo6dW5pcXVlX3B0cjxXZWJDb3JlOjpHcmFwaGljc0xheWVyPiBtX3Jvb3RMYXllcjsK ICAgICBzdGQ6OnVuaXF1ZV9wdHI8V2ViQ29yZTo6R3JhcGhpY3NMYXllcj4gbV9ub25Db21wb3Np dGVkQ29udGVudExheWVyOwo=