139773 2014-12-18 05:26:12 -0800 [EFL][WK2] Minibrowser : Add search icon to search bar 2015-05-16 00:12:40 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 tanay.c webkit-unassigned commit-queue gyuyoung.kim ossy ryuan.choi oldest_to_newest 1056758 0 tanay.c 2014-12-18 05:26:12 -0800 Add decoration icon in the search field in the minibrowser. 1056760 1 243494 tanay.c 2014-12-18 05:28:34 -0800 Created attachment 243494 Patch 1060780 2 tanay.c 2015-01-13 01:24:02 -0800 (In reply to comment #1) > Created attachment 243494 [details] > Patch Hi all, request to review. 1070380 3 ossy 2015-02-19 03:29:48 -0800 I tested, it works fine for me. It seems a little bit strange for me that search_icon is handled in a different way as other parts of the search toolbar, but I'm not EFL UI expert, so I let the technical review for others. 1073976 4 tanay.c 2015-03-03 21:44:22 -0800 Hi , It is implemented such that it supports changes to search icon as per the theme. Also to reuse the existing icon. Please let me know if there are any other comments? 1073980 5 243494 ryuan.choi 2015-03-03 21:51:07 -0800 Comment on attachment 243494 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243494&action=review > Tools/MiniBrowser/efl/main.c:417 > + edje_obj = edje_object_add(window->elm_window); > + edje_object_file_set(edje_obj, DEFAULT_THEME_DIR "/default.edj", "webkit/widget/search/results_decoration"); > + icon = edje_object_part_object_get(edje_obj, "decoration"); Are there any reason you want to use edje object of webkit theme instead of standard elm_icon such as "edit-find" ? 1074041 6 tanay.c 2015-03-04 04:19:10 -0800 I cannot find a icon suitable for this purpose in the already existing elm_icon's. Since the suitable icon is only available in webkit theme i am re-using the same. 1074786 7 ryuan.choi 2015-03-05 18:20:21 -0800 (In reply to comment #6) > I cannot find a icon suitable for this purpose in the already existing > elm_icon's. Since the suitable icon is only available in webkit theme i am > re-using the same. Please check "edit-find". It is introduced since 1.13. I think that we can use it because ewebkit is under development on EFL 1.13 since r180697. 1095042 8 253178 tanay.c 2015-05-14 23:15:02 -0700 Created attachment 253178 Patch 1095043 9 tanay.c 2015-05-14 23:17:26 -0700 Sorry for the delay. I am uploading a patch using the "edit-find" icon available in EFL 1.13. Please have a look. 1095411 10 253178 gyuyoung.kim 2015-05-15 23:23:46 -0700 Comment on attachment 253178 Patch LGTM. r=me. 1095417 11 253178 commit-queue 2015-05-16 00:12:31 -0700 Comment on attachment 253178 Patch Clearing flags on attachment: 253178 Committed r184432: <http://trac.webkit.org/changeset/184432> 1095418 12 commit-queue 2015-05-16 00:12:40 -0700 All reviewed patches have been landed. Closing bug. 243494 2014-12-18 05:28:34 -0800 2015-05-14 23:14:52 -0700 Patch bug-139773-20141218185855.patch text/plain 1980 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE3NzQ5MikKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE0LTEyLTE4ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtXSzJdIE1pbmlicm93c2VyIDogQWRkIHNlYXJjaCBpY29uIHRvIHNlYXJj aCBiYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz OTc3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TWluaUJyb3dzZXIvZWZsL21haW4uYzoKKyAgICAgICAgKHNlYXJjaF9pY29uX3Nob3cpOiBBZGRl ZC4KKyAgICAgICAgKHNlYXJjaF9ib3hfc2hvdyk6IE1vZGlmaWVkLiAKKwogMjAxNC0xMi0xNyAg THVjYXMgRm9yc2NobGVyICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBB cHBsZSBidWlsZGJvdCBzbGF2ZXMgdG8gdGhlaXIgbmV3IGhvbWUuCkluZGV4OiBUb29scy9NaW5p QnJvd3Nlci9lZmwvbWFpbi5jCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xzL01pbmlCcm93c2VyL2VmbC9t YWluLmMJKHJldmlzaW9uIDE3NzQ4OSkKKysrIFRvb2xzL01pbmlCcm93c2VyL2VmbC9tYWluLmMJ KHdvcmtpbmcgY29weSkKQEAgLTQwNywxMCArNDA3LDI3IEBAIHN0YXRpYyB2b2lkIHdpbmRvd19j bG9zZShCcm93c2VyX1dpbmRvdwogfQogCiBzdGF0aWMgdm9pZAorc2VhcmNoX2ljb25fc2hvdyhC cm93c2VyX1dpbmRvdyAqd2luZG93KQoreworICAgIEV2YXNfT2JqZWN0ICplZGplX29iajsKKyAg ICBjb25zdCBFdmFzX09iamVjdCAqaWNvbjsKKworICAgIGVkamVfb2JqID0gZWRqZV9vYmplY3Rf YWRkKHdpbmRvdy0+ZWxtX3dpbmRvdyk7CisgICAgZWRqZV9vYmplY3RfZmlsZV9zZXQoZWRqZV9v YmosIERFRkFVTFRfVEhFTUVfRElSICIvZGVmYXVsdC5lZGoiLCAid2Via2l0L3dpZGdldC9zZWFy Y2gvcmVzdWx0c19kZWNvcmF0aW9uIik7CisgICAgaWNvbiA9IGVkamVfb2JqZWN0X3BhcnRfb2Jq ZWN0X2dldChlZGplX29iaiwgImRlY29yYXRpb24iKTsKKyAgICBlbG1fb2JqZWN0X3BhcnRfY29u dGVudF91bnNldCh3aW5kb3ctPnNlYXJjaC5zZWFyY2hfZmllbGQsICJpY29uIik7CisgICAgZWxt X29iamVjdF9wYXJ0X2NvbnRlbnRfc2V0KHdpbmRvdy0+c2VhcmNoLnNlYXJjaF9maWVsZCwgImlj b24iLCAoRXZhc19PYmplY3QgKilpY29uKTsKKyAgICBldmFzX29iamVjdF9zaXplX2hpbnRfbWlu X3NldCgoRXZhc19PYmplY3QgKilpY29uLCAyMCwgMjApOworICAgIGV2YXNfb2JqZWN0X3NpemVf aGludF9tYXhfc2V0KChFdmFzX09iamVjdCAqKWljb24sIDIwLCAyMCk7CisgICAgZWxtX2VudHJ5 X2ljb25fdmlzaWJsZV9zZXQod2luZG93LT5zZWFyY2guc2VhcmNoX2ZpZWxkLCBFSU5BX1RSVUUp OworfQorCitzdGF0aWMgdm9pZAogc2VhcmNoX2JveF9zaG93KEJyb3dzZXJfV2luZG93ICp3aW5k b3cpCiB7CiAgICAgZXZhc19vYmplY3Rfc2l6ZV9oaW50X21pbl9zZXQod2luZG93LT5zZWFyY2gu c2VhcmNoX2JhciwgU0VBUkNIX0ZJRUxEX1NJWkUgKyAyICogU0VBUkNIX0JVVFRPTl9TSVpFLCBT RUFSQ0hfQlVUVE9OX1NJWkUpOwogCisgICAgc2VhcmNoX2ljb25fc2hvdyh3aW5kb3cpOwogICAg IGV2YXNfb2JqZWN0X3Nob3cod2luZG93LT5zZWFyY2guc2VhcmNoX2Jhcik7CiAgICAgZXZhc19v YmplY3Rfc2hvdyh3aW5kb3ctPnNlYXJjaC5zZWFyY2hfZmllbGQpOwogICAgIGV2YXNfb2JqZWN0 X3Nob3cod2luZG93LT5zZWFyY2guc2VhcmNoX2ZpZWxkX2NvdW50KTsK 253178 2015-05-14 23:15:02 -0700 2015-05-16 00:12:31 -0700 Patch bug-139773-20150515114350.patch text/plain 1733 tanay.c SW5kZXg6IFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9DaGFuZ2VMb2cJKHJl dmlzaW9uIDE4NDM3MykKKysrIFRvb2xzL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE0IEBACisyMDE1LTA1LTE0ICBUYW5heSBDICA8dGFuYXkuY0BzYW1zdW5nLmNvbT4KKwor ICAgICAgICBbRUZMXVtXSzJdIE1pbmlicm93c2VyIDogQWRkIHNlYXJjaCBpY29uIHRvIHNlYXJj aCBiYXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz OTc3MworCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICog TWluaUJyb3dzZXIvZWZsL21haW4uYzogCisgICAgICAgIChzZWFyY2hfaWNvbl9zaG93KTogQWRk ZWQuCisgICAgICAgIChzZWFyY2hfYm94X3Nob3cpOiBNb2RpZmllZC4KKwogMjAxNS0wNS0xNCAg VGltb3RoeSBIb3J0b24gIDx0aW1vdGh5X2hvcnRvbkBhcHBsZS5jb20+CiAKICAgICAgICAgQWRk IGEgbGF5b3V0IG1vZGUgdGhhdCBzY2FsZXMgZG93biB0aGUgdmlldyB0byB0cnkgdG8gZml0IHRo ZSBkb2N1bWVudApJbmRleDogVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwo9PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 Ci0tLSBUb29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCShyZXZpc2lvbiAxODQzMzApCisrKyBU b29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCSh3b3JraW5nIGNvcHkpCkBAIC00MDcsMTAgKzQw NywyMyBAQCBzdGF0aWMgdm9pZCB3aW5kb3dfY2xvc2UoQnJvd3Nlcl9XaW5kb3cKIH0KIAogc3Rh dGljIHZvaWQKK3NlYXJjaF9pY29uX3Nob3coQnJvd3Nlcl9XaW5kb3cgKndpbmRvdykKK3sKKyAg ICBFdmFzX09iamVjdCAqaWNvbiA9IGVsbV9pY29uX2FkZCh3aW5kb3ctPmVsbV93aW5kb3cpOwor ICAgIGVsbV9pY29uX3N0YW5kYXJkX3NldChpY29uLCAiZWRpdC1maW5kIik7CisgICAgZWxtX29i amVjdF9wYXJ0X2NvbnRlbnRfc2V0KHdpbmRvdy0+c2VhcmNoLnNlYXJjaF9maWVsZCwgImljb24i LCBpY29uKTsKKyAgICBldmFzX29iamVjdF9zaXplX2hpbnRfbWluX3NldChpY29uLCAyMCwgMjAp OworICAgIGV2YXNfb2JqZWN0X3NpemVfaGludF9tYXhfc2V0KGljb24sIDIwLCAyMCk7CisgICAg ZWxtX2VudHJ5X2ljb25fdmlzaWJsZV9zZXQod2luZG93LT5zZWFyY2guc2VhcmNoX2ZpZWxkLCBF SU5BX1RSVUUpOworICAgIGV2YXNfb2JqZWN0X3Nob3coaWNvbik7Cit9CisKK3N0YXRpYyB2b2lk CiBzZWFyY2hfYm94X3Nob3coQnJvd3Nlcl9XaW5kb3cgKndpbmRvdykKIHsKICAgICBldmFzX29i amVjdF9zaXplX2hpbnRfbWluX3NldCh3aW5kb3ctPnNlYXJjaC5zZWFyY2hfYmFyLCBTRUFSQ0hf RklFTERfU0laRSArIDIgKiBTRUFSQ0hfQlVUVE9OX1NJWkUsIFNFQVJDSF9CVVRUT05fU0laRSk7 CiAKKyAgICBzZWFyY2hfaWNvbl9zaG93KHdpbmRvdyk7CiAgICAgZXZhc19vYmplY3Rfc2hvdyh3 aW5kb3ctPnNlYXJjaC5zZWFyY2hfYmFyKTsKICAgICBldmFzX29iamVjdF9zaG93KHdpbmRvdy0+ c2VhcmNoLnNlYXJjaF9maWVsZCk7CiAgICAgZXZhc19vYmplY3Rfc2hvdyh3aW5kb3ctPnNlYXJj aC5zZWFyY2hfZmllbGRfY291bnQpOwo=