139771 2014-12-18 05:06:55 -0800 [GTK] [EFL] Enable per_test_timeout 2014-12-18 05:32:52 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez ap cgarcia commit-queue glenn gyuyoung.kim mrobinson ossy pnormand oldest_to_newest 1056754 0 clopez 2014-12-18 05:06:55 -0800 Following the discussion on https://bugs.webkit.org/show_bug.cgi?id=139671 and https://bugs.webkit.org/show_bug.cgi?id=139734 supports_per_test_timeout() should be enabled in order to pass to WKTR the --timeout parameter: Tools/Scripts/webkitpy/port/driver.py: if self._port.supports_per_test_timeout(): Tools/Scripts/webkitpy/port/driver.py: command += "'--timeout'%s" % driver_input.timeout This is needed to make WKTR use either the default port timeout, or the user supplied timeout via "Tools/Scripts/run-webkit-tests --time-out-ms=...". Otherwise WTR will use the default (30 seconds after r177363). GTK and EFL ports are not enabling it, so enable it. 1056759 1 243493 clopez 2014-12-18 05:27:59 -0800 Created attachment 243493 Patch 1056761 2 243493 ossy 2014-12-18 05:29:44 -0800 Comment on attachment 243493 Patch rs=me 1056763 3 243493 clopez 2014-12-18 05:32:44 -0800 Comment on attachment 243493 Patch Clearing flags on attachment: 243493 Committed r177493: <http://trac.webkit.org/changeset/177493> 1056764 4 clopez 2014-12-18 05:32:52 -0800 All reviewed patches have been landed. Closing bug. 243493 2014-12-18 05:27:59 -0800 2014-12-18 05:32:44 -0800 Patch bug-139771-20141218142758.patch text/plain 2120 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NDkxCmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggOTE5ZDdkNjU0Mjk1NmYxMjFhNGE4ZTlmMDNlZTk3MjY2 MWRlNzExNi4uYmE3NThiNmMzYzgyOTYwMTU2YjhlZGZiY2Y3ZTUwMzEzNTk2ODhhZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5 IEBACisyMDE0LTEyLTE4ICBDYXJsb3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2Fs aWEuY29tPgorCisgICAgICAgIFtHVEtdIFtFRkxdIEVuYWJsZSBwZXJfdGVzdF90aW1lb3V0Cisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk3NzEKKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBUaGlzIGlzIG5l ZWRlZCB0byBtYWtlIFdLVFIgdXNlIGVpdGhlciB0aGUgZGVmYXVsdCBwb3J0IHRpbWVvdXQsIG9y IHRoZQorICAgICAgICB1c2VyIHN1cHBsaWVkIHRpbWVvdXQgdmlhIHRoZSAiLS10aW1lLW91dC1t cyIgcGFyYW1ldGVyIG9mIHJ1bi13ZWJraXQtdGVzdHMuCisgICAgICAgIE90aGVyd2lzZSBXVFIg d2lsbCB1c2UgdGhlIGRlZmF1bHQgKDMwIHNlY29uZHMgYWZ0ZXIgcjE3NzM2MyBhbmQgcjE3NzQ3 MSkuCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3BvcnQvZWZsLnB5OgorICAgICAgICAo RWZsUG9ydC5zdXBwb3J0c19wZXJfdGVzdF90aW1lb3V0KTogRW5hYmxlZC4KKyAgICAgICAgKiBT Y3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3RrLnB5OgorICAgICAgICAoR3RrUG9ydC5zdXBwb3J0c19w ZXJfdGVzdF90aW1lb3V0KTogRW5hYmxlZC4KKwogMjAxNC0xMi0xNyAgTHVjYXMgRm9yc2NobGVy ICA8bGZvcnNjaGxlckBhcHBsZS5jb20+CiAKICAgICAgICAgTW92ZSBBcHBsZSBidWlsZGJvdCBz bGF2ZXMgdG8gdGhlaXIgbmV3IGhvbWUuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtp dHB5L3BvcnQvZWZsLnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2VmbC5weQppbmRl eCA2NmQ5ZjNlZWI0YTdkZjcwY2VlZTQ1ZTg4NDIwNGUwZDJhMzc2NTc2Li4zYzg5MjE5N2VjYjNl NzQ2YmQ1ZGJmZjQzODViNzJiOTI5MDFlMGY0IDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dl YmtpdHB5L3BvcnQvZWZsLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9lZmwu cHkKQEAgLTc4LDYgKzc4LDkgQEAgY2xhc3MgRWZsUG9ydChQb3J0KToKIAogICAgICAgICByZXR1 cm4gZW52CiAKKyAgICBkZWYgc3VwcG9ydHNfcGVyX3Rlc3RfdGltZW91dChzZWxmKToKKyAgICAg ICAgcmV0dXJuIFRydWUKKwogICAgIGRlZiBkZWZhdWx0X3RpbWVvdXRfbXMoc2VsZik6CiAgICAg ICAgICMgVGVzdHMgcnVuIGNvbnNpZGVyYWJseSBzbG93ZXIgdW5kZXIgZ2RiCiAgICAgICAgICMg b3IgdmFsZ3JpbmQuCmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQvZ3Rr LnB5IGIvVG9vbHMvU2NyaXB0cy93ZWJraXRweS9wb3J0L2d0ay5weQppbmRleCAzMzhlMmQxMzVl NjcxMjcyNGE0NzBkMTc4MDA5ODQ5ZDBmMzBhZjg2Li5hZDQ1MWJlNGIzYWQ2MGRjODZiNjlmNjk1 ZWMyNDdkNWY4ZDU5NWVkIDEwMDY0NAotLS0gYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5L3BvcnQv Z3RrLnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9ndGsucHkKQEAgLTgwLDYg KzgwLDkgQEAgY2xhc3MgR3RrUG9ydChQb3J0KToKICAgICAgICAgICAgIHJldHVybiBYb3JnRHJp dmVyCiAgICAgICAgIHJldHVybiBYdmZiRHJpdmVyCiAKKyAgICBkZWYgc3VwcG9ydHNfcGVyX3Rl c3RfdGltZW91dChzZWxmKToKKyAgICAgICAgcmV0dXJuIFRydWUKKwogICAgIGRlZiBkZWZhdWx0 X3RpbWVvdXRfbXMoc2VsZik6CiAgICAgICAgICMgU3RhcnRpbmcgYW4gYXBwbGljYXRpb24gdW5k ZXIgVmFsZ3JpbmQgdGFrZXMgYSBsb3QgbG9uZ2VyIHRoYW4gbm9ybWFsCiAgICAgICAgICMgc28g aW5jcmVhc2UgdGhlIHRpbWVvdXQgKGVtcGlyaWNhbGx5IDEweCBpcyBlbm91Z2ggdG8gYXZvaWQg dGltZW91dHMpLgo=