139766 2014-12-18 01:16:10 -0800 Internals methods return 0 instead of false when they fail 2014-12-18 09:44:23 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski commit-queue darin rniwa oldest_to_newest 1056729 0 g.czajkowski 2014-12-18 01:16:10 -0800 Clean up. Darin asked me to change those values when he was reviewing bug 133939 comment 11. 1056730 1 243485 g.czajkowski 2014-12-18 01:18:33 -0800 Created attachment 243485 Patch 1056794 2 243485 commit-queue 2014-12-18 09:44:19 -0800 Comment on attachment 243485 Patch Clearing flags on attachment: 243485 Committed r177500: <http://trac.webkit.org/changeset/177500> 1056795 3 commit-queue 2014-12-18 09:44:23 -0800 All reviewed patches have been landed. Closing bug. 243485 2014-12-18 01:18:33 -0800 2014-12-18 09:44:19 -0800 Patch bug-139766-20141218101832.patch text/plain 2430 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NDg4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMDYxMDlmNjQyZmZhZDhj M2ZmZjRmZGFhMDNjMWE4MDJhYzdiZThlMS4uZGQzMTBmYmI3ODJkNmJhY2M4ODQwNjZjZmZkNTRi Y2UwYTUxZGFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEyLTE4ICBHcnpl Z29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1bmcuY29tPgorCisgICAgICAgIElu dGVybmFscyBtZXRob2RzIHJldHVybiAwIGluc3RlYWQgb2YgZmFsc2Ugd2hlbiB0aGV5IGZhaWwK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTc2Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFNvbWUgSW50 ZXJuYWxzIG1ldGhvZCBleHBsaWNpdGx5IHJldHVybiAwIGFsdGhvdWdoCisgICAgICAgIHRoZXkg ZXhwZWN0IGJvb2xlYW4gdmFsdWUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBubyBiZWhhdmlv ciBjaGFuZ2UuCisKKyAgICAgICAgKiB0ZXN0aW5nL0ludGVybmFscy5jcHA6CisgICAgICAgIChX ZWJDb3JlOjpJbnRlcm5hbHM6Omhhc1NwZWxsaW5nTWFya2VyKToKKyAgICAgICAgKFdlYkNvcmU6 OkludGVybmFsczo6aGFzQXV0b2NvcnJlY3RlZE1hcmtlcik6CisgICAgICAgIChXZWJDb3JlOjpJ bnRlcm5hbHM6OmlzT3ZlcndyaXRlTW9kZUVuYWJsZWQpOgorICAgICAgICAoV2ViQ29yZTo6SW50 ZXJuYWxzOjpoYXNHcmFtbWFyTWFya2VyKToKKyAgICAgICAgUmV0dXJuIGZhbHNlIGluc3RlYWQg b2YgMC4KKwogMjAxNC0xMi0xNyAgQ3NhYmEgT3N6dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3Jn PgogCiAgICAgICAgIFVSVEJGIGFmdGVyIHIxNzc0NTIuCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS90ZXN0aW5nL0ludGVybmFscy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS90ZXN0aW5nL0ludGVy bmFscy5jcHAKaW5kZXggYWIyNDFlNmZjOTYzNmY2Y2M5OWExZDc0Mjk5YjM2NDAwZjY4MjUwZC4u ZWE5NjkxY2ZkN2NhYWVhMDIyZDZjZTMwOWFhN2UyYTUyZWE1ZmMxYyAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvdGVzdGluZy9JbnRlcm5hbHMuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3Rl c3RpbmcvSW50ZXJuYWxzLmNwcApAQCAtMTMzNSw3ICsxMzM1LDcgQEAgYm9vbCBJbnRlcm5hbHM6 Omhhc1NwZWxsaW5nTWFya2VyKGludCBmcm9tLCBpbnQgbGVuZ3RoLCBFeGNlcHRpb25Db2RlJikK IHsKICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBjb250ZXh0RG9jdW1lbnQoKTsKICAgICBpZiAo IWRvY3VtZW50IHx8ICFkb2N1bWVudC0+ZnJhbWUoKSkKLSAgICAgICAgcmV0dXJuIDA7CisgICAg ICAgIHJldHVybiBmYWxzZTsKIAogICAgIHVwZGF0ZUVkaXRvclVJTm93SWZTY2hlZHVsZWQoKTsK IApAQCAtMTM0Niw3ICsxMzQ2LDcgQEAgYm9vbCBJbnRlcm5hbHM6Omhhc0F1dG9jb3JyZWN0ZWRN YXJrZXIoaW50IGZyb20sIGludCBsZW5ndGgsIEV4Y2VwdGlvbkNvZGUmKQogewogICAgIERvY3Vt ZW50KiBkb2N1bWVudCA9IGNvbnRleHREb2N1bWVudCgpOwogICAgIGlmICghZG9jdW1lbnQgfHwg IWRvY3VtZW50LT5mcmFtZSgpKQotICAgICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIGZh bHNlOwogCiAgICAgdXBkYXRlRWRpdG9yVUlOb3dJZlNjaGVkdWxlZCgpOwogCkBAIC0xNDMxLDcg KzE0MzEsNyBAQCBib29sIEludGVybmFsczo6aXNPdmVyd3JpdGVNb2RlRW5hYmxlZChFeGNlcHRp b25Db2RlJikKIHsKICAgICBEb2N1bWVudCogZG9jdW1lbnQgPSBjb250ZXh0RG9jdW1lbnQoKTsK ICAgICBpZiAoIWRvY3VtZW50IHx8ICFkb2N1bWVudC0+ZnJhbWUoKSkKLSAgICAgICAgcmV0dXJu IDA7CisgICAgICAgIHJldHVybiBmYWxzZTsKIAogICAgIHJldHVybiBkb2N1bWVudC0+ZnJhbWUo KS0+ZWRpdG9yKCkuaXNPdmVyd3JpdGVNb2RlRW5hYmxlZCgpOwogfQpAQCAtMTU2MSw3ICsxNTYx LDcgQEAgYm9vbCBJbnRlcm5hbHM6Omhhc0dyYW1tYXJNYXJrZXIoaW50IGZyb20sIGludCBsZW5n dGgsIEV4Y2VwdGlvbkNvZGUmKQogewogICAgIERvY3VtZW50KiBkb2N1bWVudCA9IGNvbnRleHRE b2N1bWVudCgpOwogICAgIGlmICghZG9jdW1lbnQgfHwgIWRvY3VtZW50LT5mcmFtZSgpKQotICAg ICAgICByZXR1cm4gMDsKKyAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcmV0dXJuIGRvY3Vt ZW50LT5mcmFtZSgpLT5lZGl0b3IoKS5zZWxlY3Rpb25TdGFydEhhc01hcmtlckZvcihEb2N1bWVu dE1hcmtlcjo6R3JhbW1hciwgZnJvbSwgbGVuZ3RoKTsKIH0K