139752 2014-12-17 15:36:21 -0800 Fix the GTK build after r177452 2014-12-17 23:19:22 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139735 1 ossy ossy andersca cgarcia clopez commit-queue kling ossy oldest_to_newest 1056567 0 ossy 2014-12-17 15:36:21 -0800 Fix the GTK build after r177452 1056568 1 243465 ossy 2014-12-17 15:36:38 -0800 Created attachment 243465 Patch 1056569 2 commit-queue 2014-12-17 15:38:29 -0800 Attachment 243465 did not pass style-queue: ERROR: Source/WebCore/ChangeLog:8: You should remove the 'No new tests' and either add and list tests, or explain why no new tests were possible. [changelog/nonewtests] [5] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1056570 3 ossy 2014-12-17 15:40:47 -0800 I don't know what is PluginDatabase, if GTK really needs it or not, ... It is only a speculative fix, which made the build happy. Feel free to reuse this patch and fix it properly. Maybe removing code from FrameLoader.cpp is absolutely incorrect, at least !COCOA&&!EFL&&!GTK port ( == WIN ? ). 1056611 4 andersca 2014-12-17 16:59:22 -0800 Thanks for the analysis! Turns out that FrameLoader::defaultObjectContentType is only used on Windows, so I'm going to move that code there. 1056690 5 andersca 2014-12-17 17:56:58 -0800 I got rid of the function in https://trac.webkit.org/r177482 1056724 6 ossy 2014-12-17 23:19:22 -0800 cmake fix landed in https://trac.webkit.org/changeset/177488 243465 2014-12-17 15:36:38 -0800 2014-12-17 15:36:38 -0800 Patch bug-139752-20141217153728.patch text/plain 3979 ossy U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NDY0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZjFmYjY0ZGRmZGI4MGIx YzQxYzhmZWMwNWFjNWJhNGQwZmM3MjIzMC4uNGY2MTVjNWZiOTRjY2EzYjI2YmJjY2Y3ODAzY2Uy ZmVlOTI5MGEwMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTE3ICBDc2Fi YSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CisKKyAgICAgICAgRml4IHRoZSBHVEsg YnVpbGQgYWZ0ZXIgcjE3NzQ1MgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM5NzUyCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIChPT1BTISkuCisKKyAgICAgICAgKiBDTWFrZUxpc3Rz LnR4dDoKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6RnJhbWVMb2FkZXI6OmRlZmF1bHRPYmplY3RDb250ZW50VHlwZSk6CisKIDIwMTQtMTItMTcg IHBlYXZvQG91dGxvb2suY29tICA8cGVhdm9Ab3V0bG9vay5jb20+CiAKICAgICAgICAgW0N1cmxd IENvbXBpbGUgZXJyb3IsIHNldFdhc0NhY2hlZCBtZXRob2QgaGFzIGJlZW4gcmVtb3ZlZC4KZGlm ZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwppbmRleCBhZmU1ODA2YTg5OGZmM2ZiMTJkNWMyZDgyYTU1ZjcyZTNiZTBkZDIyLi5hNGEz MDgzMWY5MjI1YjM2NGFhMzM0YTVkMWQyYzJjOWM2ODJhZjdiIDEwMDY0NAotLS0gYS9Tb3VyY2Uv V2ViS2l0Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMg KzEsMTIgQEAKKzIwMTQtMTItMTcgIENzYWJhIE9zenRyb2dvbsOhYyAgPG9zc3lAd2Via2l0Lm9y Zz4KKworICAgICAgICBGaXggdGhlIEdUSyBidWlsZCBhZnRlciByMTc3NDUyCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk3NTIKKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9QbHVnaW5z L3VuaXgvUGx1Z2luSW5mb1N0b3JlVW5peC5jcHA6CisKIDIwMTQtMTItMTcgIEVucmljYSBDYXN1 Y2NpICA8ZW5yaWNhQGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBEZWZpbmUgYnV0dG9uIGFu ZCBhY3Rpb24gc2hvdWxkIHJlc3BlY3QgcHJvZmlsZSBzZXR0aW5ncy4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NNYWtlTGlzdHMudHh0IGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50 eHQKaW5kZXggZWI1ZTBiMGUyMmFjNGE3YWVkOWYzMmZjYmJhZDU0MmYxZTZhNjliMy4uM2M1NWE1 NzcyZGRkMmM3OGUxZmE1NDk4ZmEyNDIzNWU3YWZjMTdhMyAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQK QEAgLTIyNDMsNyArMjI0Myw2IEBAIHNldChXZWJDb3JlX1NPVVJDRVMKICAgICBwbHVnaW5zL0RP TVBsdWdpbi5jcHAKICAgICBwbHVnaW5zL0RPTVBsdWdpbkFycmF5LmNwcAogICAgIHBsdWdpbnMv UGx1Z2luRGF0YS5jcHAKLSAgICBwbHVnaW5zL1BsdWdpbkRhdGFiYXNlLmNwcAogICAgIHBsdWdp bnMvUGx1Z2luRGVidWcuY3BwCiAgICAgcGx1Z2lucy9QbHVnaW5NYWluVGhyZWFkU2NoZWR1bGVy LmNwcAogICAgIHBsdWdpbnMvUGx1Z2luU3RyZWFtLmNwcApkaWZmIC0tZ2l0IGEvU291cmNlL1dl YkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFt ZUxvYWRlci5jcHAKaW5kZXggMjdmNTI4NTIxMDYwZWQ3NjllZmM4MjNlZmYyMzMzZGQ2Y2U3YzQx NS4uMzUxNzI2NTM5YzVmZTMyMzk4MjBlNmRhNGY1MWUwZGE0ODI1MzQ1MSAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC05MCw3ICs5MCw2IEBACiAjaW5jbHVkZSAiUGFn ZVRyYW5zaXRpb25FdmVudC5oIgogI2luY2x1ZGUgIlBsYXRmb3JtU3RyYXRlZ2llcy5oIgogI2lu Y2x1ZGUgIlBsdWdpbkRhdGEuaCIKLSNpbmNsdWRlICJQbHVnaW5EYXRhYmFzZS5oIgogI2luY2x1 ZGUgIlBsdWdpbkRvY3VtZW50LmgiCiAjaW5jbHVkZSAiUG9saWN5Q2hlY2tlci5oIgogI2luY2x1 ZGUgIlByb2dyZXNzVHJhY2tlci5oIgpAQCAtOTY0LDIxICs5NjMsMTAgQEAgT2JqZWN0Q29udGVu dFR5cGUgRnJhbWVMb2FkZXI6OmRlZmF1bHRPYmplY3RDb250ZW50VHlwZShjb25zdCBVUkwmIHVy bCwgY29uc3QgU3QKICAgICBpZiAobWltZVR5cGUuaXNFbXB0eSgpKQogICAgICAgICBtaW1lVHlw ZSA9IG1pbWVUeXBlRnJvbVVSTCh1cmwpOwogCi0jaWYgIVBMQVRGT1JNKENPQ09BKSAmJiAhUExB VEZPUk0oRUZMKSAvLyBNYWMgaGFzIG5vIFBsdWdpbkRhdGFiYXNlLCBub3IgZG9lcyBFRkwKLSAg ICBpZiAobWltZVR5cGUuaXNFbXB0eSgpKSB7Ci0gICAgICAgIFN0cmluZyBkZWNvZGVkUGF0aCA9 IGRlY29kZVVSTEVzY2FwZVNlcXVlbmNlcyh1cmwucGF0aCgpKTsKLSAgICAgICAgbWltZVR5cGUg PSBQbHVnaW5EYXRhYmFzZTo6aW5zdGFsbGVkUGx1Z2lucygpLT5NSU1FVHlwZUZvckV4dGVuc2lv bihkZWNvZGVkUGF0aC5zdWJzdHJpbmcoZGVjb2RlZFBhdGgucmV2ZXJzZUZpbmQoJy4nKSArIDEp KTsKLSAgICB9Ci0jZW5kaWYKLQogICAgIGlmIChtaW1lVHlwZS5pc0VtcHR5KCkpCiAgICAgICAg IHJldHVybiBPYmplY3RDb250ZW50RnJhbWU7IC8vIEdvIGFoZWFkIGFuZCBob3BlIHRoYXQgd2Ug Y2FuIGRpc3BsYXkgdGhlIGNvbnRlbnQuCiAKLSNpZiAhUExBVEZPUk0oQ09DT0EpICYmICFQTEFU Rk9STShFRkwpIC8vIE1hYyBoYXMgbm8gUGx1Z2luRGF0YWJhc2UsIG5vciBkb2VzIEVGTAotICAg IGJvb2wgcGx1Z0luU3VwcG9ydHNNSU1FVHlwZSA9IFBsdWdpbkRhdGFiYXNlOjppbnN0YWxsZWRQ bHVnaW5zKCktPmlzTUlNRVR5cGVSZWdpc3RlcmVkKG1pbWVUeXBlKTsKLSNlbHNlCiAgICAgYm9v bCBwbHVnSW5TdXBwb3J0c01JTUVUeXBlID0gZmFsc2U7Ci0jZW5kaWYKIAogICAgIGlmIChNSU1F VHlwZVJlZ2lzdHJ5Ojppc1N1cHBvcnRlZEltYWdlTUlNRVR5cGUobWltZVR5cGUpKQogICAgICAg ICByZXR1cm4gc2hvdWxkUHJlZmVyUGx1Z0luc0ZvckltYWdlcyAmJiBwbHVnSW5TdXBwb3J0c01J TUVUeXBlID8gV2ViQ29yZTo6T2JqZWN0Q29udGVudE5ldHNjYXBlUGx1Z2luIDogV2ViQ29yZTo6 T2JqZWN0Q29udGVudEltYWdlOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1BsdWdpbnMvdW5peC9QbHVnaW5JbmZvU3RvcmVVbml4LmNwcCBiL1NvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9QbHVnaW5zL3VuaXgvUGx1Z2luSW5mb1N0b3JlVW5peC5jcHAKaW5kZXggYTk2ODU2 MThmNDQ2ZGUzYTk1MDQ3Yjc5YWM5MGVkMTU4M2JmYzEyNi4uNWY1NDA5ZmU0YTExYjU4Y2FmMGVm MDBmZWNjOGE0YzIxMzhiZDQ2YiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNz L1BsdWdpbnMvdW5peC9QbHVnaW5JbmZvU3RvcmVVbml4LmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvUGx1Z2lucy91bml4L1BsdWdpbkluZm9TdG9yZVVuaXguY3BwCkBAIC0zMiw3 ICszMiw2IEBACiAjaW5jbHVkZSAiUGx1Z2luSW5mb1N0b3JlLmgiCiAKICNpbmNsdWRlICJOZXRz Y2FwZVBsdWdpbk1vZHVsZS5oIgotI2luY2x1ZGUgIlBsdWdpbkRhdGFiYXNlLmgiCiAjaW5jbHVk ZSA8V2ViQ29yZS9GaWxlU3lzdGVtLmg+CiAKICNpZiBQTEFURk9STShHVEspCg==