139748 2014-12-17 14:17:42 -0800 [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts 2015-01-26 20:06:42 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser ap commit-queue dbates ddkilzer glenn jake.nielsen.webkit simon.fraser oldest_to_newest 1056547 0 simon.fraser 2014-12-17 14:17:42 -0800 [iOS] Remove the various aliases for --ios-simulator (--sim, --simulator, --ios-sim) in arguments for build and test scripts 1056552 1 243461 simon.fraser 2014-12-17 14:19:19 -0800 Created attachment 243461 Patch 1056555 2 243461 dbates 2014-12-17 14:23:42 -0800 Comment on attachment 243461 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243461&action=review > Tools/Scripts/webkitpy/port/factory.py:47 > + optparse.make_option('--ios-simulator', action='store_const', dest='platform', This will break the Apple Internal iOS test bots. Please coordinate with Jake Nielsen. 1056693 3 simon.fraser 2014-12-17 17:59:44 -0800 Actually the bots can migrate to using --ios-simulator right now; that works. 1062231 4 ddkilzer 2015-01-18 16:16:00 -0800 There was one patch landed for this bug as a staging change to allow time to update internal buildbots: Committed r177510: <http://trac.webkit.org/changeset/177510> 1063911 5 ddkilzer 2015-01-24 08:24:25 -0800 (In reply to comment #4) > There was one patch landed for this bug as a staging change to allow time to > update internal buildbots: > > Committed r177510: <http://trac.webkit.org/changeset/177510> Internal buildbots have been updated to use --ios-simulator. Clear to land this patch now. 1064371 6 dbates 2015-01-26 20:06:42 -0800 Committed r179162: <http://trac.webkit.org/changeset/179162> 243461 2014-12-17 14:19:19 -0800 2014-12-17 14:23:42 -0800 Patch bug-139748-20141217142009.patch text/plain 5330 simon.fraser U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MzI4CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggODMxY2Q4ZDk0M2VkYTUwMTBmODlhZDVmZDY5NGM3NGJm OGJjNTNjNC4uNDdkNjBkMjBiZGVmM2YxZjQwMjdmODQ2ZTgxNzhkNWZhZTk4ZjBlZiAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI1 IEBACisyMDE0LTEyLTE3ICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUuY29tPgor CisgICAgICAgIFtpT1NdIFJlbW92ZSB0aGUgdmFyaW91cyBhbGlhc2VzIGZvciAtLWlvcy1zaW11 bGF0b3IgKC0tc2ltLCAtLXNpbXVsYXRvciwgLS1pb3Mtc2ltKSBpbiBhcmd1bWVudHMgZm9yIGJ1 aWxkIGFuZCB0ZXN0IHNjcmlwdHMKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzOTc0OAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorICAgICAgICAKKyAgICAgICAgVGhlcmUgd2FzIG11Y2ggY29uZnVzaW9uIHJlc3VsdGluZyBm cm9tIHRoZSBtdWx0aXR1ZGUgb2YgYWxpYXNlcyB1c2VkIHRvIGJ1aWxkL3Rlc3QgZm9yIHRoZSBp T1Mgc2ltdWxhdG9yLgorICAgICAgICBTdGFuZGFyZGl6ZSBvbiAiLS1pb3Mtc2ltdWxhdG9yIiwg d2hpY2ggaXMgYWxzbyB0aGUgbmFtZSBvZiB0aGUgbGF5b3V0IHRlc3RzIGRpcmVjdG9yeS4KKyAg ICAgICAgCisgICAgICAgIFRoaXMgZml4ZXMgYW4gaXNzdWUgd2hlcmUgcnVuLWFwaS10ZXN0cyBh bmQgc29tZSBvdGhlciBzY3JpcHRzIGZhaWxlZCB3aGVuIHJ1biB3aXRoCisgICAgICAgIC0tc2lt dWxhdG9yLgorCisgICAgICAgICogU2NyaXB0cy9idWlsZC13ZWJraXQ6CisgICAgICAgICogU2Ny aXB0cy9wYWNrYWdlLXJvb3Q6CisgICAgICAgICh1c2FnZSk6CisgICAgICAgICogU2NyaXB0cy93 ZWJraXRkaXJzLnBtOgorICAgICAgICAoYXJndW1lbnRzRm9yQ29uZmlndXJhdGlvbik6CisgICAg ICAgIChkZXRlcm1pbmVYY29kZVNESyk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9wb3J0 L2ZhY3RvcnkucHk6CisgICAgICAgIChwbGF0Zm9ybV9vcHRpb25zKToKKwogMjAxNC0xMi0xNSAg RMOhbmllbCBCw6F0eWFpICA8ZGJhdHlhaS51LXN6ZWdlZEBwYXJ0bmVyLnNhbXN1bmcuY29tPgog CiAgICAgICAgIFtFRkxdIEZUTCBKSVQgbm90IHdvcmtpbmcgb24gQVJNNjQKZGlmZiAtLWdpdCBh L1Rvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0IGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQK aW5kZXggYmYyYzcyOWI2Mjg0NjliYTA2NTJmZmIzMTFmZjYxMDBhYTFiMDcwMC4uMjE1YjVhM2Fh MjMzMmEzMDI4ZTQ3NGM4ZGNhMGExZDA4YWU1MDViMiAxMDA3NTUKLS0tIGEvVG9vbHMvU2NyaXB0 cy9idWlsZC13ZWJraXQKKysrIGIvVG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTg5LDcg Kzg5LDcgQEAgVXNhZ2U6ICRwcm9ncmFtTmFtZSBbb3B0aW9uc10gW29wdGlvbnMgdG8gcGFzcyB0 byBidWlsZCBzeXN0ZW1dCiAgIC0tcmVsZWFzZSAgICAgICAgICAgICAgICAgICAgICAgICBDb21w aWxlIHdpdGggUmVsZWFzZSBjb25maWd1cmF0aW9uCiAgIC0tc2RrPTxzZGs+ICAgICAgICAgICAg ICAgICAgICAgICBVc2UgYSBzcGVjaWZpYyBYY29kZSBTREsgKGlPUyBhbmQgTWFjIG9ubHkpCiAg IC0tZGV2aWNlICAgICAgICAgICAgICAgICAgICAgICAgICBVc2UgdGhlIGN1cnJlbnQgaXBob25l b3MuaW50ZXJuYWwgU0RLIChpT1Mgb25seSkKLSAgLS1zaW11bGF0b3IgICAgICAgICAgICAgICAg ICAgICAgIFVzZSB0aGUgY3VycmVudCBpcGhvbmVzaW11bGF0b3IgU0RLIChpT1Mgb25seSkKKyAg LS1pb3Mtc2ltdWxhdG9yICAgICAgICAgICAgICAgICAgIFVzZSB0aGUgY3VycmVudCBpcGhvbmVz aW11bGF0b3IgU0RLIChpT1Mgb25seSkKICAgLS1jb3ZlcmFnZSAgICAgICAgICAgICAgICAgICAg ICAgIEVuYWJsZSBjb2RlIGNvdmVyYWdlIHN1cHBvcnQgKE1hYyBvbmx5KQogICAtLWFuYWx5emUg ICAgICAgICAgICAgICAgICAgICAgICAgRW5hYmxlIHN0YXRpYyBhbmF5bHNpcyAoaU9TIGFuZCBN YWMgb25seSkKIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0cy9wYWNrYWdlLXJvb3QgYi9Ub29s cy9TY3JpcHRzL3BhY2thZ2Utcm9vdAppbmRleCBjMmU2YjdhOTkxOGZkNzlhNDBhOWFjYzFlZGI2 MGU5YWU0ZWY2NzJiLi5lZWFkMWU0ZGQ2ODRmYWVkZThkZWE5OWZlNTlhMWZjNDcxN2ZmYTVmIDEw MDc1NQotLS0gYS9Ub29scy9TY3JpcHRzL3BhY2thZ2Utcm9vdAorKysgYi9Ub29scy9TY3JpcHRz L3BhY2thZ2Utcm9vdApAQCAtNDcsNyArNDcsNyBAQCBzdWIgdXNhZ2UoKQogICAgICAgLS1zZGsg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNwZWNpZmllcyBTREsgZm9yIHdoaWNoIHRoZSBy b290cyBhcmUgc3RhZ2VkCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg KERlZmF1bHQ6IGN1cnJlbnRseSBpbnN0YWxsZWQgQmFzZSBTREspCiAgICAgICAtLWRldmljZSAg ICAgICAgICAgICAgICAgICAgICAgICAgRXF1aXZhbGVudCB0byAtLXNkayBpcGhvbmVvcy5pbnRl cm5hbAotICAgICAgLS1zaW11bGF0b3IgICAgICAgICAgICAgICAgICAgICAgIEVxdWl2YWxlbnQg dG8gLS1zZGsgaXBob25lc2ltdWxhdG9yCisgICAgICAtLWlvcy1zaW11bGF0b3IgICAgICAgICAg ICAgICAgICAgRXF1aXZhbGVudCB0byAtLXNkayBpcGhvbmVzaW11bGF0b3IKICAgICAgIC0tZGVi dWcgICAgICAgICAgICAgICAgICAgICAgICAgICBQYWNrYWdlIHJvb3RzIGZyb20gRGVidWctPHBs YXRmb3JtPgogICAgICAgLS1yZWxlYXNlICAgICAgICAgICAgICAgICAgICAgICAgIFBhY2thZ2Ug cm9vdHMgZnJvbSBSZWxlYXNlLTxwbGF0Zm9ybT4KIApkaWZmIC0tZ2l0IGEvVG9vbHMvU2NyaXB0 cy93ZWJraXRkaXJzLnBtIGIvVG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDU1YTgy NTBmMWM1ZGNkYTYxMjkyY2RjMDllNThhZmQyOGZkZDY3MzMuLjQ0ZmViMjg5ZDNjNzNlZWQ1OWQy YzQyNDBhNWNjYzdlZmI4NzQ1OWMgMTAwNzU1Ci0tLSBhL1Rvb2xzL1NjcmlwdHMvd2Via2l0ZGly cy5wbQorKysgYi9Ub29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTM5NSw3ICszOTUsNiBA QCBzdWIgYXJndW1lbnRzRm9yQ29uZmlndXJhdGlvbigpCiAgICAgcHVzaChAYXJncywgJy0tZGVi dWcnKSBpZiAoJGNvbmZpZ3VyYXRpb24gPX4gIl5EZWJ1ZyIpOwogICAgIHB1c2goQGFyZ3MsICct LXJlbGVhc2UnKSBpZiAoJGNvbmZpZ3VyYXRpb24gPX4gIl5SZWxlYXNlIik7CiAgICAgcHVzaChA YXJncywgJy0tZGV2aWNlJykgaWYgKGRlZmluZWQgJHhjb2RlU0RLICYmICR4Y29kZVNESyA9fiAv XmlwaG9uZW9zLyk7Ci0gICAgcHVzaChAYXJncywgJy0tc2ltJykgaWYgKGRlZmluZWQgJHhjb2Rl U0RLICYmICR4Y29kZVNESyA9fiAvXmlwaG9uZXNpbXVsYXRvci8pOwogICAgIHB1c2goQGFyZ3Ms ICctLWlvcy1zaW11bGF0b3InKSBpZiAoZGVmaW5lZCAkeGNvZGVTREsgJiYgJHhjb2RlU0RLID1+ IC9eaXBob25lc2ltdWxhdG9yLyk7CiAgICAgcHVzaChAYXJncywgJy0tMzItYml0JykgaWYgKCRh cmNoaXRlY3R1cmUgbmUgIng4Nl82NCIgYW5kICFpc1dpbjY0KCkpOwogICAgIHB1c2goQGFyZ3Ms ICctLTY0LWJpdCcpIGlmIChpc1dpbjY0KCkpOwpAQCAtNDE2LDkgKzQxNSw3IEBAIHN1YiBkZXRl cm1pbmVYY29kZVNESwogICAgIGlmIChjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1Yo Ii0tZGV2aWNlIikpIHsKICAgICAgICAgJHhjb2RlU0RLIHx8PSAnaXBob25lb3MuaW50ZXJuYWwn OwogICAgIH0KLSAgICBpZiAoY2hlY2tGb3JBcmd1bWVudEFuZFJlbW92ZUZyb21BUkdWKCItLXNp bSIpIHx8Ci0gICAgICAgIGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9tQVJHVigiLS1zaW11 bGF0b3IiKSB8fAotICAgICAgICBjaGVja0ZvckFyZ3VtZW50QW5kUmVtb3ZlRnJvbUFSR1YoIi0t aW9zLXNpbXVsYXRvciIpKSB7CisgICAgaWYgKGNoZWNrRm9yQXJndW1lbnRBbmRSZW1vdmVGcm9t QVJHVigiLS1pb3Mtc2ltdWxhdG9yIikpIHsKICAgICAgICAgJHhjb2RlU0RLIHx8PSAnaXBob25l c2ltdWxhdG9yJzsKICAgICB9CiB9CmRpZmYgLS1naXQgYS9Ub29scy9TY3JpcHRzL3dlYmtpdHB5 L3BvcnQvZmFjdG9yeS5weSBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkvcG9ydC9mYWN0b3J5LnB5 CmluZGV4IDQ3NDQwN2Y0N2U4MjM3M2IzNGIwOTIxMWM5ZTNlMDc2Y2EwYTEyNWEuLmI1ZWJiODBi Mjc4YjhjYjA0YmNkZGFkOWY0ZTAxZjI0MTk0MjNmOWUgMTAwNjQ0Ci0tLSBhL1Rvb2xzL1Njcmlw dHMvd2Via2l0cHkvcG9ydC9mYWN0b3J5LnB5CisrKyBiL1Rvb2xzL1NjcmlwdHMvd2Via2l0cHkv cG9ydC9mYWN0b3J5LnB5CkBAIC00NCw5ICs0NCw5IEBAIGRlZiBwbGF0Zm9ybV9vcHRpb25zKHVz ZV9nbG9icz1GYWxzZSk6CiAgICAgcmV0dXJuIFsKICAgICAgICAgb3B0cGFyc2UubWFrZV9vcHRp b24oJy0tcGxhdGZvcm0nLCBhY3Rpb249J3N0b3JlJywKICAgICAgICAgICAgIGhlbHA9KCdHbG9i LXN0eWxlIGxpc3Qgb2YgcGxhdGZvcm0vcG9ydHMgdG8gdXNlIChlLmcuLCAibWFjKiIpJyBpZiB1 c2VfZ2xvYnMgZWxzZSAnUGxhdGZvcm0gdG8gdXNlIChlLmcuLCAibWFjLWxpb24iKScpKSwKLSAg ICAgICAgb3B0cGFyc2UubWFrZV9vcHRpb24oJy0taW9zLXNpbScsIGFjdGlvbj0nc3RvcmVfY29u c3QnLCBkZXN0PSdwbGF0Zm9ybScsCisgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0aW9uKCctLWlv cy1zaW11bGF0b3InLCBhY3Rpb249J3N0b3JlX2NvbnN0JywgZGVzdD0ncGxhdGZvcm0nLAogICAg ICAgICAgICAgY29uc3Q9KCdpb3Mtc2ltdWxhdG9yJyksCi0gICAgICAgICAgICBoZWxwPSgnQWxp YXMgZm9yIC0tcGxhdGZvcm09aW9zLXNpbSonIGlmIHVzZV9nbG9icyBlbHNlICdBbGlhcyBmb3Ig LS1wbGF0Zm9ybT1pb3Mtc2ltdWxhdG9yJykpLAorICAgICAgICAgICAgaGVscD0oJ0FsaWFzIGZv ciAtLXBsYXRmb3JtPWlvcy1zaW11bGF0b3InKSksCiAgICAgICAgIG9wdHBhcnNlLm1ha2Vfb3B0 aW9uKCctLWVmbCcsIGFjdGlvbj0nc3RvcmVfY29uc3QnLCBkZXN0PSdwbGF0Zm9ybScsCiAgICAg ICAgICAgICBjb25zdD0oJ2VmbConIGlmIHVzZV9nbG9icyBlbHNlICdlZmwnKSwKICAgICAgICAg ICAgIGhlbHA9KCdBbGlhcyBmb3IgLS1wbGF0Zm9ybT1lZmwqJyBpZiB1c2VfZ2xvYnMgZWxzZSAn QWxpYXMgZm9yIC0tcGxhdGZvcm09ZWZsJykpLAo=