139739 2014-12-17 12:11:28 -0800 [iOS] Define button and action should respect profile settings. 2014-12-17 13:56:04 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified iOS 8.1 RESOLVED FIXED P2 Normal --- 1 enrica enrica commit-queue oldest_to_newest 1056493 0 enrica 2014-12-17 12:11:28 -0800 The define button and action should only be available if not explicitly disabled via profile. 1056496 1 enrica 2014-12-17 12:15:10 -0800 rdar://problem/15461887 1056497 2 243449 enrica 2014-12-17 12:16:53 -0800 Created attachment 243449 Patch 1056498 3 commit-queue 2014-12-17 12:18:50 -0800 Attachment 243449 did not pass style-queue: ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:51: Alphabetical sorting problem. [build/include_order] [4] ERROR: Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:1342: Multi line control clauses should use braces. [whitespace/braces] [4] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1056539 4 243449 joepeck 2014-12-17 13:46:56 -0800 Comment on attachment 243449 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243449&action=review r=me > Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:52 > +#import <ManagedConfiguration/MCProfileConnection.h> > +#import <ManagedConfiguration/MCFeatures.h> Nit: `sort` which you already noticed. Are these SPI? In order for this to build with the public SDK do you have to do something special? dbates has been doing something like that, so there may be something you have to do here, or maybe not. 1056543 5 enrica 2014-12-17 13:56:04 -0800 Committed revision 177463. 243449 2014-12-17 12:16:53 -0800 2014-12-17 13:46:56 -0800 Patch definectl.txt text/plain 2602 enrica SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzQ1MikKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEyLTE3ICBFbnJpY2Eg Q2FzdWNjaSAgPGVucmljYUBhcHBsZS5jb20+CisKKyAgICAgICAgW2lPU10gRGVmaW5lIGJ1dHRv biBhbmQgYWN0aW9uIHNob3VsZCByZXNwZWN0IHByb2ZpbGUgc2V0dGluZ3MuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk3MzkKKyAgICAgICAgcmRh cjovL3Byb2JsZW0vMTU0NjE4ODcKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICAqIFVJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlld0ludGVyYWN0aW9uLm1t OgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IGNhblBlcmZvcm1BY3Rpb246d2l0aFNlbmRlcjpd KToKKyAgICAgICAgKC1bV0tDb250ZW50VmlldyBfZGVmaW5lOl0pOgorCiAyMDE0LTEyLTE3ICBB bmRyZWFzIEtsaW5nICA8YWtsaW5nQGFwcGxlLmNvbT4KIAogICAgICAgICBQdXJnZSBQYXNzUmVm UHRyIGZyb20gRnJhbWUuCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvaW9zL1dLQ29u dGVudFZpZXdJbnRlcmFjdGlvbi5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvaW9zL1dLQ29udGVudFZpZXdJbnRlcmFjdGlvbi5tbQkocmV2aXNpb24gMTc3NDQ4KQor KysgU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL2lvcy9XS0NvbnRlbnRWaWV3SW50ZXJhY3Rpb24u bW0JKHdvcmtpbmcgY29weSkKQEAgLTQ4LDYgKzQ4LDggQEAKICNpbXBvcnQgIl9XS0Zvcm1JbnB1 dFNlc3Npb24uaCIKICNpbXBvcnQgPENvcmVUZXh0L0NURm9udERlc2NyaXB0b3IuaD4KICNpbXBv cnQgPERhdGFEZXRlY3RvcnNVSS9ERERldGVjdGlvbkNvbnRyb2xsZXIuaD4KKyNpbXBvcnQgPE1h bmFnZWRDb25maWd1cmF0aW9uL01DUHJvZmlsZUNvbm5lY3Rpb24uaD4KKyNpbXBvcnQgPE1hbmFn ZWRDb25maWd1cmF0aW9uL01DRmVhdHVyZXMuaD4KICNpbXBvcnQgPFRleHRJbnB1dC9USV9OU1N0 cmluZ0V4dHJhcy5oPgogI2ltcG9ydCA8VUlLaXQvVUlBcHBsaWNhdGlvbl9Qcml2YXRlLmg+CiAj aW1wb3J0IDxVSUtpdC9VSUZvbnRfUHJpdmF0ZS5oPgpAQCAtNjksNiArNzEsMTEgQEAKIAogU09G VF9MSU5LX1BSSVZBVEVfRlJBTUVXT1JLKERhdGFEZXRlY3RvcnNVSSkKIFNPRlRfTElOS19DTEFT UyhEYXRhRGV0ZWN0b3JzVUksIERERGV0ZWN0aW9uQ29udHJvbGxlcikKK1NPRlRfTElOS19QUklW QVRFX0ZSQU1FV09SSyhNYW5hZ2VkQ29uZmlndXJhdGlvbik7CitTT0ZUX0xJTktfQ0xBU1MoTWFu YWdlZENvbmZpZ3VyYXRpb24sIE1DUHJvZmlsZUNvbm5lY3Rpb24pOworU09GVF9MSU5LX0NPTlNU QU5UKE1hbmFnZWRDb25maWd1cmF0aW9uLCBNQ0ZlYXR1cmVEZWZpbml0aW9uTG9va3VwQWxsb3dl ZCwgTlNTdHJpbmcgKikKKworI2RlZmluZSBNQ0ZlYXR1cmVEZWZpbml0aW9uTG9va3VwQWxsb3dl ZCBnZXRNQ0ZlYXR1cmVEZWZpbml0aW9uTG9va3VwQWxsb3dlZCgpCiAKIHVzaW5nIG5hbWVzcGFj ZSBXZWJDb3JlOwogdXNpbmcgbmFtZXNwYWNlIFdlYktpdDsKQEAgLTEzMzIsNiArMTMzOSw5IEBA ICAgICAgICAgLy8gYWNjZXB0YWJsZSwgYnV0IHRoZSBpbnRlcmZhY2UKICAgICAgICAgaWYgKCF0 ZXh0TGVuZ3RoIHx8IHRleHRMZW5ndGggPiAyMDApCiAgICAgICAgICAgICByZXR1cm4gTk87CiAK KyAgICAgICAgaWYgKFtbZ2V0TUNQcm9maWxlQ29ubmVjdGlvbkNsYXNzKCkgc2hhcmVkQ29ubmVj dGlvbl0gZWZmZWN0aXZlQm9vbFZhbHVlRm9yU2V0dGluZzpNQ0ZlYXR1cmVEZWZpbml0aW9uTG9v a3VwQWxsb3dlZF0gPT0gTUNSZXN0cmljdGVkQm9vbEV4cGxpY2l0Tm8pCisgICAgICAgICAgICBy ZXR1cm4gTk87CisgICAgICAgICAgICAKICAgICAgICAgcmV0dXJuIFlFUzsKICAgICB9CiAKQEAg LTE0NzIsNiArMTQ4Miw5IEBAIC0gKHZvaWQpX3Nob3dEaWN0aW9uYXJ5OihOU1N0cmluZyAqKXRl eHQKIAogLSAodm9pZClfZGVmaW5lOihpZClzZW5kZXIKIHsKKyAgICBpZiAoW1tnZXRNQ1Byb2Zp bGVDb25uZWN0aW9uQ2xhc3MoKSBzaGFyZWRDb25uZWN0aW9uXSBlZmZlY3RpdmVCb29sVmFsdWVG b3JTZXR0aW5nOk1DRmVhdHVyZURlZmluaXRpb25Mb29rdXBBbGxvd2VkXSA9PSBNQ1Jlc3RyaWN0 ZWRCb29sRXhwbGljaXRObykKKyAgICAgICAgcmV0dXJuOworCiAgICAgX3BhZ2UtPmdldFNlbGVj dGlvbk9yQ29udGVudHNBc1N0cmluZyhbc2VsZl0oY29uc3QgU3RyaW5nJiBzdHJpbmcsIENhbGxi YWNrQmFzZTo6RXJyb3IgZXJyb3IpIHsKICAgICAgICAgaWYgKGVycm9yICE9IENhbGxiYWNrQmFz ZTo6RXJyb3I6Ok5vbmUpCiAgICAgICAgICAgICByZXR1cm47Cg==