139735 2014-12-17 11:02:16 -0800 Get rid of PluginPackageNone.cpp 2014-12-17 15:37:20 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139752 1 andersca andersca cgarcia clopez ossy oldest_to_newest 1056378 0 andersca 2014-12-17 11:02:16 -0800 Get rid of PluginPackageNone.cpp 1056379 1 243444 andersca 2014-12-17 11:02:39 -0800 Created attachment 243444 Patch 1056492 2 andersca 2014-12-17 12:09:46 -0800 Committed r177452: <http://trac.webkit.org/changeset/177452> 1056525 3 clopez 2014-12-17 13:20:50 -0800 (In reply to comment #2) > Committed r177452: <http://trac.webkit.org/changeset/177452> This has broken the GTK build: https://build.webkit.org/builders/GTK%20Linux%2064-bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio 1056527 4 andersca 2014-12-17 13:22:26 -0800 (In reply to comment #3) > (In reply to comment #2) > > Committed r177452: <http://trac.webkit.org/changeset/177452> > > This has broken the GTK build: > https://build.webkit.org/builders/GTK%20Linux%2064- > bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at all. 1056566 5 ossy 2014-12-17 15:32:29 -0800 (In reply to comment #4) > (In reply to comment #3) > > (In reply to comment #2) > > > Committed r177452: <http://trac.webkit.org/changeset/177452> > > > > This has broken the GTK build: > > https://build.webkit.org/builders/GTK%20Linux%2064- > > bit%20Release%20%28Build%29/builds/53722/steps/compile-webkit/logs/stdio > > OK. EWS bot seems stuck. I don't think GTK+ needs to build PluginDatabase at > all. It seems PluginDatabase is used by GTK in FrameLoader.cpp in !PLATFORM(COCOA) && !PLATFORM(EFL) blocks. 243444 2014-12-17 11:02:39 -0800 2014-12-17 11:41:47 -0800 Patch bug-139735-20141217110330.patch text/plain 4922 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3NDQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWQ5NzJhM2RkOTk3ZTI4 YmM1MzhiOGQ0YTg2MGExZmZhNTA2ZGQzNS4uMGI1MDNhNDljMDVlMmViOTBkNzVkYjQ0ZDhkODk4 NTY4ZjMzODhmMCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTE3ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgR2V0IHJpZCBvZiBQ bHVnaW5QYWNrYWdlTm9uZS5jcHAKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzOTczNQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogQ01ha2VMaXN0cy50eHQ6CisgICAgICAgICogUGxhdGZvcm1FZmwuY21h a2U6CisgICAgICAgICogUGxhdGZvcm1HVEsuY21ha2U6CisgICAgICAgICogUGxhdGZvcm1XaW4u Y21ha2U6CisgICAgICAgICogcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHA6IFJlbW92ZWQu CisKIDIwMTQtMTItMTYgIE15bGVzIEMuIE1heGZpZWxkICA8bW1heGZpZWxkQGFwcGxlLmNvbT4K IAogICAgICAgICBBZGRyZXNzaW5nIG1vcmUgcG9zdC1yZXZpZXcgY29tbWVudHMgaW4gcjE3NzAz NQpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvQ01ha2VMaXN0cy50eHQgYi9Tb3VyY2UvV2Vi Q29yZS9DTWFrZUxpc3RzLnR4dAppbmRleCA3MmVkZWY2MTJhMDMxYmRhOTI3YWNmZWI4ZTMzZTdi ODdhNTFhODcwLi4yNjYwNmQ2YmM1YTc2MmM5NWZkZGYzOGFhMDJiMDc1YmQxMGMyNzU1IDEwMDY0 NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DTWFrZUxpc3RzLnR4dAorKysgYi9Tb3VyY2UvV2ViQ29y ZS9DTWFrZUxpc3RzLnR4dApAQCAtMjc4Myw3ICsyNzgzLDYgQEAgZW5kaWYgKCkKIAogaWYgKE5P VCBFTkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQSSkKICAgICBsaXN0KEFQUEVORCBXZWJDb3JlX1NP VVJDRVMKLSAgICAgICAgcGx1Z2lucy9QbHVnaW5QYWNrYWdlTm9uZS5jcHAKICAgICAgICAgcGx1 Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKICAgICApCiBlbmRpZiAoKQpkaWZmIC0tZ2l0IGEvU291 cmNlL1dlYkNvcmUvUGxhdGZvcm1FZmwuY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUVm bC5jbWFrZQppbmRleCAxYmJlZDBmMDQwYmU5ZTdjYmFlMzY5NjI1NWRiN2FhYTI2ZTVlMGU0Li45 NTEzNzY3MDkyZDY2N2Q4ZmZmNjJmZGI4NmJjYzcyMDM2NGM0NTM2IDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9QbGF0Zm9ybUVmbC5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9y bUVmbC5jbWFrZQpAQCAtMjQ3LDcgKzI0Nyw2IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNF UwogCiAgICAgcGxhdGZvcm0vdGV4dC9lbmNoYW50L1RleHRDaGVja2VyRW5jaGFudC5jcHAKIAot ICAgIHBsdWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCiAgICAgcGx1Z2lucy9QbHVnaW5WaWV3 Tm9uZS5jcHAKICkKIApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1HVEsuY21h a2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQppbmRleCBhYTRiYzljMjIwODBk NmUwNzZiMTIxYmNkNTBjY2FkYTJjZmY3MDZhLi4xYmY2NzNhYTllYWZkMDcxYTc1MzFlZTRhNzZi MjRkMTI5OWJlZGQ1IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFr ZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybUdUSy5jbWFrZQpAQCAtMTkyLDcgKzE5Miw2 IEBAIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNFUwogCiAgICAgcGxhdGZvcm0vbmV0d29yay9n dGsvQ3JlZGVudGlhbEJhY2tpbmdTdG9yZS5jcHAKIAotICAgIHBsdWdpbnMvUGx1Z2luUGFja2Fn ZU5vbmUuY3BwCiAgICAgcGx1Z2lucy9QbHVnaW5WaWV3Tm9uZS5jcHAKICkKIApkaWZmIC0tZ2l0 IGEvU291cmNlL1dlYkNvcmUvUGxhdGZvcm1XaW4uY21ha2UgYi9Tb3VyY2UvV2ViQ29yZS9QbGF0 Zm9ybVdpbi5jbWFrZQppbmRleCAzNTVmMTkzZmRhMTRlOWFiZjVjMDJjMDA0ODEyNTllMjZmMThl OTBhLi4zMTU4YWY4MDAyN2Y4Y2E5OWU4MmZkMzkwMjY3OTQ3OTA1ODM0MDYzIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9QbGF0Zm9ybVdpbi5jbWFrZQorKysgYi9Tb3VyY2UvV2ViQ29yZS9Q bGF0Zm9ybVdpbi5jbWFrZQpAQCAtODMsNyArODMsNiBAQCBpZiAoRU5BQkxFX05FVFNDQVBFX1BM VUdJTl9BUEkpCiAgICAgKQogZWxzZSAoKQogICAgIGxpc3QoQVBQRU5EIFdlYkNvcmVfU09VUkNF UwotICAgICAgICBwbHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcAogICAgICAgICBwbHVnaW5z L1BsdWdpblZpZXdOb25lLmNwcAogICAgICkKIGVuZGlmICgpCmRpZmYgLS1naXQgYS9Tb3VyY2Uv V2ViQ29yZS9wbHVnaW5zL1BsdWdpblBhY2thZ2VOb25lLmNwcCBiL1NvdXJjZS9XZWJDb3JlL3Bs dWdpbnMvUGx1Z2luUGFja2FnZU5vbmUuY3BwCmRlbGV0ZWQgZmlsZSBtb2RlIDEwMDY0NAppbmRl eCA1NWI2MDY2MDU2YjBmMjJmOTI3MzI3ZDFiZWE5MjU2MzQxZGY0ODM2Li4wMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwCi0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsdWdpbnMv UGx1Z2luUGFja2FnZU5vbmUuY3BwCisrKyAvZGV2L251bGwKQEAgLTEsNzYgKzAsMCBAQAotLyoK LSAqIENvcHlyaWdodCAoQykgMjAwOCBLZXZpbiBPbGxpdmllciA8a2V2aW5vQHRoZW9sbGl2aWVy cy5jb20+IEFsbCBSaWdodHMgUmVzZXJ2ZWQuCi0gKgotICogUmVkaXN0cmlidXRpb24gYW5kIHVz ZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0Ci0gKiBtb2RpZmlj YXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlv bnMKLSAqIGFyZSBtZXQ6Ci0gKiAxLiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVz dCByZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAotICogICAgbm90aWNlLCB0aGlzIGxpc3Qgb2Yg Y29uZGl0aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgotICogMi4gUmVkaXN0cmli dXRpb25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZSBjb3B5cmlnaHQK LSAqICAgIG5vdGljZSwgdGhpcyBsaXN0IG9mIGNvbmRpdGlvbnMgYW5kIHRoZSBmb2xsb3dpbmcg ZGlzY2xhaW1lciBpbiB0aGUKLSAqICAgIGRvY3VtZW50YXRpb24gYW5kL29yIG90aGVyIG1hdGVy aWFscyBwcm92aWRlZCB3aXRoIHRoZSBkaXN0cmlidXRpb24uCi0gKgotICogVEhJUyBTT0ZUV0FS RSBJUyBQUk9WSURFRCBCWSBBUFBMRSBJTkMuIGBgQVMgSVMnJyBBTkQgQU5ZCi0gKiBFWFBSRVNT IE9SIElNUExJRUQgV0FSUkFOVElFUywgSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sIFRI RQotICogSU1QTElFRCBXQVJSQU5USUVTIE9GIE1FUkNIQU5UQUJJTElUWSBBTkQgRklUTkVTUyBG T1IgQSBQQVJUSUNVTEFSCi0gKiBQVVJQT1NFIEFSRSBESVNDTEFJTUVELiAgSU4gTk8gRVZFTlQg U0hBTEwgQVBQTEUgSU5DLiBPUgotICogQ09OVFJJQlVUT1JTIEJFIExJQUJMRSBGT1IgQU5ZIERJ UkVDVCwgSU5ESVJFQ1QsIElOQ0lERU5UQUwsIFNQRUNJQUwsCi0gKiBFWEVNUExBUlksIE9SIENP TlNFUVVFTlRJQUwgREFNQUdFUyAoSU5DTFVESU5HLCBCVVQgTk9UIExJTUlURUQgVE8sCi0gKiBQ Uk9DVVJFTUVOVCBPRiBTVUJTVElUVVRFIEdPT0RTIE9SIFNFUlZJQ0VTOyBMT1NTIE9GIFVTRSwg REFUQSwgT1IKLSAqIFBST0ZJVFM7IE9SIEJVU0lORVNTIElOVEVSUlVQVElPTikgSE9XRVZFUiBD QVVTRUQgQU5EIE9OIEFOWSBUSEVPUlkKLSAqIE9GIExJQUJJTElUWSwgV0hFVEhFUiBJTiBDT05U UkFDVCwgU1RSSUNUIExJQUJJTElUWSwgT1IgVE9SVAotICogKElOQ0xVRElORyBORUdMSUdFTkNF IE9SIE9USEVSV0lTRSkgQVJJU0lORyBJTiBBTlkgV0FZIE9VVCBPRiBUSEUgVVNFCi0gKiBPRiBU SElTIFNPRlRXQVJFLCBFVkVOIElGIEFEVklTRUQgT0YgVEhFIFBPU1NJQklMSVRZIE9GIFNVQ0gg REFNQUdFLgotICovCi0KLSNpbmNsdWRlICJjb25maWcuaCIKLSNpbmNsdWRlICJQbHVnaW5QYWNr YWdlLmgiCi0KLW5hbWVzcGFjZSBXZWJDb3JlIHsKLQotdm9pZCBQbHVnaW5QYWNrYWdlOjpkZXRl cm1pbmVRdWlya3MoY29uc3QgU3RyaW5nJikKLXsKLX0KLQotYm9vbCBQbHVnaW5QYWNrYWdlOjpm ZXRjaEluZm8oKQotewotICAgIHJldHVybiBmYWxzZTsKLX0KLQotYm9vbCBQbHVnaW5QYWNrYWdl Ojpsb2FkKCkKLXsKLSAgICByZXR1cm4gZmFsc2U7Ci19Ci0KLSNpZiBFTkFCTEUoTkVUU0NBUEVf UExVR0lOX0FQSSkKLXVpbnQxNl90IFBsdWdpblBhY2thZ2U6Ok5QVmVyc2lvbigpIGNvbnN0Ci17 Ci0gICAgcmV0dXJuIDA7Ci19Ci0jZW5kaWYKLQotUGFzc1JlZlB0cjxQbHVnaW5QYWNrYWdlPiBQ bHVnaW5QYWNrYWdlOjpjcmVhdGVQYWNrYWdlKGNvbnN0IFN0cmluZyYsIGNvbnN0IHRpbWVfdCYp Ci17Ci0gICAgcmV0dXJuIDA7Ci19Ci0KLXVuc2lnbmVkIFBsdWdpblBhY2thZ2U6Omhhc2goKSBj b25zdAotewotICAgIHJldHVybiAwOwotfQotCi1ib29sIFBsdWdpblBhY2thZ2U6OmVxdWFsKGNv bnN0IFBsdWdpblBhY2thZ2UmLCBjb25zdCBQbHVnaW5QYWNrYWdlJikKLXsKLSAgICByZXR1cm4g dHJ1ZTsKLX0KLQotaW50IFBsdWdpblBhY2thZ2U6OmNvbXBhcmUoY29uc3QgUGx1Z2luUGFja2Fn ZSYpIGNvbnN0Ci17Ci0gICAgcmV0dXJuIDA7Ci19Ci0KLVBsdWdpblBhY2thZ2U6On5QbHVnaW5Q YWNrYWdlKCkKLXsKLX0KLQotfQo=