139682 2014-12-16 10:07:04 -0800 Put some common code in StorageNamespaceProvider 2015-05-05 14:47:53 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1055994 0 andersca 2014-12-16 10:07:04 -0800 Put some common code in StorageNamespaceProvider 1055995 1 243365 andersca 2014-12-16 10:12:35 -0800 Created attachment 243365 Patch 1056000 2 andersca 2014-12-16 10:38:34 -0800 Committed r177365: <http://trac.webkit.org/changeset/177365> 1091894 3 243365 joepeck 2015-05-05 14:47:53 -0700 Comment on attachment 243365 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243365&action=review > Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:203 > - return page->sessionStorage()->storageArea(document->securityOrigin()); > + return m_pageAgent->page()->storageNamespaceProvider().localStorageArea(*targetFrame->document()); Looks like this makes the Inspector always return localStorage instead of sessionStorage in some cases. 243365 2014-12-16 10:12:35 -0800 2014-12-16 10:37:10 -0800 Patch bug-139682-20141216101325.patch text/plain 7304 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MzYxCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNzg4ZmI1ZGMxZTVjMmIw Zjc5YWVhNzc2NWQ1OGI1MGE1ZmYzNTBhZC4uMzZmOWUxZWM5ZGU4ZmUzYjAyYzRiYjg1MTU3ZjJj MzdhZGVhNjIxMyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSw1ICsxLDI3IEBACiAyMDE0LTEyLTE2ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKKyAgICAgICAgUHV0IHNvbWUgY29t bW9uIGNvZGUgaW4gU3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVyCisgICAgICAgIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk2ODIKKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBXZSBoYXZlIGNvZGUgaW4gdHdvIHBsYWNlcyB0 aGF0IGdldHMgdGhlIGxvY2FsIHN0b3JhZ2UgYXJlYSBmcm9tIGEgZ2l2ZW4gZG9jdW1lbnQsCisg ICAgICAgIGNob29zaW5nIGVpdGhlciB0aGUgbG9jYWwgc3RvcmFnZSBuYW1lc3BhY2Ugb3IgdGhl IHRyYW5zaWVudCBsb2NhbCBzdG9yYWdlIG5hbWVzcGFjZS4KKyAgICAgICAgTW92ZSBpdCB0byBT dG9yYWdlTmFtZXNwYWNlUHJvdmlkZXI6OmxvY2FsU3RvcmFnZUFyZWEuCisKKyAgICAgICAgKiBi aW5kaW5ncy9qcy9TY3JpcHRDb250cm9sbGVyLmNwcDoKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5z cGVjdG9yRE9NU3RvcmFnZUFnZW50LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRP TVN0b3JhZ2VBZ2VudDo6ZmluZFN0b3JhZ2VBcmVhKToKKyAgICAgICAgKiBwYWdlL0RPTVdpbmRv dy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpET01XaW5kb3c6OmxvY2FsU3RvcmFnZSk6CisgICAg ICAgICogcGFnZS9OYXZpZ2F0b3IuY3BwOgorICAgICAgICAqIHN0b3JhZ2UvU3RvcmFnZU5hbWVz cGFjZVByb3ZpZGVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlN0b3JhZ2VOYW1lc3BhY2VQcm92 aWRlcjo6bG9jYWxTdG9yYWdlQXJlYSk6CisgICAgICAgIChXZWJDb3JlOjpTdG9yYWdlTmFtZXNw YWNlUHJvdmlkZXI6OmxvY2FsU3RvcmFnZU5hbWVzcGFjZSk6CisgICAgICAgICogc3RvcmFnZS9T dG9yYWdlTmFtZXNwYWNlUHJvdmlkZXIuaDoKKworMjAxNC0xMi0xNiAgQW5kZXJzIENhcmxzc29u ICA8YW5kZXJzY2FAYXBwbGUuY29tPgorCiAgICAgICAgIEFkZCBGZWF0dXJlQ291bnRlcktleXMu aCB0byB0aGUgWGNvZGUgcHJvamVjdC4KIAogICAgICAgICAqIFdlYkNvcmUueGNvZGVwcm9qL3By b2plY3QucGJ4cHJvajoKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2JpbmRpbmdzL2pzL1Nj cmlwdENvbnRyb2xsZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29u dHJvbGxlci5jcHAKaW5kZXggYzk5YWRmZGVlMGIzN2NiYzVhZGE1NjgzODQyYTg1MDc3NzU2YjE2 NC4uNzAyMTQ0YzY2NDQxNmFhZjhiOGZhZGM2MjVjNzUxMTg4MzcyZjI2MyAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAKKysrIGIvU291 cmNlL1dlYkNvcmUvYmluZGluZ3MvanMvU2NyaXB0Q29udHJvbGxlci5jcHAKQEAgLTQzLDcgKzQz LDYgQEAKICNpbmNsdWRlICJTY3JpcHRTb3VyY2VDb2RlLmgiCiAjaW5jbHVkZSAiU2NyaXB0YWJs ZURvY3VtZW50UGFyc2VyLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKLSNpbmNsdWRlICJTdG9y YWdlTmFtZXNwYWNlLmgiCiAjaW5jbHVkZSAiVXNlckdlc3R1cmVJbmRpY2F0b3IuaCIKICNpbmNs dWRlICJXZWJDb3JlSlNDbGllbnREYXRhLmgiCiAjaW5jbHVkZSAibnBydW50aW1lX2ltcGwuaCIK ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01TdG9yYWdl QWdlbnQuY3BwIGIvU291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTVN0b3JhZ2VB Z2VudC5jcHAKaW5kZXggNDFiYWYwYTA5YTA1MjM4Mjg5MGY0MGMzMjc4NmJhNWJiNzMzNzJlNS4u ZDdjNWVhMzBmY2Q0MjY4ZmJjMGVmOWVjZDBiZmY1ZDE3ZGQ3ZDdhZCAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTVN0b3JhZ2VBZ2VudC5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvaW5zcGVjdG9yL0luc3BlY3RvckRPTVN0b3JhZ2VBZ2VudC5jcHAKQEAg LTQ1LDcgKzQ1LDYgQEAKICNpbmNsdWRlICJQYWdlR3JvdXAuaCIKICNpbmNsdWRlICJTZWN1cml0 eU9yaWdpbi5oIgogI2luY2x1ZGUgIlN0b3JhZ2UuaCIKLSNpbmNsdWRlICJTdG9yYWdlTmFtZXNw YWNlLmgiCiAjaW5jbHVkZSAiU3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVyLmgiCiAjaW5jbHVkZSAi Vm9pZENhbGxiYWNrLmgiCiAjaW5jbHVkZSA8aW5zcGVjdG9yL0luc3BlY3RvckZyb250ZW5kRGlz cGF0Y2hlcnMuaD4KQEAgLTIwMSwxNCArMjAwLDcgQEAgUGFzc1JlZlB0cjxTdG9yYWdlQXJlYT4g SW5zcGVjdG9yRE9NU3RvcmFnZUFnZW50OjpmaW5kU3RvcmFnZUFyZWEoRXJyb3JTdHJpbmcmIGUK ICAgICAgICAgcmV0dXJuIG51bGxwdHI7CiAgICAgfQogCi0gICAgUGFnZSogcGFnZSA9IG1fcGFn ZUFnZW50LT5wYWdlKCk7Ci0gICAgRG9jdW1lbnQqIGRvY3VtZW50ID0gdGFyZ2V0RnJhbWUtPmRv Y3VtZW50KCk7Ci0gICAgaWYgKGlzTG9jYWxTdG9yYWdlKSB7Ci0gICAgICAgIGlmIChkb2N1bWVu dC0+c2VjdXJpdHlPcmlnaW4oKS0+Y2FuQWNjZXNzTG9jYWxTdG9yYWdlKGRvY3VtZW50LT50b3BP cmlnaW4oKSkpCi0gICAgICAgICAgICByZXR1cm4gcGFnZS0+c3RvcmFnZU5hbWVzcGFjZVByb3Zp ZGVyKCkubG9jYWxTdG9yYWdlTmFtZXNwYWNlKCkuc3RvcmFnZUFyZWEoZG9jdW1lbnQtPnNlY3Vy aXR5T3JpZ2luKCkpOwotICAgICAgICByZXR1cm4gcGFnZS0+c3RvcmFnZU5hbWVzcGFjZVByb3Zp ZGVyKCkudHJhbnNpZW50TG9jYWxTdG9yYWdlTmFtZXNwYWNlKCpkb2N1bWVudC0+dG9wT3JpZ2lu KCkpLnN0b3JhZ2VBcmVhKGRvY3VtZW50LT5zZWN1cml0eU9yaWdpbigpKTsKLSAgICB9Ci0gICAg cmV0dXJuIHBhZ2UtPnNlc3Npb25TdG9yYWdlKCktPnN0b3JhZ2VBcmVhKGRvY3VtZW50LT5zZWN1 cml0eU9yaWdpbigpKTsKKyAgICByZXR1cm4gbV9wYWdlQWdlbnQtPnBhZ2UoKS0+c3RvcmFnZU5h bWVzcGFjZVByb3ZpZGVyKCkubG9jYWxTdG9yYWdlQXJlYSgqdGFyZ2V0RnJhbWUtPmRvY3VtZW50 KCkpOwogfQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2Vi Q29yZS9wYWdlL0RPTVdpbmRvdy5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0RPTVdpbmRvdy5j cHAKaW5kZXggM2I4M2U3OTZiMjllYzc0YmJjOTkwODIxZjg3NTc5ZTc4MTQxOGRkZC4uMTZhYjUw ZDQ1ZTE4ZGY5NDNkYTQ2YzUwMzZkOGQ4ZTZiMTIxNjE2YSAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9ET01XaW5kb3cuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvRE9NV2lu ZG93LmNwcApAQCAtODU2LDEyICs4NTYsNyBAQCBTdG9yYWdlKiBET01XaW5kb3c6OmxvY2FsU3Rv cmFnZShFeGNlcHRpb25Db2RlJiBlYykgY29uc3QKICAgICBpZiAoIXBhZ2UtPnNldHRpbmdzKCku bG9jYWxTdG9yYWdlRW5hYmxlZCgpKQogICAgICAgICByZXR1cm4gbnVsbHB0cjsKIAotICAgIFJl ZlB0cjxTdG9yYWdlQXJlYT4gc3RvcmFnZUFyZWE7Ci0KLSAgICBpZiAoZG9jdW1lbnQtPnNlY3Vy aXR5T3JpZ2luKCktPmNhbkFjY2Vzc0xvY2FsU3RvcmFnZShkb2N1bWVudC0+dG9wT3JpZ2luKCkp KQotICAgICAgICBzdG9yYWdlQXJlYSA9IHBhZ2UtPnN0b3JhZ2VOYW1lc3BhY2VQcm92aWRlcigp LmxvY2FsU3RvcmFnZU5hbWVzcGFjZSgpLnN0b3JhZ2VBcmVhKGRvY3VtZW50LT5zZWN1cml0eU9y aWdpbigpKTsKLSAgICBlbHNlCi0gICAgICAgIHN0b3JhZ2VBcmVhID0gcGFnZS0+c3RvcmFnZU5h bWVzcGFjZVByb3ZpZGVyKCkudHJhbnNpZW50TG9jYWxTdG9yYWdlTmFtZXNwYWNlKCpkb2N1bWVu dC0+dG9wT3JpZ2luKCkpLnN0b3JhZ2VBcmVhKGRvY3VtZW50LT5zZWN1cml0eU9yaWdpbigpKTsK KyAgICBSZWZQdHI8U3RvcmFnZUFyZWE+IHN0b3JhZ2VBcmVhID0gcGFnZS0+c3RvcmFnZU5hbWVz cGFjZVByb3ZpZGVyKCkubG9jYWxTdG9yYWdlQXJlYSgqZG9jdW1lbnQpOwogCiAgICAgaWYgKCFz dG9yYWdlQXJlYS0+Y2FuQWNjZXNzU3RvcmFnZShtX2ZyYW1lKSkgewogICAgICAgICBlYyA9IFNF Q1VSSVRZX0VSUjsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNw cCBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvTmF2aWdhdG9yLmNwcAppbmRleCBiYjJhMjU0Y2FjODgw MmFhNTMxNjljMjhjOTg3YWNlNjQxNWZiYWJlLi4yNTg5NWJmNTQxNTQ1NjA3Y2U0MjFmOWRlNzQ1 ZDY3YzA2OTg5NjI0IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wYWdlL05hdmlnYXRvci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGFnZS9OYXZpZ2F0b3IuY3BwCkBAIC0zNyw3ICszNyw2 IEBACiAjaW5jbHVkZSAiU2NyaXB0Q29udHJvbGxlci5oIgogI2luY2x1ZGUgIlNlY3VyaXR5T3Jp Z2luLmgiCiAjaW5jbHVkZSAiU2V0dGluZ3MuaCIKLSNpbmNsdWRlICJTdG9yYWdlTmFtZXNwYWNl LmgiCiAjaW5jbHVkZSA8d3RmL0hhc2hTZXQuaD4KICNpbmNsdWRlIDx3dGYvTnVtYmVyT2ZDb3Jl cy5oPgogI2luY2x1ZGUgPHd0Zi9TdGRMaWJFeHRyYXMuaD4KZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVyLmNwcCBiL1NvdXJjZS9XZWJD b3JlL3N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVyLmNwcAppbmRleCBhNzg0NGM0ZTQw NjU1NDA0ZTUxZmI0ZWM0ZDM5Y2Y2M2M5NmI2NTk2Li5hY2YzNzNmZjFkNzFhYTM2ZDk1OTg0N2Vi OTQ1OTI2ZGUxNTQ5YzBmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdlL1N0b3Jh Z2VOYW1lc3BhY2VQcm92aWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9y YWdlTmFtZXNwYWNlUHJvdmlkZXIuY3BwCkBAIC0yNiw2ICsyNiw4IEBACiAjaW5jbHVkZSAiY29u ZmlnLmgiCiAjaW5jbHVkZSAiU3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVyLmgiCiAKKyNpbmNsdWRl ICJEb2N1bWVudC5oIgorI2luY2x1ZGUgIlN0b3JhZ2VBcmVhLmgiCiAjaW5jbHVkZSAiU3RvcmFn ZU5hbWVzcGFjZS5oIgogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CkBAIC01Niw2ICs1OCwxMyBAQCB2 b2lkIFN0b3JhZ2VOYW1lc3BhY2VQcm92aWRlcjo6cmVtb3ZlUGFnZShQYWdlJiBwYWdlKQogICAg IG1fcGFnZXMucmVtb3ZlKCZwYWdlKTsKIH0KIAorUmVmUHRyPFN0b3JhZ2VBcmVhPiBTdG9yYWdl TmFtZXNwYWNlUHJvdmlkZXI6OmxvY2FsU3RvcmFnZUFyZWEoRG9jdW1lbnQmIGRvY3VtZW50KQor eworICAgIGF1dG8mIHN0b3JhZ2VOYW1lc3BhY2UgPSBkb2N1bWVudC5zZWN1cml0eU9yaWdpbigp LT5jYW5BY2Nlc3NMb2NhbFN0b3JhZ2UoZG9jdW1lbnQudG9wT3JpZ2luKCkpID8gbG9jYWxTdG9y YWdlTmFtZXNwYWNlKCkgOiB0cmFuc2llbnRMb2NhbFN0b3JhZ2VOYW1lc3BhY2UoKmRvY3VtZW50 LnRvcE9yaWdpbigpKTsKKworICAgIHJldHVybiBzdG9yYWdlTmFtZXNwYWNlLnN0b3JhZ2VBcmVh KGRvY3VtZW50LnNlY3VyaXR5T3JpZ2luKCkpOworfQorCiBTdG9yYWdlTmFtZXNwYWNlJiBTdG9y YWdlTmFtZXNwYWNlUHJvdmlkZXI6OmxvY2FsU3RvcmFnZU5hbWVzcGFjZSgpCiB7CiAgICAgaWYg KCFtX2xvY2FsU3RvcmFnZU5hbWVzcGFjZSkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0 b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVyLmggYi9Tb3VyY2UvV2ViQ29yZS9zdG9yYWdl L1N0b3JhZ2VOYW1lc3BhY2VQcm92aWRlci5oCmluZGV4IDI2MGVlMTA4NmY1YzRkZjk5MTAzMDZj ODdmMmY1ZDgyMTZlNGVkYmIuLjgzOTFiZDRjMmU2YWFlYTE1MzE3MmE3YmYxMGVmN2RiZDE4NDgw NjQgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3N0b3JhZ2UvU3RvcmFnZU5hbWVzcGFjZVBy b3ZpZGVyLmgKKysrIGIvU291cmNlL1dlYkNvcmUvc3RvcmFnZS9TdG9yYWdlTmFtZXNwYWNlUHJv dmlkZXIuaApAQCAtMzQsOCArMzQsMTAgQEAKIAogbmFtZXNwYWNlIFdlYkNvcmUgewogCitjbGFz cyBEb2N1bWVudDsKIGNsYXNzIFBhZ2U7CiBjbGFzcyBTZWN1cml0eU9yaWdpbjsKK2NsYXNzIFN0 b3JhZ2VBcmVhOwogY2xhc3MgU3RvcmFnZU5hbWVzcGFjZTsKIAogY2xhc3MgU3RvcmFnZU5hbWVz cGFjZVByb3ZpZGVyIDogcHVibGljIFJlZkNvdW50ZWQ8U3RvcmFnZU5hbWVzcGFjZVByb3ZpZGVy PiB7CkBAIC00NCw4ICs0Niw3IEBAIHB1YmxpYzoKICAgICB2aXJ0dWFsIH5TdG9yYWdlTmFtZXNw YWNlUHJvdmlkZXIoKTsKIAogICAgIHZpcnR1YWwgUmVmUHRyPFN0b3JhZ2VOYW1lc3BhY2U+IGNy ZWF0ZVNlc3Npb25TdG9yYWdlTmFtZXNwYWNlKFBhZ2UmLCB1bnNpZ25lZCBxdW90YSkgPSAwOwot ICAgIFN0b3JhZ2VOYW1lc3BhY2UmIGxvY2FsU3RvcmFnZU5hbWVzcGFjZSgpOwotICAgIFN0b3Jh Z2VOYW1lc3BhY2UmIHRyYW5zaWVudExvY2FsU3RvcmFnZU5hbWVzcGFjZShTZWN1cml0eU9yaWdp biYpOworICAgIFJlZlB0cjxTdG9yYWdlQXJlYT4gbG9jYWxTdG9yYWdlQXJlYShEb2N1bWVudCYp OwogCiAgICAgdm9pZCBhZGRQYWdlKFBhZ2UmKTsKICAgICB2b2lkIHJlbW92ZVBhZ2UoUGFnZSYp OwpAQCAtNTQsNiArNTUsOSBAQCBwcm90ZWN0ZWQ6CiAgICAgU3RvcmFnZU5hbWVzcGFjZSogb3B0 aW9uYWxMb2NhbFN0b3JhZ2VOYW1lc3BhY2UoKSB7IHJldHVybiBtX2xvY2FsU3RvcmFnZU5hbWVz cGFjZS5nZXQoKTsgfQogCiBwcml2YXRlOgorICAgIFN0b3JhZ2VOYW1lc3BhY2UmIGxvY2FsU3Rv cmFnZU5hbWVzcGFjZSgpOworICAgIFN0b3JhZ2VOYW1lc3BhY2UmIHRyYW5zaWVudExvY2FsU3Rv cmFnZU5hbWVzcGFjZShTZWN1cml0eU9yaWdpbiYpOworCiAgICAgdmlydHVhbCBSZWZQdHI8U3Rv cmFnZU5hbWVzcGFjZT4gY3JlYXRlTG9jYWxTdG9yYWdlTmFtZXNwYWNlKHVuc2lnbmVkIHF1b3Rh KSA9IDA7CiAgICAgdmlydHVhbCBSZWZQdHI8U3RvcmFnZU5hbWVzcGFjZT4gY3JlYXRlVHJhbnNp ZW50TG9jYWxTdG9yYWdlTmFtZXNwYWNlKFNlY3VyaXR5T3JpZ2luJiwgdW5zaWduZWQgcXVvdGEp ID0gMDsKIAo=