139676 2014-12-16 01:57:52 -0800 Set relayoutChildren to 'true' only if size change happens in Table 2014-12-28 11:32:39 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 rtakacs webkit-unassigned commit-queue darin esprehn+autocc glenn hyatt kling kondapallykalyan ossy oldest_to_newest 1055955 0 rtakacs 2014-12-16 01:57:52 -0800 This patch passes 'true' value for layoutPositionedObjects() in case of size change. It helps to avoid unneccessary setChildNeedsLayout() and setPreferredLogicalWidthsDirty() calls. 1055956 1 243354 rtakacs 2014-12-16 02:00:26 -0800 Created attachment 243354 patch 1057358 2 243354 ossy 2014-12-22 01:17:23 -0800 Comment on attachment 243354 patch r- due to missing changelog 1057570 3 243668 evab.u-szeged 2014-12-23 01:09:00 -0800 Created attachment 243668 Added the missing changelog 1057571 4 243669 rtakacs 2014-12-23 01:14:37 -0800 Created attachment 243669 patch 1058033 5 243669 darin 2014-12-28 10:51:22 -0800 Comment on attachment 243669 patch I guess there’s no simple way to make a test to show the performance improvement from this? Too bad; we really prefer tests for anything like this. 1058043 6 243669 commit-queue 2014-12-28 11:32:34 -0800 Comment on attachment 243669 patch Clearing flags on attachment: 243669 Committed r177782: <http://trac.webkit.org/changeset/177782> 1058044 7 commit-queue 2014-12-28 11:32:39 -0800 All reviewed patches have been landed. Closing bug. 243354 2014-12-16 02:00:26 -0800 2014-12-23 01:09:00 -0800 patch 2014_12_16.diff text/plain 1391 rtakacs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAgYi9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3BwCmluZGV4IDkwZTQ0NTAuLmFk OWIxYjMgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxlLmNwcApAQCAtNDMx LDEzICs0MzEsMTMgQEAgdm9pZCBSZW5kZXJUYWJsZTo6bGF5b3V0KCkKICAgICAvLyBGSVhNRTog V2Ugc2hvdWxkIGRvIHRoaXMgcmVjYWxjIGxhemlseSBpbiBib3JkZXJTdGFydC9ib3JkZXJFbmQg c28gdGhhdCB3ZSBkb24ndCBoYXZlIHRvIG1ha2Ugc3VyZQogICAgIC8vIHRvIGNhbGwgdGhpcyBi ZWZvcmUgd2UgY2FsbCBib3JkZXJTdGFydC9ib3JkZXJFbmQgdG8gYXZvaWQgZ2V0dGluZyBhIHN0 YWxlIHZhbHVlLgogICAgIHJlY2FsY0JvcmRlcnNJblJvd0RpcmVjdGlvbigpOwotICAgICAgICAK KwogICAgIExheW91dFJlcGFpbnRlciByZXBhaW50ZXIoKnRoaXMsIGNoZWNrRm9yUmVwYWludER1 cmluZ0xheW91dCgpKTsKICAgICBMYXlvdXRTdGF0ZU1haW50YWluZXIgc3RhdGVQdXNoZXIodmll dygpLCAqdGhpcywgbG9jYXRpb25PZmZzZXQoKSwgaGFzVHJhbnNmb3JtKCkgfHwgaGFzUmVmbGVj dGlvbigpIHx8IHN0eWxlKCkuaXNGbGlwcGVkQmxvY2tzV3JpdGluZ01vZGUoKSk7CiAKLSAgICBz ZXRMb2dpY2FsSGVpZ2h0KDApOwotICAgIAogICAgIExheW91dFVuaXQgb2xkTG9naWNhbFdpZHRo ID0gbG9naWNhbFdpZHRoKCk7CisgICAgTGF5b3V0VW5pdCBvbGRMb2dpY2FsSGVpZ2h0ID0gbG9n aWNhbEhlaWdodCgpOworICAgIHNldExvZ2ljYWxIZWlnaHQoMCk7CiAgICAgdXBkYXRlTG9naWNh bFdpZHRoKCk7CiAKICAgICBpZiAobG9naWNhbFdpZHRoKCkgIT0gb2xkTG9naWNhbFdpZHRoKSB7 CkBAIC01NTksOCArNTU5LDggQEAgdm9pZCBSZW5kZXJUYWJsZTo6bGF5b3V0KCkKICAgICAgICAg dXBkYXRlTG9naWNhbEhlaWdodCgpOwogCiAgICAgLy8gdGFibGUgY2FuIGJlIGNvbnRhaW5pbmcg YmxvY2sgb2YgcG9zaXRpb25lZCBlbGVtZW50cy4KLSAgICAvLyBGSVhNRTogT25seSBwYXNzIHRy dWUgaWYgd2lkdGggb3IgaGVpZ2h0IGNoYW5nZWQuCi0gICAgbGF5b3V0UG9zaXRpb25lZE9iamVj dHModHJ1ZSk7CisgICAgYm9vbCBkaW1lbnNpb25DaGFuZ2VkID0gb2xkTG9naWNhbFdpZHRoICE9 IGxvZ2ljYWxXaWR0aCgpIHx8IG9sZExvZ2ljYWxIZWlnaHQgIT0gbG9naWNhbEhlaWdodCgpOwor ICAgIGxheW91dFBvc2l0aW9uZWRPYmplY3RzKGRpbWVuc2lvbkNoYW5nZWQpOwogCiAgICAgdXBk YXRlTGF5ZXJUcmFuc2Zvcm0oKTsKIAo= 243668 2014-12-23 01:09:00 -0800 2014-12-23 01:14:37 -0800 Added the missing changelog 2014_12_23.diff text/plain 2311 evab.u-szeged ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZGQzMDJjLi5lODUwYzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMTItMjMgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNzLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgU2V0IHJlbGF5b3V0Q2hpbGRyZW4gdG8gJ3RydWUnIG9u bHkgaWYgc2l6ZSBjaGFuZ2UgaGFwcGVucyBpbiBUYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5Njc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFzcyAndHJ1ZScgdmFsdWUgZm9yIGxheW91dFBv c2l0aW9uZWRPYmplY3RzKCkgaW4gY2FzZSBvZiBzaXplIGNoYW5nZS4KKyAgICAgICAgSXQgaGVs cHMgdG8gYXZvaWQgdW5uZWNjZXNzYXJ5IHNldENoaWxkTmVlZHNMYXlvdXQoKSBhbmQKKyAgICAg ICAgc2V0UHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KCkgY2FsbHMuCisKKyAgICAgICAgVGhp cyBpcyBhIGJhY2twb3J0IG9mIG15IGZpeCBpbiBCbGluazogaHR0cHM6Ly9jb2RlcmV2aWV3LmNo cm9taXVtLm9yZy83MTQ5MzMwMDIvCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OmxheW91dCk6CisKIDIwMTQtMTIt MjIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBMb2cg d2hpY2ggdHlwZSBvZiByZXNvdXJjZXMgYXJlIGNvbW1vbmx5IGxvYWRlZCB1c2luZyBGZWF0dXJl Q291bnRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKaW5kZXggOWU4 NTVkMS4uZWZjYjFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3Bw CkBAIC00MzEsMTMgKzQzMSwxMyBAQCB2b2lkIFJlbmRlclRhYmxlOjpsYXlvdXQoKQogICAgIC8v IEZJWE1FOiBXZSBzaG91bGQgZG8gdGhpcyByZWNhbGMgbGF6aWx5IGluIGJvcmRlclN0YXJ0L2Jv cmRlckVuZCBzbyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gbWFrZSBzdXJlCiAgICAgLy8gdG8gY2Fs bCB0aGlzIGJlZm9yZSB3ZSBjYWxsIGJvcmRlclN0YXJ0L2JvcmRlckVuZCB0byBhdm9pZCBnZXR0 aW5nIGEgc3RhbGUgdmFsdWUuCiAgICAgcmVjYWxjQm9yZGVyc0luUm93RGlyZWN0aW9uKCk7Ci0g ICAgICAgIAorCiAgICAgTGF5b3V0UmVwYWludGVyIHJlcGFpbnRlcigqdGhpcywgY2hlY2tGb3JS ZXBhaW50RHVyaW5nTGF5b3V0KCkpOwogICAgIExheW91dFN0YXRlTWFpbnRhaW5lciBzdGF0ZVB1 c2hlcih2aWV3KCksICp0aGlzLCBsb2NhdGlvbk9mZnNldCgpLCBoYXNUcmFuc2Zvcm0oKSB8fCBo YXNSZWZsZWN0aW9uKCkgfHwgc3R5bGUoKS5pc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpKTsK IAotICAgIHNldExvZ2ljYWxIZWlnaHQoMCk7Ci0gICAgCiAgICAgTGF5b3V0VW5pdCBvbGRMb2dp Y2FsV2lkdGggPSBsb2dpY2FsV2lkdGgoKTsKKyAgICBMYXlvdXRVbml0IG9sZExvZ2ljYWxIZWln aHQgPSBsb2dpY2FsSGVpZ2h0KCk7CisgICAgc2V0TG9naWNhbEhlaWdodCgwKTsKICAgICB1cGRh dGVMb2dpY2FsV2lkdGgoKTsKIAogICAgIGlmIChsb2dpY2FsV2lkdGgoKSAhPSBvbGRMb2dpY2Fs V2lkdGgpIHsKQEAgLTU1OSw4ICs1NTksOCBAQCB2b2lkIFJlbmRlclRhYmxlOjpsYXlvdXQoKQog ICAgICAgICB1cGRhdGVMb2dpY2FsSGVpZ2h0KCk7CiAKICAgICAvLyB0YWJsZSBjYW4gYmUgY29u dGFpbmluZyBibG9jayBvZiBwb3NpdGlvbmVkIGVsZW1lbnRzLgotICAgIC8vIEZJWE1FOiBPbmx5 IHBhc3MgdHJ1ZSBpZiB3aWR0aCBvciBoZWlnaHQgY2hhbmdlZC4KLSAgICBsYXlvdXRQb3NpdGlv bmVkT2JqZWN0cyh0cnVlKTsKKyAgICBib29sIGRpbWVuc2lvbkNoYW5nZWQgPSBvbGRMb2dpY2Fs V2lkdGggIT0gbG9naWNhbFdpZHRoKCkgfHwgb2xkTG9naWNhbEhlaWdodCAhPSBsb2dpY2FsSGVp Z2h0KCk7CisgICAgbGF5b3V0UG9zaXRpb25lZE9iamVjdHMoZGltZW5zaW9uQ2hhbmdlZCk7CiAK ICAgICB1cGRhdGVMYXllclRyYW5zZm9ybSgpOwogCg== 243669 2014-12-23 01:14:37 -0800 2014-12-28 11:32:34 -0800 patch 2014_12_23.diff text/plain 2311 rtakacs ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA5ZGQzMDJjLi5lODUwYzQ4IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkg QEAKKzIwMTQtMTItMjMgIFJvbGFuZCBUYWthY3MgIDxydGFrYWNzLnUtc3plZ2VkQHBhcnRuZXIu c2Ftc3VuZy5jb20+CisKKyAgICAgICAgU2V0IHJlbGF5b3V0Q2hpbGRyZW4gdG8gJ3RydWUnIG9u bHkgaWYgc2l6ZSBjaGFuZ2UgaGFwcGVucyBpbiBUYWJsZQorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5Njc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgUGFzcyAndHJ1ZScgdmFsdWUgZm9yIGxheW91dFBv c2l0aW9uZWRPYmplY3RzKCkgaW4gY2FzZSBvZiBzaXplIGNoYW5nZS4KKyAgICAgICAgSXQgaGVs cHMgdG8gYXZvaWQgdW5uZWNjZXNzYXJ5IHNldENoaWxkTmVlZHNMYXlvdXQoKSBhbmQKKyAgICAg ICAgc2V0UHJlZmVycmVkTG9naWNhbFdpZHRoc0RpcnR5KCkgY2FsbHMuCisKKyAgICAgICAgVGhp cyBpcyBhIGJhY2twb3J0IG9mIG15IGZpeCBpbiBCbGluazogaHR0cHM6Ly9jb2RlcmV2aWV3LmNo cm9taXVtLm9yZy83MTQ5MzMwMDIvCisKKyAgICAgICAgKiByZW5kZXJpbmcvUmVuZGVyVGFibGUu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6UmVuZGVyVGFibGU6OmxheW91dCk6CisKIDIwMTQtMTIt MjIgIENocmlzIER1bWV6ICA8Y2R1bWV6QGFwcGxlLmNvbT4KIAogICAgICAgICBbaU9TXSBMb2cg d2hpY2ggdHlwZSBvZiByZXNvdXJjZXMgYXJlIGNvbW1vbmx5IGxvYWRlZCB1c2luZyBGZWF0dXJl Q291bnRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclRhYmxl LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJUYWJsZS5jcHAKaW5kZXggOWU4 NTVkMS4uZWZjYjFjZCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRl clRhYmxlLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyVGFibGUuY3Bw CkBAIC00MzEsMTMgKzQzMSwxMyBAQCB2b2lkIFJlbmRlclRhYmxlOjpsYXlvdXQoKQogICAgIC8v IEZJWE1FOiBXZSBzaG91bGQgZG8gdGhpcyByZWNhbGMgbGF6aWx5IGluIGJvcmRlclN0YXJ0L2Jv cmRlckVuZCBzbyB0aGF0IHdlIGRvbid0IGhhdmUgdG8gbWFrZSBzdXJlCiAgICAgLy8gdG8gY2Fs bCB0aGlzIGJlZm9yZSB3ZSBjYWxsIGJvcmRlclN0YXJ0L2JvcmRlckVuZCB0byBhdm9pZCBnZXR0 aW5nIGEgc3RhbGUgdmFsdWUuCiAgICAgcmVjYWxjQm9yZGVyc0luUm93RGlyZWN0aW9uKCk7Ci0g ICAgICAgIAorCiAgICAgTGF5b3V0UmVwYWludGVyIHJlcGFpbnRlcigqdGhpcywgY2hlY2tGb3JS ZXBhaW50RHVyaW5nTGF5b3V0KCkpOwogICAgIExheW91dFN0YXRlTWFpbnRhaW5lciBzdGF0ZVB1 c2hlcih2aWV3KCksICp0aGlzLCBsb2NhdGlvbk9mZnNldCgpLCBoYXNUcmFuc2Zvcm0oKSB8fCBo YXNSZWZsZWN0aW9uKCkgfHwgc3R5bGUoKS5pc0ZsaXBwZWRCbG9ja3NXcml0aW5nTW9kZSgpKTsK IAotICAgIHNldExvZ2ljYWxIZWlnaHQoMCk7Ci0gICAgCiAgICAgTGF5b3V0VW5pdCBvbGRMb2dp Y2FsV2lkdGggPSBsb2dpY2FsV2lkdGgoKTsKKyAgICBMYXlvdXRVbml0IG9sZExvZ2ljYWxIZWln aHQgPSBsb2dpY2FsSGVpZ2h0KCk7CisgICAgc2V0TG9naWNhbEhlaWdodCgwKTsKICAgICB1cGRh dGVMb2dpY2FsV2lkdGgoKTsKIAogICAgIGlmIChsb2dpY2FsV2lkdGgoKSAhPSBvbGRMb2dpY2Fs V2lkdGgpIHsKQEAgLTU1OSw4ICs1NTksOCBAQCB2b2lkIFJlbmRlclRhYmxlOjpsYXlvdXQoKQog ICAgICAgICB1cGRhdGVMb2dpY2FsSGVpZ2h0KCk7CiAKICAgICAvLyB0YWJsZSBjYW4gYmUgY29u dGFpbmluZyBibG9jayBvZiBwb3NpdGlvbmVkIGVsZW1lbnRzLgotICAgIC8vIEZJWE1FOiBPbmx5 IHBhc3MgdHJ1ZSBpZiB3aWR0aCBvciBoZWlnaHQgY2hhbmdlZC4KLSAgICBsYXlvdXRQb3NpdGlv bmVkT2JqZWN0cyh0cnVlKTsKKyAgICBib29sIGRpbWVuc2lvbkNoYW5nZWQgPSBvbGRMb2dpY2Fs V2lkdGggIT0gbG9naWNhbFdpZHRoKCkgfHwgb2xkTG9naWNhbEhlaWdodCAhPSBsb2dpY2FsSGVp Z2h0KCk7CisgICAgbGF5b3V0UG9zaXRpb25lZE9iamVjdHMoZGltZW5zaW9uQ2hhbmdlZCk7CiAK ICAgICB1cGRhdGVMYXllclRyYW5zZm9ybSgpOwogCg==