139667 2014-12-15 20:01:00 -0800 Incorrect order of arguments in initial-letter property 2015-06-16 11:14:05 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Mac (Intel) OS X 10.8 RESOLVED FIXED InRadar, WebExposed P2 Normal --- 1 dauwhe galineau commit-queue galineau hyatt jonlee mmaxfield simon.fraser webkit-bug-importer oldest_to_newest 1055837 0 dauwhe 2014-12-15 20:01:00 -0800 The order of arguments in the implementation of the initial-letter property does not match the current spec (http://dev.w3.org/csswg/css-inline/#sizing-drop-initials). The first argument should be size, and the second argument should be the number of lines that the initial letter sinks. This was incorrect in earlier versions of the editor's draft, due to an error by said editor. For example, p::first-letter { -webkit-initial-letter: 3 1 } should produce a pure "raised cap," the size of a 3-line drop cap but sitting on the first text baseline. 1068176 1 246350 galineau 2015-02-10 16:39:45 -0800 Created attachment 246350 fix.patch Swapped the arguments in CSSParser.cpp. Updated the layout tests. 1068367 2 246350 darin 2015-02-11 08:32:12 -0800 Comment on attachment 246350 fix.patch I think we shipped this in multiple web browser versions. Maybe we should swap the order only when removing the WebKit prefix and keep the backwards version for a while with the vendor prefix? 1068375 3 jonlee 2015-02-11 09:23:23 -0800 (In reply to comment #2) > Comment on attachment 246350 [details] > fix.patch > > I think we shipped this in multiple web browser versions. Maybe we should > swap the order only when removing the WebKit prefix and keep the backwards > version for a while with the vendor prefix? We haven't shipped this. You might be confusing this with first-letter (see 136484). 1073429 4 galineau 2015-03-02 13:15:54 -0800 Any additional work needed to land this patch? 1102279 5 webkit-bug-importer 2015-06-16 10:58:14 -0700 <rdar://problem/21404945> 1102280 6 246350 commit-queue 2015-06-16 10:58:59 -0700 Comment on attachment 246350 fix.patch Clearing flags on attachment: 246350 Committed r185595: <http://trac.webkit.org/changeset/185595> 1102281 7 commit-queue 2015-06-16 10:59:04 -0700 All reviewed patches have been landed. Closing bug. 246350 2015-02-10 16:39:45 -0800 2015-06-16 10:58:59 -0700 fix.patch fix-139667.patch text/plain 6711 galineau ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBkMWIyYjgzLi44ZjAyY2ExIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTggQEAKKzIwMTUtMDIt MTAgIHN5bHZhaW4tZ2FsaW5lYXUgIDxnYWxpbmVhdUBhZG9iZS5jb20+CisKKyAgICAgICAgSW5j b3JyZWN0IG9yZGVyIG9mIGFyZ3VtZW50cyBpbiBpbml0aWFsLWxldHRlciBwcm9wZXJ0eQorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NjY3CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVXBkYXRlIGluaXRp YWwtbGV0dGVyIHRlc3RzIHRvIHJlZmxlY3QgdGhlIHZhbHVlJ3MgbmV3IG9yZGVyaW5nLCBwZXIg Q1NTIElubGluZSBMYXlvdXQgbW9kdWxlLgorCisgICAgICAgICogZmFzdC9jc3MtZ2VuZXJhdGVk LWNvbnRlbnQvaW5pdGlhbC1sZXR0ZXItYm9yZGVyLXBhZGRpbmcuaHRtbDoKKyAgICAgICAgKiBm YXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9pbml0aWFsLWxldHRlci1jbGVhcmFuY2UuaHRtbDoK KyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9pbml0aWFsLWxldHRlci1kZXNj ZW5kZXIuaHRtbDoKKyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9pbml0aWFs LWxldHRlci1yYWlzZWQuaHRtbDoKKyAgICAgICAgKiBmYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVu dC9pbml0aWFsLWxldHRlci1zdW5rZW4uaHRtbDoKKwogMjAxNS0wMi0wOSAgRGF2aWQgS2lsemVy ICA8ZGRraWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIFtpT1NdIEdhcmRlbmluZzogY3NzMy9t YXNraW5nL21hc2stcmVwZWF0LXNwYWNlLXBhZGRpbmcuaHRtbApkaWZmIC0tZ2l0IGEvTGF5b3V0 VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaW5pdGlhbC1sZXR0ZXItYm9yZGVyLXBh ZGRpbmcuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2luaXRp YWwtbGV0dGVyLWJvcmRlci1wYWRkaW5nLmh0bWwKaW5kZXggNzFjYWQ5Zi4uOTcxYmNhNyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaW5pdGlhbC1s ZXR0ZXItYm9yZGVyLXBhZGRpbmcuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5l cmF0ZWQtY29udGVudC9pbml0aWFsLWxldHRlci1ib3JkZXItcGFkZGluZy5odG1sCkBAIC0yLDcg KzIsNyBAQAogPGhlYWQ+CiA8c3R5bGU+CiBkaXYgeyB3aWR0aDo0MDBweDsgbWFyZ2luOjFlbSB9 Ci1kaXY6OmZpcnN0LWxldHRlciB7IGNvbG9yOnJlZDsgYm9yZGVyOjJweCBzb2xpZCByZWQ7IHBh ZGRpbmc6MXB4OyAtd2Via2l0LWluaXRpYWwtbGV0dGVyOiAyIDM7IG1hcmdpbi1yaWdodDoycHg7 IG1hcmdpbi1sZWZ0OjJweCB9CitkaXY6OmZpcnN0LWxldHRlciB7IGNvbG9yOnJlZDsgYm9yZGVy OjJweCBzb2xpZCByZWQ7IHBhZGRpbmc6MXB4OyAtd2Via2l0LWluaXRpYWwtbGV0dGVyOiAzIDI7 IG1hcmdpbi1yaWdodDoycHg7IG1hcmdpbi1sZWZ0OjJweCB9CiBzcGFuLnJ0bCB7IGRpcmVjdGlv bjpydGw7IGRpc3BsYXk6YmxvY2sgfQogPC9zdHlsZT4KIDwvaGVhZD4KZGlmZiAtLWdpdCBhL0xh eW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2luaXRpYWwtbGV0dGVyLWNsZWFy YW5jZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaW5pdGlh bC1sZXR0ZXItY2xlYXJhbmNlLmh0bWwKaW5kZXggMDFjNzg5MS4uOGI5Mzc4MiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaW5pdGlhbC1sZXR0ZXIt Y2xlYXJhbmNlLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRl bnQvaW5pdGlhbC1sZXR0ZXItY2xlYXJhbmNlLmh0bWwKQEAgLTIsNyArMiw3IEBACiA8aGVhZD4K IDxzdHlsZT4KIGRpdiB7IHdpZHRoOjQwMHB4OyBtYXJnaW46MWVtIH0KLWRpdjo6Zmlyc3QtbGV0 dGVyIHsgZm9udC1mYW1pbHk6IFphcGZpbm87IC13ZWJraXQtaW5pdGlhbC1sZXR0ZXI6IDIgNDsg bWFyZ2luLXJpZ2h0OjJweDsgbWFyZ2luLWxlZnQ6MjsgfQorZGl2OjpmaXJzdC1sZXR0ZXIgeyBm b250LWZhbWlseTogWmFwZmlubzsgLXdlYmtpdC1pbml0aWFsLWxldHRlcjogNCAyOyBtYXJnaW4t cmlnaHQ6MnB4OyBtYXJnaW4tbGVmdDoyOyB9CiAKIDwvc3R5bGU+CiA8L2hlYWQ+CmRpZmYgLS1n aXQgYS9MYXlvdXRUZXN0cy9mYXN0L2Nzcy1nZW5lcmF0ZWQtY29udGVudC9pbml0aWFsLWxldHRl ci1kZXNjZW5kZXIuaHRtbCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50 L2luaXRpYWwtbGV0dGVyLWRlc2NlbmRlci5odG1sCmluZGV4IDU2NTBjZGQuLmUwYWNlNzggMTAw NjQ0Ci0tLSBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2luaXRpYWwt bGV0dGVyLWRlc2NlbmRlci5odG1sCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRl ZC1jb250ZW50L2luaXRpYWwtbGV0dGVyLWRlc2NlbmRlci5odG1sCkBAIC0yLDcgKzIsNyBAQAog PGhlYWQ+CiA8c3R5bGU+CiBkaXYgeyB3aWR0aDo0MDBweDsgbWFyZ2luOjFlbSB9Ci1kaXY6OmZp cnN0LWxldHRlciB7IGZvbnQtZmFtaWx5OiBaYXBmaW5vOyAtd2Via2l0LWluaXRpYWwtbGV0dGVy OiAyIDQ7IG1hcmdpbi1yaWdodDoycHg7IG1hcmdpbi1sZWZ0OjIgfQorZGl2OjpmaXJzdC1sZXR0 ZXIgeyBmb250LWZhbWlseTogWmFwZmlubzsgLXdlYmtpdC1pbml0aWFsLWxldHRlcjogNCAyOyBt YXJnaW4tcmlnaHQ6MnB4OyBtYXJnaW4tbGVmdDoyIH0KIAogPC9zdHlsZT4KIDwvaGVhZD4KZGlm ZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2luaXRpYWwt bGV0dGVyLXJhaXNlZC5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRl bnQvaW5pdGlhbC1sZXR0ZXItcmFpc2VkLmh0bWwKaW5kZXggOGYyNzM0Yi4uY2ZmNjdkNyAxMDA2 NDQKLS0tIGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaW5pdGlhbC1s ZXR0ZXItcmFpc2VkLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNv bnRlbnQvaW5pdGlhbC1sZXR0ZXItcmFpc2VkLmh0bWwKQEAgLTIsNyArMiw3IEBACiA8aGVhZD4K IDxzdHlsZT4KIGRpdiB7IHdpZHRoOjQwMHB4OyBtYXJnaW46MWVtIH0KLWRpdjo6Zmlyc3QtbGV0 dGVyIHsgLXdlYmtpdC1pbml0aWFsLWxldHRlcjogMiAzOyBtYXJnaW4tcmlnaHQ6MnB4OyBtYXJn aW4tbGVmdDoycHggfQorZGl2OjpmaXJzdC1sZXR0ZXIgeyAtd2Via2l0LWluaXRpYWwtbGV0dGVy OiAzIDI7IG1hcmdpbi1yaWdodDoycHg7IG1hcmdpbi1sZWZ0OjJweCB9CiBzcGFuLnJ0bCB7IGRp cmVjdGlvbjpydGw7IGRpc3BsYXk6YmxvY2sgfQogPC9zdHlsZT4KIDwvaGVhZD4KZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzLWdlbmVyYXRlZC1jb250ZW50L2luaXRpYWwtbGV0dGVy LXN1bmtlbi5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaW5p dGlhbC1sZXR0ZXItc3Vua2VuLmh0bWwKaW5kZXggY2ZmNjdkNy4uOGYyNzM0YiAxMDA2NDQKLS0t IGEvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQvaW5pdGlhbC1sZXR0ZXIt c3Vua2VuLmh0bWwKKysrIGIvTGF5b3V0VGVzdHMvZmFzdC9jc3MtZ2VuZXJhdGVkLWNvbnRlbnQv aW5pdGlhbC1sZXR0ZXItc3Vua2VuLmh0bWwKQEAgLTIsNyArMiw3IEBACiA8aGVhZD4KIDxzdHls ZT4KIGRpdiB7IHdpZHRoOjQwMHB4OyBtYXJnaW46MWVtIH0KLWRpdjo6Zmlyc3QtbGV0dGVyIHsg LXdlYmtpdC1pbml0aWFsLWxldHRlcjogMyAyOyBtYXJnaW4tcmlnaHQ6MnB4OyBtYXJnaW4tbGVm dDoycHggfQorZGl2OjpmaXJzdC1sZXR0ZXIgeyAtd2Via2l0LWluaXRpYWwtbGV0dGVyOiAyIDM7 IG1hcmdpbi1yaWdodDoycHg7IG1hcmdpbi1sZWZ0OjJweCB9CiBzcGFuLnJ0bCB7IGRpcmVjdGlv bjpydGw7IGRpc3BsYXk6YmxvY2sgfQogPC9zdHlsZT4KIDwvaGVhZD4KZGlmZiAtLWdpdCBhL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCBk ZjMwMGI0Li4wMTdkZGUzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysr IGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTUtMDItMTAg IHN5bHZhaW4tZ2FsaW5lYXUgIDxnYWxpbmVhdUBhZG9iZS5jb20+CisKKyAgICAgICAgSW5jb3Jy ZWN0IG9yZGVyIG9mIGFyZ3VtZW50cyBpbiBpbml0aWFsLWxldHRlciBwcm9wZXJ0eQorICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NjY3CisKKyAgICAg ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgVGhlIENTUyBzcGVjaWZp Y2F0aW9uIHN3YXBwZWQgdGhlIG9yZGVyIG9mIHRoZSBpbml0aWFsLWxldHRlcnMgbnVtZXJpYyB2 YWx1ZXMuCisgICAgICAgIFRoZSBkcm9wIGNhcCdzIGhlaWdodCBub3cgY29tZXMgZmlyc3QsIGZv bGxvd2VkIGJ5IGl0cyBvcHRpb25hbCB2ZXJ0aWNhbCBwb3NpdGlvbi4KKyAgICAgICAgU2VlIGh0 dHA6Ly93d3cudzMub3JnL1RSL2Nzcy1pbmxpbmUvI3NpemluZy1kcm9wLWluaXRpYWxzLgorICAg ICAgICAgCisgICAgICAgIE5vIG5ldyB0ZXN0cy4gRXhpc3RpbmcgdGVzdHMgdXBkYXRlZC4KKwor ICAgICAgICAqIGNzcy9DU1NQYXJzZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6Q1NTUGFyc2Vy OjpwYXJzZVZhbHVlKTogc3dhcCBhcmd1bWVudHMgdG8gcmVmbGVjdCBuZXcgc3BlYyBvcmRlci4K KwogMjAxNS0wMi0wOSAgRGFyaW4gQWRsZXIgIDxkYXJpbkBhcHBsZS5jb20+CiAKICAgICAgICAg VHJ5IHRvIGZpeCBidWlsZCBvbiBwbGF0Zm9ybXMgdGhhdCB1c2UgU1ZHICJhbGwgaW4gb25lIiBm aWxlIChXaW5kb3dzKS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIu Y3BwIGIvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKaW5kZXggNjJiODc5MC4uZGFh ZjZiMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKKysrIGIv U291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKQEAgLTI0NzMsMTcgKzI0NzMsMTcgQEAg Ym9vbCBDU1NQYXJzZXI6OnBhcnNlVmFsdWUoQ1NTUHJvcGVydHlJRCBwcm9wSWQsIGJvb2wgaW1w b3J0YW50KQogICAgICAgICAgICAgdmFsaWRQcmltaXRpdmUgPSB2YWxpZGF0ZVVuaXQodmFsdWVX aXRoQ2FsY3VsYXRpb24sIEZQb3NpdGl2ZUludGVnZXIpOwogICAgICAgICAgICAgaWYgKCF2YWxp ZFByaW1pdGl2ZSkKICAgICAgICAgICAgICAgICByZXR1cm4gZmFsc2U7Ci0gICAgICAgICAgICBS ZWZQdHI8Q1NTUHJpbWl0aXZlVmFsdWU+IHBhcnNlZFZhbHVlMSA9IGNyZWF0ZVByaW1pdGl2ZU51 bWVyaWNWYWx1ZSh2YWx1ZVdpdGhDYWxjdWxhdGlvbik7Ci0gICAgICAgICAgICBSZWZQdHI8Q1NT UHJpbWl0aXZlVmFsdWU+IHBhcnNlZFZhbHVlMjsKKyAgICAgICAgICAgIFJlZlB0cjxDU1NQcmlt aXRpdmVWYWx1ZT4gaGVpZ2h0ID0gY3JlYXRlUHJpbWl0aXZlTnVtZXJpY1ZhbHVlKHZhbHVlV2l0 aENhbGN1bGF0aW9uKTsKKyAgICAgICAgICAgIFJlZlB0cjxDU1NQcmltaXRpdmVWYWx1ZT4gcG9z aXRpb247CiAgICAgICAgICAgICBpZiAobnVtID09IDIpIHsKICAgICAgICAgICAgICAgICBWYWx1 ZVdpdGhDYWxjdWxhdGlvbiBuZXh0VmFsdWVXaXRoQ2FsY3VsYXRpb24oKm1fdmFsdWVMaXN0LT5u ZXh0KCkpOwogICAgICAgICAgICAgICAgIHZhbGlkUHJpbWl0aXZlID0gdmFsaWRhdGVVbml0KG5l eHRWYWx1ZVdpdGhDYWxjdWxhdGlvbiwgRlBvc2l0aXZlSW50ZWdlcik7CiAgICAgICAgICAgICAg ICAgaWYgKCF2YWxpZFByaW1pdGl2ZSkKICAgICAgICAgICAgICAgICAgICAgcmV0dXJuIGZhbHNl OwotICAgICAgICAgICAgICAgIHBhcnNlZFZhbHVlMiA9IGNyZWF0ZVByaW1pdGl2ZU51bWVyaWNW YWx1ZShuZXh0VmFsdWVXaXRoQ2FsY3VsYXRpb24pOworICAgICAgICAgICAgICAgIHBvc2l0aW9u ID0gY3JlYXRlUHJpbWl0aXZlTnVtZXJpY1ZhbHVlKG5leHRWYWx1ZVdpdGhDYWxjdWxhdGlvbik7 CiAgICAgICAgICAgICB9IGVsc2UKLSAgICAgICAgICAgICAgICBwYXJzZWRWYWx1ZTIgPSBwYXJz ZWRWYWx1ZTE7Ci0gICAgICAgICAgICBhZGRQcm9wZXJ0eShwcm9wSWQsIGNyZWF0ZVByaW1pdGl2 ZVZhbHVlUGFpcihwYXJzZWRWYWx1ZTEucmVsZWFzZSgpLCBwYXJzZWRWYWx1ZTIucmVsZWFzZSgp KSwgaW1wb3J0YW50KTsKKyAgICAgICAgICAgICAgICBwb3NpdGlvbiA9IGhlaWdodDsKKyAgICAg ICAgICAgIGFkZFByb3BlcnR5KHByb3BJZCwgY3JlYXRlUHJpbWl0aXZlVmFsdWVQYWlyKHBvc2l0 aW9uLnJlbGVhc2UoKSwgaGVpZ2h0LnJlbGVhc2UoKSksIGltcG9ydGFudCk7CiAgICAgICAgICAg ICByZXR1cm4gdHJ1ZTsKICAgICAgICAgfQogICAgICAgICBicmVhazsK