139663 2014-12-15 18:42:15 -0800 Web Inspector: Uncaught Exception when dismissing Go To Line dialog 2015-01-06 18:56:59 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck webkit-unassigned commit-queue graouts joepeck jonowells mattbaker nvasilyev timothy webkit-bug-importer oldest_to_newest 1055825 0 joepeck 2014-12-15 18:42:15 -0800 * SUMMARY Uncaught Exception when dismissing Go To Line dialog: [Error] NotFoundError: DOM Exception 8: An attempt was made to reference a Node in a context where it does not exist. removeChild (Main.js, line 6910) dismiss (Main.js, line 6910) _handleKeydownEvent (Main.js, line 6919) handleEvent (Main.js, line 6912) * STEPS TO REPRODUCE 1. Inspect any page 2. Go to source code text editor 3. Open Go To Line Dialog (Cmd+L) 4. Input a number and push Return to dismiss the dialog => uncaught exception * NOTES - The exception is happening because dismiss is getting called twice. Once by the key event, once by the "blur" event that is happening as the result of removeChild. This double dismiss causes an exception. 1055827 1 243335 joepeck 2014-12-15 18:44:44 -0800 Created attachment 243335 [PATCH] Proposed Fix 1055828 2 joepeck 2014-12-15 18:45:31 -0800 Example debugging: Resources/Views/GoToLineDialog.js:70:20: CONSOLE LOG dismissing Resources/Views/GoToLineDialog.js:71:22: CONSOLE TRACE 0: dismiss(Resources/Views/GoToLineDialog.js:71:22) 1: _handleKeydownEvent(Resources/Views/GoToLineDialog.js:138:29) 2: handleEvent(Resources/Views/GoToLineDialog.js:98:37) Resources/Views/GoToLineDialog.js:70:20: CONSOLE LOG dismissing Resources/Views/GoToLineDialog.js:71:22: CONSOLE TRACE 0: dismiss(Resources/Views/GoToLineDialog.js:71:22) 1: _handleBlurEvent(Resources/Views/GoToLineDialog.js:149:21) 2: handleEvent(Resources/Views/GoToLineDialog.js:101:34) 3: removeChild([native code]) 4: dismiss(Resources/Views/GoToLineDialog.js:81:27) 5: _handleKeydownEvent(Resources/Views/GoToLineDialog.js:138:29) 6: handleEvent(Resources/Views/GoToLineDialog.js:98:37) Shows the nested nature. 1056435 3 webkit-bug-importer 2014-12-17 11:23:39 -0800 <rdar://problem/19281546> 1059278 4 243335 commit-queue 2015-01-06 18:56:55 -0800 Comment on attachment 243335 [PATCH] Proposed Fix Clearing flags on attachment: 243335 Committed r178018: <http://trac.webkit.org/changeset/178018> 1059279 5 commit-queue 2015-01-06 18:56:59 -0800 All reviewed patches have been landed. Closing bug. 243335 2014-12-15 18:44:44 -0800 2015-01-06 18:56:55 -0800 [PATCH] Proposed Fix proposed-fix.patch text/plain 2146 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGEwYWNjYjAuLjNmMGQwMWQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4IEBACisyMDE0LTEyLTE1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogVW5jYXVn aHQgRXhjZXB0aW9uIHdoZW4gZGlzbWlzc2luZyBHbyBUbyBMaW5lIGRpYWxvZworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NjYzCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbGluZyByZW1vdmVDaGls ZCB3b3VsZCB0cmlnZ2VyIHRoZSBibHVyIGV2ZW50IGhhbmRsZXIgYW5kIGRvIGEKKyAgICAgICAg bmVzdGVkIGNhbGwgb2YgZGlzbWlzcygpLCByZS1lbnRlcmluZyBhbmQgcmVtb3Zpbmcgd2hpbGUg aW4gdGhlIG1pZGRsZQorICAgICAgICBvZiByZW1vdmluZy4gQXZvaWQgcmUtZW50cmFuY3kgdG8g YXZvaWQgdGhlIGV4Y2VwdGlvbi4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvR29U b0xpbmVEaWFsb2cuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuR29Ub0xpbmVEaWFsb2cpOgor ICAgICAgICAoV2ViSW5zcGVjdG9yLkdvVG9MaW5lRGlhbG9nLnByb3RvdHlwZS5kaXNtaXNzKToK KwogMjAxNC0xMi0xMiAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAg ICAgICAgIFdlYiBJbnNwZWN0b3I6IENTU1N0eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yIGZhaWxz IHRvIHVwZGF0ZSBpZiBjb21wdXRlZCBwcm9wZXJ0aWVzIGNoYW5nZWQgZnJvbSBlbXB0eSB0byBu b24tZW1wdHkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNl L1ZpZXdzL0dvVG9MaW5lRGlhbG9nLmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRl cmZhY2UvVmlld3MvR29Ub0xpbmVEaWFsb2cuanMKaW5kZXggMzc2YmQ5Ny4uMWQwNzdjMyAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvR29Ub0xp bmVEaWFsb2cuanMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmll d3MvR29Ub0xpbmVEaWFsb2cuanMKQEAgLTQ0LDYgKzQ0LDggQEAgV2ViSW5zcGVjdG9yLkdvVG9M aW5lRGlhbG9nID0gZnVuY3Rpb24oKQogICAgIHRoaXMuX2lucHV0LmFkZEV2ZW50TGlzdGVuZXIo ImJsdXIiLCB0aGlzKTsKICAgICB0aGlzLl9jbGVhckljb24uYWRkRXZlbnRMaXN0ZW5lcigibW91 c2Vkb3duIiwgdGhpcyk7CiAgICAgdGhpcy5fY2xlYXJJY29uLmFkZEV2ZW50TGlzdGVuZXIoImNs aWNrIiwgdGhpcyk7CisKKyAgICB0aGlzLl9kaXNtaXNzaW5nID0gZmFsc2U7CiB9OwogCiBXZWJJ bnNwZWN0b3IuR29Ub0xpbmVEaWFsb2cuU3R5bGVDbGFzc05hbWUgPSAiZ28tdG8tbGluZS1kaWFs b2ciOwpAQCAtNjUsMTQgKzY3LDIxIEBAIFdlYkluc3BlY3Rvci5Hb1RvTGluZURpYWxvZy5wcm90 b3R5cGUgPSB7CiAKICAgICBkaXNtaXNzOiBmdW5jdGlvbigpCiAgICAgeworICAgICAgICBpZiAo dGhpcy5fZGlzbWlzc2luZykKKyAgICAgICAgICAgIHJldHVybjsKKwogICAgICAgICB2YXIgcGFy ZW50ID0gdGhpcy5fZWxlbWVudC5wYXJlbnROb2RlOwogICAgICAgICBpZiAoIXBhcmVudCkKICAg ICAgICAgICAgIHJldHVybjsKIAorICAgICAgICB0aGlzLl9kaXNtaXNzaW5nID0gdHJ1ZTsKKwog ICAgICAgICBwYXJlbnQucmVtb3ZlQ2hpbGQodGhpcy5fZWxlbWVudCk7CiAKICAgICAgICAgaWYg KHRoaXMuZGVsZWdhdGUgJiYgdHlwZW9mIHRoaXMuZGVsZWdhdGUuZ29Ub0xpbmVEaWFsb2dXYXNE aXNtaXNzZWQgPT09ICJmdW5jdGlvbiIpCiAgICAgICAgICAgICB0aGlzLmRlbGVnYXRlLmdvVG9M aW5lRGlhbG9nV2FzRGlzbWlzc2VkKHRoaXMpOworCisgICAgICAgIHRoaXMuX2Rpc21pc3Npbmcg PSBmYWxzZTsKICAgICB9LAogCiAgICAgLy8gUHJvdGVjdGVkCg==