139644 2014-12-15 05:24:54 -0800 The SVGDocument of an SVGImage should not perform any additional actions when the SVGImage is being destroyed 2014-12-18 03:57:05 -0800 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED AdobeTracked P2 Normal --- 139294 139592 1 stavila stavila commit-queue d-r esprehn+autocc fmalita gyuyoung.kim japhet kangil.han koivisto mihnea pdr schenney sergio simon.fraser oldest_to_newest 1055603 0 stavila 2014-12-15 05:24:54 -0800 In SVGImage::~SVGImage, when detaching the frame, the SVGDocument of the image performs additional actions (such as dispatching events and performing style recalc) even though it is being destroyed (the document is created by the image and destroyed together with it). This is not only useless, but can cause additional problems. 1055614 1 243294 stavila 2014-12-15 07:04:27 -0800 Created attachment 243294 Patch 1055615 2 243294 koivisto 2014-12-15 07:19:28 -0800 Comment on attachment 243294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243294&action=review > Source/WebCore/dom/Document.h:534 > + inline bool isBeingDestroyed() const { return m_isBeingDestroyed; } > + inline void setIsBeingDestroyed() { m_isBeingDestroyed = true; } This sounds very generic yet it is only ever set for SVG images. Can we just have isSVGImage() or similar? Other places that check for that seem to use frame()->page()->chrome().client().isSVGImageChromeClient(). 1055616 3 243294 stavila 2014-12-15 07:22:02 -0800 Comment on attachment 243294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243294&action=review >> Source/WebCore/dom/Document.h:534 >> + inline void setIsBeingDestroyed() { m_isBeingDestroyed = true; } > > This sounds very generic yet it is only ever set for SVG images. > > Can we just have isSVGImage() or similar? Other places that check for that seem to use frame()->page()->chrome().client().isSVGImageChromeClient(). I can do that but since the actions that are taken when the flag is set are not SVG-specific but rather specific for any document being destroyed, isn't this more consistent? 1055620 4 stavila 2014-12-15 07:47:27 -0800 Another thing would be that I would like to only affect the particular scenario of the SVGImage being destroyed, I don't want to change it for all SVGImages, in any scenario. 1055621 5 koivisto 2014-12-15 08:02:39 -0800 (In reply to comment #4) > Another thing would be that I would like to only affect the particular > scenario of the SVGImage being destroyed, I don't want to change it for all > SVGImages, in any scenario. What are those scenarios and why don't you want to change them? 1055622 6 stavila 2014-12-15 08:06:12 -0800 Because I don't know all the cases when closeURL might be called on SVGDocuments attached to SVGImages and I feel keeping this restricted to only the problem at hand is the safest way to avoid unforeseen efects. 1055724 7 243294 simon.fraser 2014-12-15 13:46:10 -0800 Comment on attachment 243294 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243294&action=review >>> Source/WebCore/dom/Document.h:534 >>> + inline void setIsBeingDestroyed() { m_isBeingDestroyed = true; } >> >> This sounds very generic yet it is only ever set for SVG images. >> >> Can we just have isSVGImage() or similar? Other places that check for that seem to use frame()->page()->chrome().client().isSVGImageChromeClient(). > > I can do that but since the actions that are taken when the flag is set are not SVG-specific but rather specific for any document being destroyed, isn't this more consistent? I don't like having both this and RenderObject::documentBeingDestroyed() (which calls Document::renderTreeBeingDestroyed()) which means something different. Either they should be true at the same time, or they need names that distinguish them. 1055959 8 243355 stavila 2014-12-16 02:13:13 -0800 Created attachment 243355 Implemented reviewer feedback 1056296 9 243355 commit-queue 2014-12-17 02:13:47 -0800 Comment on attachment 243355 Implemented reviewer feedback Clearing flags on attachment: 243355 Committed r177441: <http://trac.webkit.org/changeset/177441> 1056297 10 commit-queue 2014-12-17 02:13:57 -0800 All reviewed patches have been landed. Closing bug. 1056744 11 stavila 2014-12-18 03:57:05 -0800 *** Bug 139592 has been marked as a duplicate of this bug. *** 243294 2014-12-15 07:04:27 -0800 2014-12-16 02:13:13 -0800 Patch 139644.patch text/plain 4234 stavila ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCBjODlkNzFjLi5mNmRkOTAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTQtMTItMTUgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgorCisgICAg ICAgIFRoZSBTVkdEb2N1bWVudCBvZiBhbiBTVkdJbWFnZSBzaG91bGQgbm90IHBlcmZvcm0gYW55 IGFkZGl0aW9uYWwgYWN0aW9ucyB3aGVuIHRoZSBTVkdJbWFnZSBpcyBiZWluZyBkZXN0cm95ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTY0NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYW4g U1ZHSW1hZ2UgaXMgZGVzdHJveWVkLCBoYXZpbmcgaXRzIFNWR0RvY3VtZW50IHBlcmZvcm0gc3R5 bGUgcmVjYWxjIGFuZCBkaXNwYXRjaGluZyBldmVudHMgaXMgbm90IG9ubHkKKyAgICAgICAgdXNl bGVzcyBidXQgY2FuIGFsc28gY2F1c2UgcHJvYmxlbXMsIHN1Y2ggYXMgcmUtZW50cmFuY3kgaW4g U3R5bGVSZXNvbHZlcjo6bG9hZFBlbmRpbmdSZXNvdXJjZXMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIHJlcXVpcmVkLCBleGlzdGluZyB0ZXN0cyBjb3ZlciB0aGlzIGNoYW5nZS4KKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6RG9jdW1l bnQpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OmlzQmVpbmdEZXN0cm95ZWQpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldElz QmVpbmdEZXN0cm95ZWQpOgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2xvc2VVUkwpOgorICAgICAgICAqIHN2Zy9ncmFw aGljcy9TVkdJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6flNWR0ltYWdl KToKKwogMjAxNC0xMi0xNSAgR3l1eW91bmcgS2ltICA8Z3l1eW91bmcua2ltQHNhbXN1bmcuY29t PgogCiAgICAgICAgIFtHVEtdIFJlbW92ZSBHYW1lcGFkRGV2aWNlR3RrOjpjcmVhdGUoKQpkaWZm IC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3Jl L2RvbS9Eb2N1bWVudC5jcHAKaW5kZXggNjMzNzM3Zi4uOGQ4ZmFiOSAxMDA2NDQKLS0tIGEvU291 cmNlL1dlYkNvcmUvZG9tL0RvY3VtZW50LmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9kb20vRG9j dW1lbnQuY3BwCkBAIC00NjksNiArNDY5LDcgQEAgRG9jdW1lbnQ6OkRvY3VtZW50KEZyYW1lKiBm cmFtZSwgY29uc3QgVVJMJiB1cmwsIHVuc2lnbmVkIGRvY3VtZW50Q2xhc3NlcywgdW5zaWcKICAg ICAsIG1faXNOb25SZW5kZXJlZFBsYWNlaG9sZGVyKGNvbnN0cnVjdGlvbkZsYWdzICYgTm9uUmVu ZGVyZWRQbGFjZWhvbGRlcikKICAgICAsIG1fc2F3RWxlbWVudHNJbktub3duTmFtZXNwYWNlcyhm YWxzZSkKICAgICAsIG1faXNTcmNkb2NEb2N1bWVudChmYWxzZSkKKyAgICAsIG1faXNCZWluZ0Rl c3Ryb3llZChmYWxzZSkKICAgICAsIG1fZXZlbnRRdWV1ZSgqdGhpcykKICAgICAsIG1fd2Vha0Zh Y3RvcnkodGhpcykKICNpZiBFTkFCTEUoRlVMTFNDUkVFTl9BUEkpCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9kb20vRG9jdW1lbnQuaCBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5o CmluZGV4IDVlYjA3NDcuLmRlMGFjNDcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2RvbS9E b2N1bWVudC5oCisrKyBiL1NvdXJjZS9XZWJDb3JlL2RvbS9Eb2N1bWVudC5oCkBAIC01MjksNiAr NTI5LDkgQEAgcHVibGljOgogICAgIHN0YXRpYyB1aW50MzJfdCBpc0hUTUxEb2N1bWVudENsYXNz RmxhZygpIHsgcmV0dXJuIEhUTUxEb2N1bWVudENsYXNzOyB9CiAKICAgICBib29sIGlzU3JjZG9j RG9jdW1lbnQoKSBjb25zdCB7IHJldHVybiBtX2lzU3JjZG9jRG9jdW1lbnQ7IH0KKyAgICAKKyAg ICBpbmxpbmUgYm9vbCBpc0JlaW5nRGVzdHJveWVkKCkgY29uc3QgeyByZXR1cm4gbV9pc0JlaW5n RGVzdHJveWVkOyB9CisgICAgaW5saW5lIHZvaWQgc2V0SXNCZWluZ0Rlc3Ryb3llZCgpIHsgbV9p c0JlaW5nRGVzdHJveWVkID0gdHJ1ZTsgfQogCiAgICAgU3R5bGVSZXNvbHZlciogc3R5bGVSZXNv bHZlcklmRXhpc3RzKCkgY29uc3QgeyByZXR1cm4gbV9zdHlsZVJlc29sdmVyLmdldCgpOyB9CiAK QEAgLTE1NTksNiArMTU2Miw4IEBAIHByaXZhdGU6CiAKICAgICBib29sIG1fc2F3RWxlbWVudHNJ bktub3duTmFtZXNwYWNlczsKICAgICBib29sIG1faXNTcmNkb2NEb2N1bWVudDsKKyAgICAKKyAg ICBib29sIG1faXNCZWluZ0Rlc3Ryb3llZDsKIAogICAgIFJlbmRlclB0cjxSZW5kZXJWaWV3PiBt X3JlbmRlclZpZXc7CiAgICAgbXV0YWJsZSBEb2N1bWVudEV2ZW50UXVldWUgbV9ldmVudFF1ZXVl OwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1Nv dXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggNWU1N2U5NS4uNzE0ZTlh MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysg Yi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC01NDIsNyArNTQyLDEz IEBAIGJvb2wgRnJhbWVMb2FkZXI6OmNsb3NlVVJMKCkKICAgICAKICAgICAvLyBTaG91bGQgb25s eSBzZW5kIHRoZSBwYWdlaGlkZSBldmVudCBoZXJlIGlmIHRoZSBjdXJyZW50IGRvY3VtZW50IGV4 aXN0cyBhbmQgaGFzIG5vdCBiZWVuIHBsYWNlZCBpbiB0aGUgcGFnZSBjYWNoZS4gICAgCiAgICAg RG9jdW1lbnQqIGN1cnJlbnREb2N1bWVudCA9IG1fZnJhbWUuZG9jdW1lbnQoKTsKLSAgICBzdG9w TG9hZGluZyhjdXJyZW50RG9jdW1lbnQgJiYgIWN1cnJlbnREb2N1bWVudC0+aW5QYWdlQ2FjaGUo KSA/IFVubG9hZEV2ZW50UG9saWN5VW5sb2FkQW5kUGFnZUhpZGUgOiBVbmxvYWRFdmVudFBvbGlj eVVubG9hZE9ubHkpOworICAgIFVubG9hZEV2ZW50UG9saWN5IHVubG9hZEV2ZW50UG9saWN5Owor ICAgIGlmIChjdXJyZW50RG9jdW1lbnQgJiYgY3VycmVudERvY3VtZW50LT5pc0JlaW5nRGVzdHJv eWVkKCkpCisgICAgICAgIHVubG9hZEV2ZW50UG9saWN5ID0gVW5sb2FkRXZlbnRQb2xpY3lOb25l OworICAgIGVsc2UKKyAgICAgICAgdW5sb2FkRXZlbnRQb2xpY3kgPSBjdXJyZW50RG9jdW1lbnQg JiYgIWN1cnJlbnREb2N1bWVudC0+aW5QYWdlQ2FjaGUoKSA/IFVubG9hZEV2ZW50UG9saWN5VW5s b2FkQW5kUGFnZUhpZGUgOiBVbmxvYWRFdmVudFBvbGljeVVubG9hZE9ubHk7CisKKyAgICBzdG9w TG9hZGluZyh1bmxvYWRFdmVudFBvbGljeSk7CiAgICAgCiAgICAgbV9mcmFtZS5lZGl0b3IoKS5j bGVhclVuZG9SZWRvT3BlcmF0aW9ucygpOwogICAgIHJldHVybiB0cnVlOwpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcCBiL1NvdXJjZS9XZWJDb3Jl L3N2Zy9ncmFwaGljcy9TVkdJbWFnZS5jcHAKaW5kZXggNTcyMTVkOS4uOGEyNzEzNCAxMDA2NDQK LS0tIGEvU291cmNlL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR0ltYWdlLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9zdmcvZ3JhcGhpY3MvU1ZHSW1hZ2UuY3BwCkBAIC01Nyw2ICs1Nyw3IEBAIFNW R0ltYWdlOjp+U1ZHSW1hZ2UoKQogICAgIGlmIChtX3BhZ2UpIHsKICAgICAgICAgLy8gU3RvcmUg bV9wYWdlIGluIGEgbG9jYWwgdmFyaWFibGUsIGNsZWFyaW5nIG1fcGFnZSwgc28gdGhhdCBTVkdJ bWFnZUNocm9tZUNsaWVudCBrbm93cyB3ZSdyZSBkZXN0cnVjdGVkLgogICAgICAgICBzdGQ6OnVu aXF1ZV9wdHI8UGFnZT4gY3VycmVudFBhZ2UgPSBXVEY6Om1vdmUobV9wYWdlKTsKKyAgICAgICAg Y3VycmVudFBhZ2UtPm1haW5GcmFtZSgpLmRvY3VtZW50KCktPnNldElzQmVpbmdEZXN0cm95ZWQo KTsKICAgICAgICAgY3VycmVudFBhZ2UtPm1haW5GcmFtZSgpLmxvYWRlcigpLmZyYW1lRGV0YWNo ZWQoKTsgLy8gQnJlYWsgYm90aCB0aGUgbG9hZGVyIGFuZCB2aWV3IHJlZmVyZW5jZXMgdG8gdGhl IGZyYW1lCiAgICAgfQogCg== 243355 2014-12-16 02:13:13 -0800 2014-12-17 02:13:47 -0800 Implemented reviewer feedback 139644.patch text/plain 2579 stavila ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCA1MTI5NjgxLi5lZWMwYTU2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUg QEAKKzIwMTQtMTItMTUgIFJhZHUgU3RhdmlsYSAgPHN0YXZpbGFAYWRvYmUuY29tPgorCisgICAg ICAgIFRoZSBTVkdEb2N1bWVudCBvZiBhbiBTVkdJbWFnZSBzaG91bGQgbm90IHBlcmZvcm0gYW55 IGFkZGl0aW9uYWwgYWN0aW9ucyB3aGVuIHRoZSBTVkdJbWFnZSBpcyBiZWluZyBkZXN0cm95ZWQK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTY0NAor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFdoZW4gYW4g U1ZHSW1hZ2UgaXMgZGVzdHJveWVkLCBoYXZpbmcgaXRzIFNWR0RvY3VtZW50IHBlcmZvcm0gc3R5 bGUgcmVjYWxjIGFuZCBkaXNwYXRjaGluZyBldmVudHMgaXMgbm90IG9ubHkKKyAgICAgICAgdXNl bGVzcyBidXQgY2FuIGFsc28gY2F1c2UgcHJvYmxlbXMsIHN1Y2ggYXMgcmUtZW50cmFuY3kgaW4g U3R5bGVSZXNvbHZlcjo6bG9hZFBlbmRpbmdSZXNvdXJjZXMuCisKKyAgICAgICAgTm8gbmV3IHRl c3RzIHJlcXVpcmVkLCBleGlzdGluZyB0ZXN0cyBjb3ZlciB0aGlzIGNoYW5nZS4KKworICAgICAg ICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpEb2N1bWVudDo6RG9jdW1l bnQpOgorICAgICAgICAqIGRvbS9Eb2N1bWVudC5oOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1l bnQ6OmlzQmVpbmdEZXN0cm95ZWQpOgorICAgICAgICAoV2ViQ29yZTo6RG9jdW1lbnQ6OnNldElz QmVpbmdEZXN0cm95ZWQpOgorICAgICAgICAqIGxvYWRlci9GcmFtZUxvYWRlci5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y2xvc2VVUkwpOgorICAgICAgICAqIHN2Zy9ncmFw aGljcy9TVkdJbWFnZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTVkdJbWFnZTo6flNWR0ltYWdl KToKKwogMjAxNC0xMi0xNiAgU2ViYXN0aWFuIERyw7ZnZSAgPHNlYmFzdGlhbkBjZW50cmljdWxh ci5jb20+CiAKICAgICAgICAgW0dTdHJlYW1lcl0gRml4IGRlYWRsb2NrIHdoZW4gc2h1dHRpbmcg ZG93biBBdWRpb0Rlc3RpbmF0aW9uCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcApp bmRleCA1ZTU3ZTk1Li5jYzk0MjBjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIv RnJhbWVMb2FkZXIuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5j cHAKQEAgLTUzOSwxMCArNTM5LDE4IEBAIHZvaWQgRnJhbWVMb2FkZXI6OndpbGxUcmFuc2l0aW9u VG9Db21taXR0ZWQoKQogYm9vbCBGcmFtZUxvYWRlcjo6Y2xvc2VVUkwoKQogewogICAgIGhpc3Rv cnkoKS5zYXZlRG9jdW1lbnRTdGF0ZSgpOwotICAgIAotICAgIC8vIFNob3VsZCBvbmx5IHNlbmQg dGhlIHBhZ2VoaWRlIGV2ZW50IGhlcmUgaWYgdGhlIGN1cnJlbnQgZG9jdW1lbnQgZXhpc3RzIGFu ZCBoYXMgbm90IGJlZW4gcGxhY2VkIGluIHRoZSBwYWdlIGNhY2hlLiAgICAKKwogICAgIERvY3Vt ZW50KiBjdXJyZW50RG9jdW1lbnQgPSBtX2ZyYW1lLmRvY3VtZW50KCk7Ci0gICAgc3RvcExvYWRp bmcoY3VycmVudERvY3VtZW50ICYmICFjdXJyZW50RG9jdW1lbnQtPmluUGFnZUNhY2hlKCkgPyBV bmxvYWRFdmVudFBvbGljeVVubG9hZEFuZFBhZ2VIaWRlIDogVW5sb2FkRXZlbnRQb2xpY3lVbmxv YWRPbmx5KTsKKyAgICBVbmxvYWRFdmVudFBvbGljeSB1bmxvYWRFdmVudFBvbGljeTsKKyAgICBp ZiAobV9mcmFtZS5wYWdlKCkgJiYgbV9mcmFtZS5wYWdlKCktPmNocm9tZSgpLmNsaWVudCgpLmlz U1ZHSW1hZ2VDaHJvbWVDbGllbnQoKSkgeworICAgICAgICAvLyBJZiB0aGlzIGlzIHRoZSBTVkdE b2N1bWVudCBvZiBhbiBTVkdJbWFnZSwgbm8gbmVlZCB0byBkaXNwYXRjaCBldmVudHMgb3IgcmVj YWxjU3R5bGUuCisgICAgICAgIHVubG9hZEV2ZW50UG9saWN5ID0gVW5sb2FkRXZlbnRQb2xpY3lO b25lOworICAgIH0gZWxzZSB7CisgICAgICAgIC8vIFNob3VsZCBvbmx5IHNlbmQgdGhlIHBhZ2Vo aWRlIGV2ZW50IGhlcmUgaWYgdGhlIGN1cnJlbnQgZG9jdW1lbnQgZXhpc3RzIGFuZCBoYXMgbm90 IGJlZW4gcGxhY2VkIGluIHRoZSBwYWdlIGNhY2hlLgorICAgICAgICB1bmxvYWRFdmVudFBvbGlj eSA9IGN1cnJlbnREb2N1bWVudCAmJiAhY3VycmVudERvY3VtZW50LT5pblBhZ2VDYWNoZSgpID8g VW5sb2FkRXZlbnRQb2xpY3lVbmxvYWRBbmRQYWdlSGlkZSA6IFVubG9hZEV2ZW50UG9saWN5VW5s b2FkT25seTsKKyAgICB9CisKKyAgICBzdG9wTG9hZGluZyh1bmxvYWRFdmVudFBvbGljeSk7CiAg ICAgCiAgICAgbV9mcmFtZS5lZGl0b3IoKS5jbGVhclVuZG9SZWRvT3BlcmF0aW9ucygpOwogICAg IHJldHVybiB0cnVlOwo=