139623 2014-12-13 10:39:26 -0800 Web Inspector: Empty attribute added to a DOM tree outline element should not add whitespace within the tag 2017-03-18 17:58:31 -0700 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 burg hi commit-queue graouts hi inspector-bugzilla-changes webkit-bug-importer oldest_to_newest 1055435 0 burg 2014-12-13 10:39:26 -0800 Steps to reproduce: 1. Click on a DOM element in the DOM tree with no attributes 2. <enter> to start editing 3. <enter> again to commit the edit This adds an empty attribute to the UI, even though the attribute is never added in the backend. If you instead add multiple spaces between steps 2 and 3, the edit is aborted and no extra space is added in the tag (presumably, this is because the backend rejected the change). This is similar to https://bugs.webkit.org/show_bug.cgi?id=111036. 1056442 1 webkit-bug-importer 2014-12-17 11:24:06 -0800 <rdar://problem/19281562> 1288898 2 304738 hi 2017-03-16 18:54:18 -0700 Created attachment 304738 Patch 1289327 3 304738 nvasilyev 2017-03-18 16:25:56 -0700 Comment on attachment 304738 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=304738&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeElement.js:984 > + if (!newText.trim().length) if (!newText.trim()) An empty string is already a falsy value. 1289339 4 304738 bburg 2017-03-18 17:07:23 -0700 Comment on attachment 304738 Patch r=me 1289341 5 304888 hi 2017-03-18 17:17:09 -0700 Created attachment 304888 Patch 1289347 6 304888 commit-queue 2017-03-18 17:58:23 -0700 Comment on attachment 304888 Patch Clearing flags on attachment: 304888 Committed r214141: <http://trac.webkit.org/changeset/214141> 1289348 7 commit-queue 2017-03-18 17:58:31 -0700 All reviewed patches have been landed. Closing bug. 304738 2017-03-16 18:54:18 -0700 2017-03-18 17:17:09 -0700 Patch bug-139623-20170316195417.patch text/plain 1553 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IGU3ZjNkYmI2MGNiYTcxYjc3OTE2ODdmOWY5NzBi MzhjM2MzMGNkYWEuLjQyOGYyMzQyNjUxY2U0M2JkZjJjMDI4YWZkMzlhNWRjZmI3N2I1YTIgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dl Ykluc3BlY3RvclVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTE2ICBEZXZp biBSb3Vzc28gIDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0 b3I6IEVtcHR5IGF0dHJpYnV0ZSBhZGRlZCB0byBhIERPTSB0cmVlIG91dGxpbmUgZWxlbWVudCBz aG91bGQgbm90IGFkZCB3aGl0ZXNwYWNlIHdpdGhpbiB0aGUgdGFnCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk2MjMKKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICAqIFVzZXJJbnRlcmZhY2UvVmlld3MvRE9N VHJlZUVsZW1lbnQuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQucHJv dG90eXBlLl9hdHRyaWJ1dGVFZGl0aW5nQ29tbWl0dGVkKToKKyAgICAgICAgSWYgdGhlIGBuZXdU ZXh0YCBhZnRlciBlZGl0aW5nIGhhcyBubyBjb250ZW50LCByZW1vdmUgdGhlIGVsZW1lbnQgZm9y IHRoYXQgYXR0cmlidXRlLgorCiAyMDE3LTAzLTE2ICBNYXR0IEJha2VyICA8bWF0dGJha2VyQGFw cGxlLmNvbT4KIAogICAgICAgICBXZWIgSW5zcGVjdG9yOiBSRUdSRVNTSU9OIChyMjEzNjkxKTog U2F2aW5nIERPTSBicmVha3BvaW50cyBicm9rZW4gYWZ0ZXIgcmVmYWN0b3JpbmcKZGlmZiAtLWdp dCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVt ZW50LmpzIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUVsZW1lbnQuanMKaW5kZXggMWJiOWY2MjY1MjVhYTlhODdhNmQ1NzQyODdkMjI1NzEwOGFjMmVi Ni4uNGJjYWRlZTZjZTZjYTAyZjZiM2Q2ZDc0ZjQ3ZDcwZmI2ZjUyY2QyNiAxMDA2NDQKLS0tIGEv U291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQu anMKKysrIGIvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJl ZUVsZW1lbnQuanMKQEAgLTk4MSw2ICs5ODEsOSBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1l bnQgPSBjbGFzcyBET01UcmVlRWxlbWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5UcmVlRWxlbQog ICAgIHsKICAgICAgICAgdGhpcy5fZWRpdGluZyA9IGZhbHNlOwogCisgICAgICAgIGlmICghbmV3 VGV4dC50cmltKCkubGVuZ3RoKQorICAgICAgICAgICAgZWxlbWVudC5yZW1vdmUoKTsKKwogICAg ICAgICBpZiAoIW1vdmVEaXJlY3Rpb24gJiYgbmV3VGV4dCA9PT0gb2xkVGV4dCkKICAgICAgICAg ICAgIHJldHVybjsKIAo= 304888 2017-03-18 17:17:09 -0700 2017-03-18 17:58:23 -0700 Patch 139623.diff text/plain 1411 hi ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDhiYzQ5ODIuLmYyNGY3NTUgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE0IEBACisyMDE3LTAzLTE4ICBEZXZpbiBSb3Vzc28g IDx3ZWJraXRAZGV2aW5yb3Vzc28uY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEVtcHR5 IGF0dHJpYnV0ZSBhZGRlZCB0byBhIERPTSB0cmVlIG91dGxpbmUgZWxlbWVudCBzaG91bGQgbm90 IGFkZCB3aGl0ZXNwYWNlIHdpdGhpbiB0aGUgdGFnCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk2MjMKKworICAgICAgICBSZXZpZXdlZCBieSBCcmlh biBCdXJnLgorCisgICAgICAgICogVXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlRWxlbWVudC5q czoKKyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlRWxlbWVudC5wcm90b3R5cGUuX2F0dHJp YnV0ZUVkaXRpbmdDb21taXR0ZWQpOgorICAgICAgICBJZiB0aGUgYG5ld1RleHRgIGFmdGVyIGVk aXRpbmcgaGFzIG5vIGNvbnRlbnQsIHJlbW92ZSB0aGUgZWxlbWVudCBmb3IgdGhhdCBhdHRyaWJ1 dGUuCisKIDIwMTctMDMtMTcgIERldmluIFJvdXNzbyAgPHdlYmtpdEBkZXZpbnJvdXNzby5jb20+ CiAKICAgICAgICAgV2ViIEluc3BlY3Rvcjogd3JvbmcgZmlsZW5hbWUgd2hlbiBzYXZpbmcgcmVz b3VyY2UgZnJvbSBSZXNvdXJjZUltYWdlQ29udGVudFZpZXcKZGlmZiAtLWdpdCBhL1NvdXJjZS9X ZWJJbnNwZWN0b3JVSS9Vc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVFbGVtZW50LmpzIGIvU291 cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMK aW5kZXggMWJiOWY2Mi4uZWEyZmE3MCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJ L1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKKysrIGIvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvRE9NVHJlZUVsZW1lbnQuanMKQEAgLTk4MSw2 ICs5ODEsOSBAQCBXZWJJbnNwZWN0b3IuRE9NVHJlZUVsZW1lbnQgPSBjbGFzcyBET01UcmVlRWxl bWVudCBleHRlbmRzIFdlYkluc3BlY3Rvci5UcmVlRWxlbQogICAgIHsKICAgICAgICAgdGhpcy5f ZWRpdGluZyA9IGZhbHNlOwogCisgICAgICAgIGlmICghbmV3VGV4dC50cmltKCkpCisgICAgICAg ICAgICBlbGVtZW50LnJlbW92ZSgpOworCiAgICAgICAgIGlmICghbW92ZURpcmVjdGlvbiAmJiBu ZXdUZXh0ID09PSBvbGRUZXh0KQogICAgICAgICAgICAgcmV0dXJuOwogCg==