139620 2014-12-13 02:11:56 -0800 [GTK] build fails with error: xgettext: Non-ASCII string at ../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:131. 2014-12-16 05:20:38 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 sun.shin webkit-unassigned berto cgarcia changseok commit-queue gustavo gyuyoung.kim mcatanzaro mrobinson oldest_to_newest 1055417 0 sun.shin 2014-12-13 02:11:56 -0800 [GTK] build fails with error: xgettext: Non-ASCII string at ../../../WebKit2/UIProcess/API/gtk/WebKitAuthenticationDialog.cpp:131. This error is came from r177161. 1055418 1 243254 sun.shin 2014-12-13 02:20:20 -0800 Created attachment 243254 Patch 1055419 2 commit-queue 2014-12-13 02:22:25 -0800 Thanks for the patch. If this patch contains new public API please make sure it follows the guidelines for new WebKit2 GTK+ API. See http://trac.webkit.org/wiki/WebKitGTK/AddingNewWebKit2API 1055595 3 243254 gustavo 2014-12-15 03:26:00 -0800 Comment on attachment 243254 Patch That doesn't cause issues to the build on the bots, nor for the developers or downstreams, could it be you have a very old version of xgettext, for instance? 1055599 4 sun.shin 2014-12-15 04:46:49 -0800 FYI, I am using following systems: OS: ubuntu 14.04 LTS gettext version: 0.18.3 LANG: en_US.UTF-8 When I try to update gettext version, the system says following: sudo apt-get install gettext Reading package lists... Done Building dependency tree Reading state information... Done gettext is already the newest version. The following packages were automatically installed and are no longer required: libasyncns0:i386 libatk-bridge2.0-0:i386 libatspi2.0-0:i386 libaudio2:i386 libcaca0:i386 libcairo-gobject2:i386 libcolord1:i386 libdbusmenu-gtk3-4:i386 libdevmapper1.02.1:i386 libdrm-intel1:i386 libdrm-nouveau2:i386 libdrm-radeon1:i386 libelf1:i386 libflac8:i386 libgl1-mesa-dri:i386 libgl1-mesa-glx:i386 libglapi-mesa:i386 libgtk-3-0:i386 liblcms2-2:i386 libllvm3.4:i386 libmysqlclient18:i386 libogg0:i386 libpciaccess0:i386 libpulse0:i386 libpython2.7:i386 libpython2.7-minimal:i386 libpython2.7-stdlib:i386 libqt4-declarative:i386 libqt4-network:i386 libqt4-opengl:i386 libqt4-script:i386 libqt4-sql:i386 libqt4-sql-mysql:i386 libqt4-xml:i386 libqt4-xmlpatterns:i386 libqtcore4:i386 libqtdbus4:i386 libqtgui4:i386 libreadline6:i386 libsdl1.2debian:i386 libsndfile1:i386 libtxc-dxtn-s2tc0:i386 libvorbis0a:i386 libvorbisenc2:i386 libwayland-client0:i386 libwayland-cursor0:i386 libwrap0:i386 libx11-xcb1:i386 libxcb-dri2-0:i386 libxcb-dri3-0:i386 libxcb-glx0:i386 libxcb-present0:i386 libxcb-sync1:i386 libxkbcommon0:i386 libxml2:i386 libxmu6:i386 libxshmfence1:i386 libxxf86vm1:i386 linux-image-generic mysql-common Use 'apt-get autoremove' to remove them. 0 upgraded, 0 newly installed, 0 to remove and 2 not upgrade So, I don't think it is a matter of gettext but a language configurations. More strangely, I has been compiling webkit-gtk quite a long time and found this error very recently. So, how about fix this problem at this time, even if it does not happens everywhere to prevent some other victims will loose their time. 1055600 5 cgarcia 2014-12-15 05:16:55 -0800 (In reply to comment #4) > FYI, I am using following systems: > OS: ubuntu 14.04 LTS > gettext version: 0.18.3 > LANG: en_US.UTF-8 > So, I don't think it is a matter of gettext but a language configurations. > More strangely, I has been compiling webkit-gtk quite a long time and found > this error very recently. > > So, how about fix this problem at this time, even if it does not happens > everywhere to prevent some other victims will loose their time. Yes, we should fix it, but removing the utf8 chars from translatable strings is not a solution but a workaround, because we should be able to use utf8. 1055601 6 243289 cgarcia 2014-12-15 05:17:42 -0800 Created attachment 243289 Patch Passing --from-code=UTF-8 to xgettext should work 1055605 7 sun.shin 2014-12-15 05:36:40 -0800 OK.. I agree with your approach. 1055606 8 cgarcia 2014-12-15 05:39:31 -0800 Committed r177277: <http://trac.webkit.org/changeset/177277> 1055965 9 mcatanzaro 2014-12-16 05:20:38 -0800 (In reply to comment #6) > Passing --from-code=UTF-8 to xgettext should work Yes, this was the correct fix. At some point that was already in my patch, but since it's been several months I don't know how it got lost; sorry. 243254 2014-12-13 02:20:20 -0800 2014-12-15 05:36:58 -0800 Patch bug-139620-20141213122105.patch text/plain 1883 sun.shin U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MjU2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggOTlmMDM4OGNhYTc3MDI4 ZWU3NzNmNGI1YTYxNGE0NTA4MzJiZTg1ZS4uYjJlZGM1YjgxNzZkZDU2MzFhYmFmYmRlNmVmOGIz ZTZmOWY3YzhiZiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEyLTEzICBCeXVu Z3Nlb24gU2hpbiAgPHN1bi5zaGluQGxnZS5jb20+CisKKyAgICAgICAgRml4IEdUSyBidWlsZCBl cnJvciBieSByZW1vdmluZyBub24tYXNjaWkgc3RyaW5nIGluIHdlYmtpdEF1dGhlbnRpY2F0aW9u RGlhbG9nSW5pdGlhbGl6ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MTM5NjIwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisK KyAgICAgICAgUmVwbGFjZSBhcmd1bWVudCBzdHJpbmcg4oCcJXPigJ0gdG8gJyVzJyBvZiBnX3N0 cmR1cF9wcmludGYuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9XZWJLaXRBdXRoZW50 aWNhdGlvbkRpYWxvZy5jcHA6CisgICAgICAgICh3ZWJraXRBdXRoZW50aWNhdGlvbkRpYWxvZ0lu aXRpYWxpemUpOgorCiAyMDE0LTEyLTEyICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xvdWdo QGFwcGxlLmNvbT4KIAogICAgICAgICBTcGxpdCBXZWJQYWdlUHJveHk6Om1fcHJldmVudFByb2Nl c3NTdXBwcmVzc2lvbiB0byB0cmFjayBwcmVmL3Zpc2liaWxpdHkgc2VwYXJhdGVseQpkaWZmIC0t Z2l0IGEvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0aGVudGljYXRp b25EaWFsb2cuY3BwIGIvU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0QXV0 aGVudGljYXRpb25EaWFsb2cuY3BwCmluZGV4IGFkZDdkMzJiNGM5ZjQ0ZWJmYzAwN2RjODQ4NjZi ZGUwYjZhNzMxZWMuLjYzNzJlOWQyNDJiZWQwNDdkYjcxMTcxZDQ5MWJhNTgwOTk0ZmYwMDkgMTAw NjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dGhlbnRp Y2F0aW9uRGlhbG9nLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRBdXRoZW50aWNhdGlvbkRpYWxvZy5jcHAKQEAgLTEyOCw3ICsxMjgsNyBAQCBzdGF0aWMg dm9pZCB3ZWJraXRBdXRoZW50aWNhdGlvbkRpYWxvZ0luaXRpYWxpemUoV2ViS2l0QXV0aGVudGlj YXRpb25EaWFsb2cqIGF1dAogICAgIFN0cmluZyByZWFsbSA9IGNoYWxsZW5nZS5wcm90ZWN0aW9u U3BhY2UoKS5yZWFsbSgpOwogICAgIGlmICghcmVhbG0uaXNFbXB0eSgpKSB7CiAgICAgICAgIC8v IExhYmVsIG9uIHRoZSBIVFRQIGF1dGhlbnRpY2F0aW9uIGRpYWxvZy4gJXMgaXMgYSAocHJvYmFi bHkgRW5nbGlzaCkgbWVzc2FnZSBmcm9tIHRoZSB3ZWJzaXRlLgotICAgICAgICBHVW5pcXVlUHRy PGNoYXI+IG1lc3NhZ2UoZ19zdHJkdXBfcHJpbnRmKF8oIlRoZSBzaXRlIHNheXM6IOKAnCVz4oCd IiksIHJlYWxtLnV0ZjgoKS5kYXRhKCkpKTsKKyAgICAgICAgR1VuaXF1ZVB0cjxjaGFyPiBtZXNz YWdlKGdfc3RyZHVwX3ByaW50ZihfKCJUaGUgc2l0ZSBzYXlzOiAnJXMnIiksIHJlYWxtLnV0Zjgo KS5kYXRhKCkpKTsKICAgICAgICAgbGFiZWwgPSBjcmVhdGVMYWJlbFdpdGhMaW5lV3JhcChtZXNz YWdlLmdldCgpKTsKICAgICAgICAgZ3RrX3dpZGdldF9zaG93KGxhYmVsKTsKICAgICAgICAgZ3Rr X2JveF9wYWNrX3N0YXJ0KEdUS19CT1goYXV0aEJveCksIGxhYmVsLCBGQUxTRSwgRkFMU0UsIDAp Owo= 243289 2014-12-15 05:17:42 -0800 2014-12-15 05:36:59 -0800 Patch wk-gettext-utf8.diff text/plain 1192 cgarcia ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DTWFrZUxpc3RzLnR4 dCBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DTWFrZUxpc3RzLnR4dAppbmRleCBi NTAwNWMyLi5lNDQ5MzRkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv cG8vQ01ha2VMaXN0cy50eHQKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL3BvL0NN YWtlTGlzdHMudHh0CkBAIC0yNSw2ICsyNSw3IEBAIGFkZF9jdXN0b21fY29tbWFuZCgKICAgICAg ICAgICAgIC0tcGFja2FnZS1uYW1lPSJ3ZWJraXRndGsiCiAgICAgICAgICAgICAtLWtleXdvcmQ9 XwogICAgICAgICAgICAgLS1rZXl3b3JkPU5fCisgICAgICAgICAgICAtLWZyb20tY29kZT1VVEYt OAogICAgICAgICAgICAgLW8gJHtwb3RfZmlsZX0KICAgICBXT1JLSU5HX0RJUkVDVE9SWSAke0NN QUtFX0NVUlJFTlRfU09VUkNFX0RJUn0vLi4KICkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3Jl L3BsYXRmb3JtL2d0ay9wby9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9ndGsv cG8vQ2hhbmdlTG9nCmluZGV4IGExZDNkOWYuLmViY2QxZTYgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL3BsYXRmb3JtL2d0ay9wby9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3RrL3BvL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEyIEBACisyMDE0LTEyLTE1ICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KKworICAgICAgICBbR1RLXSBi dWlsZCBmYWlscyB3aXRoIGVycm9yOiB4Z2V0dGV4dDogTm9uLUFTQ0lJIHN0cmluZyBhdCAuLi8u Li8uLi9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdEF1dGhlbnRpY2F0aW9uRGlhbG9n LmNwcDoxMzEuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9p ZD0xMzk2MjAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICAqIENNYWtlTGlzdHMudHh0OiBQYXNzIC0tZnJvbS1jb2RlPVVURi04IHRvIHhnZXR0ZXh0Lgor CiAyMDE0LTEyLTEyICBTaGFua2FyIFByYXNhZCAgPHN2ZW5rYXRlQHJlZGhhdC5jb20+CiAKICAg ICAgICAgW2tuXSBLYW5uYWRhIFRyYW5zbGF0aW9uIGZvciB3ZWJraXQgLSBVcGRhdGVkCg==