139610 2014-12-12 17:52:01 -0800 Web Inspector: CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty 2014-12-15 16:00:51 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 joepeck joepeck commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1055362 0 joepeck 2014-12-12 17:52:01 -0800 * SUMMARY CSSStyleDeclarationTextEditor fails to update if computed properties changed from empty to non-empty. No steps to reproduce, this requires a CSSAgent.getComputedStyleForNode to return an empty list, followed by a non-empty list later. However, that said, it seems this seems like a bug worth fixing now instead of later. 1055363 1 243237 joepeck 2014-12-12 17:54:41 -0800 Created attachment 243237 [PATCH] Proposed Fix 1055786 2 243237 commit-queue 2014-12-15 16:00:48 -0800 Comment on attachment 243237 [PATCH] Proposed Fix Clearing flags on attachment: 243237 Committed r177322: <http://trac.webkit.org/changeset/177322> 1055787 3 commit-queue 2014-12-15 16:00:51 -0800 All reviewed patches have been landed. Closing bug. 243237 2014-12-12 17:54:41 -0800 2014-12-15 16:00:48 -0800 [PATCH] Proposed Fix fix-computed.patch text/plain 1899 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDEzYzIyOTYxLi5hMGFjY2IwIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvQ2hhbmdlTG9nCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0 b3JVSS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOCBAQAorMjAxNC0xMi0xMiAgSm9zZXBoIFBlY29y YXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IENTU1N0 eWxlRGVjbGFyYXRpb25UZXh0RWRpdG9yIGZhaWxzIHRvIHVwZGF0ZSBpZiBjb21wdXRlZCBwcm9w ZXJ0aWVzIGNoYW5nZWQgZnJvbSBlbXB0eSB0byBub24tZW1wdHkKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTYxMAorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoZSBDU1NTdHlsZURlY2xhcmF0aW9uVGV4 dEVkaXRvciBmb3IgQ29tcHV0ZWQgU3R5bGUgUHJvcGVydGllcyBhbHdheXMgaGFzCisgICAgICAg IGVtcHR5IERPTU5vZGVTdHlsZXMgdGV4dC4gSG93ZXZlciB3ZSB3b3VsZCBub3QgcmVzZXQgY29u dGVudHMgaWYgcHJvcGVydGllcworICAgICAgICBjaGFuZ2VkIGFuZCB0aGUgYWN0dWFseSBjb250 ZW50IHdhcyBlbXB0eS4gU28gb25jZSBlbXB0eSwgd2UgY291bGQgbmV2ZXIKKyAgICAgICAgcmVj b3Zlci4gSW4gZmFjdCwgd2Ugc2hvdWxkIGFsd2F5cyByZWZyZXNoIGZvciBDb21wdXRlZCBTdHls ZXMuCisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0NTU1N0eWxlRGVjbGFyYXRpb25U ZXh0RWRpdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9yLkNTU1N0eWxlRGVjbGFyYXRpb25U ZXh0RWRpdG9yLnByb3RvdHlwZS5fcHJvcGVydGllc0NoYW5nZWQpOgorCiAyMDE0LTEyLTA4ICBK b3NlcGggUGVjb3Jhcm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CiAKICAgICAgICAgV2ViIEluc3Bl Y3RvcjogSGlkZSBDb21wb3NpdGluZyBCb3JkZXJzIEJ1dHRvbiBpZiBiYWNrZW5kIHJldHVybnMg YW4gZXJyb3IgdGhhdCBpdCBpcyB1bnN1cHBvcnRlZApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYklu c3BlY3RvclVJL1VzZXJJbnRlcmZhY2UvVmlld3MvQ1NTU3R5bGVEZWNsYXJhdGlvblRleHRFZGl0 b3IuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHls ZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwppbmRleCBhZGU3ZTAxLi4yMTI0N2FhIDEwMDY0NAot LS0gYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVyZmFjZS9WaWV3cy9DU1NTdHlsZURl Y2xhcmF0aW9uVGV4dEVkaXRvci5qcworKysgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlcklu dGVyZmFjZS9WaWV3cy9DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5qcwpAQCAtNzI2LDcg KzcyNiw3IEBAIFdlYkluc3BlY3Rvci5DU1NTdHlsZURlY2xhcmF0aW9uVGV4dEVkaXRvci5wcm90 b3R5cGUgPSB7CiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgLy8gUmVzZXQgdGhlIGNv bnRlbnQgaWYgdGhlIHRleHQgaXMgZGlmZmVyZW50IGFuZCB3ZSBhcmUgbm90IGZvY3VzZWQuCi0g ICAgICAgIGlmICghdGhpcy5mb2N1c2VkICYmIHRoaXMuX3N0eWxlLnRleHQgIT09IHRoaXMuX2Zv cm1hdHRlZENvbnRlbnQoKSkgeworICAgICAgICBpZiAoIXRoaXMuZm9jdXNlZCAmJiAoIXRoaXMu X3N0eWxlLnRleHQgfHwgdGhpcy5fc3R5bGUudGV4dCAhPT0gdGhpcy5fZm9ybWF0dGVkQ29udGVu dCgpKSkgewogICAgICAgICAgICAgdGhpcy5fcmVzZXRDb250ZW50KCk7CiAgICAgICAgICAgICBy ZXR1cm47CiAgICAgICAgIH0K