139585 2014-12-12 07:19:32 -0800 [EFL] MiniBrowser's window_create may return NULL 2014-12-13 01:22:21 -0800 1 1 1 Unclassified WebKit WebKit EFL 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 g.czajkowski g.czajkowski commit-queue gyuyoung.kim lucas.de.marchi ryuan.choi oldest_to_newest 1054831 0 g.czajkowski 2014-12-12 07:19:32 -0800 Cleanup. NULL checking here is a bit silly as it happens after using object which may be NULL. 1054832 1 243198 g.czajkowski 2014-12-12 07:22:23 -0800 Created attachment 243198 Patch 1055401 2 243198 gyuyoung.kim 2014-12-13 00:07:40 -0800 Comment on attachment 243198 Patch This patch seems to clear than before. LGTM 1055410 3 g.czajkowski 2014-12-13 00:48:13 -0800 (In reply to comment #2) > Comment on attachment 243198 [details] > Patch > > This patch seems to clear than before. LGTM Thanks Gyuyoung! 1055414 4 243198 commit-queue 2014-12-13 01:22:16 -0800 Comment on attachment 243198 Patch Clearing flags on attachment: 243198 Committed r177256: <http://trac.webkit.org/changeset/177256> 1055415 5 commit-queue 2014-12-13 01:22:21 -0800 All reviewed patches have been landed. Closing bug. 243198 2014-12-12 07:22:23 -0800 2014-12-13 01:22:16 -0800 Patch bug-139585-20141212162306.patch text/plain 1739 g.czajkowski U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MDU0CmRpZmYgLS1naXQgYS9Ub29scy9DaGFuZ2VMb2cg Yi9Ub29scy9DaGFuZ2VMb2cKaW5kZXggM2Y0OTU2YTk2ZmM2OWU3ZWI1MWZkODdiNTNmYTgxM2M0 YjgyYmI3NS4uNGViYWZkYTkzZjRlMGJlMDNjYWVhZGJkODFjOGMzYTE3M2E4MmU3ZSAxMDA2NDQK LS0tIGEvVG9vbHMvQ2hhbmdlTG9nCisrKyBiL1Rvb2xzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE2 IEBACisyMDE0LTEyLTEyICBHcnplZ29yeiBDemFqa293c2tpICA8Zy5jemFqa293c2tpQHNhbXN1 bmcuY29tPgorCisgICAgICAgIFtFRkxdIE1pbmlCcm93c2VyJ3Mgd2luZG93X2NyZWF0ZSBtYXkg cmV0dXJuIE5VTEwKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTEzOTU4NQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1vdmUgTlVMTCBjaGVja2luZyBiZWZvcmUgdXNpbmcgb2JqZWN0IHdoaWNoIHdpbmRvd19j cmVhdGUKKyAgICAgICAgcmV0dXJucy4KKworICAgICAgICAqIE1pbmlCcm93c2VyL2VmbC9tYWlu LmM6CisgICAgICAgIChlbG1fbWFpbik6CisKIDIwMTQtMTItMTAgIEdyemVnb3J6IEN6YWprb3dz a2kgIDxnLmN6YWprb3dza2lAc2Ftc3VuZy5jb20+CiAKICAgICAgICAgW0VGTF0gTWluaUJyb3dz ZXIgc3RlYWxzIHdlYiB2aWV3J3MgZm9jdXMKZGlmZiAtLWdpdCBhL1Rvb2xzL01pbmlCcm93c2Vy L2VmbC9tYWluLmMgYi9Ub29scy9NaW5pQnJvd3Nlci9lZmwvbWFpbi5jCmluZGV4IGFmZWEwYmIy MTIzMGMzZThiMzVmYWYxOTU2OWE4NjBjZTM0ZWEyY2IuLjM0MzExOWVmNWNiMTg5NmRkMTg0ZDBj M2QwMjNlYjhmZGI5MmM3M2UgMTAwNjQ0Ci0tLSBhL1Rvb2xzL01pbmlCcm93c2VyL2VmbC9tYWlu LmMKKysrIGIvVG9vbHMvTWluaUJyb3dzZXIvZWZsL21haW4uYwpAQCAtMjQ2MiwxOCArMjQ2Miwx NiBAQCBlbG1fbWFpbihpbnQgYXJnYywgY2hhciAqYXJndltdKQogICAgIGlmICh3aW5kb3dfc2l6 ZV9zdHJpbmcpCiAgICAgICAgIHBhcnNlX3dpbmRvd19zaXplKHdpbmRvd19zaXplX3N0cmluZywg JndpbmRvd193aWR0aCwgJndpbmRvd19oZWlnaHQpOwogCisgICAgd2luZG93ID0gd2luZG93X2Ny ZWF0ZShOVUxMLCAwLCAwKTsKKyAgICBpZiAoIXdpbmRvdykKKyAgICAgICAgcmV0dXJuIHF1aXQo RUlOQV9GQUxTRSwgIkVSUk9SOiBjb3VsZCBub3QgY3JlYXRlIGJyb3dzZXIgd2luZG93LlxuIik7 CisKICAgICBpZiAoYXJncyA8IGFyZ2MpIHsKICAgICAgICAgY2hhciAqdXJsID0gdXJsX2Zyb21f dXNlcl9pbnB1dChhcmd2W2FyZ3NdKTsKLSAgICAgICAgd2luZG93ID0gd2luZG93X2NyZWF0ZShO VUxMLCAwLCAwKTsKICAgICAgICAgZXdrX3ZpZXdfdXJsX3NldCh3aW5kb3ctPmV3a192aWV3LCB1 cmwpOwogICAgICAgICBmcmVlKHVybCk7Ci0gICAgfSBlbHNlIHsKLSAgICAgICAgd2luZG93ID0g d2luZG93X2NyZWF0ZShOVUxMLCAwLCAwKTsKKyAgICB9IGVsc2UKICAgICAgICAgZXdrX3ZpZXdf dXJsX3NldCh3aW5kb3ctPmV3a192aWV3LCBERUZBVUxUX1VSTCk7Ci0gICAgfQotCi0gICAgaWYg KCF3aW5kb3cpCi0gICAgICAgIHJldHVybiBxdWl0KEVJTkFfRkFMU0UsICJFUlJPUjogY291bGQg bm90IGNyZWF0ZSBicm93c2VyIHdpbmRvdy5cbiIpOwogCiAgICAgd2luZG93cyA9IGVpbmFfbGlz dF9hcHBlbmQod2luZG93cywgd2luZG93KTsKIAo=