139573 2014-12-11 18:17:56 -0800 Web Inspector: Crash when trying to inspect LocalStorage 2014-12-11 18:26:37 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED DoNotImportToRadar P2 Normal --- 1 joepeck joepeck andersca commit-queue graouts joepeck timothy webkit-bug-importer oldest_to_newest 1054728 0 joepeck 2014-12-11 18:17:56 -0800 * SUMMARY Crash trying to own LocalStorage view in Web Inspector. * STEPS TO REPRODUCE 1. Inspect a page like twitter.com 2. Click "Local Storage" in Resources navigation sidebar => CRASH * CRASH Exception Type: EXC_BAD_ACCESS (SIGSEGV) Exception Codes: KERN_INVALID_ADDRESS at 0x0000000000000000 Thread 0 Crashed:: Dispatch queue: com.apple.main-thread 0 com.apple.WebCore 0x00000001036c36dd WebCore::InspectorDOMStorageAgent::findStorageArea(WTF::String&, WTF::RefPtr<Inspector::InspectorObject> const&, WebCore::Frame*&) + 269 1 com.apple.WebCore 0x00000001036c3253 WebCore::InspectorDOMStorageAgent::getDOMStorageItems(WTF::String&, WTF::RefPtr<Inspector::InspectorObject> const&, WTF::RefPtr<Inspector::Protocol::Array<Inspector::Protocol::Array<WTF::String> > >&) + 51 2 com.apple.JavaScriptCore 0x0000000102c6b726 Inspector::InspectorDOMStorageBackendDispatcher::getDOMStorageItems(long, Inspector::InspectorObject const&) + 438 3 com.apple.JavaScriptCore 0x0000000102c6b29b Inspector::InspectorDOMStorageBackendDispatcher::dispatch(long, WTF::String const&, WTF::PassRefPtr<Inspector::InspectorObject>) + 139 4 com.apple.JavaScriptCore 0x0000000102c4f61b Inspector::InspectorBackendDispatcher::dispatch(WTF::String const&) + 1723 1054729 1 243171 joepeck 2014-12-11 18:19:18 -0800 Created attachment 243171 [PATCH] Proposed Fix 1054731 2 commit-queue 2014-12-11 18:21:59 -0800 Attachment 243171 did not pass style-queue: ERROR: Source/WebCore/inspector/InspectorDOMStorageAgent.cpp:205: Declaration has space between type name and * in Document *document [whitespace/declaration] [3] Total errors found: 1 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 1054733 3 243171 joepeck 2014-12-11 18:24:28 -0800 Comment on attachment 243171 [PATCH] Proposed Fix Style issue, I'll land manually. 1054734 4 joepeck 2014-12-11 18:26:37 -0800 http://trac.webkit.org/changeset/177202 243171 2014-12-11 18:19:18 -0800 2014-12-11 18:24:28 -0800 [PATCH] Proposed Fix storage.patch text/plain 2268 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJDb3JlL0No YW5nZUxvZwppbmRleCAwYjk4Mjk0Li5iZGI3Y2E2IDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29y ZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTYg QEAKKzIwMTQtMTItMTEgIEpvc2VwaCBQZWNvcmFybyAgPHBlY29yYXJvQGFwcGxlLmNvbT4KKwor ICAgICAgICBXZWIgSW5zcGVjdG9yOiBDcmFzaCB3aGVuIHRyeWluZyB0byBpbnNwZWN0IExvY2Fs U3RvcmFnZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM5NTczCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TW92ZSBhd2F5IGZyb20gUGFnZUdyb3VwOjpsb2NhbFN0b3JhZ2UgYW5kIGluc3RlYWQgdG8gU3Rv cmFnZU5hbWVzcGFjZVByb3ZpZGVyLgorICAgICAgICBUaGlzIG1hdGNoZXMgd2hhdCBET01XaW5k b3c6OmxvY2FsU3RvcmFnZSBkb2VzIHRvIGdldCB0aGUgU3RvcmFnZUFyZWEgZm9yIGEgZG9jdW1l bnQuCisKKyAgICAgICAgKiBpbnNwZWN0b3IvSW5zcGVjdG9yRE9NU3RvcmFnZUFnZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6Okluc3BlY3RvckRPTVN0b3JhZ2VBZ2VudDo6ZmluZFN0b3JhZ2VB cmVhKToKKwogMjAxNC0xMi0xMSAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29t PgogCiAgICAgICAgIENhbGwgU3RvcmFnZVRocmVhZDo6cmVsZWFzZUZhc3RNYWxsb2NGcmVlTWVt b3J5SW5BbGxUaHJlYWRzIGZyb20gV2ViS2l0CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9p bnNwZWN0b3IvSW5zcGVjdG9yRE9NU3RvcmFnZUFnZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL2lu c3BlY3Rvci9JbnNwZWN0b3JET01TdG9yYWdlQWdlbnQuY3BwCmluZGV4IDllMGNlMTEuLjkyY2Yx OWIgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01TdG9y YWdlQWdlbnQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL2luc3BlY3Rvci9JbnNwZWN0b3JET01T dG9yYWdlQWdlbnQuY3BwCkBAIC00Niw2ICs0Niw3IEBACiAjaW5jbHVkZSAiU2VjdXJpdHlPcmln aW4uaCIKICNpbmNsdWRlICJTdG9yYWdlLmgiCiAjaW5jbHVkZSAiU3RvcmFnZU5hbWVzcGFjZS5o IgorI2luY2x1ZGUgIlN0b3JhZ2VOYW1lc3BhY2VQcm92aWRlci5oIgogI2luY2x1ZGUgIlZvaWRD YWxsYmFjay5oIgogI2luY2x1ZGUgPGluc3BlY3Rvci9JbnNwZWN0b3JGcm9udGVuZERpc3BhdGNo ZXJzLmg+CiAjaW5jbHVkZSA8aW5zcGVjdG9yL0luc3BlY3RvclZhbHVlcy5oPgpAQCAtMjAxLDkg KzIwMiwxMyBAQCBQYXNzUmVmUHRyPFN0b3JhZ2VBcmVhPiBJbnNwZWN0b3JET01TdG9yYWdlQWdl bnQ6OmZpbmRTdG9yYWdlQXJlYShFcnJvclN0cmluZyYgZQogICAgIH0KIAogICAgIFBhZ2UqIHBh Z2UgPSBtX3BhZ2VBZ2VudC0+cGFnZSgpOwotICAgIGlmIChpc0xvY2FsU3RvcmFnZSkKLSAgICAg ICAgcmV0dXJuIHBhZ2UtPmdyb3VwKCkubG9jYWxTdG9yYWdlKCktPnN0b3JhZ2VBcmVhKHRhcmdl dEZyYW1lLT5kb2N1bWVudCgpLT5zZWN1cml0eU9yaWdpbigpKTsKLSAgICByZXR1cm4gcGFnZS0+ c2Vzc2lvblN0b3JhZ2UoKS0+c3RvcmFnZUFyZWEodGFyZ2V0RnJhbWUtPmRvY3VtZW50KCktPnNl Y3VyaXR5T3JpZ2luKCkpOworICAgIERvY3VtZW50ICpkb2N1bWVudCA9IHRhcmdldEZyYW1lLT5k b2N1bWVudCgpOworICAgIGlmIChpc0xvY2FsU3RvcmFnZSkgeworICAgICAgICBpZiAoZG9jdW1l bnQtPnNlY3VyaXR5T3JpZ2luKCktPmNhbkFjY2Vzc0xvY2FsU3RvcmFnZShkb2N1bWVudC0+dG9w T3JpZ2luKCkpKQorICAgICAgICAgICAgcmV0dXJuIHBhZ2UtPnN0b3JhZ2VOYW1lc3BhY2VQcm92 aWRlcigpLmxvY2FsU3RvcmFnZU5hbWVzcGFjZSgpLnN0b3JhZ2VBcmVhKGRvY3VtZW50LT5zZWN1 cml0eU9yaWdpbigpKTsKKyAgICAgICAgcmV0dXJuIHBhZ2UtPnN0b3JhZ2VOYW1lc3BhY2VQcm92 aWRlcigpLnRyYW5zaWVudExvY2FsU3RvcmFnZU5hbWVzcGFjZSgqZG9jdW1lbnQtPnRvcE9yaWdp bigpKS5zdG9yYWdlQXJlYShkb2N1bWVudC0+c2VjdXJpdHlPcmlnaW4oKSk7CisgICAgfQorICAg IHJldHVybiBwYWdlLT5zZXNzaW9uU3RvcmFnZSgpLT5zdG9yYWdlQXJlYShkb2N1bWVudC0+c2Vj dXJpdHlPcmlnaW4oKSk7CiB9CiAKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUK