139561 2014-12-11 14:39:18 -0800 REGRESSION(r160182): Fragment parser doesn't close a form element with a close tag 2014-12-14 02:58:21 -0800 1 1 1 Unclassified WebKit DOM 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar, Regression P2 Normal --- 1 rniwa rniwa ap benjamin commit-queue darin esprehn+autocc gyuyoung.kim kling koivisto m.goleb+bugzilla shawnjan oldest_to_newest 1054621 0 rniwa 2014-12-11 14:39:18 -0800 http://trac.webkit.org/r160182 caused a regression in which a form element starts with <form> but doesn't get closed with </form>. 1054622 1 rniwa 2014-12-11 14:39:35 -0800 rdar://problem/18525239 1054623 2 rniwa 2014-12-11 14:39:42 -0800 <rdar://problem/18525239> 1054633 3 243152 rniwa 2014-12-11 15:05:10 -0800 Created attachment 243152 Fixes the bug 1054634 4 243153 rniwa 2014-12-11 15:07:19 -0800 Created attachment 243153 Reverted the scheme changes 1054667 5 benjamin 2014-12-11 16:04:28 -0800 *** Bug 137337 has been marked as a duplicate of this bug. *** 1055378 6 243153 darin 2014-12-12 19:53:28 -0800 Comment on attachment 243153 Reverted the scheme changes View in context: https://bugs.webkit.org/attachment.cgi?id=243153&action=review > Source/WebCore/html/parser/HTMLConstructionSite.cpp:462 > + m_form = static_pointer_cast<HTMLFormElement>(element.release()); Can we use to<HTMLFormElement> instead? 1055380 7 243153 cdumez 2014-12-12 19:59:00 -0800 Comment on attachment 243153 Reverted the scheme changes View in context: https://bugs.webkit.org/attachment.cgi?id=243153&action=review >> Source/WebCore/html/parser/HTMLConstructionSite.cpp:462 >> + m_form = static_pointer_cast<HTMLFormElement>(element.release()); > > Can we use to<HTMLFormElement> instead? We ended up calling it downcast<> :) And if we use downcast, then we can get rid of the assertion above. 1055462 8 243153 darin 2014-12-13 18:57:09 -0800 Comment on attachment 243153 Reverted the scheme changes View in context: https://bugs.webkit.org/attachment.cgi?id=243153&action=review >>> Source/WebCore/html/parser/HTMLConstructionSite.cpp:462 >>> + m_form = static_pointer_cast<HTMLFormElement>(element.release()); >> >> Can we use to<HTMLFormElement> instead? > > We ended up calling it downcast<> :) > > And if we use downcast, then we can get rid of the assertion above. That’s funny, I can’t believe I forgot it was named downcast. Yes, we should use downcast here! 1055475 9 rniwa 2014-12-13 23:14:31 -0800 (In reply to comment #8) > Comment on attachment 243153 [details] > Reverted the scheme changes > > View in context: > https://bugs.webkit.org/attachment.cgi?id=243153&action=review > > >>> Source/WebCore/html/parser/HTMLConstructionSite.cpp:462 > >>> + m_form = static_pointer_cast<HTMLFormElement>(element.release()); > >> > >> Can we use to<HTMLFormElement> instead? > > > > We ended up calling it downcast<> :) > > > > And if we use downcast, then we can get rid of the assertion above. > > That’s funny, I can’t believe I forgot it was named downcast. Yes, we should > use downcast here! How do I use downcast here given element is a PassRefPtr? 1055483 10 243153 cdumez 2014-12-14 00:44:17 -0800 Comment on attachment 243153 Reverted the scheme changes View in context: https://bugs.webkit.org/attachment.cgi?id=243153&action=review >>>>> Source/WebCore/html/parser/HTMLConstructionSite.cpp:462 >>>>> + m_form = static_pointer_cast<HTMLFormElement>(element.release()); >>>> >>>> Can we use to<HTMLFormElement> instead? >>> >>> We ended up calling it downcast<> :) >>> >>> And if we use downcast, then we can get rid of the assertion above. >> >> That’s funny, I can’t believe I forgot it was named downcast. Yes, we should use downcast here! > > How do I use downcast here given element is a PassRefPtr? downcast<>() doesn't yet know of smart pointers. So right now, you would have to do: m_form = downcast<HTMLFormElement>(element.get()); Sadly this causes some ref-counting churn. 1055484 11 243153 cdumez 2014-12-14 00:54:13 -0800 Comment on attachment 243153 Reverted the scheme changes View in context: https://bugs.webkit.org/attachment.cgi?id=243153&action=review >>>>>> Source/WebCore/html/parser/HTMLConstructionSite.cpp:462 >>>>>> + m_form = static_pointer_cast<HTMLFormElement>(element.release()); >>>>> >>>>> Can we use to<HTMLFormElement> instead? >>>> >>>> We ended up calling it downcast<> :) >>>> >>>> And if we use downcast, then we can get rid of the assertion above. >>> >>> That’s funny, I can’t believe I forgot it was named downcast. Yes, we should use downcast here! >> >> How do I use downcast here given element is a PassRefPtr? > > downcast<>() doesn't yet know of smart pointers. So right now, you would have to do: > m_form = downcast<HTMLFormElement>(element.get()); > > Sadly this causes some ref-counting churn. The equivalent to static_pointer_cast<>() using downcast<>() right now would be: m_form = adoptRef(downcast<HTMLFormElement>(element.leakRef())); However, this isn't terribly readable. 1055485 12 243153 rniwa 2014-12-14 02:24:35 -0800 Comment on attachment 243153 Reverted the scheme changes I'm gonna commit this as is. We can't fix static_pointer_cast later when we support downcast for PassRefPtr. 1055487 13 243153 commit-queue 2014-12-14 02:58:15 -0800 Comment on attachment 243153 Reverted the scheme changes Clearing flags on attachment: 243153 Committed r177263: <http://trac.webkit.org/changeset/177263> 1055488 14 commit-queue 2014-12-14 02:58:21 -0800 All reviewed patches have been landed. Closing bug. 243152 2014-12-11 15:05:10 -0800 2014-12-11 15:07:13 -0800 Fixes the bug bug-139561-20141211150553.patch text/plain 6511 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzE4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIxIEBACisyMDE0LTEyLTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2MDE4Mik6 IEZyYWdtZW50IHBhcnNlciBkb2Vzbid0IGNsb3NlIGEgZm9ybSBlbGVtZW50IHdpdGggYSBjbG9z ZSB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz OTU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBidWcgd2FzIGNhdXNlZCBieSB1cyBub3Qgc2V0dGluZyB0aGUgZm9ybSBwb2ludGVyIGluIGlu c2VydEhUTUxGb3JtRWxlbWVudC4KKyAgICAgICAgU2luY2Ugd2UgYWxyZWFkeSBhdm9pZCBhc3Nv Y2lhdGluZyBhIGZvcm0gaW5zaWRlIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpjcmVhdGVIVE1MRWxl bWVudCwKKyAgICAgICAgd2UgZGlkbid0IG5lZWQgdGhpcyBjb2RlIGF0IGFsbC4KKworICAgICAg ICBUZXN0OiBmYXN0L2RvbS9kb20tcGFyc2UtY2xvc2UtZm9ybS5odG1sCisKKyAgICAgICAgKiBo dG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpI VE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0SFRNTEZvcm1FbGVtZW50KToKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlOjppbnNpZGVUZW1wbGF0ZUVsZW1lbnQpOiBEZWxl dGVkLgorICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmg6CisKIDIw MTQtMTItMTEgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAg ICAgICAgIEZpeCB0aGUgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCShyZXZpc2lvbiAxNzcwOTgpCisrKyBT b3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQ1OSwxMiArNDU5LDEwIEBAIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6 Omluc2VydEhUTUxGb3IKIHsKICAgICBSZWZQdHI8RWxlbWVudD4gZWxlbWVudCA9IGNyZWF0ZUhU TUxFbGVtZW50KHRva2VuKTsKICAgICBBU1NFUlQoaXM8SFRNTEZvcm1FbGVtZW50PigqZWxlbWVu dCkpOwotICAgIFJlZlB0cjxIVE1MRm9ybUVsZW1lbnQ+IGZvcm0gPSBzdGF0aWNfcG9pbnRlcl9j YXN0PEhUTUxGb3JtRWxlbWVudD4oZWxlbWVudC5yZWxlYXNlKCkpOwotICAgIGlmICghaW5zaWRl VGVtcGxhdGVFbGVtZW50KCkpCi0gICAgICAgIG1fZm9ybSA9IGZvcm07Ci0gICAgZm9ybS0+c2V0 RGVtb3RlZChpc0RlbW90ZWQpOwotICAgIGF0dGFjaExhdGVyKGN1cnJlbnROb2RlKCksIGZvcm0p OwotICAgIG1fb3BlbkVsZW1lbnRzLnB1c2goSFRNTFN0YWNrSXRlbTo6Y3JlYXRlKGZvcm0ucmVs ZWFzZSgpLCB0b2tlbikpOworICAgIG1fZm9ybSA9IHN0YXRpY19wb2ludGVyX2Nhc3Q8SFRNTEZv cm1FbGVtZW50PihlbGVtZW50LnJlbGVhc2UoKSk7CisgICAgbV9mb3JtLT5zZXREZW1vdGVkKGlz RGVtb3RlZCk7CisgICAgYXR0YWNoTGF0ZXIoY3VycmVudE5vZGUoKSwgbV9mb3JtKTsKKyAgICBt X29wZW5FbGVtZW50cy5wdXNoKEhUTUxTdGFja0l0ZW06OmNyZWF0ZShtX2Zvcm0sIHRva2VuKSk7 CiB9CiAKIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2VydEhUTUxFbGVtZW50KEF0b21p Y0hUTUxUb2tlbiogdG9rZW4pCkBAIC02MjQsMTEgKzYyMiw2IEBAIGlubGluZSBEb2N1bWVudCYg SFRNTENvbnN0cnVjdGlvblNpdGU6Om8KICAgICByZXR1cm4gY3VycmVudE5vZGUoKS0+ZG9jdW1l bnQoKTsKIH0KIAotaW5saW5lIGJvb2wgSFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2lkZVRlbXBs YXRlRWxlbWVudCgpCi17Ci0gICAgcmV0dXJuICFvd25lckRvY3VtZW50Rm9yQ3VycmVudE5vZGUo KS5mcmFtZSgpOwotfQotCiBQYXNzUmVmUHRyPEVsZW1lbnQ+IEhUTUxDb25zdHJ1Y3Rpb25TaXRl OjpjcmVhdGVIVE1MRWxlbWVudChBdG9taWNIVE1MVG9rZW4qIHRva2VuKQogewogICAgIFF1YWxp ZmllZE5hbWUgdGFnTmFtZShudWxsQXRvbSwgdG9rZW4tPm5hbWUoKSwgeGh0bWxOYW1lc3BhY2VV UkkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNp dGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3Ry dWN0aW9uU2l0ZS5oCShyZXZpc2lvbiAxNzcwOTgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3Bh cnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQsNyArMTQ0 LDYgQEAgcHVibGljOgogICAgIEhUTUxTdGFja0l0ZW0qIGN1cnJlbnRTdGFja0l0ZW0oKSBjb25z dCB7IHJldHVybiBtX29wZW5FbGVtZW50cy50b3BTdGFja0l0ZW0oKTsgfQogICAgIEhUTUxTdGFj a0l0ZW0qIG9uZUJlbG93VG9wKCkgY29uc3QgeyByZXR1cm4gbV9vcGVuRWxlbWVudHMub25lQmVs b3dUb3AoKTsgfQogICAgIERvY3VtZW50JiBvd25lckRvY3VtZW50Rm9yQ3VycmVudE5vZGUoKTsK LSAgICBib29sIGluc2lkZVRlbXBsYXRlRWxlbWVudCgpOwogICAgIEhUTUxFbGVtZW50U3RhY2sq IG9wZW5FbGVtZW50cygpIGNvbnN0IHsgcmV0dXJuICZtX29wZW5FbGVtZW50czsgfQogICAgIEhU TUxGb3JtYXR0aW5nRWxlbWVudExpc3QqIGFjdGl2ZUZvcm1hdHRpbmdFbGVtZW50cygpIGNvbnN0 IHsgcmV0dXJuICZtX2FjdGl2ZUZvcm1hdHRpbmdFbGVtZW50czsgfQogICAgIGJvb2wgY3VycmVu dElzUm9vdE5vZGUoKSB7IHJldHVybiBtX29wZW5FbGVtZW50cy50b3BOb2RlKCkgPT0gbV9vcGVu RWxlbWVudHMucm9vdE5vZGUoKTsgfQpJbmRleDogV2ViS2l0Lnhjd29ya3NwYWNlL3hjc2hhcmVk ZGF0YS94Y3NjaGVtZXMvQWxsIFNvdXJjZSAodGFyZ2V0IFdlYlByb2Nlc3MpLnhjc2NoZW1lCj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdC54Y3dvcmtzcGFjZS94Y3NoYXJlZGRhdGEveGNzY2hlbWVzL0Fs bCBTb3VyY2UgKHRhcmdldCBXZWJQcm9jZXNzKS54Y3NjaGVtZQkocmV2aXNpb24gMTc3MDk4KQor KysgV2ViS2l0Lnhjd29ya3NwYWNlL3hjc2hhcmVkZGF0YS94Y3NjaGVtZXMvQWxsIFNvdXJjZSAo dGFyZ2V0IFdlYlByb2Nlc3MpLnhjc2NoZW1lCSh3b3JraW5nIGNvcHkpCkBAIC0zLDcgKzMsOCBA QAogICAgdmVyc2lvbiA9ICIxLjciPgogICAgPEJ1aWxkQWN0aW9uCiAgICAgICBwYXJhbGxlbGl6 ZUJ1aWxkYWJsZXMgPSAiTk8iCi0gICAgICBidWlsZEltcGxpY2l0RGVwZW5kZW5jaWVzID0gIllF UyI+CisgICAgICBidWlsZEltcGxpY2l0RGVwZW5kZW5jaWVzID0gIllFUyIKKyAgICAgIGVuYWJs ZUFkZHJlc3NTYW5pdGl6ZXIgPSAiTk8iPgogICAgICAgPFByZUFjdGlvbnM+CiAgICAgICAgICA8 RXhlY3V0aW9uQWN0aW9uCiAgICAgICAgICAgICBBY3Rpb25UeXBlID0gIlhjb2RlLklERVN0YW5k YXJkRXhlY3V0aW9uQWN0aW9uc0NvcmUuRXhlY3V0aW9uQWN0aW9uVHlwZS5TaGVsbFNjcmlwdEFj dGlvbiI+CkBAIC0xNjIsOCArMTYzLDEwIEBACiAgICAgICBidWlsZENvbmZpZ3VyYXRpb24gPSAi RGVidWciCiAgICAgICBpZ25vcmVzUGVyc2lzdGVudFN0YXRlT25MYXVuY2ggPSAiTk8iCiAgICAg ICBkZWJ1Z0RvY3VtZW50VmVyc2lvbmluZyA9ICJZRVMiCisgICAgICBkZWJ1Z1NlcnZpY2VFeHRl bnNpb24gPSAiaW50ZXJuYWwiCiAgICAgICBhbGxvd0xvY2F0aW9uU2ltdWxhdGlvbiA9ICJZRVMi PgotICAgICAgPEJ1aWxkYWJsZVByb2R1Y3RSdW5uYWJsZT4KKyAgICAgIDxCdWlsZGFibGVQcm9k dWN0UnVubmFibGUKKyAgICAgICAgIHJ1bm5hYmxlRGVidWdnaW5nTW9kZSA9ICIwIj4KICAgICAg ICAgIDxCdWlsZGFibGVSZWZlcmVuY2UKICAgICAgICAgICAgIEJ1aWxkYWJsZUlkZW50aWZpZXIg PSAicHJpbWFyeSIKICAgICAgICAgICAgIEJsdWVwcmludElkZW50aWZpZXIgPSAiMUE1MERCMUQx MTBBM0JEQzAwMEQzRkU1IgpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTc3MTg0KQorKysgTGF5b3V0VGVz dHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMTItMTEg IFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVTU0lPTihy MTYwMTgyKTogRnJhZ21lbnQgcGFyc2VyIGRvZXNuJ3QgY2xvc2UgYSBmb3JtIGVsZW1lbnQgd2l0 aCBhIGNsb3NlIHRhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5j Z2k/aWQ9MTM5NTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAg ICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QuCisKKyAgICAgICAgKiBmYXN0L2RvbS9kb20t cGFyc2UtY2xvc2UtZm9ybS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvZG9t L2RvbS1wYXJzZS1jbG9zZS1mb3JtLmh0bWw6IEFkZGVkLgorCiAyMDE0LTEyLTExICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGZhc3Qvd29ya2Vycy93b3Jr ZXItY29uc3RydWN0b3IuaHRtbCBmcmVxdWVudGx5IGNyYXNoZXMKSW5kZXg6IExheW91dFRlc3Rz L2Zhc3QvZG9tL2RvbS1wYXJzZS1jbG9zZS1mb3JtLWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb20tcGFyc2UtY2xvc2UtZm9ybS1leHBlY3RlZC50eHQJ KHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb20tcGFyc2UtY2xvc2UtZm9y bS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorVGhpcyB0ZXN0 cyB0aGF0IERPTVBhcnNlciBjbG9zZXMgYSBmb3JtIGVsZW1lbnQgd2hlbiBpdCBzZWVzIGl0cyBj bG9zZSB0YWcuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIg bWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIChuZXcgRE9N UGFyc2VyKCkpLnBhcnNlRnJvbVN0cmluZygiPGZvcm0+PC9mb3JtPnRleHQiLCAidGV4dC9odG1s IikuYm9keS5pbm5lckhUTUwgaXMgIjxmb3JtPjwvZm9ybT50ZXh0IgorUEFTUyBzdWNjZXNzZnVs bHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3RzL2Zh c3QvZG9tL2RvbS1wYXJzZS1jbG9zZS1mb3JtLmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVz dHMvZmFzdC9kb20vZG9tLXBhcnNlLWNsb3NlLWZvcm0uaHRtbAkocmV2aXNpb24gMCkKKysrIExh eW91dFRlc3RzL2Zhc3QvZG9tL2RvbS1wYXJzZS1jbG9zZS1mb3JtLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTAsMCArMSwxNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5PgorPHNj cmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+Cis8c2Ny aXB0PgorCitkZXNjcmlwdGlvbignVGhpcyB0ZXN0cyB0aGF0IERPTVBhcnNlciBjbG9zZXMgYSBm b3JtIGVsZW1lbnQgd2hlbiBpdCBzZWVzIGl0cyBjbG9zZSB0YWcuJyk7CisKK3Nob3VsZEJlRXF1 YWxUb1N0cmluZygnKG5ldyBET01QYXJzZXIoKSkucGFyc2VGcm9tU3RyaW5nKCI8Zm9ybT48L2Zv cm0+dGV4dCIsICJ0ZXh0L2h0bWwiKS5ib2R5LmlubmVySFRNTCcsICc8Zm9ybT48L2Zvcm0+dGV4 dCcpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+Cis8c2Ny aXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2Jv ZHk+Cis8L2h0bWw+Cg== 243153 2014-12-11 15:07:19 -0800 2014-12-14 02:58:15 -0800 Reverted the scheme changes bug-139561-20141211150802.patch text/plain 5377 rniwa SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzE4NCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDIzIEBACisyMDE0LTEyLTExICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgorCisgICAgICAgIFJFR1JFU1NJT04ocjE2MDE4Mik6 IEZyYWdtZW50IHBhcnNlciBkb2Vzbid0IGNsb3NlIGEgZm9ybSBlbGVtZW50IHdpdGggYSBjbG9z ZSB0YWcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEz OTU2MQorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRo ZSBidWcgd2FzIGNhdXNlZCBieSB1cyBub3Qgc2V0dGluZyB0aGUgZm9ybSBwb2ludGVyIGluIGlu c2VydEhUTUxGb3JtRWxlbWVudC4KKyAgICAgICAgU2luY2Ugd2UgYWxyZWFkeSBhdm9pZCBhc3Nv Y2lhdGluZyBhIGZvcm0gaW5zaWRlIEhUTUxDb25zdHJ1Y3Rpb25TaXRlOjpjcmVhdGVIVE1MRWxl bWVudCwKKyAgICAgICAgd2UgZGlkbid0IG5lZWQgdGhpcyBjb2RlIGF0IGFsbC4KKworICAgICAg ICBGaXhlZCB0aGUgYnVnIGJ5IHBhcnRpYWxseSByZXZlcnRpbmcgcjE2MDE4Mi4KKworICAgICAg ICBUZXN0OiBmYXN0L2RvbS9kb20tcGFyc2UtY2xvc2UtZm9ybS5odG1sCisKKyAgICAgICAgKiBo dG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpI VE1MQ29uc3RydWN0aW9uU2l0ZTo6aW5zZXJ0SFRNTEZvcm1FbGVtZW50KToKKyAgICAgICAgKFdl YkNvcmU6OkhUTUxDb25zdHJ1Y3Rpb25TaXRlOjppbnNpZGVUZW1wbGF0ZUVsZW1lbnQpOiBEZWxl dGVkLgorICAgICAgICAqIGh0bWwvcGFyc2VyL0hUTUxDb25zdHJ1Y3Rpb25TaXRlLmg6CisKIDIw MTQtMTItMTEgIFRpbW90aHkgSG9ydG9uICA8dGltb3RoeV9ob3J0b25AYXBwbGUuY29tPgogCiAg ICAgICAgIEZpeCB0aGUgYnVpbGQuCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9I VE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYkNvcmUvaHRt bC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNpdGUuY3BwCShyZXZpc2lvbiAxNzcwOTgpCisrKyBT b3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5jcHAJKHdvcmtp bmcgY29weSkKQEAgLTQ1OSwxMiArNDU5LDEwIEBAIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6 Omluc2VydEhUTUxGb3IKIHsKICAgICBSZWZQdHI8RWxlbWVudD4gZWxlbWVudCA9IGNyZWF0ZUhU TUxFbGVtZW50KHRva2VuKTsKICAgICBBU1NFUlQoaXM8SFRNTEZvcm1FbGVtZW50PigqZWxlbWVu dCkpOwotICAgIFJlZlB0cjxIVE1MRm9ybUVsZW1lbnQ+IGZvcm0gPSBzdGF0aWNfcG9pbnRlcl9j YXN0PEhUTUxGb3JtRWxlbWVudD4oZWxlbWVudC5yZWxlYXNlKCkpOwotICAgIGlmICghaW5zaWRl VGVtcGxhdGVFbGVtZW50KCkpCi0gICAgICAgIG1fZm9ybSA9IGZvcm07Ci0gICAgZm9ybS0+c2V0 RGVtb3RlZChpc0RlbW90ZWQpOwotICAgIGF0dGFjaExhdGVyKGN1cnJlbnROb2RlKCksIGZvcm0p OwotICAgIG1fb3BlbkVsZW1lbnRzLnB1c2goSFRNTFN0YWNrSXRlbTo6Y3JlYXRlKGZvcm0ucmVs ZWFzZSgpLCB0b2tlbikpOworICAgIG1fZm9ybSA9IHN0YXRpY19wb2ludGVyX2Nhc3Q8SFRNTEZv cm1FbGVtZW50PihlbGVtZW50LnJlbGVhc2UoKSk7CisgICAgbV9mb3JtLT5zZXREZW1vdGVkKGlz RGVtb3RlZCk7CisgICAgYXR0YWNoTGF0ZXIoY3VycmVudE5vZGUoKSwgbV9mb3JtKTsKKyAgICBt X29wZW5FbGVtZW50cy5wdXNoKEhUTUxTdGFja0l0ZW06OmNyZWF0ZShtX2Zvcm0sIHRva2VuKSk7 CiB9CiAKIHZvaWQgSFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2VydEhUTUxFbGVtZW50KEF0b21p Y0hUTUxUb2tlbiogdG9rZW4pCkBAIC02MjQsMTEgKzYyMiw2IEBAIGlubGluZSBEb2N1bWVudCYg SFRNTENvbnN0cnVjdGlvblNpdGU6Om8KICAgICByZXR1cm4gY3VycmVudE5vZGUoKS0+ZG9jdW1l bnQoKTsKIH0KIAotaW5saW5lIGJvb2wgSFRNTENvbnN0cnVjdGlvblNpdGU6Omluc2lkZVRlbXBs YXRlRWxlbWVudCgpCi17Ci0gICAgcmV0dXJuICFvd25lckRvY3VtZW50Rm9yQ3VycmVudE5vZGUo KS5mcmFtZSgpOwotfQotCiBQYXNzUmVmUHRyPEVsZW1lbnQ+IEhUTUxDb25zdHJ1Y3Rpb25TaXRl OjpjcmVhdGVIVE1MRWxlbWVudChBdG9taWNIVE1MVG9rZW4qIHRva2VuKQogewogICAgIFF1YWxp ZmllZE5hbWUgdGFnTmFtZShudWxsQXRvbSwgdG9rZW4tPm5hbWUoKSwgeGh0bWxOYW1lc3BhY2VV UkkpOwpJbmRleDogU291cmNlL1dlYkNvcmUvaHRtbC9wYXJzZXIvSFRNTENvbnN0cnVjdGlvblNp dGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9odG1sL3BhcnNlci9IVE1MQ29uc3Ry dWN0aW9uU2l0ZS5oCShyZXZpc2lvbiAxNzcwOTgpCisrKyBTb3VyY2UvV2ViQ29yZS9odG1sL3Bh cnNlci9IVE1MQ29uc3RydWN0aW9uU2l0ZS5oCSh3b3JraW5nIGNvcHkpCkBAIC0xNDQsNyArMTQ0 LDYgQEAgcHVibGljOgogICAgIEhUTUxTdGFja0l0ZW0qIGN1cnJlbnRTdGFja0l0ZW0oKSBjb25z dCB7IHJldHVybiBtX29wZW5FbGVtZW50cy50b3BTdGFja0l0ZW0oKTsgfQogICAgIEhUTUxTdGFj a0l0ZW0qIG9uZUJlbG93VG9wKCkgY29uc3QgeyByZXR1cm4gbV9vcGVuRWxlbWVudHMub25lQmVs b3dUb3AoKTsgfQogICAgIERvY3VtZW50JiBvd25lckRvY3VtZW50Rm9yQ3VycmVudE5vZGUoKTsK LSAgICBib29sIGluc2lkZVRlbXBsYXRlRWxlbWVudCgpOwogICAgIEhUTUxFbGVtZW50U3RhY2sq IG9wZW5FbGVtZW50cygpIGNvbnN0IHsgcmV0dXJuICZtX29wZW5FbGVtZW50czsgfQogICAgIEhU TUxGb3JtYXR0aW5nRWxlbWVudExpc3QqIGFjdGl2ZUZvcm1hdHRpbmdFbGVtZW50cygpIGNvbnN0 IHsgcmV0dXJuICZtX2FjdGl2ZUZvcm1hdHRpbmdFbGVtZW50czsgfQogICAgIGJvb2wgY3VycmVu dElzUm9vdE5vZGUoKSB7IHJldHVybiBtX29wZW5FbGVtZW50cy50b3BOb2RlKCkgPT0gbV9vcGVu RWxlbWVudHMucm9vdE5vZGUoKTsgfQpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTc3MTg0KQorKysgTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQt MTItMTEgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUkVHUkVT U0lPTihyMTYwMTgyKTogRnJhZ21lbnQgcGFyc2VyIGRvZXNuJ3QgY2xvc2UgYSBmb3JtIGVsZW1l bnQgd2l0aCBhIGNsb3NlIHRhZworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM5NTYxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgQWRkZWQgYSByZWdyZXNzaW9uIHRlc3QuCisKKyAgICAgICAgKiBmYXN0L2Rv bS9kb20tcGFyc2UtY2xvc2UtZm9ybS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGZh c3QvZG9tL2RvbS1wYXJzZS1jbG9zZS1mb3JtLmh0bWw6IEFkZGVkLgorCiAyMDE0LTEyLTExICBB bGV4ZXkgUHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgogCiAgICAgICAgIGZhc3Qvd29ya2Vy cy93b3JrZXItY29uc3RydWN0b3IuaHRtbCBmcmVxdWVudGx5IGNyYXNoZXMKSW5kZXg6IExheW91 dFRlc3RzL2Zhc3QvZG9tL2RvbS1wYXJzZS1jbG9zZS1mb3JtLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb20tcGFyc2UtY2xvc2UtZm9ybS1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9mYXN0L2RvbS9kb20tcGFyc2UtY2xv c2UtZm9ybS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSwxMCBAQAorVGhp cyB0ZXN0cyB0aGF0IERPTVBhcnNlciBjbG9zZXMgYSBmb3JtIGVsZW1lbnQgd2hlbiBpdCBzZWVz IGl0cyBjbG9zZSB0YWcuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAi UEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCitQQVNTIChu ZXcgRE9NUGFyc2VyKCkpLnBhcnNlRnJvbVN0cmluZygiPGZvcm0+PC9mb3JtPnRleHQiLCAidGV4 dC9odG1sIikuYm9keS5pbm5lckhUTUwgaXMgIjxmb3JtPjwvZm9ybT50ZXh0IgorUEFTUyBzdWNj ZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRl c3RzL2Zhc3QvZG9tL2RvbS1wYXJzZS1jbG9zZS1mb3JtLmh0bWwKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvZmFzdC9kb20vZG9tLXBhcnNlLWNsb3NlLWZvcm0uaHRtbAkocmV2aXNpb24gMCkK KysrIExheW91dFRlc3RzL2Zhc3QvZG9tL2RvbS1wYXJzZS1jbG9zZS1mb3JtLmh0bWwJKHdvcmtp bmcgY29weSkKQEAgLTAsMCArMSwxNiBAQAorPCFET0NUWVBFIGh0bWw+Cis8aHRtbD4KKzxib2R5 PgorPHNjcmlwdCBzcmM9Ii4uLy4uL3Jlc291cmNlcy9qcy10ZXN0LXByZS5qcyI+PC9zY3JpcHQ+ Cis8c2NyaXB0PgorCitkZXNjcmlwdGlvbignVGhpcyB0ZXN0cyB0aGF0IERPTVBhcnNlciBjbG9z ZXMgYSBmb3JtIGVsZW1lbnQgd2hlbiBpdCBzZWVzIGl0cyBjbG9zZSB0YWcuJyk7CisKK3Nob3Vs ZEJlRXF1YWxUb1N0cmluZygnKG5ldyBET01QYXJzZXIoKSkucGFyc2VGcm9tU3RyaW5nKCI8Zm9y bT48L2Zvcm0+dGV4dCIsICJ0ZXh0L2h0bWwiKS5ib2R5LmlubmVySFRNTCcsICc8Zm9ybT48L2Zv cm0+dGV4dCcpOworCit2YXIgc3VjY2Vzc2Z1bGx5UGFyc2VkID0gdHJ1ZTsKKworPC9zY3JpcHQ+ Cis8c2NyaXB0IHNyYz0iLi4vLi4vcmVzb3VyY2VzL2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+ Cis8L2JvZHk+Cis8L2h0bWw+Cg==