139535 2014-12-11 04:20:37 -0800 [GTK] Fix Build Warning in WebKit2/UIProcess module 2014-12-12 08:58:42 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kumar.rohit webkit-unassigned andersca cgarcia commit-queue gustavo mrobinson oldest_to_newest 1054464 0 kumar.rohit 2014-12-11 04:20:37 -0800 Unused variable warning in WebKit2/UIProcess/API/gtk/WebKitWebView.cpp file and Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp file. [351/405] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/UIProcess/API/gtk/WebKitWebView.cpp.o ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:581:17: warning: unused parameter ‘webView’ [-Wunused-parameter] static gboolean webkitWebViewShowNotification(WebKitWebView* webView, WebKitNotification* webNotification) ^ ../../Source/WebKit2/UIProcess/API/gtk/WebKitWebView.cpp:605:17: warning: unused parameter ‘webView’ [-Wunused-parameter] static gboolean webkitWebViewCloseNotification(WebKitWebView* webView, WebKitNotification* webNotification) ../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:6: warning: unused parameter ‘modifiedSince’ [-Wunused-parameter] void NetworkProcess::clearDiskCache(std::chrono::system_clock::time_point modifiedSince, std::function<void ()> completionHandler) ^ ../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:6: warning: unused parameter ‘completionHandler’ [-Wunused-parameter] 1054470 1 243117 kumar.rohit 2014-12-11 04:33:08 -0800 Created attachment 243117 Patch 1054475 2 kumar.rohit 2014-12-11 05:16:45 -0800 NetworkProcess.cpp build warning is fixed in another bug https://bugs.webkit.org/show_bug.cgi?id=139534 1054476 3 243119 kumar.rohit 2014-12-11 05:20:10 -0800 Created attachment 243119 Patch 1054836 4 243119 commit-queue 2014-12-12 08:58:37 -0800 Comment on attachment 243119 Patch Clearing flags on attachment: 243119 Committed r177224: <http://trac.webkit.org/changeset/177224> 1054837 5 commit-queue 2014-12-12 08:58:42 -0800 All reviewed patches have been landed. Closing bug. 243117 2014-12-11 04:33:08 -0800 2014-12-11 05:19:58 -0800 Patch bug-139535-20141211180526.patch text/plain 2391 kumar.rohit SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzE0NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTExICBSb2hpdCBL dW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBCdWlsZCBXYXJu aW5nIGluIFdlYktpdDIvVUlQcm9jZXNzIG1vZHVsZSBmb3IgR1RLIGJ1aWxkIGFuZCBXZWJLaXQy L05ldHdvcmtQcm9jZXNzIG1vZHVsZSBpbiBHVEsgYW5kIEVGTCBidWlsZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NTM1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBOZXR3b3JrUHJvY2Vzcy9zb3Vw L05ldHdvcmtQcm9jZXNzU291cC5jcHA6CisgICAgICAgIChXZWJLaXQ6Ok5ldHdvcmtQcm9jZXNz OjpjbGVhckRpc2tDYWNoZSk6CisgICAgICAgICogVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2Vi Vmlldy5jcHA6CisgICAgICAgICh3ZWJraXRXZWJWaWV3U2hvd05vdGlmaWNhdGlvbik6CisgICAg ICAgICh3ZWJraXRXZWJWaWV3Q2xvc2VOb3RpZmljYXRpb24pOgorCiAyMDE0LTEyLTExICBDYXJs b3MgR2FyY2lhIENhbXBvcyAgPGNnYXJjaWFAaWdhbGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBU aW1lcnMgbWlnaHQgbmV2ZXIgYmUgZmlyZWQgZHVyaW5nIGFuaW1hdGlvbnMKSW5kZXg6IFNvdXJj ZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9j ZXNzU291cC5jcHAJKHJldmlzaW9uIDE3NzE0NCkKKysrIFNvdXJjZS9XZWJLaXQyL05ldHdvcmtQ cm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTQ1 LDcgKzE0NSw3IEBAIHZvaWQgTmV0d29ya1Byb2Nlc3M6OmNsZWFyQ2FjaGVGb3JBbGxPcmkKICAg ICBjbGVhckRpc2tDYWNoZShzdGQ6OmNocm9ubzo6c3lzdGVtX2Nsb2NrOjp0aW1lX3BvaW50Ojpt aW4oKSwgW10geyB9KTsKIH0KIAotdm9pZCBOZXR3b3JrUHJvY2Vzczo6Y2xlYXJEaXNrQ2FjaGUo c3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCBtb2RpZmllZFNpbmNlLCBzdGQ6 OmZ1bmN0aW9uPHZvaWQgKCk+IGNvbXBsZXRpb25IYW5kbGVyKQordm9pZCBOZXR3b3JrUHJvY2Vz czo6Y2xlYXJEaXNrQ2FjaGUoc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCAv KiBtb2RpZmllZFNpbmNlICovLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IC8qIGNvbXBsZXRpb25I YW5kbGVyICovKQogewogICAgIC8vIEZJWE1FOiBGaW5kIGEgd2F5IHRvIG9ubHkgY2xlYXIgYSBw YXJ0IG9mIHRoZSBjYWNoZSBiYXNlZCBvbiB0aGUgZGF0ZS4KICAgICBzb3VwX2NhY2hlX2NsZWFy KFNvdXBOZXR3b3JrU2Vzc2lvbjo6ZGVmYXVsdFNlc3Npb24oKS5jYWNoZSgpKTsKSW5kZXg6IFNv dXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3BwCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZpZXcuY3Bw CShyZXZpc2lvbiAxNzcxNDQpCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3LmNwcAkod29ya2luZyBjb3B5KQpAQCAtNTk3LDYgKzU5Nyw3IEBAIHN0YXRp YyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3U2hvd05vdGlmaWMKICAgICBub3RpZnlfbm90aWZpY2F0 aW9uX3Nob3cobm90aWZpY2F0aW9uLmdldCgpLCBudWxscHRyKTsKICAgICByZXR1cm4gVFJVRTsK ICNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHdlYlZpZXcpOwogICAgIFVOVVNFRF9QQVJBTSh3ZWJO b3RpZmljYXRpb24pOwogICAgIHJldHVybiBGQUxTRTsKICNlbmRpZgpAQCAtNjExLDYgKzYxMiw3 IEBAIHN0YXRpYyBnYm9vbGVhbiB3ZWJraXRXZWJWaWV3Q2xvc2VOb3RpZmkKICAgICB9CiAgICAg cmV0dXJuIFRSVUU7CiAjZWxzZQorICAgIFVOVVNFRF9QQVJBTSh3ZWJWaWV3KTsKICAgICBVTlVT RURfUEFSQU0od2ViTm90aWZpY2F0aW9uKTsKICAgICByZXR1cm4gRkFMU0U7CiAjZW5kaWYK 243119 2014-12-11 05:20:10 -0800 2014-12-12 08:58:37 -0800 Patch bug-139535-20141211185228.patch text/plain 1469 kumar.rohit SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzE0NCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE0IEBACisyMDE0LTEyLTExICBSb2hpdCBL dW1hciAgPGt1bWFyLnJvaGl0QHNhbXN1bmcuY29tPgorCisgICAgICAgIEZpeCBCdWlsZCBXYXJu aW5nIGluIFdlYktpdDIvVUlQcm9jZXNzIG1vZHVsZSBmb3IgR1RLIGJ1aWxkIGFuZCBXZWJLaXQy L05ldHdvcmtQcm9jZXNzIG1vZHVsZSBpbiBHVEsgYW5kIEVGTCBidWlsZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NTM1CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvQVBJL2d0ay9X ZWJLaXRXZWJWaWV3LmNwcDogVXNlIFVOVVNFRF9QQVJBTSBmb3IgY29uZGl0aW9uYWwgI2lmIGNh c2UKKyAgICAgICAgKHdlYmtpdFdlYlZpZXdTaG93Tm90aWZpY2F0aW9uKToKKyAgICAgICAgKHdl YmtpdFdlYlZpZXdDbG9zZU5vdGlmaWNhdGlvbik6CisKIDIwMTQtMTItMTEgIENhcmxvcyBHYXJj aWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtdIFRpbWVycyBt aWdodCBuZXZlciBiZSBmaXJlZCBkdXJpbmcgYW5pbWF0aW9ucwpJbmRleDogU291cmNlL1dlYktp dDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYktpdDIvVUlQcm9jZXNzL0FQSS9ndGsvV2ViS2l0V2ViVmlldy5jcHAJKHJldmlzaW9u IDE3NzE0NCkKKysrIFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9BUEkvZ3RrL1dlYktpdFdlYlZp ZXcuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC01OTcsNiArNTk3LDcgQEAgc3RhdGljIGdib29sZWFu IHdlYmtpdFdlYlZpZXdTaG93Tm90aWZpYwogICAgIG5vdGlmeV9ub3RpZmljYXRpb25fc2hvdyhu b3RpZmljYXRpb24uZ2V0KCksIG51bGxwdHIpOwogICAgIHJldHVybiBUUlVFOwogI2Vsc2UKKyAg ICBVTlVTRURfUEFSQU0od2ViVmlldyk7CiAgICAgVU5VU0VEX1BBUkFNKHdlYk5vdGlmaWNhdGlv bik7CiAgICAgcmV0dXJuIEZBTFNFOwogI2VuZGlmCkBAIC02MTEsNiArNjEyLDcgQEAgc3RhdGlj IGdib29sZWFuIHdlYmtpdFdlYlZpZXdDbG9zZU5vdGlmaQogICAgIH0KICAgICByZXR1cm4gVFJV RTsKICNlbHNlCisgICAgVU5VU0VEX1BBUkFNKHdlYlZpZXcpOwogICAgIFVOVVNFRF9QQVJBTSh3 ZWJOb3RpZmljYXRpb24pOwogICAgIHJldHVybiBGQUxTRTsKICNlbmRpZgo=