139534 2014-12-11 03:56:31 -0800 [SOUP] [GTK] warning: unused parameter at NetworkProcessSoup.cpp after r177056 2014-12-11 05:36:42 -0800 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez clopez andersca cgarcia koivisto mrobinson ossy svillar oldest_to_newest 1054458 0 clopez 2014-12-11 03:56:31 -0800 After 177056 <http://trac.webkit.org/r177056> when building WebKitGTK+ the following warnings happen: [5015/5536] Building CXX object Source/WebKit2/CMakeFiles/WebKit2.dir/NetworkProcess/soup/NetworkProcessSoup.cpp.o ../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:75: warning: unused parameter 'modifiedSince' [-Wunused-parameter] ../../Source/WebKit2/NetworkProcess/soup/NetworkProcessSoup.cpp:148:113: warning: unused parameter 'completionHandler' [-Wunused-parameter] 1054460 1 243112 clopez 2014-12-11 03:59:44 -0800 Created attachment 243112 Patch 1054462 2 243112 mrobinson 2014-12-11 04:09:51 -0800 Comment on attachment 243112 Patch Instead of unused parameter simply put the name of the parameter in comments like this: void NetworkProcess::clearDiskCache(std::chrono::system_clock::time_point /* modifiedSince */, std::function<void ()> /* completionHandler */) 1054465 3 243114 clopez 2014-12-11 04:25:35 -0800 Created attachment 243114 Patch 1054478 4 243114 clopez 2014-12-11 05:36:35 -0800 Comment on attachment 243114 Patch Clearing flags on attachment: 243114 Committed r177145: <http://trac.webkit.org/changeset/177145> 1054479 5 clopez 2014-12-11 05:36:42 -0800 All reviewed patches have been landed. Closing bug. 243112 2014-12-11 03:59:44 -0800 2014-12-11 04:25:28 -0800 Patch bug-139534-20141211130026.patch text/plain 1568 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTE2YzdkZWM1ZDMwOTRk ZTMzNGM1YzFiYjdjNDE2ZjhkNTc5NWNiYy4uOWI4ZTY2MTc4N2EzMzRlYTRhZDM4ZTllMzI1ZmFm ZjMyMGRkY2I4MyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTExICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtT T1VQXSBbR1RLXSB3YXJuaW5nOiB1bnVzZWQgcGFyYW1ldGVyIGF0IE5ldHdvcmtQcm9jZXNzU291 cC5jcHAgYWZ0ZXIgcjE3NzA1Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzOTUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3Bw OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6Y2xlYXJEaXNrQ2FjaGUpOiBBZGQg VU5VU0VEX1BBUkFNIG1hY3Jvcy4KKwogMjAxNC0xMi0xMCAgSmFlaHVuIExpbSAgPGxqYWVodW4u bGltQHNhbXN1bmcuY29tPgogCiAgICAgICAgIFtDTWFrZV0gRml4IGJ1aWxkIGFmdGVyIFdlYlN0 b3JhZ2VOYW1lc3BhY2VQcm92aWRlcgpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYktpdDIvTmV0d29y a1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCmluZGV4IDE3NjY5ODExMjk4 MTdkNjlmNDgwNWFkZjQ3MTA0MGM2MzAyNDQwNzEuLjJiZTE1MjhiZjY1ZTdhYzMzMzAxMjdlZjli ZWI2ZTdmYTM5NGFiYTcgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNz L3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3Jr UHJvY2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKQEAgLTE0OCw2ICsxNDgsOCBAQCB2 b2lkIE5ldHdvcmtQcm9jZXNzOjpjbGVhckNhY2hlRm9yQWxsT3JpZ2lucyh1aW50MzJfdCBjYWNo ZXNUb0NsZWFyKQogdm9pZCBOZXR3b3JrUHJvY2Vzczo6Y2xlYXJEaXNrQ2FjaGUoc3RkOjpjaHJv bm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCBtb2RpZmllZFNpbmNlLCBzdGQ6OmZ1bmN0aW9u PHZvaWQgKCk+IGNvbXBsZXRpb25IYW5kbGVyKQogewogICAgIC8vIEZJWE1FOiBGaW5kIGEgd2F5 IHRvIG9ubHkgY2xlYXIgYSBwYXJ0IG9mIHRoZSBjYWNoZSBiYXNlZCBvbiB0aGUgZGF0ZS4KKyAg ICBVTlVTRURfUEFSQU0obW9kaWZpZWRTaW5jZSk7CisgICAgVU5VU0VEX1BBUkFNKGNvbXBsZXRp b25IYW5kbGVyKTsKICAgICBzb3VwX2NhY2hlX2NsZWFyKFNvdXBOZXR3b3JrU2Vzc2lvbjo6ZGVm YXVsdFNlc3Npb24oKS5jYWNoZSgpKTsKIH0KIAo= 243114 2014-12-11 04:25:35 -0800 2014-12-11 05:36:35 -0800 Patch bug-139534-20141211132616.patch text/plain 1719 clopez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MTQzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViS2l0Mi9DaGFuZ2VMb2cKaW5kZXggZTE2YzdkZWM1ZDMwOTRk ZTMzNGM1YzFiYjdjNDE2ZjhkNTc5NWNiYy4uNTgxNmEwZDMyMjMzZGY5N2JlZTY4MjA1OTVkYWQz NTU3NjE1NGViMiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJLaXQyL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTExICBDYXJs b3MgQWxiZXJ0byBMb3BleiBQZXJleiAgPGNsb3BlekBpZ2FsaWEuY29tPgorCisgICAgICAgIFtT T1VQXSBbR1RLXSB3YXJuaW5nOiB1bnVzZWQgcGFyYW1ldGVyIGF0IE5ldHdvcmtQcm9jZXNzU291 cC5jcHAgYWZ0ZXIgcjE3NzA1Ni4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTEzOTUzNAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEp LgorCisgICAgICAgICogTmV0d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3Bw OgorICAgICAgICAoV2ViS2l0OjpOZXR3b3JrUHJvY2Vzczo6Y2xlYXJEaXNrQ2FjaGUpOiBDb21t ZW50IHRoZSBwYXJhbWV0ZXIgbmFtZXMuCisKIDIwMTQtMTItMTAgIEphZWh1biBMaW0gIDxsamFl aHVuLmxpbUBzYW1zdW5nLmNvbT4KIAogICAgICAgICBbQ01ha2VdIEZpeCBidWlsZCBhZnRlciBX ZWJTdG9yYWdlTmFtZXNwYWNlUHJvdmlkZXIKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL05l dHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcCBiL1NvdXJjZS9XZWJLaXQy L05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0d29ya1Byb2Nlc3NTb3VwLmNwcAppbmRleCAxNzY2OTgx MTI5ODE3ZDY5ZjQ4MDVhZGY0NzEwNDBjNjMwMjQ0MDcxLi41MTc5MzExYTc3NmJhMTUzY2E3NTk2 NzgzNzYzNWY1NzUxOWFhZjAzIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJv Y2Vzcy9zb3VwL05ldHdvcmtQcm9jZXNzU291cC5jcHAKKysrIGIvU291cmNlL1dlYktpdDIvTmV0 d29ya1Byb2Nlc3Mvc291cC9OZXR3b3JrUHJvY2Vzc1NvdXAuY3BwCkBAIC0xNDUsNyArMTQ1LDcg QEAgdm9pZCBOZXR3b3JrUHJvY2Vzczo6Y2xlYXJDYWNoZUZvckFsbE9yaWdpbnModWludDMyX3Qg Y2FjaGVzVG9DbGVhcikKICAgICBjbGVhckRpc2tDYWNoZShzdGQ6OmNocm9ubzo6c3lzdGVtX2Ns b2NrOjp0aW1lX3BvaW50OjptaW4oKSwgW10geyB9KTsKIH0KIAotdm9pZCBOZXR3b3JrUHJvY2Vz czo6Y2xlYXJEaXNrQ2FjaGUoc3RkOjpjaHJvbm86OnN5c3RlbV9jbG9jazo6dGltZV9wb2ludCBt b2RpZmllZFNpbmNlLCBzdGQ6OmZ1bmN0aW9uPHZvaWQgKCk+IGNvbXBsZXRpb25IYW5kbGVyKQor dm9pZCBOZXR3b3JrUHJvY2Vzczo6Y2xlYXJEaXNrQ2FjaGUoc3RkOjpjaHJvbm86OnN5c3RlbV9j bG9jazo6dGltZV9wb2ludCAvKiBtb2RpZmllZFNpbmNlICovLCBzdGQ6OmZ1bmN0aW9uPHZvaWQg KCk+IC8qIGNvbXBsZXRpb25IYW5kbGVyICovKQogewogICAgIC8vIEZJWE1FOiBGaW5kIGEgd2F5 IHRvIG9ubHkgY2xlYXIgYSBwYXJ0IG9mIHRoZSBjYWNoZSBiYXNlZCBvbiB0aGUgZGF0ZS4KICAg ICBzb3VwX2NhY2hlX2NsZWFyKFNvdXBOZXR3b3JrU2Vzc2lvbjo6ZGVmYXVsdFNlc3Npb24oKS5j YWNoZSgpKTsK