139501 2014-12-10 11:59:29 -0800 Please disable the webkitFirstVersionWithInitConstructorSupport check on Apple TV 2015-04-27 16:55:02 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren benjamin cmarcelo commit-queue oldest_to_newest 1054264 0 ggaren 2014-12-10 11:59:29 -0800 Please disable the webkitFirstVersionWithInitConstructorSupport check on ATV 1054282 1 243059 ggaren 2014-12-10 12:56:08 -0800 Created attachment 243059 Patch 1054286 2 ggaren 2014-12-10 13:10:08 -0800 Committed r177091: <http://trac.webkit.org/changeset/177091> 1089273 3 243059 joepeck 2015-04-27 16:55:02 -0700 Comment on attachment 243059 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=243059&action=review > Source/JavaScriptCore/API/JSWrapperMap.mm:664 > +#if PLATFORM(APPLETV) > + // There are no old clients on Apple TV, so there's no need for backwards compatibility. > + return true; > +#endif > + > static int32_t versionOfLinkTimeLibrary = 0; > if (!versionOfLinkTimeLibrary) > versionOfLinkTimeLibrary = NSVersionOfLinkTimeLibrary("JavaScriptCore"); I imagine that if we enabled unreachable code warnings it might complain about the unreachable code after the #if. Perhaps an #if/#else/#endif might be better. 243059 2014-12-10 12:56:08 -0800 2014-12-10 13:05:41 -0800 Patch bug-139501-20141210125650.patch text/plain 2731 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc3MDg2KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE5IEBA CisyMDE0LTEyLTEwICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUGxlYXNlIGRpc2FibGUgdGhlIHdlYmtpdEZpcnN0VmVyc2lvbldpdGhJbml0Q29uc3RydWN0 b3JTdXBwb3J0IGNoZWNrIG9uIEFwcGxlIFRWCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBOU1ZlcnNpb25PZkxpbmtUaW1lTGlicmFyeSBvbmx5IHdvcmtz IGlmIHlvdSBsaW5rIGRpcmVjdGx5IGFnYWluc3QKKyAgICAgICAgSmF2YVNjcmlwdENvcmUsIHdo aWNoIGlzIGEgYml0IGF3a3dhcmQgZm9yIG91ciBBcHBsZSBUViBjbGllbnQgdG8gZG8uCisKKyAg ICAgICAgSXQncyBlYXN5IGVub3VnaCBqdXN0IHRvIGRpc2FibGUgdGhpcyBjaGVjayBvbiBBcHBs ZSBUViwgc2luY2UgaXQgaGFzIG5vCisgICAgICAgIGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5IHJl cXVpcmVtZW50LgorCisgICAgICAgICogQVBJL0pTV3JhcHBlck1hcC5tbToKKyAgICAgICAgKHN1 cHBvcnRzSW5pdE1ldGhvZENvbnN0cnVjdG9ycyk6CisKIDIwMTQtMTItMTAgIE1hdHRoZXcgTWly bWFuICA8bW1pcm1hbkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4ZXMgb3BlcmF0aW9uUHV0QnlJ ZHMgc3VjaCB0aGF0IHRoZXkgY2hlY2sgdGhhdCB0aGUgcHV0IGRpZG4ndApJbmRleDogU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS9KU1dyYXBwZXJNYXAubW0KPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNl L0phdmFTY3JpcHRDb3JlL0FQSS9KU1dyYXBwZXJNYXAubW0JKHJldmlzaW9uIDE3NzAyNikKKysr IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9BUEkvSlNXcmFwcGVyTWFwLm1tCSh3b3JraW5nIGNvcHkp CkBAIC02NTQsNiArNjU0LDExIEBAIE5TX1JPT1RfQ0xBU1MgQGludGVyZmFjZSBKU0V4cG9ydCA8 SlNFeHAKIAogYm9vbCBzdXBwb3J0c0luaXRNZXRob2RDb25zdHJ1Y3RvcnMoKQogeworI2lmIFBM QVRGT1JNKEFQUExFVFYpCisgICAgLy8gVGhlcmUgYXJlIG5vIG9sZCBjbGllbnRzIG9uIEFwcGxl IFRWLCBzbyB0aGVyZSdzIG5vIG5lZWQgZm9yIGJhY2t3YXJkcyBjb21wYXRpYmlsaXR5LgorICAg IHJldHVybiB0cnVlOworI2VuZGlmCisKICAgICBzdGF0aWMgaW50MzJfdCB2ZXJzaW9uT2ZMaW5r VGltZUxpYnJhcnkgPSAwOwogICAgIGlmICghdmVyc2lvbk9mTGlua1RpbWVMaWJyYXJ5KQogICAg ICAgICB2ZXJzaW9uT2ZMaW5rVGltZUxpYnJhcnkgPSBOU1ZlcnNpb25PZkxpbmtUaW1lTGlicmFy eSgiSmF2YVNjcmlwdENvcmUiKTsKSW5kZXg6IFNvdXJjZS9XVEYvQ2hhbmdlTG9nCj09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT0KLS0tIFNvdXJjZS9XVEYvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzcwODkpCisrKyBTb3VyY2Uv V1RGL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTEw ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAgICAgUGxlYXNlIGRp c2FibGUgdGhlIHdlYmtpdEZpcnN0VmVyc2lvbldpdGhJbml0Q29uc3RydWN0b3JTdXBwb3J0IGNo ZWNrIG9uIEFwcGxlIFRWCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzk1MDEKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBBZGRlZCBhIHBsYXRmb3JtIGRlZmluaXRpb24gZm9yIEFQUExFVFYuCisKKyAgICAg ICAgKEl0J3Mgbm90IGFuIE9TIGJlY2F1c2UgaXQncyBub3QgbXV0dWFsbHkgZXhjbHVzaXZlIHdp dGggb3RoZXIgT1MgZGVmaW5pdGlvbnMuKQorCisgICAgICAgICogd3RmL1BsYXRmb3JtLmg6CisK IDIwMTQtMTItMTAgIE1hcnRpbiBSb2JpbnNvbiAgPG1yb2JpbnNvbkBpZ2FsaWEuY29tPgogCiAg ICAgICAgIFtHVEtdIEFkZCBzdXBwb3J0IGZvciB0ZXh0LWRlY29yYXRpb24tc2tpcApJbmRleDog U291cmNlL1dURi93dGYvUGxhdGZvcm0uaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV1RGL3d0Zi9Q bGF0Zm9ybS5oCShyZXZpc2lvbiAxNzcwMjYpCisrKyBTb3VyY2UvV1RGL3d0Zi9QbGF0Zm9ybS5o CSh3b3JraW5nIGNvcHkpCkBAIC00NTIsNiArNDUyLDExIEBACiAjZW5kaWYKICNlbmRpZgogCisv KiBQTEFURk9STShBUFBMRVRWKSAqLworI2lmIGRlZmluZWQoVEFSR0VUX09TX1RWKSAmJiBUQVJH RVRfT1NfVFYKKyNkZWZpbmUgV1RGX1BMQVRGT1JNX0FQUExFVFYgMQorI2VuZGlmCisKIC8qIEdy YXBoaWNzIGVuZ2luZXMgKi8KIAogLyogVVNFKENHKSBhbmQgUExBVEZPUk0oQ0kpICovCg==