139476 2014-12-10 03:50:40 -0800 Floats Don't Overhang Their Block Formatting Contex 2014-12-15 13:06:50 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 jfernandez jfernandez commit-queue esprehn+autocc glenn kondapallykalyan oldest_to_newest 1054106 0 jfernandez 2014-12-10 03:50:40 -0800 Floats Don't Overhang Their Block Formatting Context Per http://www.w3.org/TR/CSS2/visuren.html#float-position: "References to [the elements] in the [rules that govern the behaviour of floats] refer only to other elements in the same block formatting context as the float." This means we don't need to look for intruding or overhanging floats in boxes that establish a new block formatting context. I couldn't find a test where we failed this rule but we do appear to be doing unnecessary work in rebuildFloatsFromIntruding() so make sure we avoid adding floats from different block formatting contexts. 1054107 1 243007 jfernandez 2014-12-10 04:14:40 -0800 Created attachment 243007 Patch 1055702 2 243007 hyatt 2014-12-15 12:26:35 -0800 Comment on attachment 243007 Patch r=me 1055713 3 243007 commit-queue 2014-12-15 13:06:46 -0800 Comment on attachment 243007 Patch Clearing flags on attachment: 243007 Committed r177308: <http://trac.webkit.org/changeset/177308> 1055714 4 commit-queue 2014-12-15 13:06:50 -0800 All reviewed patches have been landed. Closing bug. 243007 2014-12-10 04:14:40 -0800 2014-12-15 13:06:46 -0800 Patch bug-139476-20141210131514.patch text/plain 6675 jfernandez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc3MDE1CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjA0YmM5ODM1NTk4NzRh MWQ2ZjQ2MDI2MmY4N2VkNmQxNWQ2ZmVjYi4uOGMzYjZkOGQ2NWQ3ZTIxZDY1NjAxODNjNmVlYWY4 NWEzYTZjZTRiNSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDMxIEBACisyMDE0LTEyLTEwICBKYXZp ZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29tPgorCisgICAgICAgIEZsb2F0cyBE b24ndCBPdmVyaGFuZyBUaGVpciBCbG9jayBGb3JtYXR0aW5nIENvbnRleAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NDc2CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgRnJvbSBCbGluayByMTcyNTMwIGJ5 IDxyb2Job2dhbkBnbWFpbC5jb20+CisKKyAgICAgICAgRmxvYXRzIERvbid0IE92ZXJoYW5nIFRo ZWlyIEJsb2NrIEZvcm1hdHRpbmcgQ29udGV4dCBQZXIKKyAgICAgICAgaHR0cDovL3d3dy53My5v cmcvVFIvQ1NTMi92aXN1cmVuLmh0bWwjZmxvYXQtcG9zaXRpb246ICJSZWZlcmVuY2VzCisgICAg ICAgIHRvIFt0aGUgZWxlbWVudHNdIGluIHRoZSBbcnVsZXMgdGhhdCBnb3Zlcm4gdGhlIGJlaGF2 aW91ciBvZgorICAgICAgICBmbG9hdHNdIHJlZmVyIG9ubHkgdG8gb3RoZXIgZWxlbWVudHMgaW4g dGhlIHNhbWUgYmxvY2sgZm9ybWF0dGluZworICAgICAgICBjb250ZXh0IGFzIHRoZSBmbG9hdC4i CisKKyAgICAgICAgVGhpcyBtZWFucyB3ZSBkb24ndCBuZWVkIHRvIGxvb2sgZm9yIGludHJ1ZGlu ZyBvciBvdmVyaGFuZ2luZworICAgICAgICBmbG9hdHMgaW4gYm94ZXMgdGhhdCBlc3RhYmxpc2gg YSBuZXcgYmxvY2sgZm9ybWF0dGluZworICAgICAgICBjb250ZXh0LiBFdmVuIHRoYXQgd2UgZG9u J3QgaGF2ZSBhIHRlc3QgYnJlYWtpbmcgdGhpcyBydWxlIGl0CisgICAgICAgIHNlZW1zIHdlIGFy ZSBkb2luZyB1bm5lY2Vzc2FyeSB3b3JrIGluCisgICAgICAgIHJlYnVpbGRGbG9hdHNGcm9tSW50 cnVkaW5nKCkgc28gbWFrZSBzdXJlIHdlIGF2b2lkIGFkZGluZyBmbG9hdHMKKyAgICAgICAgZnJv bSBkaWZmZXJlbnQgYmxvY2sgZm9ybWF0dGluZyBjb250ZXh0cy4KKworICAgICAgICBUZXN0Ogor ICAgICAgICBmYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0cy1kby1ub3Qtb3ZlcmhhbmctZnJvbS1ibG9j ay1mb3JtYXR0aW5nLWNvbnRleHQuaHRtbAorCisgICAgICAgICogcmVuZGVyaW5nL1JlbmRlckJs b2NrRmxvdy5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJCbG9ja0Zsb3c6OmFkZEludHJ1 ZGluZ0Zsb2F0cyk6CisKIDIwMTQtMTItMDkgIEFsYmVydG8gR2FyY2lhICA8YmVydG9AaWdhbGlh LmNvbT4KIAogICAgICAgICBbTWVkaWFdW0dUS11bRUZMXSBSZWR1Y2Ugc3R5bGUgdXBkYXRlcyAo cGFpbnRpbmcpIGluIGNvbnRyb2xzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyQmxvY2tGbG93LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJC bG9ja0Zsb3cuY3BwCmluZGV4IGFjOTFkZTY5ZTgwMTAzMzNiMzE4MzFhNjBhMGQxZjljNzZhYTkz N2UuLjE5OWUxNDNlZmNlNjcwN2I5ODEzNWU2YTdjNTllZDJiODBhNDg0ODYgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCisrKyBiL1NvdXJj ZS9XZWJDb3JlL3JlbmRlcmluZy9SZW5kZXJCbG9ja0Zsb3cuY3BwCkBAIC0yNjU4LDYgKzI2NTgs MTAgQEAgdm9pZCBSZW5kZXJCbG9ja0Zsb3c6OmFkZEludHJ1ZGluZ0Zsb2F0cyhSZW5kZXJCbG9j a0Zsb3cqIHByZXYsIExheW91dFVuaXQgbG9naWMKIHsKICAgICBBU1NFUlQoIWF2b2lkc0Zsb2F0 cygpKTsKIAorICAgIC8vIElmIHdlIGNyZWF0ZSBvdXIgb3duIGJsb2NrIGZvcm1hdHRpbmcgY29u dGV4dCB0aGVuIG91ciBjb250ZW50cyBkb24ndCBpbnRlcmFjdCB3aXRoIGZsb2F0cyBvdXRzaWRl IGl0LCBldmVuIHRob3NlIGZyb20gb3VyIHBhcmVudC4KKyAgICBpZiAoY3JlYXRlc05ld0Zvcm1h dHRpbmdDb250ZXh0KCkpCisgICAgICAgIHJldHVybjsKKwogICAgIC8vIElmIHRoZSBwYXJlbnQg b3IgcHJldmlvdXMgc2libGluZyBkb2Vzbid0IGhhdmUgYW55IGZsb2F0cyB0byBhZGQsIGRvbid0 IGJvdGhlci4KICAgICBpZiAoIXByZXYtPm1fZmxvYXRpbmdPYmplY3RzKQogICAgICAgICByZXR1 cm47CmRpZmYgLS1naXQgYS9MYXlvdXRUZXN0cy9DaGFuZ2VMb2cgYi9MYXlvdXRUZXN0cy9DaGFu Z2VMb2cKaW5kZXggMjZjZTU1YzNiNGMyMmVjNGJlNzYyY2E2YWFlMjU3NDFmYWQwM2I3My4uOGJi ODgyNzA0MjY1NTJhMjA2YTk3N2IwMmEwZGRiM2RmYzgyNjZiNCAxMDA2NDQKLS0tIGEvTGF5b3V0 VGVzdHMvQ2hhbmdlTG9nCisrKyBiL0xheW91dFRlc3RzL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE4 IEBACisyMDE0LTEyLTEwICBKYXZpZXIgRmVybmFuZGV6ICA8amZlcm5hbmRlekBpZ2FsaWEuY29t PgorCisgICAgICAgIEZsb2F0cyBEb24ndCBPdmVyaGFuZyBUaGVpciBCbG9jayBGb3JtYXR0aW5n IENvbnRleAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM5NDc2CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg RnJvbSBCbGluayByMTcyNTMwIGJ5IDxyb2Job2dhbkBnbWFpbC5jb20+CisKKyAgICAgICAgVGVz dHMgdG8gdmVyaWZ5IHRoYXQgZmxvYXQgZWxlbWVudHMgZG9uJ3Qgb3ZlcmhhbmcgYmxvY2tzIHdp dGggYQorICAgICAgICBkaWZmZXJlbnQgZm9ybWF0dGluZyBjb250ZXh0LgorCisgICAgICAgICog ZmFzdC9ibG9jay9mbG9hdC9mbG9hdHMtZG8tbm90LW92ZXJoYW5nLWZyb20tYmxvY2stZm9ybWF0 dGluZy1jb250ZXh0LWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogZmFzdC9ibG9jay9m bG9hdC9mbG9hdHMtZG8tbm90LW92ZXJoYW5nLWZyb20tYmxvY2stZm9ybWF0dGluZy1jb250ZXh0 Lmh0bWw6IEFkZGVkLgorCiAyMDE0LTEyLTA5ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdh bGlhLmNvbT4KIAogICAgICAgICBbR1RLXSBCdW1wIG1pbmltdW0gdmVyc2lvbiBvZiBBVEsgdXNl ZCBieSBqaGJ1aWxkIHRvIGF0IGxlYXN0IDIuMTUuMgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMv ZmFzdC9ibG9jay9mbG9hdC9mbG9hdHMtZG8tbm90LW92ZXJoYW5nLWZyb20tYmxvY2stZm9ybWF0 dGluZy1jb250ZXh0LWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQv ZmxvYXRzLWRvLW5vdC1vdmVyaGFuZy1mcm9tLWJsb2NrLWZvcm1hdHRpbmctY29udGV4dC1leHBl Y3RlZC50eHQKbmV3IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAwMDAwMDAwMC4uNWMwYjgxNzJjMjk3MDIzOTI0YTBhM2Q2NDJjODg4ZmIzZjdh ODRkYgotLS0gL2Rldi9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvYmxvY2svZmxvYXQvZmxv YXRzLWRvLW5vdC1vdmVyaGFuZy1mcm9tLWJsb2NrLWZvcm1hdHRpbmctY29udGV4dC1leHBlY3Rl ZC50eHQKQEAgLTAsMCArMSwxMSBAQAoraHR0cDovL3d3dy53My5vcmcvVFIvQ1NTMi92aXN1cmVu Lmh0bWwjZmxvYXQtcG9zaXRpb246ICJSZWZlcmVuY2VzIHRvIFt0aGUgZWxlbWVudHNdIGluIHRo ZSBbcnVsZXMgdGhhdCBnb3Zlcm4gdGhlIGJlaGF2aW91ciBvZiBmbG9hdHNdIHJlZmVyIG9ubHkg dG8gb3RoZXIgZWxlbWVudHMgaW4gdGhlIHNhbWUgYmxvY2sgZm9ybWF0dGluZyBjb250ZXh0IGFz IHRoZSBmbG9hdC4iIAorIFBBU1MKKyAKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BBU1MKK1BB U1MKKworUEFTUwpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC9ibG9jay9mbG9hdC9mbG9h dHMtZG8tbm90LW92ZXJoYW5nLWZyb20tYmxvY2stZm9ybWF0dGluZy1jb250ZXh0Lmh0bWwgYi9M YXlvdXRUZXN0cy9mYXN0L2Jsb2NrL2Zsb2F0L2Zsb2F0cy1kby1ub3Qtb3ZlcmhhbmctZnJvbS1i bG9jay1mb3JtYXR0aW5nLWNvbnRleHQuaHRtbApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi45MzU5Y2NmMjA1MDVlMTEx NTc2N2NmYzNjZDY5ZjVkNTNlZmM4MjFiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9ibG9jay9mbG9hdC9mbG9hdHMtZG8tbm90LW92ZXJoYW5nLWZyb20tYmxvY2stZm9ybWF0 dGluZy1jb250ZXh0Lmh0bWwKQEAgLTAsMCArMSw3NCBAQAorPCFET0NUWVBFIEhUTUw+Cis8aHRt bD4KKzxzdHlsZT4KK2JvZHkgeworICAgIG1hcmdpbjogMHB4OworICAgIHBhZGRpbmc6IDBweDsK K30KKy5pdGVtIHsKKyAgICBoZWlnaHQ6IDQwcHg7CisgICAgd2lkdGg6IDQwcHg7Cit9CitmaWVs ZHNldCB7CisgICAgYm9yZGVyOiAwcHg7CisgICAgcGFkZGluZzogMHB4OworICAgIG1hcmdpbjog MHB4OworfQorLnRlc3QgeworICAgIHdpZHRoOiA0MHB4OworICAgIGhlaWdodDo0MHB4OworICAg IGJhY2tncm91bmQtY29sb3I6IHJlZDsKK30KKy5jb250YWluZXIgeworICAgIHBvc2l0aW9uOiBy ZWxhdGl2ZTsKKyAgICBtYXJnaW46IDBweDsKKyAgICBwYWRkaW5nOiAwcHg7Cit9CisuZmxvYXQg eworICAgIGZsb2F0OiBsZWZ0OworICAgIHdpZHRoOiA0MHB4OworICAgIGhlaWdodDo4MHB4Owor ICAgIGJhY2tncm91bmQtY29sb3I6IGJsdWU7Cit9Cis8L3N0eWxlPgorPHNjcmlwdCBzcmM9Ii4u Ly4uLy4uL3Jlc291cmNlcy9jaGVjay1sYXlvdXQuanMiPjwvc2NyaXB0PgorPGJvZHkgb25sb2Fk PSJjaGVja0xheW91dCgnLnRlc3QnKSI+CitodHRwOi8vd3d3LnczLm9yZy9UUi9DU1MyL3Zpc3Vy ZW4uaHRtbCNmbG9hdC1wb3NpdGlvbjoKKyJSZWZlcmVuY2VzIHRvIFt0aGUgZWxlbWVudHNdIGlu IHRoZSBbcnVsZXMgdGhhdCBnb3Zlcm4gdGhlIGJlaGF2aW91ciBvZiBmbG9hdHNdIHJlZmVyIG9u bHkgdG8gb3RoZXIgZWxlbWVudHMgaW4gdGhlIHNhbWUgYmxvY2sgZm9ybWF0dGluZyBjb250ZXh0 IGFzIHRoZSBmbG9hdC4iCis8YnI+Cis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYg Y2xhc3M9Iml0ZW0iIHN0eWxlPSJkaXNwbGF5OiBpbmxpbmUtYmxvY2s7Ij48ZGl2IGNsYXNzPSJm bG9hdCI+PC9kaXY+PC9kaXY+CisgICAgPGRpdiBjbGFzcz0idGVzdCIgZGF0YS10b3RhbC14PTA+ PC9kaXY+Cis8L2Rpdj4KKzxkaXYgY2xhc3M9ImNvbnRhaW5lciI+CisgICAgPGRpdiBjbGFzcz0i aXRlbSIgc3R5bGU9ImRpc3BsYXk6IGlubGluZS10YWJsZTsiPjxkaXYgY2xhc3M9ImZsb2F0Ij48 L2Rpdj48L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJ0ZXN0IiBkYXRhLXRvdGFsLXg9MD48L2Rpdj4K KzwvZGl2PgorPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICA8ZGl2IGNsYXNzPSJpdGVtIiBz dHlsZT0iZGlzcGxheTogdGFibGUtY2FwdGlvbjsiPjxkaXYgY2xhc3M9ImZsb2F0Ij48L2Rpdj48 L2Rpdj4KKyAgICA8ZGl2IGNsYXNzPSJ0ZXN0IiBkYXRhLXRvdGFsLXg9MCBkYXRhLW9mZnNldC15 PTQwPjwvZGl2PgorPC9kaXY+Cis8ZGl2IGNsYXNzPSJjb250YWluZXIiPgorICAgIDxkaXYgY2xh c3M9Iml0ZW0iIHN0eWxlPSJvdmVyZmxvdzpoaWRkZW47Ij48ZGl2IGNsYXNzPSJmbG9hdCI+PC9k aXY+PC9kaXY+CisgICAgPGRpdiBjbGFzcz0idGVzdCIgZGF0YS10b3RhbC14PTAgZGF0YS1vZmZz ZXQteT00MD48L2Rpdj4KKzwvZGl2PgorPGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICA8ZGl2 IGNsYXNzPSJpdGVtIiBzdHlsZT0iLXdlYmtpdC1jb2x1bW5zOiAxMHB4IDI7Ij48ZGl2IGNsYXNz PSJmbG9hdCI+PC9kaXY+PC9kaXY+CisgICAgPGRpdiBjbGFzcz0idGVzdCIgZGF0YS10b3RhbC14 PTAgZGF0YS1vZmZzZXQteT00MD48L2Rpdj4KKzwvZGl2PgorPGRpdiBjbGFzcz0iY29udGFpbmVy Ij4KKyAgICA8ZGl2IGNsYXNzPSJpdGVtIiBzdHlsZT0iLXdlYmtpdC1jb2x1bW4tc3BhbjogYWxs OyI+PGRpdiBjbGFzcz0iZmxvYXQiPjwvZGl2PjwvZGl2PgorICAgIDxkaXYgY2xhc3M9InRlc3Qi IGRhdGEtdG90YWwteD0wIGRhdGEtb2Zmc2V0LXk9NDA+PC9kaXY+Cis8L2Rpdj4KKzxkaXYgY2xh c3M9ImNvbnRhaW5lciI+CisgICAgPGRpdiBzdHlsZT0iZGlzcGxheTogZmxleDsgLXdlYmtpdC1m bGV4LWRpcmVjdGlvbjogY29sdW1uOyI+CisgICAgICAgIDxkaXYgY2xhc3M9Iml0ZW0iPjxkaXYg Y2xhc3M9ImZsb2F0Ij48L2Rpdj48L2Rpdj4KKyAgICAgICAgPGRpdiBjbGFzcz0idGVzdCIgZGF0 YS10b3RhbC14PTAgZGF0YS1vZmZzZXQteT00MD48L2Rpdj4KKyAgICA8L2Rpdj4KKzwvZGl2Pgor PGRpdiBjbGFzcz0iY29udGFpbmVyIj4KKyAgICA8ZmllbGRzZXQgY2xhc3M9Iml0ZW0iPjxkaXYg Y2xhc3M9ImZsb2F0Ij48L2Rpdj48L2ZpZWxkc2V0PgorICAgIDxkaXYgY2xhc3M9InRlc3QiIGRh dGEtdG90YWwteD0wIGRhdGEtb2Zmc2V0LXk9NDA+PC9kaXY+Cis8L2Rpdj4KKzwvYm9keT4KKzwv aHRtbD4K