139459 2014-12-09 14:20:17 -0800 Kotoeri conversion sometimes decides only first character automatically in Safari 7.1 or 6.2 2014-12-09 14:39:09 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED https://bugs.webkit.org/show_bug.cgi?id=137719 InRadar P2 Normal --- 1 ap ap commit-queue oldest_to_newest 1053945 0 ap 2014-12-09 14:20:17 -0800 Steps to reproduce: 1. Make sure that http://www.yahoo.co.jp is in your history. 2. Switch to Kotoeri. 3. Open a new window with http://www.yahoo.co.jp from history menu. 4. Type "ka" Results: "k" is Roman. Alternative steps to reproduce: 1. Switch to Kotoeri. 2. Load http://www.yahoo.co.jp. 3. When the search field is already visible, but does not appear focused yet, press "k". Results: "k" is not underlined. rdar://problem/19017432 rdar://problem/19036869 1053946 1 242964 ap 2014-12-09 14:25:00 -0800 Created attachment 242964 proposed fix 1053947 2 242964 enrica 2014-12-09 14:27:44 -0800 Comment on attachment 242964 proposed fix View in context: https://bugs.webkit.org/attachment.cgi?id=242964&action=review Looks good to me. Please change the title in ChangeLog before landing. > Source/WebKit2/ChangeLog:3 > + Kotoeri conversion sometimes decides only first character automatically in Safari 7.1 or 6.2 Not sure this clear. 1053952 3 ap 2014-12-09 14:39:09 -0800 Committed <http://trac.webkit.org/r177040>. 242964 2014-12-09 14:25:00 -0800 2014-12-09 14:36:11 -0800 proposed fix UpdateWindows1.txt text/plain 5146 ap SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzAzOSkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDI0IEBACisyMDE0LTEyLTA5ICBBbGV4ZXkg UHJvc2t1cnlha292ICA8YXBAYXBwbGUuY29tPgorCisgICAgICAgIEtvdG9lcmkgY29udmVyc2lv biBzb21ldGltZXMgZGVjaWRlcyBvbmx5IGZpcnN0IGNoYXJhY3RlciBhdXRvbWF0aWNhbGx5IGlu IFNhZmFyaSA3LjEgb3IgNi4yCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3df YnVnLmNnaT9pZD0xMzk0NTkKKyAgICAgICAgcmRhcjovL3Byb2JsZW0vMTkwMTc0MzIKKyAgICAg ICAgcmRhcjovL3Byb2JsZW0vMTkwMzY4NjkKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBXaGVuIGlucHV0Q29udGV4dCBjaGFuZ2VzLCBub3RpZnkgdGhl IGFwcGxpY2F0aW9uLiBXZSBhbHJlYWR5IGRpZCB0aGlzIHdoZW4gdGhlIGNvbnRleHQKKyAgICAg ICAgY2hhbmdlZCBkdWUgdG8gcGx1Zy1pbnMsIGFuZCB0aGlzIHVzZWQgdG8gc29ydCBvZiBtYWtl IGl0IHdvcmsgb24gb24geWFob28uY28uanAsCisgICAgICAgIHdoaWNoIGhhcyBwbHVnLWlucy4g QnV0IHRoYXQgd2FzIHF1aXRlIHVucmVsaWFibGUsIGFzIGV2aWRlbmNlZCBieSB0aGUgcmVwcm9k dWNpYmxlCisgICAgICAgIGNhc2VzIHdoZXJlIHdlIGRpZG4ndCB1c2UgYW4gaW5wdXQgbWV0aG9k IGZvciB0aGUgZmlyc3Qga2V5cHJlc3MuCisKKyAgICAgICAgKiBVSVByb2Nlc3MvUGFnZUNsaWVu dC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9XZWJQYWdlUHJveHkuY3BwOgorICAgICAgICAoV2Vi S2l0OjpXZWJQYWdlUHJveHk6OmVkaXRvclN0YXRlQ2hhbmdlZCk6CisgICAgICAgICogVUlQcm9j ZXNzL21hYy9QYWdlQ2xpZW50SW1wbC5oOgorICAgICAgICAqIFVJUHJvY2Vzcy9tYWMvUGFnZUNs aWVudEltcGwubW06CisgICAgICAgIChXZWJLaXQ6OlBhZ2VDbGllbnRJbXBsOjpub3RpZnlBcHBs aWNhdGlvbkFib3V0SW5wdXRDb250ZXh0Q2hhbmdlKToKKwogMjAxNC0xMi0wOSAgSmVyZW15IEpv bmVzICA8amVyZW15akBhcHBsZS5jb20+CiAKICAgICAgICAgRW5hYmxlIGF1dG9tYXRpYyBvcHRp bWl6ZWQgZnVsbHNjcmVlbiBtb2RlLgpJbmRleDogU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL1Bh Z2VDbGllbnQuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFnZUNs aWVudC5oCShyZXZpc2lvbiAxNzY5NTApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvUGFn ZUNsaWVudC5oCSh3b3JraW5nIGNvcHkpCkBAIC0xODUsNiArMTg1LDEwIEBAIHB1YmxpYzoKICAg ICB2aXJ0dWFsIHZvaWQgd2hlZWxFdmVudFdhc05vdEhhbmRsZWRCeVdlYkNvcmUoY29uc3QgTmF0 aXZlV2ViV2hlZWxFdmVudCYpID0gMDsKICNlbmRpZgogCisjaWYgUExBVEZPUk0oTUFDKSAmJiAh VVNFKEFTWU5DX05TVEVYVElOUFVUQ0xJRU5UKQorICAgIHZpcnR1YWwgdm9pZCBub3RpZnlBcHBs aWNhdGlvbkFib3V0SW5wdXRDb250ZXh0Q2hhbmdlKCkgPSAwOworI2VuZGlmCisKICNpZiBVU0Uo QVBQS0lUKQogICAgIHZpcnR1YWwgdm9pZCBzZXRQcm9taXNlZERhdGEoY29uc3QgU3RyaW5nJiBw YXN0ZWJvYXJkTmFtZSwgUGFzc1JlZlB0cjxXZWJDb3JlOjpTaGFyZWRCdWZmZXI+IGltYWdlQnVm ZmVyLCBjb25zdCBTdHJpbmcmIGZpbGVuYW1lLCBjb25zdCBTdHJpbmcmIGV4dGVuc2lvbiwgY29u c3QgU3RyaW5nJiB0aXRsZSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGNvbnN0 IFN0cmluZyYgdXJsLCBjb25zdCBTdHJpbmcmIHZpc2libGVVcmwsIFBhc3NSZWZQdHI8V2ViQ29y ZTo6U2hhcmVkQnVmZmVyPiBhcmNoaXZlQnVmZmVyKSA9IDA7CkluZGV4OiBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0 Mi9VSVByb2Nlc3MvV2ViUGFnZVByb3h5LmNwcAkocmV2aXNpb24gMTc2OTUwKQorKysgU291cmNl L1dlYktpdDIvVUlQcm9jZXNzL1dlYlBhZ2VQcm94eS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1 NzgsNiArMzU3OCw3IEBAIHZvaWQgV2ViUGFnZVByb3h5OjplZGl0b3JTdGF0ZUNoYW5nZWQoY28K ICNpZiBQTEFURk9STShNQUMpICYmICFVU0UoQVNZTkNfTlNURVhUSU5QVVRDTElFTlQpCiAgICAg Ym9vbCBjbG9zZWRDb21wb3NpdGlvbiA9ICFlZGl0b3JTdGF0ZS5zaG91bGRJZ25vcmVDb21wb3Np dGlvblNlbGVjdGlvbkNoYW5nZSAmJiAhZWRpdG9yU3RhdGUuaGFzQ29tcG9zaXRpb24gJiYgKG1f ZWRpdG9yU3RhdGUuaGFzQ29tcG9zaXRpb24gfHwgbV90ZW1wb3JhcmlseUNsb3NlZENvbXBvc2l0 aW9uKTsKICAgICBtX3RlbXBvcmFyaWx5Q2xvc2VkQ29tcG9zaXRpb24gPSBlZGl0b3JTdGF0ZS5z aG91bGRJZ25vcmVDb21wb3NpdGlvblNlbGVjdGlvbkNoYW5nZSAmJiAobV90ZW1wb3JhcmlseUNs b3NlZENvbXBvc2l0aW9uIHx8IG1fZWRpdG9yU3RhdGUuaGFzQ29tcG9zaXRpb24pICYmICFlZGl0 b3JTdGF0ZS5oYXNDb21wb3NpdGlvbjsKKyAgICBib29sIGVkaXRhYmlsaXR5Q2hhbmdlZCA9IG1f ZWRpdG9yU3RhdGUuaXNDb250ZW50RWRpdGFibGUgIT0gZWRpdG9yU3RhdGUuaXNDb250ZW50RWRp dGFibGU7CiAjZW5kaWYKIAogICAgIG1fZWRpdG9yU3RhdGUgPSBlZGl0b3JTdGF0ZTsKQEAgLTM1 OTQsNiArMzU5NSwxMCBAQCB2b2lkIFdlYlBhZ2VQcm94eTo6ZWRpdG9yU3RhdGVDaGFuZ2VkKGNv CiAjaWYgUExBVEZPUk0oTUFDKSAmJiAhVVNFKEFTWU5DX05TVEVYVElOUFVUQ0xJRU5UKQogICAg IGlmIChjbG9zZWRDb21wb3NpdGlvbikKICAgICAgICAgbV9wYWdlQ2xpZW50Lm5vdGlmeUlucHV0 Q29udGV4dEFib3V0RGlzY2FyZGVkQ29tcG9zaXRpb24oKTsKKyAgICBpZiAoZWRpdGFiaWxpdHlD aGFuZ2VkKSB7CisgICAgICAgIC8vIFRoaXMgaXMgb25seSBuZWVkZWQgaW4gc3luYyBjb2RlIHBh dGgsIGJlY2F1c2UgQXBwS2l0IGF1dG9tYXRpY2FsbHkgcmVmcmVzaGVzIGlucHV0IGNvbnRleHQg Zm9yIGFzeW5jIGNsaWVudHMgKDxyZGFyOi8vcHJvYmxlbS8xODYwNDM2MD4pLgorICAgICAgICBt X3BhZ2VDbGllbnQubm90aWZ5QXBwbGljYXRpb25BYm91dElucHV0Q29udGV4dENoYW5nZSgpOwor ICAgIH0KICAgICBpZiAoZWRpdG9yU3RhdGUuaGFzQ29tcG9zaXRpb24pIHsKICAgICAgICAgLy8g QWJhbmRvbiB0aGUgY3VycmVudCBpbmxpbmUgaW5wdXQgc2Vzc2lvbiBpZiBzZWxlY3Rpb24gY2hh bmdlZCBmb3IgYW55IG90aGVyIHJlYXNvbiBidXQgYW4gaW5wdXQgbWV0aG9kIGNoYW5naW5nIHRo ZSBjb21wb3NpdGlvbi4KICAgICAgICAgLy8gRklYTUU6IFRoaXMgbG9naWMgc2hvdWxkIGJlIGlu IFdlYkNvcmUsIG5vIG5lZWQgdG8gcm91bmQtdHJpcCB0byBVSSBwcm9jZXNzIHRvIGNhbmNlbCB0 aGUgY29tcG9zaXRpb24uCkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3MvbWFjL1BhZ2VD bGllbnRJbXBsLmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291cmNlL1dlYktpdDIvVUlQcm9jZXNzL21hYy9Q YWdlQ2xpZW50SW1wbC5oCShyZXZpc2lvbiAxNzY5NTApCisrKyBTb3VyY2UvV2ViS2l0Mi9VSVBy b2Nlc3MvbWFjL1BhZ2VDbGllbnRJbXBsLmgJKHdvcmtpbmcgY29weSkKQEAgLTk4LDYgKzk4LDkg QEAgcHJpdmF0ZToKICAgICB2aXJ0dWFsIHZvaWQgdXBkYXRlU2VjdXJlSW5wdXRTdGF0ZSgpIG92 ZXJyaWRlOwogICAgIHZpcnR1YWwgdm9pZCByZXNldFNlY3VyZUlucHV0U3RhdGUoKSBvdmVycmlk ZTsKICAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5SW5wdXRDb250ZXh0QWJvdXREaXNjYXJkZWRDb21w b3NpdGlvbigpIG92ZXJyaWRlOworI2lmIFBMQVRGT1JNKE1BQykgJiYgIVVTRShBU1lOQ19OU1RF WFRJTlBVVENMSUVOVCkKKyAgICB2aXJ0dWFsIHZvaWQgbm90aWZ5QXBwbGljYXRpb25BYm91dElu cHV0Q29udGV4dENoYW5nZSgpIG92ZXJyaWRlOworI2VuZGlmCiAKICAgICB2aXJ0dWFsIFdlYkNv cmU6OkZsb2F0UmVjdCBjb252ZXJ0VG9EZXZpY2VTcGFjZShjb25zdCBXZWJDb3JlOjpGbG9hdFJl Y3QmKTsKICAgICB2aXJ0dWFsIFdlYkNvcmU6OkZsb2F0UmVjdCBjb252ZXJ0VG9Vc2VyU3BhY2Uo Y29uc3QgV2ViQ29yZTo6RmxvYXRSZWN0Jik7CkluZGV4OiBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nl c3MvbWFjL1BhZ2VDbGllbnRJbXBsLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJLaXQyL1VJ UHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW0JKHJldmlzaW9uIDE3Njk1MCkKKysrIFNvdXJj ZS9XZWJLaXQyL1VJUHJvY2Vzcy9tYWMvUGFnZUNsaWVudEltcGwubW0JKHdvcmtpbmcgY29weSkK QEAgLTQxOCw2ICs0MTgsMTMgQEAgdm9pZCBQYWdlQ2xpZW50SW1wbDo6bm90aWZ5SW5wdXRDb250 ZXh0QQogICAgIFttX3drVmlldyBfbm90aWZ5SW5wdXRDb250ZXh0QWJvdXREaXNjYXJkZWRDb21w b3NpdGlvbl07CiB9CiAKKyNpZiBQTEFURk9STShNQUMpICYmICFVU0UoQVNZTkNfTlNURVhUSU5Q VVRDTElFTlQpCit2b2lkIFBhZ2VDbGllbnRJbXBsOjpub3RpZnlBcHBsaWNhdGlvbkFib3V0SW5w dXRDb250ZXh0Q2hhbmdlKCkKK3sKKyAgICBbTlNBcHAgdXBkYXRlV2luZG93c107Cit9CisjZW5k aWYKKwogRmxvYXRSZWN0IFBhZ2VDbGllbnRJbXBsOjpjb252ZXJ0VG9EZXZpY2VTcGFjZShjb25z dCBGbG9hdFJlY3QmIHJlY3QpCiB7CiAgICAgcmV0dXJuIFttX3drVmlldyBfY29udmVydFRvRGV2 aWNlU3BhY2U6cmVjdF07Cg==