139453 2014-12-09 11:19:06 -0800 REGRESSION (r173272): When open PDF from Safari in iBooks, title is replaced to “QuickLookPDF-s72DbgAU-1” 2014-12-09 16:35:15 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 koivisto webkit-unassigned ap psolanki yongjun_zhang oldest_to_newest 1053877 0 koivisto 2014-12-09 11:19:06 -0800 Bug in CFNetwork code path 1053882 1 242947 koivisto 2014-12-09 11:29:43 -0800 Created attachment 242947 patch 1053883 2 koivisto 2014-12-09 11:30:32 -0800 rdar://problem/19052192 1053896 3 242947 psolanki 2014-12-09 11:57:56 -0800 Comment on attachment 242947 patch View in context: https://bugs.webkit.org/attachment.cgi?id=242947&action=review > Source/WebCore/ChangeLog:4 > + https://bugs.webkit.org/show_bug.cgi?id=139453 Can you add the radar link here as well. 1053901 4 koivisto 2014-12-09 12:07:11 -0800 https://trac.webkit.org/r177031 1053941 5 242947 darin 2014-12-09 14:08:54 -0800 Comment on attachment 242947 patch View in context: https://bugs.webkit.org/attachment.cgi?id=242947&action=review > Source/WebCore/platform/network/cf/ResourceResponseCFNet.cpp:133 > - RetainPtr<CFStringRef> suggestedFilename = adoptCF(CFURLResponseCopySuggestedFilename(m_cfResponse.get())); > + RetainPtr<CFStringRef> suggestedFilename = adoptCF(CFURLResponseCopySuggestedFilename(cfURLResponse())); > return suggestedFilename.get(); I think that code like this reads better without a local RetainPtr variable: return adoptCF(CFURLResponseCopySuggestedFilename(cfURLResponse())).get(); In fact, I would write this: CFURLResponseRef underlyingResponse = cfURLResponse(); if (!underlyingResponse) return String(); return adoptCF(CFURLResponseCopySuggestedFilename(underlyingResponse)).get(); 1053988 6 koivisto 2014-12-09 16:35:15 -0800 > CFURLResponseRef underlyingResponse = cfURLResponse(); > if (!underlyingResponse) > return String(); > return adoptCF(CFURLResponseCopySuggestedFilename(underlyingResponse)).get(); I wouldn't call it 'underlying' though as it doesn't describe the role of a synthesized CFURLResponse very well. 242947 2014-12-09 11:29:43 -0800 2014-12-09 11:57:56 -0800 patch suggested-filename-cfnet.patch text/plain 1710 koivisto SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NzAyNykKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE2IEBACisyMDE0LTEyLTA5ICBBbnR0aSBL b2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4KKworICAgICAgICBSRUdSRVNTSU9OIChyMTczMjcy KTogV2hlbiBvcGVuIFBERiBmcm9tIFNhZmFyaSBpbiBpQm9va3MsIHRpdGxlIGlzIHJlcGxhY2Vk IHRvIOKAnFF1aWNrTG9va1BERi1zNzJEYmdBVS0x4oCdCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk0NTMKKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBQdWxsaW5nIHRoZSBzdWdnZXN0ZWQgZmlsZW5hbWUg ZnJvbSB0aGUgcGxhdGZvcm0gcmVzcG9uc2UgcmV0dXJuZWQgbnVsbCBzdHJpbmcgb24gVVNFKENG TkVUV09SSykgY29kZSBwYXRoCisgICAgICAgIGlmIGl0IHdhcyB0aGUgZmlyc3QgdGhpbmcgbmVl ZGVkIGZyb20gaXQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2NmL1Jlc291cmNlUmVz cG9uc2VDRk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZVJlc3BvbnNlOjpwbGF0 Zm9ybVN1Z2dlc3RlZEZpbGVuYW1lKTogVXNlIHRoZSBsYXp5IGFjY2Vzc29yLgorCiAyMDE0LTEy LTA5ICBKb2FubWFyaWUgRGlnZ3MgIDxqZGlnZ3NAaWdhbGlhLmNvbT4KIAogICAgICAgICBBWDog W0FUS10gTWF0aE1MIHRva2VucywgdGFibGVzLCBhbmQgcm93LWxpa2UgZWxlbWVudHMgYXJlIGV4 cG9zZWQgd2l0aCBBVEtfUk9MRV9VTktOT1dOCkluZGV4OiBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9y bS9uZXR3b3JrL2NmL1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9jZi9SZXNvdXJjZVJlc3BvbnNlQ0ZOZXQuY3Bw CShyZXZpc2lvbiAxNzcwMTIpCisrKyBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2Nm L1Jlc291cmNlUmVzcG9uc2VDRk5ldC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTEyNywxMCArMTI3 LDkgQEAgQ2VydGlmaWNhdGVJbmZvIFJlc291cmNlUmVzcG9uc2U6OnBsYXRmbwogCiBTdHJpbmcg UmVzb3VyY2VSZXNwb25zZTo6cGxhdGZvcm1TdWdnZXN0ZWRGaWxlbmFtZSgpIGNvbnN0CiB7Ci0g ICAgaWYgKCFtX2NmUmVzcG9uc2UpCisgICAgaWYgKCFjZlVSTFJlc3BvbnNlKCkpCiAgICAgICAg IHJldHVybiBTdHJpbmcoKTsKLQotICAgIFJldGFpblB0cjxDRlN0cmluZ1JlZj4gc3VnZ2VzdGVk RmlsZW5hbWUgPSBhZG9wdENGKENGVVJMUmVzcG9uc2VDb3B5U3VnZ2VzdGVkRmlsZW5hbWUobV9j ZlJlc3BvbnNlLmdldCgpKSk7CisgICAgUmV0YWluUHRyPENGU3RyaW5nUmVmPiBzdWdnZXN0ZWRG aWxlbmFtZSA9IGFkb3B0Q0YoQ0ZVUkxSZXNwb25zZUNvcHlTdWdnZXN0ZWRGaWxlbmFtZShjZlVS TFJlc3BvbnNlKCkpKTsKICAgICByZXR1cm4gc3VnZ2VzdGVkRmlsZW5hbWUuZ2V0KCk7CiB9CiAK