139434 2014-12-09 01:44:10 -0800 [CMAKE] bump GSTREAMER required version to 1.2.0 2014-12-09 02:15:57 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED INVALID P2 Minor --- 1 fvallee webkit-unassigned cgarcia jberta.u-szeged pnormand oldest_to_newest 1053699 0 fvallee 2014-12-09 01:44:10 -0800 Cmake is defined required version for gstreamer as "1.0.3" but it cannot compile anymore. Following commit: "[GStreamer] HTTP source element lacks SCHEDULING query support" http://trac.webkit.org/changeset/17656 is introducing "GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED" flags which is defined only in gstreamer >= 1.2.0 (https://developer.gnome.org/gstreamer/stable/gstreamer-GstQuery.html#GstSchedulingFlags) Jhbuild is using gtk: gstreamer 1.4.4 (https://bugs.webkit.org/show_bug.cgi?id=138866) efl: gstreamer1.2.1 (https://bugs.webkit.org/show_bug.cgi?id=125155) so it should be safe to set 1.2.0 required in cmake. 1053703 1 242897 fvallee 2014-12-09 01:55:06 -0800 Created attachment 242897 Patch 1053706 2 fvallee 2014-12-09 02:06:17 -0800 there is a typo in my previous comment, correct link to gstreamer patch introducing GST_SCHEDULING_FLAG_BANDWIDTH_LIMITED is : "[GStreamer] HTTP source element lacks SCHEDULING query support" http://trac.webkit.org/changeset/176561 1053708 3 242897 mrobinson 2014-12-09 02:10:17 -0800 Comment on attachment 242897 Patch We cannot bump the required version of GStreamer for WebKitGTK+, but we can use conditional compilation to enable features when compiling against a newer version. 1053709 4 pnormand 2014-12-09 02:12:35 -0800 Right, it was my mistake, the SCHEDULING query code should be guarded with a ifdef. 1053712 5 fvallee 2014-12-09 02:15:57 -0800 ok, use compile guards is indeed a very good solution ;) 242897 2014-12-09 01:55:06 -0800 2014-12-09 02:10:17 -0800 Patch bug-139434-20141209105546.patch text/plain 1940 fvallee ZGlmZiAtLWdpdCBhL1NvdXJjZS9jbWFrZS9PcHRpb25zRWZsLmNtYWtlIGIvU291cmNlL2NtYWtl L09wdGlvbnNFZmwuY21ha2UKaW5kZXggY2IwNDUwMGQ5M2MxMzZhM2EwN2FkOGZiOWE2Y2Y4OTY4 NzI4MjU3Mi4uN2E4MDBjNWFiN2VmNTQ1MTYyODZhNGU3OWI3ZmI2Zjk3NWRkMzlhOSAxMDA2NDQK LS0tIGEvU291cmNlL2NtYWtlL09wdGlvbnNFZmwuY21ha2UKKysrIGIvU291cmNlL2NtYWtlL09w dGlvbnNFZmwuY21ha2UKQEAgLTE5OSw3ICsxOTksNyBAQCBpZiAoRU5BQkxFX1ZJREVPIE9SIEVO QUJMRV9XRUJfQVVESU8pCiAgICAgICAgIGFkZF9kZWZpbml0aW9ucygtRFdURl9VU0VfV0VCQVVE SU9fR1NUUkVBTUVSPTEpCiAgICAgZW5kaWYgKCkKIAotICAgIGZpbmRfcGFja2FnZShHU3RyZWFt ZXIgMS4wLjUgUkVRVUlSRUQgQ09NUE9ORU5UUyAke0dTVFJFQU1FUl9DT01QT05FTlRTfSkKKyAg ICBmaW5kX3BhY2thZ2UoR1N0cmVhbWVyIDEuMi4wIFJFUVVJUkVEIENPTVBPTkVOVFMgJHtHU1RS RUFNRVJfQ09NUE9ORU5UU30pCiAKICAgICBpZiAoUENfR1NUUkVBTUVSX01QRUdUU19GT1VORCkK ICAgICAgICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9HU1RSRUFNRVJfTVBFR1RTKQpkaWZm IC0tZ2l0IGEvU291cmNlL2NtYWtlL09wdGlvbnNHVEsuY21ha2UgYi9Tb3VyY2UvY21ha2UvT3B0 aW9uc0dUSy5jbWFrZQppbmRleCA0NTYyOTlhODI0NGMyMWQzYjI1ZGVjMzE0NDMzODJiYTVlNWNm MWVhLi42ZjU5ZmI1ZTNmMTliMThmMDM5OWQ2YmEzZmYxY2Q3ZmM4ODQ1NzZlIDEwMDY0NAotLS0g YS9Tb3VyY2UvY21ha2UvT3B0aW9uc0dUSy5jbWFrZQorKysgYi9Tb3VyY2UvY21ha2UvT3B0aW9u c0dUSy5jbWFrZQpAQCAtMjMzLDcgKzIzMyw3IEBAIGlmIChFTkFCTEVfVklERU8gT1IgRU5BQkxF X1dFQl9BVURJTykKICAgICAgICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9XRUJBVURJT19H U1RSRUFNRVIpCiAgICAgZW5kaWYgKCkKIAotICAgIGZpbmRfcGFja2FnZShHU3RyZWFtZXIgMS4w LjMgUkVRVUlSRUQgQ09NUE9ORU5UUyAke0dTVFJFQU1FUl9DT01QT05FTlRTfSkKKyAgICBmaW5k X3BhY2thZ2UoR1N0cmVhbWVyIDEuMi4wIFJFUVVJUkVEIENPTVBPTkVOVFMgJHtHU1RSRUFNRVJf Q09NUE9ORU5UU30pCiAKICAgICBpZiAoUENfR1NUUkVBTUVSX01QRUdUU19GT1VORCkKICAgICAg ICAgYWRkX2RlZmluaXRpb25zKC1EV1RGX1VTRV9HU1RSRUFNRVJfTVBFR1RTKQpkaWZmIC0tZ2l0 IGEvQ2hhbmdlTG9nIGIvQ2hhbmdlTG9nCmluZGV4IDdkMDA4NDgxZGRkZjJmYmI3YTk0ZjRkNGIy NmJmYzAxYjZjZTI3ZmIuLjZkYjE5OWNjOTFiMGUyZjU1ZDc4NGUzZmU1ZDU1YjFmMzQwYjAyYTAg MTAwNjQ0Ci0tLSBhL0NoYW5nZUxvZworKysgYi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAor MjAxNC0xMi0wOSAgRmFiaWVuIFZhbGzDqWUgIDxmdmFsbGVlQGNvbm5lY3RlZC1sYWJzLmNvbT4K KworICAgICAgICBbQ01BS0VdIGJ1bXAgR1NUUkVBTUVSICByZXF1aXJlZCB2ZXJzaW9uIHRvIDEu Mi4wCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0xMzk0 MzQKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHc3RT Y2hlZHVsaW5nRmxhZ3MgR1NUX1NDSEVEVUxJTkdfRkxBR19CQU5EV0lEVEhfTElNSVRFRAorICAg ICAgICBpcyBkZWZpbmVkIHNpbmNlIGdzdCAxLjIKKworICAgICAgICAqIFNvdXJjZS9jbWFrZS9P cHRpb25zRWZsLmNtYWtlOgorICAgICAgICAqIFNvdXJjZS9jbWFrZS9PcHRpb25zR1RLLmNtYWtl OgorCiAyMDE0LTEyLTA3ICBBbGJlcnRvIEdhcmNpYSAgPGJlcnRvQGlnYWxpYS5jb20+CiAKICAg ICAgICAgW0dUS10gV2ViS2l0IGhhcyBhIG5ldyByZXF1aXJlZCBkZXBlbmRlbmN5IG9uIEdudVRM Uwo=