139420 2014-12-08 15:52:12 -0800 Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow() 2014-12-08 17:28:01 -0800 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cdumez cdumez commit-queue esprehn+autocc glenn hyatt kondapallykalyan simon.fraser oldest_to_newest 1053558 0 cdumez 2014-12-08 15:52:12 -0800 Move 'text-shadow' check from RenderStyle::changeRequiresLayout() to changeAffectsVisualOverflow(). This has no behavior change as changeRequiresLayout() calls changeAffectsVisualOverflow(). However, this is clearer as text-shadow affects the visual overflow (similarly to box-shadow). 1053567 1 242859 cdumez 2014-12-08 16:03:21 -0800 Created attachment 242859 Patch 1053603 2 242859 commit-queue 2014-12-08 17:27:54 -0800 Comment on attachment 242859 Patch Clearing flags on attachment: 242859 Committed r176998: <http://trac.webkit.org/changeset/176998> 1053605 3 commit-queue 2014-12-08 17:28:01 -0800 All reviewed patches have been landed. Closing bug. 242859 2014-12-08 16:03:21 -0800 2014-12-08 17:27:54 -0800 Patch bug-139420-20141208160400.patch text/plain 2589 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTYwCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMGZkN2M3OWY0YjkxZDY4 Nzg3NTZkNWEwM2M5YjU1ZTEyODgyM2M5MC4uMGIxYTNlYmVhMDA3ZjNmZmQ0ZDU4ZjUxMjI0ZTEy NjEwOTcxOWIzYiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIyIEBACisyMDE0LTEyLTA4ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgTW92ZSAndGV4dC1zaGFkb3cn IGNoZWNrIGZyb20gUmVuZGVyU3R5bGU6OmNoYW5nZVJlcXVpcmVzTGF5b3V0KCkgdG8gY2hhbmdl QWZmZWN0c1Zpc3VhbE92ZXJmbG93KCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTEzOTQyMAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIE1vdmUgJ3RleHQtc2hhZG93JyBjaGVjayBmcm9tIFJlbmRlclN0eWxl OjpjaGFuZ2VSZXF1aXJlc0xheW91dCgpIHRvCisgICAgICAgIGNoYW5nZUFmZmVjdHNWaXN1YWxP dmVyZmxvdygpLiBUaGlzIGhhcyBubyBiZWhhdmlvciBjaGFuZ2UgYXMKKyAgICAgICAgY2hhbmdl UmVxdWlyZXNMYXlvdXQoKSBjYWxscyBjaGFuZ2VBZmZlY3RzVmlzdWFsT3ZlcmZsb3coKS4gSG93 ZXZlciwKKyAgICAgICAgdGhpcyBpcyBjbGVhcmVyIGFzIHRleHQtc2hhZG93IGFmZmVjdHMgdGhl IHZpc3VhbCBvdmVyZmxvdyAoc2ltaWxhcmx5CisgICAgICAgIHRvIGJveC1zaGFkb3cpLgorCisg ICAgICAgIE5vIG5ldyB0ZXN0cywgbm8gYmVoYXZpb3IgY2hhbmdlLgorCisgICAgICAgICogcmVu ZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlbmRlclN0 eWxlOjpjaGFuZ2VBZmZlY3RzVmlzdWFsT3ZlcmZsb3cpOgorICAgICAgICAoV2ViQ29yZTo6UmVu ZGVyU3R5bGU6OmNoYW5nZVJlcXVpcmVzTGF5b3V0KToKKwogMjAxNC0xMi0wOCAgQ3NhYmEgT3N6 dHJvZ29uw6FjICA8b3NzeUB3ZWJraXQub3JnPgogCiAgICAgICAgIFVSVEJGIGFmdGVyIHIxNzY5 NTMsIGFkZCBhbiB1bnJlYWNoYWJsZSByZXR1cm4gdG8gbWFrZSBHQ0MgaGFwcHkuCmRpZmYgLS1n aXQgYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvUmVuZGVyU3R5bGUuY3BwIGIvU291 cmNlL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1JlbmRlclN0eWxlLmNwcAppbmRleCBiZDUyOTY3 OWExM2E0NTJkZjcyOTRhZGM3NmJkNzM2ZTFjZWMxNDQwLi5jZDM1Y2IzMWJiYzQzYjExYWFjOTBm YThhYmIyZmE3ODljNTc5NGJmIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcv c3R5bGUvUmVuZGVyU3R5bGUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmluZy9zdHls ZS9SZW5kZXJTdHlsZS5jcHAKQEAgLTM5Miw2ICszOTIsMTAgQEAgaW5saW5lIGJvb2wgUmVuZGVy U3R5bGU6OmNoYW5nZUFmZmVjdHNWaXN1YWxPdmVyZmxvdyhjb25zdCBSZW5kZXJTdHlsZSYgb3Ro ZXIpIGMKICAgICAgICAgJiYgIXJhcmVOb25Jbmhlcml0ZWREYXRhLT5zaGFkb3dEYXRhRXF1aXZh bGVudCgqb3RoZXIucmFyZU5vbkluaGVyaXRlZERhdGEuZ2V0KCkpKQogICAgICAgICByZXR1cm4g dHJ1ZTsKIAorICAgIGlmIChyYXJlSW5oZXJpdGVkRGF0YS5nZXQoKSAhPSBvdGhlci5yYXJlSW5o ZXJpdGVkRGF0YS5nZXQoKQorICAgICAgICAmJiAhcmFyZUluaGVyaXRlZERhdGEtPnNoYWRvd0Rh dGFFcXVpdmFsZW50KCpvdGhlci5yYXJlSW5oZXJpdGVkRGF0YS5nZXQoKSkpCisgICAgICAgIHJl dHVybiB0cnVlOworCiAgICAgaWYgKGluaGVyaXRlZF9mbGFncy5fdGV4dF9kZWNvcmF0aW9ucyAh PSBvdGhlci5pbmhlcml0ZWRfZmxhZ3MuX3RleHRfZGVjb3JhdGlvbnMKICAgICAgICAgfHwgdmlz dWFsLT50ZXh0RGVjb3JhdGlvbiAhPSBvdGhlci52aXN1YWwtPnRleHREZWNvcmF0aW9uCiAgICAg ICAgIHx8IHJhcmVOb25Jbmhlcml0ZWREYXRhLT5tX3RleHREZWNvcmF0aW9uU3R5bGUgIT0gb3Ro ZXIucmFyZU5vbkluaGVyaXRlZERhdGEtPm1fdGV4dERlY29yYXRpb25TdHlsZSkgewpAQCAtNTM0 LDkgKzUzOCw2IEBAIGJvb2wgUmVuZGVyU3R5bGU6OmNoYW5nZVJlcXVpcmVzTGF5b3V0KGNvbnN0 IFJlbmRlclN0eWxlJiBvdGhlciwgdW5zaWduZWQmIGNoYW5nCiAgICAgICAgICAgICB8fCByYXJl SW5oZXJpdGVkRGF0YS0+bGlzdFN0eWxlSW1hZ2UgIT0gb3RoZXIucmFyZUluaGVyaXRlZERhdGEt Pmxpc3RTdHlsZUltYWdlKQogICAgICAgICAgICAgcmV0dXJuIHRydWU7CiAKLSAgICAgICAgaWYg KCFyYXJlSW5oZXJpdGVkRGF0YS0+c2hhZG93RGF0YUVxdWl2YWxlbnQoKm90aGVyLnJhcmVJbmhl cml0ZWREYXRhLmdldCgpKSkKLSAgICAgICAgICAgIHJldHVybiB0cnVlOwotCiAgICAgICAgIGlm ICh0ZXh0U3Ryb2tlV2lkdGgoKSAhPSBvdGhlci50ZXh0U3Ryb2tlV2lkdGgoKSkKICAgICAgICAg ICAgIHJldHVybiB0cnVlOwogICAgIH0K