139408 2014-12-08 11:28:51 -0800 [iOS] Safari crashes at -[_NSUndoStack popAndInvoke] when trying to undo typing on closed tab 2014-12-08 13:53:30 -0800 1 1 1 Unclassified WebKit WebKit2 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mitz mitz andersca oldest_to_newest 1053452 0 mitz 2014-12-08 11:28:51 -0800 <rdar://problem/18046692> Steps to Reproduce: 1. Type something in an input field on a webpage 2. Enter tab view, and close the tab you just typed in 3. Go to another tab 4. Shake to bring up the Undo Typing dialog 5. Tap Undo Result: Crash beneath -[_NSUndoStack popAndInvoke]. 1053457 1 242834 mitz 2014-12-08 11:34:39 -0800 Created attachment 242834 Give each WKWebContentView an undo manager 1053460 2 andersca 2014-12-08 11:38:07 -0800 Should we do this on OS X as well? Should we do it on the WKWebVIew level instead? 1053467 3 mitz 2014-12-08 11:46:01 -0800 (In reply to comment #2) > Should we do this on OS X as well? I don’t know if this bug exists in OS X. The Legacy WebKit implementation of -undoManager differs between iOS and OS X. > Should we do it on the WKWebVIew level instead? I don’t know. This change appears to fix the bug as it is. 1053468 4 andersca 2014-12-08 11:48:02 -0800 (In reply to comment #3) > > Should we do it on the WKWebVIew level instead? > > I don’t know. This change appears to fix the bug as it is. OK. Do you think adding it to the content view instead of the WKWebView could cause any problems for people subclassing WKWebView and overriding -undoManager? 1053469 5 mitz 2014-12-08 11:49:59 -0800 (In reply to comment #4) > (In reply to comment #3) > > > > Should we do it on the WKWebVIew level instead? > > > > I don’t know. This change appears to fix the bug as it is. > > OK. Do you think adding it to the content view instead of the WKWebView > could cause any problems for people subclassing WKWebView and overriding > -undoManager? Functions in PageClientImplIOS.mm access the WKContentView’s undoManager property directly, so the implementation in the WKWebView subclass won’t be called. 1053509 6 mitz 2014-12-08 13:53:30 -0800 Fixed in <http://trac.webkit.org/r176969>. 242834 2014-12-08 11:34:39 -0800 2014-12-08 12:20:29 -0800 Give each WKWebContentView an undo manager bug-139408-20141208113518.patch text/plain 1961 mitz SW5kZXg6IFNvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi S2l0Mi9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Njk1OCkKKysrIFNvdXJjZS9XZWJLaXQyL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEyLTA4ICBEYW4gQmVy bnN0ZWluICA8bWl0ekBhcHBsZS5jb20+CisKKyAgICAgICAgPHJkYXI6Ly9wcm9ibGVtLzE4MDQ2 NjkyPiBbaU9TXSBTYWZhcmkgY3Jhc2hlcyBhdCAtW19OU1VuZG9TdGFjayBwb3BBbmRJbnZva2Vd IHdoZW4gdHJ5aW5nIHRvIHVuZG8gdHlwaW5nIG9uIGNsb3NlZCB0YWIKKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTQwOAorCisgICAgICAgIFJldmll d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogVUlQcm9jZXNzL2lvcy9XS0NvbnRl bnRWaWV3Lm1tOgorICAgICAgICAoLVtXS0NvbnRlbnRWaWV3IHVuZG9NYW5hZ2VyXSk6IE92ZXJy aWRlIHRvIGluaXRpYWxpemUgaWYgbmVjZXNzYXJ5IGFuZCByZXR1cm4gYSB1bmlxdWUgdW5kbwor ICAgICAgICBtYW5hZ2VyIGZvciB0aGlzIGluc3RhbmNlLiBUaGlzIGVuc3VyZXMgdGhhdCB1bmRv YWJsZSBvcGVyYXRpb25zIGZvciB0aGlzIHdlYnZpZXcgZG9u4oCZdCBnZXQKKyAgICAgICAgcHV0 IGluIG90aGVyIHVuZG8gbWFuYWdlcnMsIGFuZCBtYXRjaGVzIFVJV2ViVmlldyBiZWhhdmlvci4K KwogMjAxNC0xMi0wOCAgQW5kZXJzIENhcmxzc29uICA8YW5kZXJzY2FAYXBwbGUuY29tPgogCiAg ICAgICAgIEFkZCBhIHN0dWIgaW1wbGVtZW50YXRpb24gb2YgV2Vic2l0ZURhdGFTdG9yZTo6cmVt b3ZlRGF0YU1vZGlmaWVkU2luY2UKSW5kZXg6IFNvdXJjZS9XZWJLaXQyL1VJUHJvY2Vzcy9pb3Mv V0tDb250ZW50Vmlldy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2ViS2l0Mi9VSVByb2Nlc3Mv aW9zL1dLQ29udGVudFZpZXcubW0JKHJldmlzaW9uIDE3Njk1MikKKysrIFNvdXJjZS9XZWJLaXQy L1VJUHJvY2Vzcy9pb3MvV0tDb250ZW50Vmlldy5tbQkod29ya2luZyBjb3B5KQpAQCAtMTc4LDYg KzE3OCw4IEBAIC0gKGluc3RhbmNldHlwZSlpbml0V2l0aEZyYW1lOihDR1JlY3QpZnIKICAgICBS ZXRhaW5QdHI8V0tJbnNwZWN0b3JIaWdobGlnaHRWaWV3PiBfaW5zcGVjdG9ySGlnaGxpZ2h0Vmll dzsKIAogICAgIEhpc3RvcmljYWxWZWxvY2l0eURhdGEgX2hpc3RvcmljYWxLaW5lbWF0aWNEYXRh OworCisgICAgUmV0YWluUHRyPE5TVW5kb01hbmFnZXI+IF91bmRvTWFuYWdlcjsKIH0KIAogLSAo aW5zdGFuY2V0eXBlKWluaXRXaXRoRnJhbWU6KENHUmVjdClmcmFtZSBjb250ZXh0OihXZWJLaXQ6 OldlYkNvbnRleHQmKWNvbnRleHQgY29uZmlndXJhdGlvbjooV2ViS2l0OjpXZWJQYWdlQ29uZmln dXJhdGlvbil3ZWJQYWdlQ29uZmlndXJhdGlvbiB3ZWJWaWV3OihXS1dlYlZpZXcgKil3ZWJWaWV3 CkBAIC0zNzUsNiArMzc3LDE0IEBAIC0gKHZvaWQpZGlkWm9vbVRvU2NhbGU6KENHRmxvYXQpc2Nh bGUKICAgICBbc2VsZiBfZGlkRW5kU2Nyb2xsaW5nT3Jab29taW5nXTsKIH0KIAorLSAoTlNVbmRv TWFuYWdlciAqKXVuZG9NYW5hZ2VyCit7CisgICAgaWYgKCFfdW5kb01hbmFnZXIpCisgICAgICAg IF91bmRvTWFuYWdlciA9IGFkb3B0TlMoW1tOU1VuZG9NYW5hZ2VyIGFsbG9jXSBpbml0XSk7CisK KyAgICByZXR1cm4gX3VuZG9NYW5hZ2VyLmdldCgpOworfQorCiAjcHJhZ21hIG1hcmsgSW50ZXJu YWwKIAogLSAodm9pZClfd2luZG93RGlkTW92ZVRvU2NyZWVuTm90aWZpY2F0aW9uOihOU05vdGlm aWNhdGlvbiAqKW5vdGlmaWNhdGlvbgo=