139401 2014-12-08 08:42:56 -0800 Remove ResourceHandle::loadsBlocked() 2014-12-08 08:57:07 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 andersca andersca oldest_to_newest 1053387 0 andersca 2014-12-08 08:42:56 -0800 Remove ResourceHandle::loadsBlocked() 1053388 1 242814 andersca 2014-12-08 08:44:04 -0800 Created attachment 242814 Patch 1053391 2 242814 dbates 2014-12-08 08:56:35 -0800 Comment on attachment 242814 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242814&action=review > Source/WebCore/page/Chrome.cpp:230 > // If loads are blocked, we can't run modal because the contents > // of the modal dialog will never show up! Is this comment still relevant? Notice that it was added when we added the conjunct "!ResourceHandle::loadsBlocked()" in <http://trac.webkit.org/changeset/17577>. 1053392 3 andersca 2014-12-08 08:57:07 -0800 Committed r176949: <http://trac.webkit.org/changeset/176949> 242814 2014-12-08 08:44:04 -0800 2014-12-08 08:56:35 -0800 Patch bug-139401-20141208084445.patch text/plain 5435 andersca U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTQ4CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNTBlOTg2NThjMDJmOWJi ZWQzMTQyY2UwYmNmYmM2YWI0YTYzNjA3Zi4uNDM5M2YzYjQ2OWE1ZWU0Y2M1MTgxMGFlZTk3ZDg1 OGJjNjc0NWU4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI0IEBACisyMDE0LTEyLTA4ICBBbmRl cnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CisKKyAgICAgICAgUmVtb3ZlIFJlc291 cmNlSGFuZGxlOjpsb2Fkc0Jsb2NrZWQoKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9y Zy9zaG93X2J1Zy5jZ2k/aWQ9MTM5NDAxCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCisKKyAgICAgICAgVGhpcyBoYXNuJ3QgcmV0dXJuZWQgdHJ1ZSBzaW5jZSBMZW9wYXJk LCBzbyBnZXQgcmlkIG9mIGl0LgorCisgICAgICAgICogcGFnZS9DaHJvbWUuY3BwOgorICAgICAg ICAoV2ViQ29yZTo6Q2hyb21lOjpjYW5SdW5Nb2RhbE5vdyk6CisgICAgICAgICogcGxhdGZvcm0v bmV0d29yay9SZXNvdXJjZUhhbmRsZS5oOgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsvY2Yv UmVzb3VyY2VIYW5kbGVDRk5ldC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhhbmRs ZTo6bG9hZHNCbG9ja2VkKTogRGVsZXRlZC4KKyAgICAgICAgKiBwbGF0Zm9ybS9uZXR3b3JrL2N1 cmwvUmVzb3VyY2VIYW5kbGVDdXJsLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlJlc291cmNlSGFu ZGxlOjpsb2Fkc0Jsb2NrZWQpOiBEZWxldGVkLgorICAgICAgICAqIHBsYXRmb3JtL25ldHdvcmsv bWFjL1Jlc291cmNlSGFuZGxlTWFjLm1tOgorICAgICAgICAoV2ViQ29yZTo6UmVzb3VyY2VIYW5k bGU6OmxvYWRzQmxvY2tlZCk6IERlbGV0ZWQuCisgICAgICAgICogcGxhdGZvcm0vbmV0d29yay9z b3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZXNvdXJjZUhh bmRsZTo6bG9hZHNCbG9ja2VkKTogRGVsZXRlZC4KKwogMjAxNC0xMi0wOCAgQ2hyaXMgRmxlaXph Y2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIEFYOiBpT1M6IFZvaWNlT3ZlciBn ZXRzIGh1bmcgb24gc29tZSB3ZWJzaXRlcyBjb25zaXN0ZW50bHkuCmRpZmYgLS1naXQgYS9Tb3Vy Y2UvV2ViQ29yZS9wYWdlL0Nocm9tZS5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9wYWdlL0Nocm9tZS5j cHAKaW5kZXggM2YwM2IzNTA3NTY2NDRmYzI4OTU5ZWJmMzQyYmQzN2IxMGQzNjg2Yy4uMjM3ZmRi YjUzYmE1Yjk3YTA5OWJmN2VkYzkyYmRjZGZiYmNmOTYwZiAxMDA2NDQKLS0tIGEvU291cmNlL1dl YkNvcmUvcGFnZS9DaHJvbWUuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BhZ2UvQ2hyb21lLmNw cApAQCAtMjI4LDggKzIyOCw3IEBAIGJvb2wgQ2hyb21lOjpjYW5SdW5Nb2RhbE5vdygpIGNvbnN0 CiB7CiAgICAgLy8gSWYgbG9hZHMgYXJlIGJsb2NrZWQsIHdlIGNhbid0IHJ1biBtb2RhbCBiZWNh dXNlIHRoZSBjb250ZW50cwogICAgIC8vIG9mIHRoZSBtb2RhbCBkaWFsb2cgd2lsbCBuZXZlciBz aG93IHVwIQotICAgIHJldHVybiBjYW5SdW5Nb2RhbCgpICYmICFSZXNvdXJjZUhhbmRsZTo6bG9h ZHNCbG9ja2VkKCkKLSAgICAgICAgICAgJiYgY2FuUnVuTW9kYWxJZkR1cmluZ1BhZ2VEaXNtaXNz YWwobV9wYWdlLCBDaHJvbWVDbGllbnQ6OkhUTUxEaWFsb2csIFN0cmluZygpKTsKKyAgICByZXR1 cm4gY2FuUnVuTW9kYWwoKSAmJiBjYW5SdW5Nb2RhbElmRHVyaW5nUGFnZURpc21pc3NhbChtX3Bh Z2UsIENocm9tZUNsaWVudDo6SFRNTERpYWxvZywgU3RyaW5nKCkpOwogfQogCiB2b2lkIENocm9t ZTo6cnVuTW9kYWwoKSBjb25zdApkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9SZXNvdXJjZUhhbmRsZS5oIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29y ay9SZXNvdXJjZUhhbmRsZS5oCmluZGV4IDMzOTQ0ZGI3NzNlYjdmZTY0ZTk1ZjI3NjA4YTZiOTgx YjQ1YTcyODMuLjc4ZDhmZDM4NDE3YjQzZjI1NTI2ODY2NjFhNGM3NzE5ZmYyNzc4NTYgMTAwNjQ0 Ci0tLSBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdvcmsvUmVzb3VyY2VIYW5kbGUuaAor KysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL1Jlc291cmNlSGFuZGxlLmgKQEAg LTE5MCw5ICsxOTAsNiBAQCBwdWJsaWM6CiAgICAgZG91YmxlIG1fcmVxdWVzdFRpbWU7CiAjZW5k aWYKIAotICAgIC8vIFVzZWQgdG8gd29yayBhcm91bmQgdGhlIGZhY3QgdGhhdCB5b3UgZG9uJ3Qg Z2V0IGFueSBtb3JlIE5TVVJMQ29ubmVjdGlvbiBjYWxsYmFja3MgdW50aWwgeW91IHJldHVybiBm cm9tIHRoZSBvbmUgeW91J3JlIGluLgotICAgIHN0YXRpYyBib29sIGxvYWRzQmxvY2tlZCgpOyAg ICAKLQogICAgIGJvb2wgaGFzQXV0aGVudGljYXRpb25DaGFsbGVuZ2UoKSBjb25zdDsKICAgICB2 b2lkIGNsZWFyQXV0aGVudGljYXRpb24oKTsKICAgICBXRUJDT1JFX0VYUE9SVCB2aXJ0dWFsIHZv aWQgY2FuY2VsKCk7CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3Jr L2NmL1Jlc291cmNlSGFuZGxlQ0ZOZXQuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0 d29yay9jZi9SZXNvdXJjZUhhbmRsZUNGTmV0LmNwcAppbmRleCAyMzY0ZWIxY2U4NDY1NWE2ZTI4 ZWIwNmM2NGM2MWZkYTI2MTdmOGIxLi40MzAwYzJkZWE2ZGQ2MDYxNGZjMjU5MjI4MjRkNmI0NWMy NWY2YWNjIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL2NmL1Jl c291cmNlSGFuZGxlQ0ZOZXQuY3BwCisrKyBiL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL25ldHdv cmsvY2YvUmVzb3VyY2VIYW5kbGVDRk5ldC5jcHAKQEAgLTU3OSwxMSArNTc5LDYgQEAgdm9pZCBS ZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5nKGJvb2wgZGVmZXJzKQogICAg ICAgICBDRlVSTENvbm5lY3Rpb25SZXN1bWUoZC0+bV9jb25uZWN0aW9uLmdldCgpKTsKIH0KIAot Ym9vbCBSZXNvdXJjZUhhbmRsZTo6bG9hZHNCbG9ja2VkKCkKLXsKLSAgICByZXR1cm4gZmFsc2U7 Ci19Ci0KICNpZiBQTEFURk9STShDT0NPQSkKIHZvaWQgUmVzb3VyY2VIYW5kbGU6OnNjaGVkdWxl KFNjaGVkdWxlUGFpciYgcGFpcikKIHsKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRm b3JtL25ldHdvcmsvY3VybC9SZXNvdXJjZUhhbmRsZUN1cmwuY3BwIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3VybC5jcHAKaW5kZXggZTI5NjNl YTRjYzVhMjdhY2YwYjc0NWUwMjkxMjY1YzFkZmExYzEyMC4uODUxMzM3OGNiZDdlNjg5ZjA2MzU3 YjNmN2Q5ZDEzZmNlODQxZTA1YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v bmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3VybC5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vbmV0d29yay9jdXJsL1Jlc291cmNlSGFuZGxlQ3VybC5jcHAKQEAgLTE2NiwxMiAr MTY2LDYgQEAgdm9pZCBSZXNvdXJjZUhhbmRsZTo6cGxhdGZvcm1TZXREZWZlcnNMb2FkaW5nKGJv b2wgZGVmZXJzKQogICAgIH0KIH0KIAotYm9vbCBSZXNvdXJjZUhhbmRsZTo6bG9hZHNCbG9ja2Vk KCkKLXsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwotICAgIHJldHVybiBmYWxzZTsKLX0KLQogYm9v bCBSZXNvdXJjZUhhbmRsZTo6c2hvdWxkVXNlQ3JlZGVudGlhbFN0b3JhZ2UoKQogewogICAgIHJl dHVybiAoIWNsaWVudCgpIHx8IGNsaWVudCgpLT5zaG91bGRVc2VDcmVkZW50aWFsU3RvcmFnZSh0 aGlzKSkgJiYgZmlyc3RSZXF1ZXN0KCkudXJsKCkucHJvdG9jb2xJc0luSFRUUEZhbWlseSgpOwpk aWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vbmV0d29yay9tYWMvUmVzb3VyY2VI YW5kbGVNYWMubW0gYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJj ZUhhbmRsZU1hYy5tbQppbmRleCA2ZGUyMDY3ODEwNzNhN2RkNDgzM2RhOTJiMzFhNTI1MTM4ZTc2 MTNkLi40ZWI4MWIyZjY0MDE0YTVlYjNkZDNlYjZkM2YwNDk0ODdlYmEzMjdkIDEwMDY0NAotLS0g YS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRsZU1hYy5t bQorKysgYi9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9uZXR3b3JrL21hYy9SZXNvdXJjZUhhbmRs ZU1hYy5tbQpAQCAtMzgxLDExICszODEsNiBAQCBOU1VSTENvbm5lY3Rpb24gKlJlc291cmNlSGFu ZGxlOjpjb25uZWN0aW9uKCkgY29uc3QKICAgICByZXR1cm4gZC0+bV9jb25uZWN0aW9uLmdldCgp OwogfQogICAgIAotYm9vbCBSZXNvdXJjZUhhbmRsZTo6bG9hZHNCbG9ja2VkKCkKLXsKLSAgICBy ZXR1cm4gZmFsc2U7Ci19Ci0KIENGU3RyaW5nUmVmIFJlc291cmNlSGFuZGxlOjpzeW5jaHJvbm91 c0xvYWRSdW5Mb29wTW9kZSgpCiB7CiAgICAgcmV0dXJuIENGU1RSKCJXZWJDb3JlU3luY2hyb25v dXNMb2FkZXJSdW5Mb29wTW9kZSIpOwpkaWZmIC0tZ2l0IGEvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vbmV0d29yay9zb3VwL1Jlc291cmNlSGFuZGxlU291cC5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAppbmRleCAwOGNjYzEz MWE5N2VlNDNjOWNhZTkzYjljOGM3NDFmNzUwOGZkNTUxLi5mYTIxOWZjM2YxYWY1MzIxOTY5ZDJl NDMyNjcxOWI0Y2NmMWIwMTlkIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9u ZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcAorKysgYi9Tb3VyY2UvV2ViQ29yZS9w bGF0Zm9ybS9uZXR3b3JrL3NvdXAvUmVzb3VyY2VIYW5kbGVTb3VwLmNwcApAQCAtMTIzOSwxMSAr MTIzOSw2IEBAIHZvaWQgUmVzb3VyY2VIYW5kbGU6OnBsYXRmb3JtU2V0RGVmZXJzTG9hZGluZyhi b29sIGRlZmVyc0xvYWRpbmcpCiAgICAgfQogfQogCi1ib29sIFJlc291cmNlSGFuZGxlOjpsb2Fk c0Jsb2NrZWQoKQotewotICAgIHJldHVybiBmYWxzZTsKLX0KLQogdm9pZCBSZXNvdXJjZUhhbmRs ZTo6cGxhdGZvcm1Mb2FkUmVzb3VyY2VTeW5jaHJvbm91c2x5KE5ldHdvcmtpbmdDb250ZXh0KiBj b250ZXh0LCBjb25zdCBSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3QsIFN0b3JlZENyZWRlbnRpYWxz IHN0b3JlZENyZWRlbnRpYWxzLCBSZXNvdXJjZUVycm9yJiBlcnJvciwgUmVzb3VyY2VSZXNwb25z ZSYgcmVzcG9uc2UsIFZlY3RvcjxjaGFyPiYgZGF0YSkKIHsKICAgICBBU1NFUlQoIWxvYWRpbmdT eW5jaHJvbm91c1JlcXVlc3QpOwo=