139400 2014-12-08 08:41:10 -0800 [iOS] YouTube plug-in replacement should support partial urls 2014-12-08 14:55:34 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 eric.carlson eric.carlson ap commit-queue oldest_to_newest 1053386 0 eric.carlson 2014-12-08 08:41:10 -0800 Some sites use urls that begin with just "//" for YouTube iFrames, so the YouTube plug-in replacement should support them. 1053393 1 242816 eric.carlson 2014-12-08 08:57:31 -0800 Created attachment 242816 Proposed patch. 1053405 2 242816 ap 2014-12-08 09:24:44 -0800 Comment on attachment 242816 Proposed patch. View in context: https://bugs.webkit.org/attachment.cgi?id=242816&action=review > Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:289 > + if (srcString.startsWith("//")) > + srcURL = URL(URL(), "http:" + srcString); > + else > + srcURL = URL(URL(), srcString); This does not look right, because for https pages, it should almost certainly use https, too. I'm only guessing about what and Flash/YouTube do, my instinct is that we should use Document::completeURL to handle any relative URLs, not just those without a scheme. 1053505 3 eric.carlson 2014-12-08 13:44:20 -0800 (In reply to comment #2) > Comment on attachment 242816 [details] > Proposed patch. > > View in context: > https://bugs.webkit.org/attachment.cgi?id=242816&action=review > > > Source/WebCore/Modules/plugins/YouTubePluginReplacement.cpp:289 > > + if (srcString.startsWith("//")) > > + srcURL = URL(URL(), "http:" + srcString); > > + else > > + srcURL = URL(URL(), srcString); > > This does not look right, because for https pages, it should almost > certainly use https, too. > > I'm only guessing about what and Flash/YouTube do, my instinct is that we > should use Document::completeURL to handle any relative URLs, not just those > without a scheme. This is an excellent suggestion, thanks! 1053506 4 242845 eric.carlson 2014-12-08 13:45:11 -0800 Created attachment 242845 Updated patch. 1053537 5 242845 commit-queue 2014-12-08 14:55:31 -0800 Comment on attachment 242845 Updated patch. Clearing flags on attachment: 242845 Committed r176977: <http://trac.webkit.org/changeset/176977> 1053539 6 commit-queue 2014-12-08 14:55:34 -0800 All reviewed patches have been landed. Closing bug. 242816 2014-12-08 08:57:31 -0800 2014-12-08 13:45:11 -0800 Proposed patch. patch_2.txt text/plain 1465 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Njk0OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFlvdVR1YmUg cGx1Zy1pbiByZXBsYWNlbWVudCBzaG91bGQgc3VwcG9ydCBwYXJ0aWFsIHVybHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTQwMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9wbHVnaW5z L1lvdVR1YmVQbHVnaW5SZXBsYWNlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpZb3VUdWJl UGx1Z2luUmVwbGFjZW1lbnQ6OnlvdVR1YmVVUkwpOiBJZiBhIHVybCBiZWdpbnMgd2l0aCBqdXN0 ICIvLyIsIHByZXBlbmQgImh0dHAiLgorCiAyMDE0LTEyLTA4ICBDaHJpcyBGbGVpemFjaCAgPGNm bGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IGlPUzogVm9pY2VPdmVyIGdldHMgaHVu ZyBvbiBzb21lIHdlYnNpdGVzIGNvbnNpc3RlbnRseS4KSW5kZXg6IFNvdXJjZS9XZWJDb3JlL01v ZHVsZXMvcGx1Z2lucy9Zb3VUdWJlUGx1Z2luUmVwbGFjZW1lbnQuY3BwCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvcGx1Z2lucy9Zb3VUdWJlUGx1Z2luUmVwbGFjZW1lbnQu Y3BwCShyZXZpc2lvbiAxNzY4NDApCisrKyBTb3VyY2UvV2ViQ29yZS9Nb2R1bGVzL3BsdWdpbnMv WW91VHViZVBsdWdpblJlcGxhY2VtZW50LmNwcAkod29ya2luZyBjb3B5KQpAQCAtMjgyLDcgKzI4 MiwxMSBAQCBzdGF0aWMgVVJMIHByb2Nlc3NBbmRDcmVhdGVZb3VUdWJlVVJMKGNvCiAKIFN0cmlu ZyBZb3VUdWJlUGx1Z2luUmVwbGFjZW1lbnQ6OnlvdVR1YmVVUkwoY29uc3QgU3RyaW5nJiBzcmNT dHJpbmcpCiB7Ci0gICAgVVJMIHNyY1VSTChVUkwoKSwgc3JjU3RyaW5nKTsKKyAgICBVUkwgc3Jj VVJMOworICAgIGlmIChzcmNTdHJpbmcuc3RhcnRzV2l0aCgiLy8iKSkKKyAgICAgICAgc3JjVVJM ID0gVVJMKFVSTCgpLCAiaHR0cDoiICsgc3JjU3RyaW5nKTsKKyAgICBlbHNlCisgICAgICAgIHNy Y1VSTCA9IFVSTChVUkwoKSwgc3JjU3RyaW5nKTsKIAogICAgIGJvb2wgaXNZb3VUdWJlU2hvcnRl bmVkVVJMID0gZmFsc2U7CiAgICAgVVJMIHlvdVR1YmVVUkwgPSBwcm9jZXNzQW5kQ3JlYXRlWW91 VHViZVVSTChzcmNVUkwsIGlzWW91VHViZVNob3J0ZW5lZFVSTCk7Cg== 242845 2014-12-08 13:45:11 -0800 2014-12-08 14:55:31 -0800 Updated patch. patch_3.txt text/plain 1538 eric.carlson SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3Njk2OCkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTA4ICBFcmljIENh cmxzb24gIDxlcmljLmNhcmxzb25AYXBwbGUuY29tPgorCisgICAgICAgIFtpT1NdIFlvdVR1YmUg cGx1Zy1pbiByZXBsYWNlbWVudCBzaG91bGQgc3VwcG9ydCBwYXJ0aWFsIHVybHMKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTQwMAorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogTW9kdWxlcy9wbHVnaW5z L1lvdVR1YmVQbHVnaW5SZXBsYWNlbWVudC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpZb3VUdWJl UGx1Z2luUmVwbGFjZW1lbnQ6OnlvdVR1YmVVUkwpOiBDYWxsIERvY3VtZW50Ojpjb21wbGV0ZVVS TC4KKwogMjAxNC0xMi0wOCAgQ2hyaXMgRHVtZXogIDxjZHVtZXpAYXBwbGUuY29tPgogCiAgICAg ICAgIFJldmVydCByMTc2MjkzICYgcjE3NjI3NQpJbmRleDogU291cmNlL1dlYkNvcmUvTW9kdWxl cy9wbHVnaW5zL1lvdVR1YmVQbHVnaW5SZXBsYWNlbWVudC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL1dlYkNvcmUvTW9kdWxlcy9wbHVnaW5zL1lvdVR1YmVQbHVnaW5SZXBsYWNlbWVudC5jcHAJ KHJldmlzaW9uIDE3Njg0MCkKKysrIFNvdXJjZS9XZWJDb3JlL01vZHVsZXMvcGx1Z2lucy9Zb3VU dWJlUGx1Z2luUmVwbGFjZW1lbnQuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC0yOCw2ICsyOCw3IEBA CiAKICNpbmNsdWRlICJIVE1MSUZyYW1lRWxlbWVudC5oIgogI2luY2x1ZGUgIkhUTUxOYW1lcy5o IgorI2luY2x1ZGUgIkhUTUxQYXJzZXJJZGlvbXMuaCIKICNpbmNsdWRlICJIVE1MUGx1Z0luRWxl bWVudC5oIgogI2luY2x1ZGUgIlBhZ2UuaCIKICNpbmNsdWRlICJSZW5kZXJFbGVtZW50LmgiCkBA IC0yODIsNyArMjgzLDcgQEAgc3RhdGljIFVSTCBwcm9jZXNzQW5kQ3JlYXRlWW91VHViZVVSTChj bwogCiBTdHJpbmcgWW91VHViZVBsdWdpblJlcGxhY2VtZW50Ojp5b3VUdWJlVVJMKGNvbnN0IFN0 cmluZyYgc3JjU3RyaW5nKQogewotICAgIFVSTCBzcmNVUkwoVVJMKCksIHNyY1N0cmluZyk7Cisg ICAgVVJMIHNyY1VSTCA9IG1fcGFyZW50RWxlbWVudC0+ZG9jdW1lbnQoKS5jb21wbGV0ZVVSTChz dHJpcExlYWRpbmdBbmRUcmFpbGluZ0hUTUxTcGFjZXMoc3JjU3RyaW5nKSk7CiAKICAgICBib29s IGlzWW91VHViZVNob3J0ZW5lZFVSTCA9IGZhbHNlOwogICAgIFVSTCB5b3VUdWJlVVJMID0gcHJv Y2Vzc0FuZENyZWF0ZVlvdVR1YmVVUkwoc3JjVVJMLCBpc1lvdVR1YmVTaG9ydGVuZWRVUkwpOwo=