139366 2014-12-07 08:14:06 -0800 Remove the option to automatically update the GObject DOM bindings symbols file 2014-12-07 08:23:03 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 cgarcia webkit-unassigned gustavo oldest_to_newest 1053143 0 cgarcia 2014-12-07 08:14:06 -0800 It's currently broken, because symbols now need to be in a specific order. Now that the symbols file only contains stable API, it's not a problem to manually update it every time new API is added. 1053152 1 242744 cgarcia 2014-12-07 08:15:34 -0800 Created attachment 242744 Patch 1053154 2 cgarcia 2014-12-07 08:23:03 -0800 Committed r176923: <http://trac.webkit.org/changeset/176923> 242744 2014-12-07 08:15:34 -0800 2014-12-07 08:18:18 -0800 Patch wkdom-new-api.diff text/plain 3196 cgarcia ZGlmZiAtLWdpdCBhL1Rvb2xzL0NoYW5nZUxvZyBiL1Rvb2xzL0NoYW5nZUxvZwppbmRleCA5NGRl MTRlLi42MDhjMDEwIDEwMDY0NAotLS0gYS9Ub29scy9DaGFuZ2VMb2cKKysrIGIvVG9vbHMvQ2hh bmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAKIDIwMTQtMTItMDcgIENhcmxvcyBHYXJjaWEgQ2FtcG9z ICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCisgICAgICAgIFJlbW92ZSB0aGUgb3B0aW9uIHRvIGF1 dG9tYXRpY2FsbHkgdXBkYXRlIHRoZSBHT2JqZWN0IERPTSBiaW5kaW5ncyBzeW1ib2xzIGZpbGUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTM2Ngor CisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEl0J3MgY3Vy cmVudGx5IGJyb2tlbiwgYmVjYXVzZSBzeW1ib2xzIG5vdyBuZWVkIHRvIGJlIGluIGEKKyAgICAg ICAgc3BlY2lmaWMgb3JkZXIuIE5vdyB0aGF0IHRoZSBzeW1ib2xzIGZpbGUgb25seSBjb250YWlu cyBzdGFibGUKKyAgICAgICAgQVBJLCBpdCdzIG5vdCBhIHByb2JsZW0gdG8gbWFudWFsbHkgdXBk YXRlIGl0IGV2ZXJ5IHRpbWUgbmV3IEFQSQorICAgICAgICBpcyBhZGRlZC4KKworICAgICAgICAq IGd0ay9jaGVjay1mb3Itd2Via2l0ZG9tLWFwaS1icmVha3M6CisgICAgICAgIChyZWFkX2V4cGVj dGVkX2FwaSk6CisgICAgICAgIChjaGVja19hcGkpOgorICAgICAgICAod3JpdGVfZXhwZWN0ZWRf YXBpKTogRGVsZXRlZC4KKworMjAxNC0xMi0wNyAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2Fy Y2lhQGlnYWxpYS5jb20+CisKICAgICAgICAgW0dUS10gVXNlIEdNYWluTG9vcFNvdXJjZSBpbiBX ZWJLaXRUZXN0UnVubmVyCiAgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVn LmNnaT9pZD0xMzg4MzEKIApkaWZmIC0tZ2l0IGEvVG9vbHMvZ3RrL2NoZWNrLWZvci13ZWJraXRk b20tYXBpLWJyZWFrcyBiL1Rvb2xzL2d0ay9jaGVjay1mb3Itd2Via2l0ZG9tLWFwaS1icmVha3MK aW5kZXggMmY0MjM3Yi4uNzBlMGYyNCAxMDA3NTUKLS0tIGEvVG9vbHMvZ3RrL2NoZWNrLWZvci13 ZWJraXRkb20tYXBpLWJyZWFrcworKysgYi9Ub29scy9ndGsvY2hlY2stZm9yLXdlYmtpdGRvbS1h cGktYnJlYWtzCkBAIC0xNiw3ICsxNiw2IEBACiAjIExpY2Vuc2UgYWxvbmcgd2l0aCB0aGlzIGxp YnJhcnk7IGlmIG5vdCwgd3JpdGUgdG8gdGhlIEZyZWUgU29mdHdhcmUKICMgRm91bmRhdGlvbiwg SW5jLiwgNTEgRnJhbmtsaW4gU3RyZWV0LCBGaWZ0aCBGbG9vciwgQm9zdG9uLCBNQSAgMDIxMTAt MTMwMSAgVVNBCiAKLWltcG9ydCBhcmdwYXJzZQogaW1wb3J0IGNvbW1vbgogaW1wb3J0IG9zCiBp bXBvcnQgc3lzCkBAIC0zNSwxMSArMzQsNyBAQCBkZWYgcmVhZF9leHBlY3RlZF9hcGkoKToKICAg ICB3aXRoIG9wZW4oRVhQRUNURURfQVBJX1BBVEgpIGFzIGZpbGVfaGFuZGxlOgogICAgICAgICBy ZXR1cm4gc2V0KGZpbGVfaGFuZGxlLnJlYWRsaW5lcygpKQogCi1kZWYgd3JpdGVfZXhwZWN0ZWRf YXBpKG5ld19leHBlY3RlZF9hcGkpOgotICAgIHdpdGggb3BlbihFWFBFQ1RFRF9BUElfUEFUSCwg J3cnKSBhcyBmaWxlX2hhbmRsZToKLSAgICAgICAgZmlsZV9oYW5kbGUud3JpdGVsaW5lcyhuZXdf ZXhwZWN0ZWRfYXBpKQotCi1kZWYgY2hlY2tfYXBpKG9wdGlvbnMsIGV4cGVjdGVkX2FwaSwgYnVp bHRfYXBpKToKK2RlZiBjaGVja19hcGkoZXhwZWN0ZWRfYXBpLCBidWlsdF9hcGkpOgogICAgIG1p c3NpbmdfYXBpID0gZXhwZWN0ZWRfYXBpLmRpZmZlcmVuY2UoYnVpbHRfYXBpKQogICAgIG5ld19h cGkgPSBidWlsdF9hcGkuZGlmZmVyZW5jZShleHBlY3RlZF9hcGkpCiAKQEAgLTU3LDIyICs1Miwx MiBAQCBkZWYgY2hlY2tfYXBpKG9wdGlvbnMsIGV4cGVjdGVkX2FwaSwgYnVpbHRfYXBpKToKICAg ICAgICAgIyBET00gYmluZGluZ3MgQVBJIHZhcmllcyBkZXBlbmRpbmcgb24gdGhlIGNvbXBpbGF0 aW9uIG9wdGlvbnMuCiAgICAgICAgICMgU28gdGhpcyBzaG91bGRuJ3QgYmUgbWFkZSBmYXRhbCB1 bnRpbCB3ZSBmaWd1cmUgb3V0IGEgd2F5IHRvIGhhbmRsZSBpdC4KICAgICAgICAgIyBTZWUgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEyMTQ4MQotICAgICAgICBzeXMu c3RkZXJyLndyaXRlKCJSZS1hZGQgdGhlIG1pc3NpbmcgQVBJIGFuZCByZXJ1biB0aGUgJXMuXG4i ICUgX19maWxlX18pCiAgICAgICAgIHJldHVybiAwCiAKICAgICBpZiBuZXdfYXBpOgotICAgICAg ICBpZiBvcHRpb25zLnJlc2V0X3Jlc3VsdHM6Ci0gICAgICAgICAgICBzeXMuc3Rkb3V0LndyaXRl KCJSZXNldHRpbmcgZXhwZWN0ZWQgQVBJXG4iKQotICAgICAgICAgICAgd3JpdGVfZXhwZWN0ZWRf YXBpKGJ1aWx0X2FwaSkKLSAgICAgICAgZWxzZToKLSAgICAgICAgICAgIHN5cy5zdGRvdXQud3Jp dGUoIkFQSSBjb21wYXRpYmxlIGNoYW5nZXMgZm91bmQgaW4gR09iamVjdCBET00gYmluZGluZ3Mu XG4iKQotICAgICAgICAgICAgc3lzLnN0ZG91dC53cml0ZSgiVG8gdXBkYXRlIHRoZSBzeW1ib2xz IGZpbGUsIHJ1biAlcyAtLXJlc2V0LXJlc3VsdHMuXG4iICUgX19maWxlX18pCisgICAgICAgIHN5 cy5zdGRvdXQud3JpdGUoIkFQSSBjb21wYXRpYmxlIGNoYW5nZXMgZm91bmQgaW4gR09iamVjdCBE T00gYmluZGluZ3MuXG4iKQogCiAgICAgcmV0dXJuIDAKIAogaWYgX19uYW1lX18gPT0gJ19fbWFp bl9fJzoKLSAgICBwYXJzZXIgPSBhcmdwYXJzZS5Bcmd1bWVudFBhcnNlcihkZXNjcmlwdGlvbj0n RGV0ZWN0IEFQSSBicmVha2FnZSBpbiB0aGUgV2ViS2l0R1RLKyBHT2JqZWN0IERPTSBiaW5kaW5n cy4nKQotICAgIHBhcnNlci5hZGRfYXJndW1lbnQoJy0tcmVzZXQtcmVzdWx0cycsIGFjdGlvbj0n c3RvcmVfdHJ1ZScsCi0gICAgICAgICAgICAgICAgICAgICAgICBoZWxwPSdXaGVuIHNwZWNpZmll ZCwgcmVzdCB0aGUgZXhwZWN0ZWQgcmVzdWx0cyBmaWxlIHdpdGggdGhlIGJ1aWx0IHJlc3VsdHMu JykKLSAgICBvcHRpb25zID0gcGFyc2VyLnBhcnNlX2FyZ3MoKQotICAgIHN5cy5leGl0KGNoZWNr X2FwaShvcHRpb25zLCByZWFkX2V4cGVjdGVkX2FwaSgpLCByZWFkX2J1aWx0X2FwaSgpKSkKKyAg ICBzeXMuZXhpdChjaGVja19hcGkocmVhZF9leHBlY3RlZF9hcGkoKSwgcmVhZF9idWlsdF9hcGko KSkpCg==