139360 2014-12-07 04:28:42 -0800 [GStreamer] Use audio-filter property for pitch-preserving element 2014-12-08 01:22:59 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Trivial --- 1 slomo slomo commit-queue oldest_to_newest 1053115 0 slomo 2014-12-07 04:28:42 -0800 Patch coming in a second. Together with my next change this allows us to use playbin's special sink selection mechanisms, which will allow us to automatically use sinks that handle compressed input if possible. But even alone it makes the code a bit simpler (once we can depend on >= 1.4.2). 1053116 1 242739 slomo 2014-12-07 04:30:48 -0800 Created attachment 242739 Patch 1053173 2 242739 gustavo 2014-12-07 10:08:44 -0800 Comment on attachment 242739 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242739&action=review > Source/WebCore/platform/graphics/gstreamer/MediaPlayerPrivateGStreamer.cpp:1834 > + // On 1.4.2 and newer we use the audio-filter property instead Nit: missing full stop. 1053188 3 242757 slomo 2014-12-07 10:41:42 -0800 Created attachment 242757 Patch 1053312 4 242757 commit-queue 2014-12-08 01:22:56 -0800 Comment on attachment 242757 Patch Clearing flags on attachment: 242757 Committed r176939: <http://trac.webkit.org/changeset/176939> 1053313 5 commit-queue 2014-12-08 01:22:59 -0800 All reviewed patches have been landed. Closing bug. 242739 2014-12-07 04:30:48 -0800 2014-12-07 10:41:37 -0800 Patch bug-139360-20141207133212.patch text/plain 3022 slomo U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMzOWQ3Y2ViOTVjMDRh ZmMwNTVhMzFkNDY0ZjA3NTFjOGM2ZTk0MC4uOWQxYjg1MTgxNzIxNmQ2MDZiYzMxMjBlMTYyNGIz NDQ3YTEwY2NjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTEyLTA3ICBTZWJh c3RpYW4gRHLDtmdlICA8c2ViYXN0aWFuQGNlbnRyaWN1bGFyLmNvbT4KKworICAgICAgICBbR1N0 cmVhbWVyXSBVc2UgYXVkaW8tZmlsdGVyIHByb3BlcnR5IG9uIEdTdHJlYW1lciA+PSAxLjQuMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MzYwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRlQXVkaW9T aW5rKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3Jl YXRlR1NUUGxheUJpbik6CisgICAgICAgIFNpbmNlIDEuNC4wIHRoZXJlIGlzIGFuIGF1ZGlvLWZp bHRlciBwcm9wZXJ0eSB3ZSBjYW4gdXNlIHRvIHBsYWNlCisgICAgICAgIHRoZSBwaXRjaC1wcmVz ZXJ2aW5nIGZpbHRlciBhdCBhIG1vcmUgY2Fub25pY2FsIHBvc2l0aW9uIGluc2lkZQorICAgICAg ICB0aGUgcGlwZWxpbmUuIFNpbmNlIDEuNC4yIHRoaXMgcHJvcGVydHkgYWxzbyBoYW5kbGVzIGFs bCBuZWNlc3NhcnkKKyAgICAgICAgY29udmVyc2lvbnMgZm9yIHVzLgorICAgICAgICBUaGlzIHNp bXBsaWZpZXMgb3VyIHNpbmsgY29kZSBhIGJpdCBiZWNhdXNlIHdlIGRvbid0IGhhdmUgdG8gY3Jl YXRlCisgICAgICAgIGEgY3VzdG9tIHNpbmsgYmluIGFueW1vcmUuCisKIDIwMTQtMTItMDcgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd IE1pc3NpbmcgQVBJIGRldGVjdGVkIGluIEdPYmplY3QgRE9NIGJpbmRpbmdzIGFmdGVyIHIxNzY2 MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5k ZXggZmNiYzZlMTUwMTgwMTRhNjA5OGI0Y2E5MmViNGNmYTk0NzJhMDY3ZC4uMjI3NmRiMzk0MDgy NjgzYmNkZWZlOTgzY2RjODViZTg2ZmFiMGE4NSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTE4MzEsNiArMTgzMSwxMCBAQCBHc3RFbGVt ZW50KiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmNyZWF0ZUF1ZGlvU2luaygpCiAgICAg aWYgKCFtX3ByZXNlcnZlc1BpdGNoKQogICAgICAgICByZXR1cm4gbV9hdXRvQXVkaW9TaW5rLmdl dCgpOwogCisgICAgLy8gT24gMS40LjIgYW5kIG5ld2VyIHdlIHVzZSB0aGUgYXVkaW8tZmlsdGVy IHByb3BlcnR5IGluc3RlYWQKKyAgICBpZiAod2Via2l0R3N0Q2hlY2tWZXJzaW9uKDEsIDQsIDIp KQorICAgICAgICByZXR1cm4gbV9hdXRvQXVkaW9TaW5rLmdldCgpOworCiAgICAgR3N0RWxlbWVu dCogc2NhbGUgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2UoInNjYWxldGVtcG8iLCAwKTsKICAg ICBpZiAoIXNjYWxlKSB7CiAgICAgICAgIEdTVF9XQVJOSU5HKCJGYWlsZWQgdG8gY3JlYXRlIHNj YWxldGVtcG8iKTsKQEAgLTE5MDIsNiArMTkwNiwxOCBAQCB2b2lkIE1lZGlhUGxheWVyUHJpdmF0 ZUdTdHJlYW1lcjo6Y3JlYXRlR1NUUGxheUJpbigpCiAKICAgICBnX29iamVjdF9zZXQobV9wbGF5 QmluLmdldCgpLCAidmlkZW8tc2luayIsIGNyZWF0ZVZpZGVvU2luaygpLCAiYXVkaW8tc2luayIs IGNyZWF0ZUF1ZGlvU2luaygpLCBudWxscHRyKTsKIAorICAgIC8vIE9uIDEuNC4yIGFuZCBuZXdl ciB3ZSB1c2UgdGhlIGF1ZGlvLWZpbHRlciBwcm9wZXJ0eSBpbnN0ZWFkCisgICAgLy8gU2VlIGh0 dHBzOi8vYnVnemlsbGEuZ25vbWUub3JnL3Nob3dfYnVnLmNnaT9pZD03MzU3NDggZm9yCisgICAg Ly8gdGhlIHJlYXNvbiBmb3IgdXNpbmcgPj0gMS40LjIgaW5zdGVhZCBvZiA+PSAxLjQuMC4KKyAg ICBpZiAobV9wcmVzZXJ2ZXNQaXRjaCAmJiB3ZWJraXRHc3RDaGVja1ZlcnNpb24oMSwgNCwgMikp IHsKKyAgICAgICAgR3N0RWxlbWVudCogc2NhbGUgPSBnc3RfZWxlbWVudF9mYWN0b3J5X21ha2Uo InNjYWxldGVtcG8iLCAwKTsKKworICAgICAgICBpZiAoIXNjYWxlKQorICAgICAgICAgICAgR1NU X1dBUk5JTkcoIkZhaWxlZCB0byBjcmVhdGUgc2NhbGV0ZW1wbyIpOworICAgICAgICBlbHNlCisg ICAgICAgICAgICBnX29iamVjdF9zZXQobV9wbGF5QmluLmdldCgpLCAiYXVkaW8tZmlsdGVyIiwg c2NhbGUsIG51bGxwdHIpOworICAgIH0KKwogICAgIEdSZWZQdHI8R3N0UGFkPiB2aWRlb1NpbmtQ YWQgPSBhZG9wdEdSZWYoZ3N0X2VsZW1lbnRfZ2V0X3N0YXRpY19wYWQobV93ZWJraXRWaWRlb1Np bmsuZ2V0KCksICJzaW5rIikpOwogICAgIGlmICh2aWRlb1NpbmtQYWQpCiAgICAgICAgIGdfc2ln bmFsX2Nvbm5lY3QodmlkZW9TaW5rUGFkLmdldCgpLCAibm90aWZ5OjpjYXBzIiwgR19DQUxMQkFD SyhtZWRpYVBsYXllclByaXZhdGVWaWRlb1NpbmtDYXBzQ2hhbmdlZENhbGxiYWNrKSwgdGhpcyk7 Cg== 242757 2014-12-07 10:41:42 -0800 2014-12-08 01:22:56 -0800 Patch bug-139360-20141207194306.patch text/plain 3024 slomo U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTE5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggODMzOWQ3Y2ViOTVjMDRh ZmMwNTVhMzFkNDY0ZjA3NTFjOGM2ZTk0MC4uOWQxYjg1MTgxNzIxNmQ2MDZiYzMxMjBlMTYyNGIz NDQ3YTEwY2NjYSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisyMDE0LTEyLTA3ICBTZWJh c3RpYW4gRHLDtmdlICA8c2ViYXN0aWFuQGNlbnRyaWN1bGFyLmNvbT4KKworICAgICAgICBbR1N0 cmVhbWVyXSBVc2UgYXVkaW8tZmlsdGVyIHByb3BlcnR5IG9uIEdTdHJlYW1lciA+PSAxLjQuMgor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MzYwCisK KyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAg ICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3JlYXRlQXVkaW9T aW5rKToKKyAgICAgICAgKFdlYkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6Y3Jl YXRlR1NUUGxheUJpbik6CisgICAgICAgIFNpbmNlIDEuNC4wIHRoZXJlIGlzIGFuIGF1ZGlvLWZp bHRlciBwcm9wZXJ0eSB3ZSBjYW4gdXNlIHRvIHBsYWNlCisgICAgICAgIHRoZSBwaXRjaC1wcmVz ZXJ2aW5nIGZpbHRlciBhdCBhIG1vcmUgY2Fub25pY2FsIHBvc2l0aW9uIGluc2lkZQorICAgICAg ICB0aGUgcGlwZWxpbmUuIFNpbmNlIDEuNC4yIHRoaXMgcHJvcGVydHkgYWxzbyBoYW5kbGVzIGFs bCBuZWNlc3NhcnkKKyAgICAgICAgY29udmVyc2lvbnMgZm9yIHVzLgorICAgICAgICBUaGlzIHNp bXBsaWZpZXMgb3VyIHNpbmsgY29kZSBhIGJpdCBiZWNhdXNlIHdlIGRvbid0IGhhdmUgdG8gY3Jl YXRlCisgICAgICAgIGEgY3VzdG9tIHNpbmsgYmluIGFueW1vcmUuCisKIDIwMTQtMTItMDcgIENh cmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgogCiAgICAgICAgIFtHVEtd IE1pc3NpbmcgQVBJIGRldGVjdGVkIGluIEdPYmplY3QgRE9NIGJpbmRpbmdzIGFmdGVyIHIxNzY2 MzAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1l ci9NZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5k ZXggZmNiYzZlMTUwMTgwMTRhNjA5OGI0Y2E5MmViNGNmYTk0NzJhMDY3ZC4uM2EwMDQ2YWE0MTk5 NzNkYjhmZmFjNWRhNDIwYzBmNjdiMzUwNTI4NyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUv cGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5j cHAKKysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlh UGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTE4MzEsNiArMTgzMSwxMCBAQCBHc3RFbGVt ZW50KiBNZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXI6OmNyZWF0ZUF1ZGlvU2luaygpCiAgICAg aWYgKCFtX3ByZXNlcnZlc1BpdGNoKQogICAgICAgICByZXR1cm4gbV9hdXRvQXVkaW9TaW5rLmdl dCgpOwogCisgICAgLy8gT24gMS40LjIgYW5kIG5ld2VyIHdlIHVzZSB0aGUgYXVkaW8tZmlsdGVy IHByb3BlcnR5IGluc3RlYWQuCisgICAgaWYgKHdlYmtpdEdzdENoZWNrVmVyc2lvbigxLCA0LCAy KSkKKyAgICAgICAgcmV0dXJuIG1fYXV0b0F1ZGlvU2luay5nZXQoKTsKKwogICAgIEdzdEVsZW1l bnQqIHNjYWxlID0gZ3N0X2VsZW1lbnRfZmFjdG9yeV9tYWtlKCJzY2FsZXRlbXBvIiwgMCk7CiAg ICAgaWYgKCFzY2FsZSkgewogICAgICAgICBHU1RfV0FSTklORygiRmFpbGVkIHRvIGNyZWF0ZSBz Y2FsZXRlbXBvIik7CkBAIC0xOTAyLDYgKzE5MDYsMTggQEAgdm9pZCBNZWRpYVBsYXllclByaXZh dGVHU3RyZWFtZXI6OmNyZWF0ZUdTVFBsYXlCaW4oKQogCiAgICAgZ19vYmplY3Rfc2V0KG1fcGxh eUJpbi5nZXQoKSwgInZpZGVvLXNpbmsiLCBjcmVhdGVWaWRlb1NpbmsoKSwgImF1ZGlvLXNpbmsi LCBjcmVhdGVBdWRpb1NpbmsoKSwgbnVsbHB0cik7CiAKKyAgICAvLyBPbiAxLjQuMiBhbmQgbmV3 ZXIgd2UgdXNlIHRoZSBhdWRpby1maWx0ZXIgcHJvcGVydHkgaW5zdGVhZC4KKyAgICAvLyBTZWUg aHR0cHM6Ly9idWd6aWxsYS5nbm9tZS5vcmcvc2hvd19idWcuY2dpP2lkPTczNTc0OCBmb3IKKyAg ICAvLyB0aGUgcmVhc29uIGZvciB1c2luZyA+PSAxLjQuMiBpbnN0ZWFkIG9mID49IDEuNC4wLgor ICAgIGlmIChtX3ByZXNlcnZlc1BpdGNoICYmIHdlYmtpdEdzdENoZWNrVmVyc2lvbigxLCA0LCAy KSkgeworICAgICAgICBHc3RFbGVtZW50KiBzY2FsZSA9IGdzdF9lbGVtZW50X2ZhY3RvcnlfbWFr ZSgic2NhbGV0ZW1wbyIsIDApOworCisgICAgICAgIGlmICghc2NhbGUpCisgICAgICAgICAgICBH U1RfV0FSTklORygiRmFpbGVkIHRvIGNyZWF0ZSBzY2FsZXRlbXBvIik7CisgICAgICAgIGVsc2UK KyAgICAgICAgICAgIGdfb2JqZWN0X3NldChtX3BsYXlCaW4uZ2V0KCksICJhdWRpby1maWx0ZXIi LCBzY2FsZSwgbnVsbHB0cik7CisgICAgfQorCiAgICAgR1JlZlB0cjxHc3RQYWQ+IHZpZGVvU2lu a1BhZCA9IGFkb3B0R1JlZihnc3RfZWxlbWVudF9nZXRfc3RhdGljX3BhZChtX3dlYmtpdFZpZGVv U2luay5nZXQoKSwgInNpbmsiKSk7CiAgICAgaWYgKHZpZGVvU2lua1BhZCkKICAgICAgICAgZ19z aWduYWxfY29ubmVjdCh2aWRlb1NpbmtQYWQuZ2V0KCksICJub3RpZnk6OmNhcHMiLCBHX0NBTExC QUNLKG1lZGlhUGxheWVyUHJpdmF0ZVZpZGVvU2lua0NhcHNDaGFuZ2VkQ2FsbGJhY2spLCB0aGlz KTsK