139358 2014-12-07 04:16:20 -0800 [SOUP] Layout test http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html fails 2016-11-05 00:59:58 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 clopez webkit-unassigned ap bugs-noreply cgarcia mrobinson thorton oldest_to_newest 1053113 0 clopez 2014-12-07 04:16:20 -0800 Since r176752 <http://trac.webkit.org/r176752> the layout test http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials.html is failing on platform GTK. The diff is (after 176757 <http://trac.webkit.org/176757>): https://build.webkit.org/results/GTK%20Linux%2064-bit%20Release%20%28Tests%29/r176761%20%284606%29/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-pretty-diff.html 1053147 1 clopez 2014-12-07 08:15:09 -0800 Marked accordingly on the GTK expectations on https://trac.webkit.org/r176922 1053170 2 ap 2014-12-07 09:49:01 -0800 Does Gtk have custom results for this test? I wonder if it actually started to pass. 1053179 3 clopez 2014-12-07 10:27:01 -0800 (In reply to comment #2) > Does Gtk have custom results for this test? I wonder if it actually started > to pass. It don't has (AFAIK). It is using the expected file for WK2 <LayoutTests/platform/wk2/http/tests/misc/authentication-redirect-3/authentication-sent-to-redirect-same-origin-with-location-credentials-expected.txt> that was added on 176757 <http://trac.webkit.org/176757> 1248116 4 cgarcia 2016-11-04 07:37:18 -0700 The diff at that time is no longer available, so I don't know if we are still failing for the same reason, but what I know id the reason why we currently do this wrong is not a regression introduced in r176752. The problem is that credentials cached in WebCore take precedence over credentials provided in the URL in case of redirection. 1248118 5 293887 cgarcia 2016-11-04 07:42:40 -0700 Created attachment 293887 Patch 1248463 6 cgarcia 2016-11-05 00:59:58 -0700 Committed r208416: <http://trac.webkit.org/changeset/208416> 293887 2016-11-04 07:42:40 -0700 2016-11-04 08:32:52 -0700 Patch wk2-http-auth.diff text/plain 4045 cgarcia ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA1NTVkMDA3Li5hMTE5NzhkIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTYtMTEt MDQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29tPgorCisgICAgICAg IFtTT1VQXSBMYXlvdXQgdGVzdCBodHRwL3Rlc3RzL21pc2MvYXV0aGVudGljYXRpb24tcmVkaXJl Y3QtMy9hdXRoZW50aWNhdGlvbi1zZW50LXRvLXJlZGlyZWN0LXNhbWUtb3JpZ2luLXdpdGgtbG9j YXRpb24tY3JlZGVudGlhbHMuaHRtbCBmYWlscworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MzU4CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ndGsvVGVzdEV4cGVjdGF0aW9uczogVW5z a2lwIGh0dHAvdGVzdHMvbWlzYy9hdXRoZW50aWNhdGlvbi1yZWRpcmVjdC0zL2F1dGhlbnRpY2F0 aW9uLXNlbnQtdG8tcmVkaXJlY3Qtc2FtZS1vcmlnaW4td2l0aC1sb2NhdGlvbi1jcmVkZW50aWFs cy5odG1sLgorCiAyMDE2LTExLTAzICBBbnR0aSBLb2l2aXN0byAgPGFudHRpQGFwcGxlLmNvbT4K IAogICAgICAgICBSRUdSRVNTSU9OIChyMjA3NjY5KTogQ3Jhc2ggdW5kZXIgU1ZHUmVuZGVyU3Vw cG9ydDo6dXBkYXRlTWFza2VkQW5jZXN0b3JTaG91bGRJc29sYXRlQmxlbmRpbmcKZGlmZiAtLWdp dCBhL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9UZXN0RXhwZWN0YXRpb25zIGIvTGF5b3V0VGVz dHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKaW5kZXggM2VmYWMxYS4uMzMwYWMzZiAx MDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKKysr IGIvTGF5b3V0VGVzdHMvcGxhdGZvcm0vZ3RrL1Rlc3RFeHBlY3RhdGlvbnMKQEAgLTIzNDMsOCAr MjM0Myw2IEBAIHdlYmtpdC5vcmcvYi8xMzkzNTIgYWNjZXNzaWJpbGl0eS9pbmxpbmUtYmxvY2st YXNzZXJ0aW9uLmh0bWwgWyBGYWlsdXJlIF0KIAogd2Via2l0Lm9yZy9iLzEzOTM1NCBmYXN0L3Jl cGFpbnQvc2VsZWN0aW9uLXJ1YnktcmwuaHRtbCBbIEZhaWx1cmUgXQogCi13ZWJraXQub3JnL2Iv MTM5MzU4IGh0dHAvdGVzdHMvbWlzYy9hdXRoZW50aWNhdGlvbi1yZWRpcmVjdC0zL2F1dGhlbnRp Y2F0aW9uLXNlbnQtdG8tcmVkaXJlY3Qtc2FtZS1vcmlnaW4td2l0aC1sb2NhdGlvbi1jcmVkZW50 aWFscy5odG1sIFsgRmFpbHVyZSBdCi0KIHdlYmtpdC5vcmcvYi8xMzkzNjEgZmFzdC9jc3MvZGF0 YS1hdHRyaWJ1dGUtc3R5bGUtc2hhcmluZy01Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdl YmtpdC5vcmcvYi8xMzkzNjEgZmFzdC9jc3MvZGF0YS1hdHRyaWJ1dGUtc3R5bGUtc2hhcmluZy02 Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0KIHdlYmtpdC5vcmcvYi8xMzkzNjEgZmFzdC9jc3Mv ZGF0YS1hdHRyaWJ1dGUtc3R5bGUtc2hhcmluZy03Lmh0bWwgWyBJbWFnZU9ubHlGYWlsdXJlIF0K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJLaXQyL0NoYW5nZUxvZyBiL1NvdXJjZS9XZWJLaXQyL0No YW5nZUxvZwppbmRleCA2MjJkNmFlLi4wMzMyNDhhIDEwMDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0 Mi9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYktpdDIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcg QEAKKzIwMTYtMTEtMDQgIENhcmxvcyBHYXJjaWEgQ2FtcG9zICA8Y2dhcmNpYUBpZ2FsaWEuY29t PgorCisgICAgICAgIFtTT1VQXSBMYXlvdXQgdGVzdCBodHRwL3Rlc3RzL21pc2MvYXV0aGVudGlj YXRpb24tcmVkaXJlY3QtMy9hdXRoZW50aWNhdGlvbi1zZW50LXRvLXJlZGlyZWN0LXNhbWUtb3Jp Z2luLXdpdGgtbG9jYXRpb24tY3JlZGVudGlhbHMuaHRtbCBmYWlscworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MzU4CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgU3RvcCBwdXR0aW5nIHRoZSBjcmVkZW50 aWFscyBpbiB0aGUgVVJMIHVuY29uZGl0aW9uYWxseSBhbmQgZW5zdXJlIHdlIG9ubHkgZG8gdGhh dCB3aGVuIHByb3ZpZGVkIGJ5IHRoZSBVUkwKKyAgICAgICAgaXRzZWxmLiBMaWJzb3VwIGhhcyBp dHMgb3duIGNhY2hlIG9mIFNvdXBBdXRoLCBzbyB3ZSBkb24ndCBuZWVkIHRvIHBhc3MgdXNlci9w YXNzIGluIHRoZSBVUkwgZm9yIGV2ZXJ5IHNpbmdsZQorICAgICAgICByZXF1ZXN0LCBsaWJzb3Vw IHdpbGwgYXV0aGVudGljYXRlIHRob3NlIGF1dG9tYXRpY2FsbHkuCisKKyAgICAgICAgKiBOZXR3 b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwOgorICAgICAgICAoV2ViS2l0 OjpOZXR3b3JrRGF0YVRhc2tTb3VwOjphcHBseUF1dGhlbnRpY2F0aW9uVG9SZXF1ZXN0KToKKwog MjAxNi0xMS0wMiAgQ2FybG9zIEdhcmNpYSBDYW1wb3MgIDxjZ2FyY2lhQGlnYWxpYS5jb20+CiAK ICAgICAgICAgTmV0d29ya1Nlc3Npb246IEFkZCBOZXR3b3JrRGF0YVRhc2sgaW1wbGVtZW50YXRp b24gZm9yIGJsb2JzCmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9z b3VwL05ldHdvcmtEYXRhVGFza1NvdXAuY3BwIGIvU291cmNlL1dlYktpdDIvTmV0d29ya1Byb2Nl c3Mvc291cC9OZXR3b3JrRGF0YVRhc2tTb3VwLmNwcAppbmRleCAxZTllZTc2Li5jZDViNjFlIDEw MDY0NAotLS0gYS9Tb3VyY2UvV2ViS2l0Mi9OZXR3b3JrUHJvY2Vzcy9zb3VwL05ldHdvcmtEYXRh VGFza1NvdXAuY3BwCisrKyBiL1NvdXJjZS9XZWJLaXQyL05ldHdvcmtQcm9jZXNzL3NvdXAvTmV0 d29ya0RhdGFUYXNrU291cC5jcHAKQEAgLTQwNSwyMiArNDA1LDE2IEBAIHZvaWQgTmV0d29ya0Rh dGFUYXNrU291cDo6dGxzRXJyb3JzQ2hhbmdlZCgpCiAKIHZvaWQgTmV0d29ya0RhdGFUYXNrU291 cDo6YXBwbHlBdXRoZW50aWNhdGlvblRvUmVxdWVzdChSZXNvdXJjZVJlcXVlc3QmIHJlcXVlc3Qp CiB7Ci0gICAgLy8gV2UgYWx3YXlzIHB1dCB0aGUgY3JlZGVudGlhbHMgaW50byB0aGUgVVJMLiBJ biB0aGUgQ29jYSBwb3J0IEhUVFAgZmFtaWx5IGNyZWRlbnRpYWxzIGFyZSBhcHBsaWVkIGluCi0g ICAgLy8gdGhlIGRpZFJlY2VpdmVDaGFsbGVuZ2UgY2FsbGJhY2ssIGJ1dCBsaWJzb3VwIHJlcXVp cmVzIHVzIHRvIHVzZSB0aGlzIG1ldGhvZCB0byBvdmVycmlkZQotICAgIC8vIGFueSBwcmV2aW91 c2x5IHJlbWVtYmVyZWQgY3JlZGVudGlhbHMuIEl0IGhhcyBpdHMgb3duIHBlci1zZXNzaW9uIGNy ZWRlbnRpYWwgc3RvcmFnZS4KKyAgICBpZiAobV91c2VyLmlzRW1wdHkoKSAmJiBtX3Bhc3N3b3Jk LmlzRW1wdHkoKSkKKyAgICAgICAgcmV0dXJuOworCiAgICAgYXV0byB1cmwgPSByZXF1ZXN0LnVy bCgpOwotICAgIGlmICghbV9pbml0aWFsQ3JlZGVudGlhbC5pc0VtcHR5KCkpIHsKLSAgICAgICAg dXJsLnNldFVzZXIobV9pbml0aWFsQ3JlZGVudGlhbC51c2VyKCkpOwotICAgICAgICB1cmwuc2V0 UGFzcyhtX2luaXRpYWxDcmVkZW50aWFsLnBhc3N3b3JkKCkpOwotICAgIH0gZWxzZSB7Ci0gICAg ICAgIHVybC5zZXRVc2VyKG1fdXNlcik7Ci0gICAgICAgIHVybC5zZXRQYXNzKG1fcGFzc3dvcmQp OwotICAgIH0KKyAgICB1cmwuc2V0VXNlcihtX3VzZXIpOworICAgIHVybC5zZXRQYXNzKG1fcGFz c3dvcmQpOworICAgIHJlcXVlc3Quc2V0VVJMKHVybCk7CiAKICAgICBtX3VzZXIgPSBTdHJpbmco KTsKICAgICBtX3Bhc3N3b3JkID0gU3RyaW5nKCk7Ci0KLSAgICByZXF1ZXN0LnNldFVSTCh1cmwp OwogfQogCiB2b2lkIE5ldHdvcmtEYXRhVGFza1NvdXA6OmF1dGhlbnRpY2F0ZUNhbGxiYWNrKFNv dXBTZXNzaW9uKiBzZXNzaW9uLCBTb3VwTWVzc2FnZSogc291cE1lc3NhZ2UsIFNvdXBBdXRoKiBz b3VwQXV0aCwgZ2Jvb2xlYW4gcmV0cnlpbmcsIE5ldHdvcmtEYXRhVGFza1NvdXAqIHRhc2spCg==