139350 2014-12-06 20:50:34 -0800 Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy() 2014-12-08 11:32:24 -0800 1 1 1 Unclassified WebKit Page Loading 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 139263 1 cdumez cdumez ap commit-queue gyuyoung.kim japhet koivisto ossy oldest_to_newest 1053080 0 cdumez 2014-12-06 20:50:34 -0800 Stop using ResourceRequest::cachePolicy() in FrameLoader::subresourceCachePolicy() and use m_loadType instead. ResourceRequest::cachePolicy() is meant to be passed to the network stack, and isn't supposed to be used as input inside WebCore [1]. [1] https://bugs.webkit.org/show_bug.cgi?id=139263#c2 1053081 1 242732 cdumez 2014-12-06 20:53:07 -0800 Created attachment 242732 Patch 1053362 2 242732 koivisto 2014-12-08 06:08:09 -0800 Comment on attachment 242732 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242732&action=review > Source/WebCore/loader/FrameLoader.cpp:2160 > + default: > + return CachePolicyVerify; > + } It would be better to list all cases rather than use default. 1053417 3 242823 cdumez 2014-12-08 10:01:00 -0800 Created attachment 242823 Patch 1053429 4 242823 commit-queue 2014-12-08 10:41:39 -0800 Comment on attachment 242823 Patch Clearing flags on attachment: 242823 Committed r176953: <http://trac.webkit.org/changeset/176953> 1053430 5 commit-queue 2014-12-08 10:41:43 -0800 All reviewed patches have been landed. Closing bug. 1053451 6 ossy 2014-12-08 11:22:23 -0800 (In reply to comment #4) > Comment on attachment 242823 [details] > Patch > > Clearing flags on attachment: 242823 > > Committed r176953: <http://trac.webkit.org/changeset/176953> It broke the EFL build, because gcc need some love - an unreachable return. I'm wondering why EFL EWS didn't notice this warning ... ../../Source/WebCore/loader/FrameLoader.cpp: In member function ‘WebCore::CachePolicy WebCore::FrameLoader::subresourceCachePolicy() const’: ../../Source/WebCore/loader/FrameLoader.cpp:2167:1: error: control reaches end of non-void function [-Werror=return-type] } ^ Fix is coming. 1053453 7 ossy 2014-12-08 11:32:24 -0800 Fix landed in https://trac.webkit.org/changeset/176958 242732 2014-12-06 20:53:07 -0800 2014-12-08 10:00:57 -0800 Patch bug-139350-20141206205343.patch text/plain 1972 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTE3CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggYTIyYjZiYzUyN2E3ODAx YjZjOWVmNTA4ZDM1OTNmZDJhMTQ4OWNhZC4uNjgyNGZlOTc5NGIxOTAyNmNlMjE0ODM1MzcxZmY1 YjVkZjdhMjU2OCAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEyLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBSZXNvdXJj ZVJlcXVlc3Q6OmNhY2hlUG9saWN5KCkgaW4gRnJhbWVMb2FkZXI6OnN1YnJlc291cmNlQ2FjaGVQ b2xpY3koKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM5MzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg U3RvcCB1c2luZyBSZXNvdXJjZVJlcXVlc3Q6OmNhY2hlUG9saWN5KCkgaW4gRnJhbWVMb2FkZXI6 OnN1YnJlc291cmNlQ2FjaGVQb2xpY3koKQorICAgICAgICBhbmQgdXNlIG1fbG9hZFR5cGUgaW5z dGVhZC4gUmVzb3VyY2VSZXF1ZXN0OjpjYWNoZVBvbGljeSgpIGlzIG1lYW50IHRvIGJlIHBhc3Nl ZAorICAgICAgICB0byB0aGUgbmV0d29yayBzdGFjaywgYW5kIGlzbid0IHN1cHBvc2VkIHRvIGJl IHVzZWQgYXMgaW5wdXQgaW5zaWRlIFdlYkNvcmUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnN1YnJlc291cmNlQ2FjaGVQb2xpY3kpOgor CiAyMDE0LTEyLTA2ICBDc2FiYSBPc3p0cm9nb27DoWMgIDxvc3N5QHdlYmtpdC5vcmc+CiAKICAg ICAgICAgVVJUQkYgYWZ0ZXIgcjE3NjkxNS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9GcmFtZUxvYWRlci5jcHAgYi9Tb3VyY2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIu Y3BwCmluZGV4IGNlYmIzYWFhY2NkNDAxMTM3YjlmOTU4Nzg2NTcwZTM4ZDFiM2NmMzEuLmRjMjBl NWIxOTJmYzUwMjkyZTc0MzdhYzFlMGY0OWM4YWUzODIzY2UgMTAwNjQ0Ci0tLSBhL1NvdXJjZS9X ZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvbG9hZGVy L0ZyYW1lTG9hZGVyLmNwcApAQCAtMjE0OCwxNCArMjE0OCwxNiBAQCBDYWNoZVBvbGljeSBGcmFt ZUxvYWRlcjo6c3VicmVzb3VyY2VDYWNoZVBvbGljeSgpIGNvbnN0CiAgICAgICAgICAgICByZXR1 cm4gcGFyZW50Q2FjaGVQb2xpY3k7CiAgICAgfQogICAgIAotICAgIGlmIChtX2xvYWRUeXBlID09 IEZyYW1lTG9hZFR5cGU6OlJlbG9hZCkKKyAgICBzd2l0Y2ggKG1fbG9hZFR5cGUpIHsKKyAgICBj YXNlIEZyYW1lTG9hZFR5cGU6OlJlbG9hZDoKICAgICAgICAgcmV0dXJuIENhY2hlUG9saWN5UmV2 YWxpZGF0ZTsKLQotICAgIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdChkb2N1bWVudExv YWRlcigpLT5yZXF1ZXN0KCkpOwotICAgIGlmIChyZXF1ZXN0LmNhY2hlUG9saWN5KCkgPT0gUmV0 dXJuQ2FjaGVEYXRhRWxzZUxvYWQpCisgICAgY2FzZSBGcmFtZUxvYWRUeXBlOjpCYWNrOgorICAg IGNhc2UgRnJhbWVMb2FkVHlwZTo6Rm9yd2FyZDoKKyAgICBjYXNlIEZyYW1lTG9hZFR5cGU6Oklu ZGV4ZWRCYWNrRm9yd2FyZDoKICAgICAgICAgcmV0dXJuIENhY2hlUG9saWN5SGlzdG9yeUJ1ZmZl cjsKLQotICAgIHJldHVybiBDYWNoZVBvbGljeVZlcmlmeTsKKyAgICBkZWZhdWx0OgorICAgICAg ICByZXR1cm4gQ2FjaGVQb2xpY3lWZXJpZnk7CisgICAgfQogfQogCiB2b2lkIEZyYW1lTG9hZGVy OjpjaGVja0xvYWRDb21wbGV0ZUZvclRoaXNGcmFtZSgpCg== 242823 2014-12-08 10:01:00 -0800 2014-12-08 10:41:39 -0800 Patch bug-139350-20141208100139.patch text/plain 2270 cdumez U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTQ5CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggNDVlM2Y0ZGE0ZTdhNGEz MDQ4YWIzMWU4Y2I5YTEyMTA1MmZkNWM0ZS4uNmFhYWUwMTg4ZGQzMjJkMmI4NDNmNjk4YjNmMGRj ZjdmOTE5MjRmNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE5IEBACisyMDE0LTEyLTA2ICBDaHJp cyBEdW1leiAgPGNkdW1lekBhcHBsZS5jb20+CisKKyAgICAgICAgU3RvcCB1c2luZyBSZXNvdXJj ZVJlcXVlc3Q6OmNhY2hlUG9saWN5KCkgaW4gRnJhbWVMb2FkZXI6OnN1YnJlc291cmNlQ2FjaGVQ b2xpY3koKQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9 MTM5MzUwCisKKyAgICAgICAgUmV2aWV3ZWQgYnkgQW50dGkgS29pdmlzdG8uCisKKyAgICAgICAg U3RvcCB1c2luZyBSZXNvdXJjZVJlcXVlc3Q6OmNhY2hlUG9saWN5KCkgaW4gRnJhbWVMb2FkZXI6 OnN1YnJlc291cmNlQ2FjaGVQb2xpY3koKQorICAgICAgICBhbmQgdXNlIG1fbG9hZFR5cGUgaW5z dGVhZC4gUmVzb3VyY2VSZXF1ZXN0OjpjYWNoZVBvbGljeSgpIGlzIG1lYW50IHRvIGJlIHBhc3Nl ZAorICAgICAgICB0byB0aGUgbmV0d29yayBzdGFjaywgYW5kIGlzbid0IHN1cHBvc2VkIHRvIGJl IHVzZWQgYXMgaW5wdXQgaW5zaWRlIFdlYkNvcmUuCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLCBu byBiZWhhdmlvciBjaGFuZ2UuCisKKyAgICAgICAgKiBsb2FkZXIvRnJhbWVMb2FkZXIuY3BwOgor ICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXI6OnN1YnJlc291cmNlQ2FjaGVQb2xpY3kpOgor CiAyMDE0LTEyLTA4ICBBbmRlcnMgQ2FybHNzb24gIDxhbmRlcnNjYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmVtb3ZlIFJlc291cmNlSGFuZGxlOjpsb2Fkc0Jsb2NrZWQoKQpkaWZmIC0tZ2l0IGEv U291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcCBiL1NvdXJjZS9XZWJDb3JlL2xv YWRlci9GcmFtZUxvYWRlci5jcHAKaW5kZXggY2ViYjNhYWFjY2Q0MDExMzdiOWY5NTg3ODY1NzBl MzhkMWIzY2YzMS4uZGFlNjBhNTY5MTY0MjM5ZGUyYTNmNmE3YTQyMzMwZmM3ZDk5NWIxZSAxMDA2 NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvbG9hZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9Tb3Vy Y2UvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwCkBAIC0yMTQ4LDE0ICsyMTQ4LDIyIEBA IENhY2hlUG9saWN5IEZyYW1lTG9hZGVyOjpzdWJyZXNvdXJjZUNhY2hlUG9saWN5KCkgY29uc3QK ICAgICAgICAgICAgIHJldHVybiBwYXJlbnRDYWNoZVBvbGljeTsKICAgICB9CiAgICAgCi0gICAg aWYgKG1fbG9hZFR5cGUgPT0gRnJhbWVMb2FkVHlwZTo6UmVsb2FkKQorICAgIHN3aXRjaCAobV9s b2FkVHlwZSkgeworICAgIGNhc2UgRnJhbWVMb2FkVHlwZTo6UmVsb2FkOgogICAgICAgICByZXR1 cm4gQ2FjaGVQb2xpY3lSZXZhbGlkYXRlOwotCi0gICAgY29uc3QgUmVzb3VyY2VSZXF1ZXN0JiBy ZXF1ZXN0KGRvY3VtZW50TG9hZGVyKCktPnJlcXVlc3QoKSk7Ci0gICAgaWYgKHJlcXVlc3QuY2Fj aGVQb2xpY3koKSA9PSBSZXR1cm5DYWNoZURhdGFFbHNlTG9hZCkKKyAgICBjYXNlIEZyYW1lTG9h ZFR5cGU6OkJhY2s6CisgICAgY2FzZSBGcmFtZUxvYWRUeXBlOjpGb3J3YXJkOgorICAgIGNhc2Ug RnJhbWVMb2FkVHlwZTo6SW5kZXhlZEJhY2tGb3J3YXJkOgogICAgICAgICByZXR1cm4gQ2FjaGVQ b2xpY3lIaXN0b3J5QnVmZmVyOwotCi0gICAgcmV0dXJuIENhY2hlUG9saWN5VmVyaWZ5OworICAg IGNhc2UgRnJhbWVMb2FkVHlwZTo6UmVsb2FkRnJvbU9yaWdpbjoKKyAgICAgICAgQVNTRVJUX05P VF9SRUFDSEVEKCk7IC8vIEFscmVhZHkgaGFuZGxlZCBhYm92ZS4KKyAgICAgICAgcmV0dXJuIENh Y2hlUG9saWN5UmVsb2FkOworICAgIGNhc2UgRnJhbWVMb2FkVHlwZTo6UmVkaXJlY3RXaXRoTG9j a2VkQmFja0ZvcndhcmRMaXN0OgorICAgIGNhc2UgRnJhbWVMb2FkVHlwZTo6UmVwbGFjZToKKyAg ICBjYXNlIEZyYW1lTG9hZFR5cGU6OlNhbWU6CisgICAgY2FzZSBGcmFtZUxvYWRUeXBlOjpTdGFu ZGFyZDoKKyAgICAgICAgcmV0dXJuIENhY2hlUG9saWN5VmVyaWZ5OworICAgIH0KIH0KIAogdm9p ZCBGcmFtZUxvYWRlcjo6Y2hlY2tMb2FkQ29tcGxldGVGb3JUaGlzRnJhbWUoKQo=