139341 2014-12-06 08:55:18 -0800 [GStreamer] Handle CLOCK_LOST and LATENCY messages 2014-12-08 01:24:32 -0800 1 1 1 Unclassified WebKit Media 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 slomo slomo commit-queue pnormand oldest_to_newest 1053022 0 slomo 2014-12-06 08:55:18 -0800 [GStreamer] Handle CLOCK_LOST and LATENCY messages 1053024 1 slomo 2014-12-06 09:11:43 -0800 Patch coming once my testbuild has finished in a few minutes :) 1053035 2 242717 slomo 2014-12-06 10:11:15 -0800 Created attachment 242717 Patch 1053131 3 pnormand 2014-12-07 06:53:03 -0800 I think Brendan had already CLOCK_LOST support in of his recent patches? The one he doesn't want to land :) 1053135 4 slomo 2014-12-07 07:31:17 -0800 Possible, I didn't look at that patch yet but it's a good thing to merge independent of all the other stuff he has in his patch and simple enough :) 1053175 5 242717 gustavo 2014-12-07 10:11:04 -0800 Comment on attachment 242717 Patch Why doesn't he want to land it? Are these messages things we can test? 1053184 6 slomo 2014-12-07 10:32:57 -0800 You could probably test it but setting up an environment to run into actual problems with these will be a lot of work. It's the right thing to do though, it's what we recommend in the documentation and also in gst-launch for example. He doesn't want to land his patches because the actual thing they're implementing (disabling audio/video streams) does not work reliable because of bugs somewhere. 1053217 7 242717 pnormand 2014-12-07 12:57:18 -0800 Comment on attachment 242717 Patch Ok! 1053314 8 242717 commit-queue 2014-12-08 01:24:28 -0800 Comment on attachment 242717 Patch Clearing flags on attachment: 242717 Committed r176940: <http://trac.webkit.org/changeset/176940> 1053315 9 commit-queue 2014-12-08 01:24:32 -0800 All reviewed patches have been landed. Closing bug. 242717 2014-12-06 10:11:15 -0800 2014-12-08 01:24:28 -0800 Patch bug-139341-20141206191236.patch text/plain 3432 slomo U3VidmVyc2lvbiBSZXZpc2lvbjogMTc2OTA2CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViQ29yZS9D aGFuZ2VMb2cgYi9Tb3VyY2UvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWZmNjNlMjA0M2U5ZjYx Y2U0ZDc0ZmE3MGI5ZDE5NWU4NWFiNjQ1ZS4uNDI4OWE3ZTI5ZTMwNWZlNjVlYzhmNjBjMzA3Nzgw NWMwODNmMjlhNiAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1Nv dXJjZS9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDI2IEBACisyMDE0LTEyLTA2ICBTZWJh c3RpYW4gRHLDtmdlICA8c2ViYXN0aWFuQGNlbnRyaWN1bGFyLmNvbT4KKworICAgICAgICBbR1N0 cmVhbWVyXSBIYW5kbGUgQ0xPQ0tfTE9TVCBhbmQgTEFURU5DWSBtZXNzYWdlcworICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MzQxCisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9ncmFwaGlj cy9nc3RyZWFtZXIvTWVkaWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyLmNwcDoKKyAgICAgICAgKFdl YkNvcmU6Ok1lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lcjo6aGFuZGxlTWVzc2FnZSk6CisgICAg ICAgIEhhbmRsZSBDTE9DS19MT1NUIG1lc3NhZ2UgYnkgc2hvcnRseSBnb2luZyBiYWNrIHRvIFBB VVNFRCBzdGF0ZQorICAgICAgICBhbmQgdGhlbiB0byBQTEFZSU5HIGFnYWluIHRvIGxldCB0aGUg cGlwZWxpbmUgc2VsZWN0IGEgbmV3IGNsb2NrCisgICAgICAgIGZvciB1cy4KKyAgICAgICAgVGhp cyBjYW4gaGFwcGVuIGlmIHRoZSBzdHJlYW0gdGhhdCBlbmRzIGluIGEgc2luayB0aGF0IHByb3Zp ZGVzCisgICAgICAgIHRoZSBjdXJyZW50IGNsb2NrIGRpc2FwcGVhcnMsIGZvciBleGFtcGxlIGlm IHRoZSBhdWRpbyBzaW5rCisgICAgICAgIHByb3ZpZGVzIHRoZSBjbG9jayBhbmQgdGhlIGF1ZGlv IHN0cmVhbSBpcyBkaXNhYmxlZC4gSXQgYWxzbworICAgICAgICBoYXBwZW5zIHJlbGF0aXZlbHkg b2Z0ZW4gd2l0aCBIVFRQIGFkYXB0aXZlIHN0cmVhbXMgd2hlbiBzd2l0Y2hpbmcKKyAgICAgICAg YmV0d2VlbiBkaWZmZXJlbnQgdmFyaWFudHMgb2YgYSBzdHJlYW0uCisKKyAgICAgICAgQWxzbyBo YW5kbGUgdGhlIExBVEVOQ1kgbWVzc2FnZSBieSB0cmlnZ2VyaW5nIHRoZSBkZWZhdWx0IEdTdHJl YW1lcgorICAgICAgICBtZWNoYW5pc20gdG8gdXBkYXRlIHRoZSBsYXRlbmN5LiBUaGlzIGNhbiBo YXBwZW4gaWYgdGhlIGxhdGVuY3kgb2YKKyAgICAgICAgbGl2ZSBlbGVtZW50cyBjaGFuZ2VzLCBv ciBmb3Igb25lIHJlYXNvbiBvciBhbm90aGVyIGEgbmV3IGxpdmUgZWxlbWVudAorICAgICAgICBp cyBhZGRlZCBvciByZW1vdmVkIGZyb20gdGhlIHBpcGVsaW5lLgorCiAyMDE0LTEyLTA1ICBDaHJp cyBGbGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgQVg6IEkgY2Fubm90 IGFjdGl2YXRlIGxpbmtzIG9uIHRoZSBtb2JpbGUgdmVyc2lvbiBvZiBuZXdzLmdvb2dsZS5jb20K ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL2dzdHJlYW1lci9N ZWRpYVBsYXllclByaXZhdGVHU3RyZWFtZXIuY3BwIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0v Z3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKaW5kZXgg ZmNiYzZlMTUwMTgwMTRhNjA5OGI0Y2E5MmViNGNmYTk0NzJhMDY3ZC4uYjU2NWMzNGFiMjhhN2Qx Y2U4YWQ5MTI4MDdhODk4ZTg2OWRjMDYxNyAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxheWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAK KysrIGIvU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvZ3N0cmVhbWVyL01lZGlhUGxh eWVyUHJpdmF0ZUdTdHJlYW1lci5jcHAKQEAgLTk5Miw2ICs5OTIsMjcgQEAgZ2Jvb2xlYW4gTWVk aWFQbGF5ZXJQcml2YXRlR1N0cmVhbWVyOjpoYW5kbGVNZXNzYWdlKEdzdE1lc3NhZ2UqIG1lc3Nh Z2UpCiAgICAgICAgICAgICAgICAgbG9hZGluZ0ZhaWxlZChNZWRpYVBsYXllcjo6RW1wdHkpOwog ICAgICAgICB9CiAgICAgICAgIGJyZWFrOworICAgIGNhc2UgR1NUX01FU1NBR0VfQ0xPQ0tfTE9T VDoKKyAgICAgICAgLy8gVGhpcyBjYW4gb25seSBoYXBwZW4gaW4gUExBWUlORyBzdGF0ZSBhbmQg d2Ugc2hvdWxkIGp1c3QKKyAgICAgICAgLy8gZ2V0IGEgbmV3IGNsb2NrIGJ5IG1vdmluZyBiYWNr IHRvIFBBVVNFRCBhbmQgdGhlbiB0bworICAgICAgICAvLyBQTEFZSU5HIGFnYWluLgorICAgICAg ICAvLyBUaGlzIGNhbiBoYXBwZW4gaWYgdGhlIHN0cmVhbSB0aGF0IGVuZHMgaW4gYSBzaW5rIHRo YXQKKyAgICAgICAgLy8gcHJvdmlkZXMgdGhlIGN1cnJlbnQgY2xvY2sgZGlzYXBwZWFycywgZm9y IGV4YW1wbGUgaWYKKyAgICAgICAgLy8gdGhlIGF1ZGlvIHNpbmsgcHJvdmlkZXMgdGhlIGNsb2Nr IGFuZCB0aGUgYXVkaW8gc3RyZWFtCisgICAgICAgIC8vIGlzIGRpc2FibGVkLiBJdCBhbHNvIGhh cHBlbnMgcmVsYXRpdmVseSBvZnRlbiB3aXRoCisgICAgICAgIC8vIEhUVFAgYWRhcHRpdmUgc3Ry ZWFtcyB3aGVuIHN3aXRjaGluZyBiZXR3ZWVuIGRpZmZlcmVudAorICAgICAgICAvLyB2YXJpYW50 cyBvZiBhIHN0cmVhbS4KKyAgICAgICAgZ3N0X2VsZW1lbnRfc2V0X3N0YXRlKG1fcGxheUJpbi5n ZXQoKSwgR1NUX1NUQVRFX1BBVVNFRCk7CisgICAgICAgIGdzdF9lbGVtZW50X3NldF9zdGF0ZSht X3BsYXlCaW4uZ2V0KCksIEdTVF9TVEFURV9QTEFZSU5HKTsKKyAgICAgICAgYnJlYWs7CisgICAg Y2FzZSBHU1RfTUVTU0FHRV9MQVRFTkNZOgorICAgICAgICAvLyBSZWNhbGN1bGF0ZSB0aGUgbGF0 ZW5jeSwgd2UgZG9uJ3QgbmVlZCBhbnkgc3BlY2lhbCBoYW5kbGluZworICAgICAgICAvLyBoZXJl IG90aGVyIHRoYW4gdGhlIEdTdHJlYW1lciBkZWZhdWx0LgorICAgICAgICAvLyBUaGlzIGNhbiBo YXBwZW4gaWYgdGhlIGxhdGVuY3kgb2YgbGl2ZSBlbGVtZW50cyBjaGFuZ2VzLCBvcgorICAgICAg ICAvLyBmb3Igb25lIHJlYXNvbiBvciBhbm90aGVyIGEgbmV3IGxpdmUgZWxlbWVudCBpcyBhZGRl ZCBvcgorICAgICAgICAvLyByZW1vdmVkIGZyb20gdGhlIHBpcGVsaW5lLgorICAgICAgICBnc3Rf YmluX3JlY2FsY3VsYXRlX2xhdGVuY3koR1NUX0JJTihtX3BsYXlCaW4uZ2V0KCkpKTsKKyAgICAg ICAgYnJlYWs7CiAgICAgY2FzZSBHU1RfTUVTU0FHRV9FTEVNRU5UOgogICAgICAgICBpZiAoZ3N0 X2lzX21pc3NpbmdfcGx1Z2luX21lc3NhZ2UobWVzc2FnZSkpIHsKICAgICAgICAgICAgIGdjaGFy KiBkZXRhaWwgPSBnc3RfbWlzc2luZ19wbHVnaW5fbWVzc2FnZV9nZXRfaW5zdGFsbGVyX2RldGFp bChtZXNzYWdlKTsK