13934 2007-05-30 11:01:15 -0700 REGRESSION: http/tests/navigation/relativeanchor-goback is failing 2007-06-08 13:15:09 -0700 1 1 1 Unclassified WebKit Forms 523.x (Safari 3) Mac OS X 10.4 RESOLVED FIXED http://build.webkit.org/results/post-commit-powerpc-mac-os-x/6871/http/tests/navigation/relativeanchor-goback-diffs.txt InRadar, LayoutTestFailure, Regression P1 Normal --- 1 aroben bdakin bdakin oldest_to_newest 8734 0 aroben 2007-05-30 11:01:15 -0700 http/tests/navigation/relativeanchor-goback is failing on the buildbot. 8739 1 aroben 2007-05-30 11:02:24 -0700 <rdar://problem/5237081> 8145 2 bdakin 2007-06-07 16:45:45 -0700 Darin mentioned that he thought that this was due to Adele's change to form element saving. 8131 3 bdakin 2007-06-07 20:14:22 -0700 This was, indeed, caused by http://trac.webkit.org/projects/webkit/changeset/21738 8132 4 bdakin 2007-06-07 21:14:21 -0700 The failing test seems straighforward enough once I read it, but I keep thinking that I understand it, and then I cannot reproduce it inside the browser. (The test relies heavily on dump render tree.) 8123 5 bdakin 2007-06-08 10:42:41 -0700 I might understand what is going on here, but I haven't confirmed yet. I think that these new results may actually be correct. The reason that I have been having so much trouble reproducing the in browser, is that the browser has a back-forward cache, and DumpRenderTree turns the back-forward cache off. So When this test "goes back" it actually kicks off a new load. And when we kick off a new load in the browser, we do not expect the form input to be retained. I think that this test was exposing the very bug that Adele fixed. Probably once upon a time, it worked as expected because there was a time when the back-forward list was enabled for DumpRenderTree. But now that it is disabled, I actually think that it is correct that the form values are reset to their defaults. I am going to work on confirming this. 8124 6 bdakin 2007-06-08 11:04:39 -0700 I have confirmed that re-enabling the back-forward cache for DumpRenderTree causes the test to pass. As I said in my previous comment, I think that this test should only pass with the back-forward cache enabled. I think that it *was* passing in DumpRenderTree before because it was hitting that case that Adele fixed. I am going to do a bit more investigation. 8101 7 bdakin 2007-06-08 12:34:04 -0700 Okay, I looked at the in the Debugger, and I feel confident that my assessment is correct. The relative URL should be treated as a different URL when it is loaded rather than "gone back to" via the back button. We have always treated them as separate if you re-enter the URL in the address bar, so it seems the same should hold for DumpRenderTree. I will edit the test to be less confusing and update the expected results. 8100 8 14905 bdakin 2007-06-08 13:10:24 -0700 Created attachment 14905 Patch Here is a patch that uploads new results for the test. I did not end up changing the text in the js-file to make the results more clear because it affects to many other tests. Seems like something that should be done after a fuller investigation of all of the tests that use that js file. 8099 9 14905 beidson 2007-06-08 13:11:42 -0700 Comment on attachment 14905 Patch Yay! 8097 10 bdakin 2007-06-08 13:15:09 -0700 Fixed with r22076. 14905 2007-06-08 13:10:24 -0700 2007-06-08 13:11:42 -0700 Patch adeleLTchange.txt text/plain 2817 bdakin SW5kZXg6IGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxhdGl2ZWFuY2hvci1nb2JhY2stZXhwZWN0 ZWQudHh0Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT0KLS0tIGh0dHAvdGVzdHMvbmF2aWdhdGlvbi9yZWxhdGl2ZWFuY2hv ci1nb2JhY2stZXhwZWN0ZWQudHh0CShyZXZpc2lvbiAyMjA1NykKKysrIGh0dHAvdGVzdHMvbmF2 aWdhdGlvbi9yZWxhdGl2ZWFuY2hvci1nb2JhY2stZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC01Miw4ICs1Miw4IEBACiAgICAgICAgIFJlbmRlckJSIHtCUn0gYXQgKDE0OCwyNTgpIHNp emUgMHgwCiAgICAgICAgIFJlbmRlck1lbnVMaXN0IHtTRUxFQ1R9IGF0ICgyLDI2OCkgc2l6ZSAy NTV4MTggW2JnY29sb3I9I0ZGRkZGRl0KICAgICAgICAgICBSZW5kZXJCbG9jayAoYW5vbnltb3Vz KSBhdCAoOCwyKSBzaXplIDIyNHgxMwotICAgICAgICAgICAgUmVuZGVyVGV4dCBhdCAoMCwwKSBz aXplIDIyNXgxMwotICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAoMCwwKSB3aWR0aCAyMjU6ICJW YWx1ZSBzZXQgYnkgVXNlciB0aGF0IHNob3VsZCBiZSBSZXN0b3JlZCIKKyAgICAgICAgICAgIFJl bmRlclRleHQgYXQgKDAsMCkgc2l6ZSA2M3gxMworICAgICAgICAgICAgICB0ZXh0IHJ1biBhdCAo MCwwKSB3aWR0aCA2MzogIkluaXRpYWwgVmFsdWUiCiAgICAgICAgIFJlbmRlckJSIHtCUn0gYXQg KDI1OSwyODEpIHNpemUgMHgwCiAgICAgICAgIFJlbmRlclRleHRDb250cm9sIHtURVhUQVJFQX0g YXQgKDIsMjkwKSBzaXplIDIzMngxMzIgW2JnY29sb3I9I0ZGRkZGRl0gW2JvcmRlcjogKDFweCBz b2xpZCAjMDAwMDAwKV0KICAgICAgICAgUmVuZGVyVGV4dCB7I3RleHR9IGF0ICgwLDApIHNpemUg MHgwCkBAIC05MiwxOCArOTIsMTggQEAKICAgICAgICAgUmVuZGVySW5saW5lIHtBfSBhdCAoMCww KSBzaXplIDUzMXgzNwogICAgICAgICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMCwwKSBzaXpl IDUzMXgzNwogICAgICAgICAgICAgdGV4dCBydW4gYXQgKDAsMCkgd2lkdGggNTMxOiAiVGhpcyBp cyBhbiBhbmNob3IgcG9pbnQgbmFtZWQgXCJhbmNob3IxXCIuIgotbGF5ZXIgYXQgKDM4OSwzNjMp IHNpemUgMTQyeDEzCitsYXllciBhdCAoMzg5LDM2Mykgc2l6ZSAxNDJ4MTMgc2Nyb2xsV2lkdGgg MTUzCiAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgzLDMpIHNpemUgMTQyeDEzCi0gICAgUmVuZGVy VGV4dCB7I3RleHR9IGF0ICgxLDApIHNpemUgMTMzeDEzCi0gICAgICB0ZXh0IHJ1biBhdCAoMSww KSB3aWR0aCAxMzM6ICJOZXcgZm9ybSB0ZXh0IGZyb20gdXNlciIKKyAgICBSZW5kZXJUZXh0IHsj dGV4dH0gYXQgKDEsMCkgc2l6ZSAxNTF4MTMKKyAgICAgIHRleHQgcnVuIGF0ICgxLDApIHdpZHRo IDE1MTogIkluaXRpYWwgdGV4dCBiZWZvcmUgdXNlciBpbnB1dCIKIGxheWVyIGF0ICgzNDcsNDAw KSBzaXplIDE0MngxMwogICBSZW5kZXJCbG9jayB7RElWfSBhdCAoMywzKSBzaXplIDE0MngxMwog bGF5ZXIgYXQgKDExLDU5Mikgc2l6ZSAyMzB4MTMwCiAgIFJlbmRlckJsb2NrIHtESVZ9IGF0ICgx LDEpIHNpemUgMjMweDEzMAotICAgIFJlbmRlclRleHQgeyN0ZXh0fSBhdCAoMywwKSBzaXplIDIw NXgzOQotICAgICAgdGV4dCBydW4gYXQgKDMsMCkgd2lkdGggMjAyOiAiTW9yZSBuZXcgZm9ybSB0 ZXh0IGZyb20gdXNlciwgd2hpY2ggIgotICAgICAgdGV4dCBydW4gYXQgKDMsMTMpIHdpZHRoIDIw NTogInNob3VsZCBiZSByZXN0b3JlZCB3aGVuIHdlIHJldHVybiB0byAiCi0gICAgICB0ZXh0IHJ1 biBhdCAoMywyNikgd2lkdGggNTM6ICJ0aGlzIHBhZ2UuIgorICAgIFJlbmRlclRleHQgeyN0ZXh0 fSBhdCAoMywwKSBzaXplIDE4NXgxMworICAgICAgdGV4dCBydW4gYXQgKDMsMCkgd2lkdGggMTg1 OiAiTW9yZSBpbml0aWFsIHRleHQgYmVmb3JlIHVzZXIgaW5wdXQuIgorICAgICAgdGV4dCBydW4g YXQgKDE4OCwwKSB3aWR0aCAwOiAiICIKKyAgICBSZW5kZXJCUiB7QlJ9IGF0ICgzLDEzKSBzaXpl IDB4MTMKIHNjcm9sbGVkIHRvIDAsOTUwCiAKID09PT09PT09PT09PT09IEJhY2sgRm9yd2FyZCBM aXN0ID09PT09PT09PT09PT09CkluZGV4OiBDaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gQ2hhbmdl TG9nCShyZXZpc2lvbiAyMjA3NSkKKysrIENoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwz ICsxLDE1IEBACisyMDA3LTA2LTA4ICBkZXRoYmFraW4gIDxiZGFraW5AYXBwbGUuY29tPgorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBmb3IgaHR0 cDovL3RyYWMud2Via2l0Lm9yZy9wcm9qZWN0cy93ZWJraXQvY2hhbmdlc2V0LzIxNzM4CisKKyAg ICAgICAgVGhpcyB0ZXN0IHN0YXJ0ZWQgZmFpbGluZyBhZnRlciBBZGVsZSdzIHIyMTczOC4gQWZ0 ZXIgaW52ZXN0aWdhdGluZyAKKyAgICAgICAgdGhpcywgaXQgdHVybnMgb3V0IHRoYXQgaXQganVz dCBuZWVkcyB1cGRhdGVkIHJlc3VsdHMuIFRoaXMgdGVzdCAKKyAgICAgICAgaGFwcGVuZWQgdG8g dGlja2xlIHRoZSB2ZXJ5IGJ1ZyB0aGF0IEFkZWxlIGZpeGVkLiAKKworICAgICAgICAqIGh0dHAv dGVzdHMvbmF2aWdhdGlvbi9yZWxhdGl2ZWFuY2hvci1nb2JhY2stZXhwZWN0ZWQudHh0OgorCiAy MDA3LTA2LTA4ICBKdXN0aW4gR2FyY2lhICA8anVzdGluLmdhcmNpYUBhcHBsZS5jb20+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgSm9obi4K