139338 2014-12-06 03:59:23 -0800 [WinCairo] Compile error, missing guard. 2014-12-06 12:18:37 -0800 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 peavo webkit-unassigned alex.christensen benjamin bfulgham commit-queue oldest_to_newest 1053004 0 peavo 2014-12-06 03:59:23 -0800 There is missing a ENABLE(CSS_SELECTORS_LEVEL4) guard in CSSParser.cpp. 1053005 1 242708 peavo 2014-12-06 04:03:00 -0800 Created attachment 242708 Patch 1053028 2 242708 alex.christensen 2014-12-06 09:45:16 -0800 Comment on attachment 242708 Patch That happens. Why is wincairo the only port noticing this? 1053039 3 242708 commit-queue 2014-12-06 10:25:33 -0800 Comment on attachment 242708 Patch Clearing flags on attachment: 242708 Committed r176907: <http://trac.webkit.org/changeset/176907> 1053040 4 commit-queue 2014-12-06 10:25:37 -0800 All reviewed patches have been landed. Closing bug. 1053054 5 peavo 2014-12-06 12:11:24 -0800 (In reply to comment #2) > Comment on attachment 242708 [details] > Patch > > That happens. Why is wincairo the only port noticing this? Thanks for reviewing :) Maybe we should enable CSS_SELECTORS_LEVEL4, to avoid more of these compile errors? 1053055 6 alex.christensen 2014-12-06 12:18:37 -0800 Maybe we should completely remove the flag if everybody else has it enabled. Ben, what do you think? 242708 2014-12-06 04:03:00 -0800 2014-12-06 10:25:33 -0800 Patch bug-139338-20141206130317.patch text/plain 1446 peavo SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjkwNikKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE1IEBACisyMDE0LTEyLTA2ICBwZWF2b0Bv dXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgorCisgICAgICAgIFtXaW5DYWlyb10gQ29t cGlsZSBlcnJvciwgbWlzc2luZyBndWFyZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTEzOTMzOAorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFRoZXJlIGlzIG1pc3NpbmcgYSBFTkFCTEUoQ1NTX1NFTEVDVE9S U19MRVZFTDQpIGd1YXJkIGluIENTU1BhcnNlci5jcHAuCisKKyAgICAgICAgKiBjc3MvQ1NTUGFy c2VyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OkNTU1BhcnNlcjo6cmVhbExleCk6CisKIDIwMTQt MTItMDUgIENocmlzIEZsZWl6YWNoICA8Y2ZsZWl6YWNoQGFwcGxlLmNvbT4KIAogICAgICAgICBB WDogSSBjYW5ub3QgYWN0aXZhdGUgbGlua3Mgb24gdGhlIG1vYmlsZSB2ZXJzaW9uIG9mIG5ld3Mu Z29vZ2xlLmNvbQpJbmRleDogU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAKPT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PQotLS0gU291cmNlL1dlYkNvcmUvY3NzL0NTU1BhcnNlci5jcHAJKHJldmlzaW9uIDE3Njkw NSkKKysrIFNvdXJjZS9XZWJDb3JlL2Nzcy9DU1NQYXJzZXIuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0xMTQ4Niw2ICsxMTQ4Niw3IEBAIHJlc3RhcnRBZnRlckNvbW1lbnQ6CiAgICAgICAgIGlmICgq Y3VycmVudENoYXJhY3RlcjxTcmNDaGFyYWN0ZXJUeXBlPigpID09ICc9JykgewogICAgICAgICAg ICAgKytjdXJyZW50Q2hhcmFjdGVyPFNyY0NoYXJhY3RlclR5cGU+KCk7CiAgICAgICAgICAgICBt X3Rva2VuID0gQ09OVEFJTlM7CisjaWYgRU5BQkxFKENTU19TRUxFQ1RPUlNfTEVWRUw0KQogICAg ICAgICB9IGVsc2UgaWYgKCpjdXJyZW50Q2hhcmFjdGVyPFNyY0NoYXJhY3RlclR5cGU+KCkgPT0g Jy0nKSB7CiAgICAgICAgICAgICByZXN1bHQgPSBjdXJyZW50Q2hhcmFjdGVyPFNyY0NoYXJhY3Rl clR5cGU+KCk7CiAKQEAgLTExNDk4LDYgKzExNDk5LDcgQEAgcmVzdGFydEFmdGVyQ29tbWVudDoK IAogICAgICAgICAgICAgbV90b2tlbiA9IExBTkdSQU5HRTsKICAgICAgICAgICAgIHl5bHZhbC0+ c3RyaW5nLmluaXQocGFyc2VkTGFuZ1JhbmdlLnRvU3RyaW5nKCkpOworI2VuZGlmCiAgICAgICAg IH0KICAgICAgICAgYnJlYWs7CiAK