<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>139330</bug_id>
          
          <creation_ts>2014-12-05 18:04:52 -0800</creation_ts>
          <short_desc>AX: I cannot activate links on the mobile version of news.google.com</short_desc>
          <delta_ts>2014-12-05 21:44:06 -0800</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Accessibility</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords>InRadar</keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="chris fleizach">cfleizach</reporter>
          <assigned_to name="chris fleizach">cfleizach</assigned_to>
          <cc>aboxhall</cc>
    
    <cc>apinheiro</cc>
    
    <cc>commit-queue</cc>
    
    <cc>dmazzoni</cc>
    
    <cc>jcraig</cc>
    
    <cc>jdiggs</cc>
    
    <cc>mario</cc>
    
    <cc>samuel_white</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>webkit-bug-importer</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>1052950</commentid>
    <comment_count>0</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2014-12-05 18:04:52 -0800</bug_when>
    <thetext>If I visit news.google.com on iPhone with VOT enabled, the mobile version by default appears. If I touch Top Stories, swipe once to the right, then double tap to activate the first top story link, nothing ahppens. Turn off VO and do the same, you’ll be brought to the proper location, which may mean a new tab.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052951</commentid>
    <comment_count>1</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2014-12-05 18:05:18 -0800</bug_when>
    <thetext>This is because news.google only listens for touch events and ignores all other kinds of clicks.
we need to simulate a touch event</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052954</commentid>
    <comment_count>2</comment_count>
      <attachid>242691</attachid>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2014-12-05 18:09:43 -0800</bug_when>
    <thetext>Created attachment 242691
patch</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052961</commentid>
    <comment_count>3</comment_count>
      <attachid>242691</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2014-12-05 19:04:53 -0800</bug_when>
    <thetext>Comment on attachment 242691
patch

View in context: https://bugs.webkit.org/attachment.cgi?id=242691&amp;action=review

&gt; Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:278
&gt; +            PlatformTouchPoint::TouchPhaseType touchPhase;
&gt; +            switch (type) {
&gt; +            case PlatformEvent::TouchStart:
&gt; +                touchPhase = PlatformTouchPoint::TouchPhaseBegan;
&gt; +                break;
&gt; +            case PlatformEvent::TouchMove:
&gt; +                touchPhase = PlatformTouchPoint::TouchPhaseMoved;
&gt; +                break;
&gt; +            case PlatformEvent::TouchEnd:
&gt; +                touchPhase = PlatformTouchPoint::TouchPhaseEnded;
&gt; +                break;
&gt; +            default:
&gt; +                ASSERT_NOT_REACHED();
&gt; +                break;
&gt; +            }

Would be nice to pull this enum translation out into a small separate function.

&gt; Source/WebCore/accessibility/AccessibilityObject.h:757
&gt; +    virtual bool isDetachedFromParent() { return false; }

Is this relevant?

&gt; LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events.html:42
&gt; +//    window.jsTestIsAsync = true;
&gt; +
&gt; +    if (window.accessibilityController) {
&gt; +
&gt; +        var button = accessibilityController.accessibleElementById(&quot;button&quot;);
&gt; +        button.press();
&gt; +    }
&gt; +//    if (window.testRunner)
&gt; +  //      testRunner.waitUntilDone();

You have some commented-out code here.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052980</commentid>
    <comment_count>4</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2014-12-05 21:31:03 -0800</bug_when>
    <thetext>(In reply to comment #3)
&gt; Comment on attachment 242691 [details]
&gt; patch
&gt; 
&gt; View in context:
&gt; https://bugs.webkit.org/attachment.cgi?id=242691&amp;action=review
&gt; 
&gt; &gt; Source/WebCore/platform/ios/PlatformEventFactoryIOS.mm:278
&gt; &gt; +            PlatformTouchPoint::TouchPhaseType touchPhase;
&gt; &gt; +            switch (type) {
&gt; &gt; +            case PlatformEvent::TouchStart:
&gt; &gt; +                touchPhase = PlatformTouchPoint::TouchPhaseBegan;
&gt; &gt; +                break;
&gt; &gt; +            case PlatformEvent::TouchMove:
&gt; &gt; +                touchPhase = PlatformTouchPoint::TouchPhaseMoved;
&gt; &gt; +                break;
&gt; &gt; +            case PlatformEvent::TouchEnd:
&gt; &gt; +                touchPhase = PlatformTouchPoint::TouchPhaseEnded;
&gt; &gt; +                break;
&gt; &gt; +            default:
&gt; &gt; +                ASSERT_NOT_REACHED();
&gt; &gt; +                break;
&gt; &gt; +            }
&gt; 
&gt; Would be nice to pull this enum translation out into a small separate
&gt; function.

Will do

&gt; 
&gt; &gt; Source/WebCore/accessibility/AccessibilityObject.h:757
&gt; &gt; +    virtual bool isDetachedFromParent() { return false; }
&gt; 
&gt; Is this relevant?

Left over from another patch. Thanks.
&gt; 
&gt; &gt; LayoutTests/platform/ios-simulator/ios-accessibility/press-fires-touch-events.html:42
&gt; &gt; +//    window.jsTestIsAsync = true;
&gt; &gt; +
&gt; &gt; +    if (window.accessibilityController) {
&gt; &gt; +
&gt; &gt; +        var button = accessibilityController.accessibleElementById(&quot;button&quot;);
&gt; &gt; +        button.press();
&gt; &gt; +    }
&gt; &gt; +//    if (window.testRunner)
&gt; &gt; +  //      testRunner.waitUntilDone();
&gt; 
&gt; You have some commented-out code here.

Thanks for review</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>1052986</commentid>
    <comment_count>5</comment_count>
    <who name="chris fleizach">cfleizach</who>
    <bug_when>2014-12-05 21:44:06 -0800</bug_when>
    <thetext>http://trac.webkit.org/changeset/176904</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>242691</attachid>
            <date>2014-12-05 18:09:43 -0800</date>
            <delta_ts>2014-12-05 19:04:53 -0800</delta_ts>
            <desc>patch</desc>
            <filename>patch</filename>
            <type>text/plain</type>
            <size>12262</size>
            <attacher name="chris fleizach">cfleizach</attacher>
            
              <data encoding="base64">SW5kZXg6IFNvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBTb3VyY2UvV2Vi
Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDE3NjkwMSkKKysrIFNvdXJjZS9XZWJDb3JlL0NoYW5n
ZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMwIEBACisyMDE0LTEyLTA1ICBDaHJpcyBG
bGVpemFjaCAgPGNmbGVpemFjaEBhcHBsZS5jb20+CisKKyAgICAgICAgQVg6IEkgY2Fubm90IGFj
dGl2YXRlIGxpbmtzIG9uIHRoZSBtb2JpbGUgdmVyc2lvbiBvZiBuZXdzLmdvb2dsZS5jb20KKyAg
ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTMzMAorCisg
ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgd2Vic2l0
ZSBvbmx5IGxpc3RlbnMgZm9yIHRvdWNoIGV2ZW50cy4gVm9pY2VPdmVyIG5vcm1hbGx5IGRpc3Bh
dGNoZXMgY2xpY2sgYW5kIG1vdXNlIGV2ZW50cywKKyAgICAgICAgc28gb24gaU9TIHRoaXMgZmFs
bHMgYW5kIFZvaWNlT3ZlciBpcyBub3QgYWJsZSB0byBhY3RpdmF0ZSBhbnl0aGluZy4KKworICAg
ICAgICBUaGUgc29sdXRpb24gaGVyZSBpcyB0byBkaXNwYXRjaCBzaW11bGF0ZWQgdG91Y2ggZG93
bi91cCBldmVudHMuCisKKyAgICAgICAgVGVzdDogcGxhdGZvcm0vaW9zLXNpbXVsYXRvci9pb3Mt
YWNjZXNzaWJpbGl0eS9wcmVzcy1maXJlcy10b3VjaC1ldmVudHMuaHRtbAorCisgICAgICAgICog
YWNjZXNzaWJpbGl0eS9BY2Nlc3NpYmlsaXR5T2JqZWN0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6
OkFjY2Vzc2liaWxpdHlPYmplY3Q6OnByZXNzKToKKyAgICAgICAgKFdlYkNvcmU6OkFjY2Vzc2li
aWxpdHlPYmplY3Q6OmRpc3BhdGNoVG91Y2hFdmVudCk6CisgICAgICAgICogYWNjZXNzaWJpbGl0
eS9BY2Nlc3NpYmlsaXR5T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpBY2Nlc3NpYmlsaXR5
T2JqZWN0Ojppc0RldGFjaGVkRnJvbVBhcmVudCk6CisgICAgICAgICogcGFnZS9FdmVudEhhbmRs
ZXIuaDoKKyAgICAgICAgKiBwYWdlL2lvcy9FdmVudEhhbmRsZXJJT1MubW06CisgICAgICAgIChX
ZWJDb3JlOjpFdmVudEhhbmRsZXI6OmRpc3BhdGNoU2ltdWxhdGVkVG91Y2hFdmVudCk6CisgICAg
ICAgICogcGxhdGZvcm0vaW9zL1BsYXRmb3JtRXZlbnRGYWN0b3J5SU9TLmg6CisgICAgICAgICog
cGxhdGZvcm0vaW9zL1BsYXRmb3JtRXZlbnRGYWN0b3J5SU9TLm1tOgorICAgICAgICAoV2ViQ29y
ZTo6UGxhdGZvcm1Ub3VjaEV2ZW50QnVpbGRlcjo6UGxhdGZvcm1Ub3VjaEV2ZW50QnVpbGRlcik6
CisgICAgICAgIChXZWJDb3JlOjpQbGF0Zm9ybUV2ZW50RmFjdG9yeTo6Y3JlYXRlUGxhdGZvcm1T
aW11bGF0ZWRUb3VjaEV2ZW50KToKKwogMjAxNC0xMi0wNSAgU2ltb24gRnJhc2VyICA8c2ltb24u
ZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBQcm9ncmFtbWF0aWMgc2Nyb2xsaW5nIGFuZCBj
b250ZW50IGNoYW5nZXMgYXJlIG5vdCBhbHdheXMgc3luY2hyb25pemVkCkluZGV4OiBTb3VyY2Uv
V2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1FdmVudEZhY3RvcnlJT1MuaAo9PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1FdmVudEZhY3RvcnlJT1Mu
aAkocmV2aXNpb24gMTc2NTg5KQorKysgU291cmNlL1dlYkNvcmUvcGxhdGZvcm0vaW9zL1BsYXRm
b3JtRXZlbnRGYWN0b3J5SU9TLmgJKHdvcmtpbmcgY29weSkKQEAgLTQ1LDYgKzQ1LDcgQEAKICAg
ICBXRUJDT1JFX0VYUE9SVCBzdGF0aWMgUGxhdGZvcm1LZXlib2FyZEV2ZW50IGNyZWF0ZVBsYXRm
b3JtS2V5Ym9hcmRFdmVudChXZWJFdmVudCAqKTsKICNpZiBFTkFCTEUoVE9VQ0hfRVZFTlRTKSB8
fCBFTkFCTEUoSU9TX1RPVUNIX0VWRU5UUykKICAgICBzdGF0aWMgUGxhdGZvcm1Ub3VjaEV2ZW50
IGNyZWF0ZVBsYXRmb3JtVG91Y2hFdmVudChXZWJFdmVudCAqKTsKKyAgICBzdGF0aWMgUGxhdGZv
cm1Ub3VjaEV2ZW50IGNyZWF0ZVBsYXRmb3JtU2ltdWxhdGVkVG91Y2hFdmVudChQbGF0Zm9ybUV2
ZW50OjpUeXBlLCBJbnRQb2ludCBsb2NhdGlvbik7CiAjZW5kaWYKIH07CiAKSW5kZXg6IFNvdXJj
ZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9QbGF0Zm9ybUV2ZW50RmFjdG9yeUlPUy5tbQo9PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09Ci0tLSBTb3VyY2UvV2ViQ29yZS9wbGF0Zm9ybS9pb3MvUGxhdGZvcm1FdmVudEZhY3RvcnlJ
T1MubW0JKHJldmlzaW9uIDE3NjU4OSkKKysrIFNvdXJjZS9XZWJDb3JlL3BsYXRmb3JtL2lvcy9Q
bGF0Zm9ybUV2ZW50RmFjdG9yeUlPUy5tbQkod29ya2luZyBjb3B5KQpAQCAtMjQ2LDEyICsyNDYs
NTMgQEAKICAgICAgICAgICAgIG1fdG91Y2hQb2ludHMudW5jaGVja2VkQXBwZW5kKFBsYXRmb3Jt
VG91Y2hQb2ludEJ1aWxkZXIoaWRlbnRpZmllciwgbG9jYXRpb24sIHRvdWNoUGhhc2UpKTsKICAg
ICAgICAgfQogICAgIH0KKyAgICAKKyAgICBQbGF0Zm9ybVRvdWNoRXZlbnRCdWlsZGVyKFBsYXRm
b3JtRXZlbnQ6OlR5cGUgdHlwZSwgSW50UG9pbnQgbG9jYXRpb24pCisgICAgeworICAgICAgICBt
X3R5cGUgPSB0eXBlOworICAgICAgICBtX3RpbWVzdGFtcCA9IGN1cnJlbnRUaW1lKCk7CisgICAg
ICAgIAorICAgICAgICBtX2dlc3R1cmVTY2FsZSA9IDE7CisgICAgICAgIG1fZ2VzdHVyZVJvdGF0
aW9uID0gMDsKKyAgICAgICAgbV9pc0dlc3R1cmUgPSAwOworICAgICAgICBtX3Bvc2l0aW9uID0g
bG9jYXRpb247CisgICAgICAgIG1fZ2xvYmFsUG9zaXRpb24gPSBsb2NhdGlvbjsKKyAgICAgICAg
CisgICAgICAgIHVuc2lnbmVkIHRvdWNoQ291bnQgPSAxOworICAgICAgICBtX3RvdWNoUG9pbnRz
LnJlc2VydmVJbml0aWFsQ2FwYWNpdHkodG91Y2hDb3VudCk7CisgICAgICAgIGZvciAodW5zaWdu
ZWQgaSA9IDA7IGkgPCB0b3VjaENvdW50OyArK2kpIHsKKyAgICAgICAgICAgIFBsYXRmb3JtVG91
Y2hQb2ludDo6VG91Y2hQaGFzZVR5cGUgdG91Y2hQaGFzZTsKKyAgICAgICAgICAgIHN3aXRjaCAo
dHlwZSkgeworICAgICAgICAgICAgY2FzZSBQbGF0Zm9ybUV2ZW50OjpUb3VjaFN0YXJ0OgorICAg
ICAgICAgICAgICAgIHRvdWNoUGhhc2UgPSBQbGF0Zm9ybVRvdWNoUG9pbnQ6OlRvdWNoUGhhc2VC
ZWdhbjsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIGNhc2UgUGxhdGZvcm1F
dmVudDo6VG91Y2hNb3ZlOgorICAgICAgICAgICAgICAgIHRvdWNoUGhhc2UgPSBQbGF0Zm9ybVRv
dWNoUG9pbnQ6OlRvdWNoUGhhc2VNb3ZlZDsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAg
ICAgICAgIGNhc2UgUGxhdGZvcm1FdmVudDo6VG91Y2hFbmQ6CisgICAgICAgICAgICAgICAgdG91
Y2hQaGFzZSA9IFBsYXRmb3JtVG91Y2hQb2ludDo6VG91Y2hQaGFzZUVuZGVkOworICAgICAgICAg
ICAgICAgIGJyZWFrOworICAgICAgICAgICAgZGVmYXVsdDoKKyAgICAgICAgICAgICAgICBBU1NF
UlRfTk9UX1JFQUNIRUQoKTsKKyAgICAgICAgICAgICAgICBicmVhazsKKyAgICAgICAgICAgIH0K
KyAgICAgICAgICAgIAorICAgICAgICAgICAgdW5zaWduZWQgaWRlbnRpZmllciA9IDE7CisgICAg
ICAgICAgICBtX3RvdWNoUG9pbnRzLnVuY2hlY2tlZEFwcGVuZChQbGF0Zm9ybVRvdWNoUG9pbnRC
dWlsZGVyKGlkZW50aWZpZXIsIGxvY2F0aW9uLCB0b3VjaFBoYXNlKSk7CisgICAgICAgIH0KKyAg
ICB9CiB9OwogCiBQbGF0Zm9ybVRvdWNoRXZlbnQgUGxhdGZvcm1FdmVudEZhY3Rvcnk6OmNyZWF0
ZVBsYXRmb3JtVG91Y2hFdmVudChXZWJFdmVudCAqZXZlbnQpCiB7CiAgICAgcmV0dXJuIFBsYXRm
b3JtVG91Y2hFdmVudEJ1aWxkZXIoZXZlbnQpOwogfQorICAgIAorUGxhdGZvcm1Ub3VjaEV2ZW50
IFBsYXRmb3JtRXZlbnRGYWN0b3J5OjpjcmVhdGVQbGF0Zm9ybVNpbXVsYXRlZFRvdWNoRXZlbnQo
UGxhdGZvcm1FdmVudDo6VHlwZSB0eXBlLCBJbnRQb2ludCBsb2NhdGlvbikKK3sKKyAgICByZXR1
cm4gUGxhdGZvcm1Ub3VjaEV2ZW50QnVpbGRlcih0eXBlLCBsb2NhdGlvbik7Cit9CisKICNlbmRp
ZiAvLyBFTkFCTEUoVE9VQ0hfRVZFTlRTKQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCkluZGV4
OiBTb3VyY2UvV2ViQ29yZS9wYWdlL0V2ZW50SGFuZGxlci5oCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJj
ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgJKHJldmlzaW9uIDE3NjU4OSkKKysrIFNvdXJj
ZS9XZWJDb3JlL3BhZ2UvRXZlbnRIYW5kbGVyLmgJKHdvcmtpbmcgY29weSkKQEAgLTIxMCw2ICsy
MTAsNyBAQAogCiAjaWYgRU5BQkxFKElPU19UT1VDSF9FVkVOVFMpCiAgICAgYm9vbCBkaXNwYXRj
aFRvdWNoRXZlbnQoY29uc3QgUGxhdGZvcm1Ub3VjaEV2ZW50JiwgY29uc3QgQXRvbWljU3RyaW5n
JiwgY29uc3QgRXZlbnRUYXJnZXRUb3VjaE1hcCYsIGZsb2F0LCBmbG9hdCk7CisgICAgYm9vbCBk
aXNwYXRjaFNpbXVsYXRlZFRvdWNoRXZlbnQoSW50UG9pbnQgbG9jYXRpb24pOwogI2VuZGlmCiAK
ICNpZiBFTkFCTEUoSU9TX0dFU1RVUkVfRVZFTlRTKQpJbmRleDogU291cmNlL1dlYkNvcmUvcGFn
ZS9pb3MvRXZlbnRIYW5kbGVySU9TLm1tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL3Bh
Z2UvaW9zL0V2ZW50SGFuZGxlcklPUy5tbQkocmV2aXNpb24gMTc2NTg5KQorKysgU291cmNlL1dl
YkNvcmUvcGFnZS9pb3MvRXZlbnRIYW5kbGVySU9TLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0xMDQs
NiArMTA0LDE1IEBACiB9CiAKICNpZiBFTkFCTEUoSU9TX1RPVUNIX0VWRU5UUykKKworYm9vbCBF
dmVudEhhbmRsZXI6OmRpc3BhdGNoU2ltdWxhdGVkVG91Y2hFdmVudChJbnRQb2ludCBsb2NhdGlv
bikKK3sKKyAgICBib29sIGhhbmRsZWQgPSBoYW5kbGVUb3VjaEV2ZW50KFBsYXRmb3JtRXZlbnRG
YWN0b3J5OjpjcmVhdGVQbGF0Zm9ybVNpbXVsYXRlZFRvdWNoRXZlbnQoUGxhdGZvcm1FdmVudDo6
VG91Y2hTdGFydCwgbG9jYXRpb24pKTsKKyAgICBpZiAoaGFuZGxlZCkKKyAgICAgICAgaGFuZGxl
VG91Y2hFdmVudChQbGF0Zm9ybUV2ZW50RmFjdG9yeTo6Y3JlYXRlUGxhdGZvcm1TaW11bGF0ZWRU
b3VjaEV2ZW50KFBsYXRmb3JtRXZlbnQ6OlRvdWNoRW5kLCBsb2NhdGlvbikpOworICAgIHJldHVy
biBoYW5kbGVkOworfQorICAgIAogdm9pZCBFdmVudEhhbmRsZXI6OnRvdWNoRXZlbnQoV2ViRXZl
bnQgKmV2ZW50KQogewogICAgIEN1cnJlbnRFdmVudFNjb3BlIHNjb3BlKGV2ZW50KTsKSW5kZXg6
IFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5oCj09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eU9iamVj
dC5oCShyZXZpc2lvbiAxNzY1ODkpCisrKyBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0Fj
Y2Vzc2liaWxpdHlPYmplY3QuaAkod29ya2luZyBjb3B5KQpAQCAtNzU0LDYgKzc1NCw3IEBACiAj
ZWxzZQogICAgIHZpcnR1YWwgdm9pZCBkZXRhY2hGcm9tUGFyZW50KCkgeyB9CiAjZW5kaWYKKyAg
ICB2aXJ0dWFsIGJvb2wgaXNEZXRhY2hlZEZyb21QYXJlbnQoKSB7IHJldHVybiBmYWxzZTsgfQog
CiAgICAgdmlydHVhbCB2b2lkIHNlbGVjdGVkQ2hpbGRyZW4oQWNjZXNzaWJpbGl0eUNoaWxkcmVu
VmVjdG9yJikgeyB9CiAgICAgdmlydHVhbCB2b2lkIHZpc2libGVDaGlsZHJlbihBY2Nlc3NpYmls
aXR5Q2hpbGRyZW5WZWN0b3ImKSB7IH0KQEAgLTk4MCw3ICs5ODEsOCBAQAogICAgIHN0YXRpYyBi
b29sIG9iamVjdE1hdGNoZXNTZWFyY2hDcml0ZXJpYVdpdGhSZXN1bHRMaW1pdChBY2Nlc3NpYmls
aXR5T2JqZWN0KiwgQWNjZXNzaWJpbGl0eVNlYXJjaENyaXRlcmlhKiwgQWNjZXNzaWJpbGl0eUNo
aWxkcmVuVmVjdG9yJik7CiAgICAgdmlydHVhbCBBY2Nlc3NpYmlsaXR5Um9sZSBidXR0b25Sb2xl
VHlwZSgpIGNvbnN0OwogICAgIGJvb2wgaXNPbnNjcmVlbigpIGNvbnN0OwotICAgIAorICAgIGJv
b2wgZGlzcGF0Y2hUb3VjaEV2ZW50KCk7CisKICNpZiAoUExBVEZPUk0oR1RLKSB8fCBQTEFURk9S
TShFRkwpKSAmJiBIQVZFKEFDQ0VTU0lCSUxJVFkpCiAgICAgYm9vbCBhbGxvd3NUZXh0UmFuZ2Vz
KCkgY29uc3Q7CiAgICAgdW5zaWduZWQgZ2V0TGVuZ3RoRm9yVGV4dFJhbmdlKCkgY29uc3Q7Cklu
ZGV4OiBTb3VyY2UvV2ViQ29yZS9hY2Nlc3NpYmlsaXR5L0FjY2Vzc2liaWxpdHlPYmplY3QuY3Bw
Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT0KLS0tIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0
eU9iamVjdC5jcHAJKHJldmlzaW9uIDE3NjU4OSkKKysrIFNvdXJjZS9XZWJDb3JlL2FjY2Vzc2li
aWxpdHkvQWNjZXNzaWJpbGl0eU9iamVjdC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM1LDYgKzM1
LDcgQEAKICNpbmNsdWRlICJBY2Nlc3NpYmlsaXR5VGFibGUuaCIKICNpbmNsdWRlICJET01Ub2tl
bkxpc3QuaCIKICNpbmNsdWRlICJFZGl0b3IuaCIKKyNpbmNsdWRlICJFdmVudEhhbmRsZXIuaCIK
ICNpbmNsdWRlICJGbG9hdFJlY3QuaCIKICNpbmNsdWRlICJGb2N1c0NvbnRyb2xsZXIuaCIKICNp
bmNsdWRlICJGcmFtZS5oIgpAQCAtODY5LDEwICs4NzAsMjcgQEAKICAgICAgICAgcHJlc3NFbGVt
ZW50ID0gaGl0VGVzdEVsZW1lbnQ7CiAgICAgCiAgICAgVXNlckdlc3R1cmVJbmRpY2F0b3IgZ2Vz
dHVyZUluZGljYXRvcihEZWZpbml0ZWx5UHJvY2Vzc2luZ1VzZXJHZXN0dXJlLCBkb2N1bWVudCk7
Ci0gICAgcHJlc3NFbGVtZW50LT5hY2Nlc3NLZXlBY3Rpb24odHJ1ZSk7CisgICAgCisgICAgYm9v
bCBkaXNwYXRjaGVkVG91Y2hFdmVudCA9IGRpc3BhdGNoVG91Y2hFdmVudCgpOworICAgIGlmICgh
ZGlzcGF0Y2hlZFRvdWNoRXZlbnQpCisgICAgICAgIHByZXNzRWxlbWVudC0+YWNjZXNzS2V5QWN0
aW9uKHRydWUpOworICAgIAogICAgIHJldHVybiB0cnVlOwogfQorICAgIAorYm9vbCBBY2Nlc3Np
YmlsaXR5T2JqZWN0OjpkaXNwYXRjaFRvdWNoRXZlbnQoKQoreworICAgIGJvb2wgaGFuZGxlZCA9
IGZhbHNlOworI2lmIEVOQUJMRShJT1NfVE9VQ0hfRVZFTlRTKQorICAgIE1haW5GcmFtZSogZnJh
bWUgPSBtYWluRnJhbWUoKTsKKyAgICBpZiAoIWZyYW1lKQorICAgICAgICByZXR1cm4gZmFsc2U7
CiAKKyAgICBmcmFtZS0+ZXZlbnRIYW5kbGVyKCkuZGlzcGF0Y2hTaW11bGF0ZWRUb3VjaEV2ZW50
KGNsaWNrUG9pbnQoKSk7CisjZW5kaWYKKyAgICByZXR1cm4gaGFuZGxlZDsKK30KKwogRnJhbWUq
IEFjY2Vzc2liaWxpdHlPYmplY3Q6OmZyYW1lKCkgY29uc3QKIHsKICAgICBOb2RlKiBub2RlID0g
dGhpcy0+bm9kZSgpOwpJbmRleDogVG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFRvb2xz
L0NoYW5nZUxvZwkocmV2aXNpb24gMTc2OTAxKQorKysgVG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5n
IGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTQtMTItMDUgIENocmlzIEZsZWl6YWNoICA8Y2Zs
ZWl6YWNoQGFwcGxlLmNvbT4KKworICAgICAgICBBWDogSSBjYW5ub3QgYWN0aXZhdGUgbGlua3Mg
b24gdGhlIG1vYmlsZSB2ZXJzaW9uIG9mIG5ld3MuZ29vZ2xlLmNvbQorICAgICAgICBodHRwczov
L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MTM5MzMwCisKKyAgICAgICAgUmV2aWV3
ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgSW1wbGVtZW50IHByZXNzIGZvciBpT1Mu
CisKKyAgICAgICAgKiBEdW1wUmVuZGVyVHJlZS9pb3MvQWNjZXNzaWJpbGl0eVVJRWxlbWVudElP
Uy5tbToKKyAgICAgICAgKEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OnByZXNzKToKKwogMjAxNC0x
Mi0wNSAgRGFuaWVsIEJhdGVzICA8ZGFiYXRlc0BhcHBsZS5jb20+CiAKICAgICAgICAgW2lPU10g
UXVlcnkgLVtXQUtXaW5kb3cgc2NyZWVuU2NhbGVdIGluc3RlYWQgb2YgdXNpbmcgV0tHZXRTY3Jl
ZW5TY2FsZUZhY3RvcigpCkluZGV4OiBUb29scy9EdW1wUmVuZGVyVHJlZS9pb3MvQWNjZXNzaWJp
bGl0eVVJRWxlbWVudElPUy5tbQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBUb29scy9EdW1wUmVuZGVyVHJlZS9p
b3MvQWNjZXNzaWJpbGl0eVVJRWxlbWVudElPUy5tbQkocmV2aXNpb24gMTc2NTg5KQorKysgVG9v
bHMvRHVtcFJlbmRlclRyZWUvaW9zL0FjY2Vzc2liaWxpdHlVSUVsZW1lbnRJT1MubW0JKHdvcmtp
bmcgY29weSkKQEAgLTc3LDYgKzc3LDcgQEAKIC0gKENHRmxvYXQpX2FjY2Vzc2liaWxpdHlNaW5W
YWx1ZTsKIC0gKENHRmxvYXQpX2FjY2Vzc2liaWxpdHlNYXhWYWx1ZTsKIC0gKHZvaWQpX2FjY2Vz
c2liaWxpdHlTZXRWYWx1ZTooTlNTdHJpbmcgKil2YWx1ZTsKKy0gKHZvaWQpX2FjY2Vzc2liaWxp
dHlBY3RpdmF0ZTsKIEBlbmQKIAogQGludGVyZmFjZSBOU09iamVjdCAoV2ViQWNjZXNzaWJpbGl0
eU9iamVjdFdyYXBwZXJQcml2YXRlKQpAQCAtNzA0LDYgKzcwNSw3IEBACiAKIHZvaWQgQWNjZXNz
aWJpbGl0eVVJRWxlbWVudDo6cHJlc3MoKQogeworICAgIFttX2VsZW1lbnQgX2FjY2Vzc2liaWxp
dHlBY3RpdmF0ZV07CiB9CiAKIEpTU3RyaW5nUmVmIEFjY2Vzc2liaWxpdHlVSUVsZW1lbnQ6OmFj
Y2Vzc2liaWxpdHlWYWx1ZSgpIGNvbnN0CkluZGV4OiBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cKPT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PQotLS0gTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCShyZXZpc2lvbiAxNzY5MDEpCisrKyBM
YXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAx
NC0xMi0wNSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgorCisgICAgICAg
IEFYOiBJIGNhbm5vdCBhY3RpdmF0ZSBsaW5rcyBvbiB0aGUgbW9iaWxlIHZlcnNpb24gb2YgbmV3
cy5nb29nbGUuY29tCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0xMzkzMzAKKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg
ICAgICAqIHBsYXRmb3JtL2lvcy1zaW11bGF0b3IvaW9zLWFjY2Vzc2liaWxpdHk6IEFkZGVkLgor
ICAgICAgICAqIHBsYXRmb3JtL2lvcy1zaW11bGF0b3IvaW9zLWFjY2Vzc2liaWxpdHkvcHJlc3Mt
ZmlyZXMtdG91Y2gtZXZlbnRzLWV4cGVjdGVkLnR4dDogQWRkZWQuCisgICAgICAgICogcGxhdGZv
cm0vaW9zLXNpbXVsYXRvci9pb3MtYWNjZXNzaWJpbGl0eS9wcmVzcy1maXJlcy10b3VjaC1ldmVu
dHMuaHRtbDogQWRkZWQuCisKIDIwMTQtMTItMDUgIEJlbmphbWluIFBvdWxhaW4gIDxicG91bGFp
bkBhcHBsZS5jb20+CiAKICAgICAgICAgRml4IHN0eWxlIHNoYXJpbmcgd2l0aCB0aGUgInR5cGUi
IGFuZCAicmVhZG9ubHkiIGF0dHJpYnV0ZXMKSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL2lv
cy1zaW11bGF0b3IvaW9zLWFjY2Vzc2liaWxpdHkvcHJlc3MtZmlyZXMtdG91Y2gtZXZlbnRzLWV4
cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxh
dG9yL2lvcy1hY2Nlc3NpYmlsaXR5L3ByZXNzLWZpcmVzLXRvdWNoLWV2ZW50cy1leHBlY3RlZC50
eHQJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yL2lv
cy1hY2Nlc3NpYmlsaXR5L3ByZXNzLWZpcmVzLXRvdWNoLWV2ZW50cy1leHBlY3RlZC50eHQJKHdv
cmtpbmcgY29weSkKQEAgLTAsMCArMSwxMiBAQAorYnV0dG9uCitFbnN1cmUgdGhhdCBpZiBhbiBl
bGVtZW50IG9uIGhhbmRsZXMgdG91Y2ggZXZlbnRzLCB0aGUgc2ltdWxhdGVkIGFjY2Vzc2liaWxp
dHkgcHJlc3Mgd2lsbCBzdGlsbCBhY3RpdmF0ZSB0aG9zZSBlbGVtZW50cy4KKworT24gc3VjY2Vz
cywgeW91IHdpbGwgc2VlIGEgc2VyaWVzIG9mICJQQVNTIiBtZXNzYWdlcywgZm9sbG93ZWQgYnkg
IlRFU1QgQ09NUExFVEUiLgorCisKK1JlY2VpdmVkIHRvdWNoIHN0YXJ0IFtvYmplY3QgVG91Y2hF
dmVudF0KK1JlY2VpdmVkIHRvdWNoIGVuZGVkIFtvYmplY3QgVG91Y2hFdmVudF0KK1BBU1Mgc3Vj
Y2Vzc2Z1bGx5UGFyc2VkIGlzIHRydWUKKworVEVTVCBDT01QTEVURQorCkluZGV4OiBMYXlvdXRU
ZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yL2lvcy1hY2Nlc3NpYmlsaXR5L3ByZXNzLWZpcmVz
LXRvdWNoLWV2ZW50cy5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09
PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL2lv
cy1zaW11bGF0b3IvaW9zLWFjY2Vzc2liaWxpdHkvcHJlc3MtZmlyZXMtdG91Y2gtZXZlbnRzLmh0
bWwJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0cy9wbGF0Zm9ybS9pb3Mtc2ltdWxhdG9yL2lv
cy1hY2Nlc3NpYmlsaXR5L3ByZXNzLWZpcmVzLXRvdWNoLWV2ZW50cy5odG1sCSh3b3JraW5nIGNv
cHkpCkBAIC0wLDAgKzEsNTEgQEAKKzwhRE9DVFlQRSBIVE1MIFBVQkxJQyAiLS8vSUVURi8vRFRE
IEhUTUwvL0VOIj4KKzxodG1sPgorPGhlYWQ+Cis8c2NyaXB0IHNyYz0iLi4vLi4vLi4vcmVzb3Vy
Y2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzY3JpcHQ+Cit2YXIgc3VjY2Vzc2Z1bGx5
UGFyc2VkID0gZmFsc2U7CitpZiAod2luZG93LnRlc3RSdW5uZXIpCisgICB0ZXN0UnVubmVyLmR1
bXBBc1RleHQoKTsKKworZnVuY3Rpb24gdG91Y2hFbmQoZXZlbnQpIHsKKyAgICBkZWJ1ZygiUmVj
ZWl2ZWQgdG91Y2ggZW5kZWQgIiArIGV2ZW50KTsKKyAgICBldmVudC5zdG9wUHJvcGFnYXRpb24o
KTsgCisgICAgZXZlbnQucHJldmVudERlZmF1bHQoKTsKK30KKworZnVuY3Rpb24gdG91Y2hTdGFy
dChldmVudCkgeworICAgIGRlYnVnKCJSZWNlaXZlZCB0b3VjaCBzdGFydCAiICsgZXZlbnQpOwor
ICAgIGV2ZW50LnN0b3BQcm9wYWdhdGlvbigpOyAKKyAgICBldmVudC5wcmV2ZW50RGVmYXVsdCgp
OworfQorCis8L3NjcmlwdD4KKzwvaGVhZD4KKzxib2R5PgorCis8ZGl2IHJvbGU9ImJ1dHRvbiIg
aWQ9ImJ1dHRvbiIgb250b3VjaHN0YXJ0PSJ0b3VjaFN0YXJ0KGV2ZW50KTsiIG9udG91Y2hlbmQ9
InRvdWNoRW5kKGV2ZW50KTsiPmJ1dHRvbjwvZGl2PgorCis8cCBpZD0iZGVzY3JpcHRpb24iPjwv
cD4KKzxkaXYgaWQ9ImNvbnNvbGUiPjwvZGl2PgorCis8c2NyaXB0PgorCisgICAgZGVzY3JpcHRp
b24oIkVuc3VyZSB0aGF0IGlmIGFuIGVsZW1lbnQgb24gaGFuZGxlcyB0b3VjaCBldmVudHMsIHRo
ZSBzaW11bGF0ZWQgYWNjZXNzaWJpbGl0eSBwcmVzcyB3aWxsIHN0aWxsIGFjdGl2YXRlIHRob3Nl
IGVsZW1lbnRzLiIpOworLy8gICAgd2luZG93LmpzVGVzdElzQXN5bmMgPSB0cnVlOworCisgICAg
aWYgKHdpbmRvdy5hY2Nlc3NpYmlsaXR5Q29udHJvbGxlcikgeworCisgICAgICAgIHZhciBidXR0
b24gPSBhY2Nlc3NpYmlsaXR5Q29udHJvbGxlci5hY2Nlc3NpYmxlRWxlbWVudEJ5SWQoImJ1dHRv
biIpOworICAgICAgICBidXR0b24ucHJlc3MoKTsKKyAgICB9CisvLyAgICBpZiAod2luZG93LnRl
c3RSdW5uZXIpCisgIC8vICAgICAgdGVzdFJ1bm5lci53YWl0VW50aWxEb25lKCk7CisKKyAgICBz
dWNjZXNzZnVsbHlQYXJzZWQgPSB0cnVlOworPC9zY3JpcHQ+CisKKzxzY3JpcHQgc3JjPSIuLi8u
Li8uLi9yZXNvdXJjZXMvanMtdGVzdC1wb3N0LmpzIj48L3NjcmlwdD4KKworPC9ib2R5PgorPC9o
dG1sPgorCg==
</data>
<flag name="review"
          id="267559"
          type_id="1"
          status="+"
          setter="simon.fraser"
    />
          </attachment>
      

    </bug>

</bugzilla>