139327 2014-12-05 17:07:55 -0800 CFA wrongly assumes that a speculation for SlowPutArrayStorageShape disallows ArrayStorageShape arrays 2014-12-08 14:13:34 -0800 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED InRadar P2 Normal --- 1 mark.lam mark.lam fpizlo ggaren mmirman msaboff webkit-bug-importer oldest_to_newest 1052932 0 mark.lam 2014-12-05 17:07:55 -0800 The code generator speculation checks for SlowPutArrayStorageShape explicitly allows ArrayStorageShape arrays. The runtime slow paths that handles SlowPutArrayStorageShape is also capable of handling ArrayStorageShape arrays. As a result, the CFA may declare some basic blocks as unreachable though the code generator expects otherwise. 1052933 1 mark.lam 2014-12-05 17:09:20 -0800 <rdar://problem/18604058> 1052935 2 webkit-bug-importer 2014-12-05 17:09:49 -0800 <rdar://problem/19164372> 1052938 3 242687 mark.lam 2014-12-05 17:18:14 -0800 Created attachment 242687 the patch Regression tests and benchmarks are in progress. 1052944 4 mark.lam 2014-12-05 17:31:41 -0800 Will write a regression test for this soon: https://bugs.webkit.org/show_bug.cgi?id=139328 1052945 5 242687 fpizlo 2014-12-05 17:32:10 -0800 Comment on attachment 242687 the patch Test? Otherwise LGTM. 1053508 6 242846 mark.lam 2014-12-08 13:52:47 -0800 Created attachment 242846 patch 2 with test added. 1053511 7 242846 msaboff 2014-12-08 14:08:27 -0800 Comment on attachment 242846 patch 2 with test added. r=me 1053514 8 mark.lam 2014-12-08 14:12:33 -0800 Thanks for the review. Landed in r176972: <http://trac.webkit.org/r176972>. 1053516 9 mark.lam 2014-12-08 14:13:34 -0800 *** Bug 139328 has been marked as a duplicate of this bug. *** 242687 2014-12-05 17:18:14 -0800 2014-12-08 13:52:47 -0800 the patch bug-139327.patch text/plain 1981 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2ODk3KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTEyLTA1ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD RkEgd3JvbmdseSBhc3N1bWVzIHRoYXQgYSBzcGVjdWxhdGlvbiBmb3IgU2xvd1B1dEFycmF5U3Rv cmFnZVNoYXBlIGRpc2FsbG93cyBBcnJheVN0b3JhZ2VTaGFwZSBhcnJheXMuCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xMzkzMjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGUgZ2VuZXJhdG9yIGFuZCBydW50aW1lIHNsb3cg cGF0aHMgZXhwZWN0cyBvdGhlcndpc2UuICBUaGlzIHBhdGNoIGZpeGVzCisgICAgICAgIENGQSB0 byBtYXRjaCB0aGUgY29kZSBnZW5lcmF0b3IncyBleHBlY3RhdGlvbi4KKworICAgICAgICAqIGRm Zy9ERkdBcnJheU1vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpBcnJheU1vZGU6OmFycmF5TW9k ZXNUaGF0UGFzc0ZpbHRlcmluZyk6CisgICAgICAgIChKU0M6OkRGRzo6QXJyYXlNb2RlOjphcnJh eU1vZGVzV2l0aEluZGV4aW5nU2hhcGVzKToKKwogMjAxNC0xMi0wNSAgUm9nZXIgRm9uZyAgPHJv Z2VyX2ZvbmdAYXBwbGUuY29tPgogCiAgICAgICAgIFtXaW5dIHByb2ogZmlsZXMgY29weWluZyBv dmVyIHRvbyBtYW55IHJlc291cmNlcy4uCkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZn L0RGR0FycmF5TW9kZS5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9kZmcv REZHQXJyYXlNb2RlLmgJKHJldmlzaW9uIDE3Njg4MikKKysrIFNvdXJjZS9KYXZhU2NyaXB0Q29y ZS9kZmcvREZHQXJyYXlNb2RlLmgJKHdvcmtpbmcgY29weSkKQEAgLTQwNiw3ICs0MDYsNyBAQCBw dWJsaWM6CiAgICAgICAgIGNhc2UgQXJyYXk6OkFycmF5U3RvcmFnZToKICAgICAgICAgICAgIHJl dHVybiBhcnJheU1vZGVzV2l0aEluZGV4aW5nU2hhcGUoQXJyYXlTdG9yYWdlU2hhcGUpOwogICAg ICAgICBjYXNlIEFycmF5OjpTbG93UHV0QXJyYXlTdG9yYWdlOgotICAgICAgICAgICAgcmV0dXJu IGFycmF5TW9kZXNXaXRoSW5kZXhpbmdTaGFwZShTbG93UHV0QXJyYXlTdG9yYWdlU2hhcGUpOwor ICAgICAgICAgICAgcmV0dXJuIGFycmF5TW9kZXNXaXRoSW5kZXhpbmdTaGFwZXMoU2xvd1B1dEFy cmF5U3RvcmFnZVNoYXBlLCBBcnJheVN0b3JhZ2VTaGFwZSk7CiAgICAgICAgIGRlZmF1bHQ6CiAg ICAgICAgICAgICByZXR1cm4gYXNBcnJheU1vZGVzKE5vbkFycmF5KTsKICAgICAgICAgfQpAQCAt NDYyLDYgKzQ2MiwxMyBAQCBwcml2YXRlOgogICAgICAgICB9CiAgICAgfQogICAgIAorICAgIEFy cmF5TW9kZXMgYXJyYXlNb2Rlc1dpdGhJbmRleGluZ1NoYXBlcyhJbmRleGluZ1R5cGUgc2hhcGUx LCBJbmRleGluZ1R5cGUgc2hhcGUyKSBjb25zdAorICAgIHsKKyAgICAgICAgQXJyYXlNb2RlcyBh cnJheU1vZGUxID0gYXJyYXlNb2Rlc1dpdGhJbmRleGluZ1NoYXBlKHNoYXBlMSk7CisgICAgICAg IEFycmF5TW9kZXMgYXJyYXlNb2RlMiA9IGFycmF5TW9kZXNXaXRoSW5kZXhpbmdTaGFwZShzaGFw ZTIpOworICAgICAgICByZXR1cm4gYXJyYXlNb2RlMSB8IGFycmF5TW9kZTI7CisgICAgfQorCiAg ICAgYm9vbCBhbHJlYWR5Q2hlY2tlZChHcmFwaCYsIE5vZGUqLCBBYnN0cmFjdFZhbHVlJiwgSW5k ZXhpbmdUeXBlIHNoYXBlKSBjb25zdDsKICAgICAKICAgICB1bmlvbiB7Cg== 242846 2014-12-08 13:52:47 -0800 2014-12-08 14:08:27 -0800 patch 2 with test added. bug-139327.patch text/plain 5452 mark.lam SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2OTY4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDE3IEBA CisyMDE0LTEyLTA4ICBNYXJrIExhbSAgPG1hcmsubGFtQGFwcGxlLmNvbT4KKworICAgICAgICBD RkEgd3JvbmdseSBhc3N1bWVzIHRoYXQgYSBzcGVjdWxhdGlvbiBmb3IgU2xvd1B1dEFycmF5U3Rv cmFnZVNoYXBlIGRpc2FsbG93cyBBcnJheVN0b3JhZ2VTaGFwZSBhcnJheXMuCisgICAgICAgIDxo dHRwczovL3dlYmtpdC5vcmcvYi8xMzkzMjc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgVGhlIGNvZGUgZ2VuZXJhdG9yIGFuZCBydW50aW1lIHNsb3cg cGF0aHMgZXhwZWN0cyBvdGhlcndpc2UuICBUaGlzIHBhdGNoIGZpeGVzCisgICAgICAgIENGQSB0 byBtYXRjaCB0aGUgY29kZSBnZW5lcmF0b3IncyBleHBlY3RhdGlvbi4KKworICAgICAgICAqIGRm Zy9ERkdBcnJheU1vZGUuaDoKKyAgICAgICAgKEpTQzo6REZHOjpBcnJheU1vZGU6OmFycmF5TW9k ZXNUaGF0UGFzc0ZpbHRlcmluZyk6CisgICAgICAgIChKU0M6OkRGRzo6QXJyYXlNb2RlOjphcnJh eU1vZGVzV2l0aEluZGV4aW5nU2hhcGVzKToKKwogMjAxNC0xMi0wOCAgQ2hyaXMgRHVtZXogIDxj ZHVtZXpAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmVydCByMTc2MjkzICYgcjE3NjI3NQpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL2RmZy9ERkdBcnJheU1vZGUuaAo9PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0t LSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FycmF5TW9kZS5oCShyZXZpc2lvbiAxNzY5 NjgpCisrKyBTb3VyY2UvSmF2YVNjcmlwdENvcmUvZGZnL0RGR0FycmF5TW9kZS5oCSh3b3JraW5n IGNvcHkpCkBAIC00MDYsNyArNDA2LDcgQEAgcHVibGljOgogICAgICAgICBjYXNlIEFycmF5OjpB cnJheVN0b3JhZ2U6CiAgICAgICAgICAgICByZXR1cm4gYXJyYXlNb2Rlc1dpdGhJbmRleGluZ1No YXBlKEFycmF5U3RvcmFnZVNoYXBlKTsKICAgICAgICAgY2FzZSBBcnJheTo6U2xvd1B1dEFycmF5 U3RvcmFnZToKLSAgICAgICAgICAgIHJldHVybiBhcnJheU1vZGVzV2l0aEluZGV4aW5nU2hhcGUo U2xvd1B1dEFycmF5U3RvcmFnZVNoYXBlKTsKKyAgICAgICAgICAgIHJldHVybiBhcnJheU1vZGVz V2l0aEluZGV4aW5nU2hhcGVzKFNsb3dQdXRBcnJheVN0b3JhZ2VTaGFwZSwgQXJyYXlTdG9yYWdl U2hhcGUpOwogICAgICAgICBkZWZhdWx0OgogICAgICAgICAgICAgcmV0dXJuIGFzQXJyYXlNb2Rl cyhOb25BcnJheSk7CiAgICAgICAgIH0KQEAgLTQ2Miw2ICs0NjIsMTMgQEAgcHJpdmF0ZToKICAg ICAgICAgfQogICAgIH0KICAgICAKKyAgICBBcnJheU1vZGVzIGFycmF5TW9kZXNXaXRoSW5kZXhp bmdTaGFwZXMoSW5kZXhpbmdUeXBlIHNoYXBlMSwgSW5kZXhpbmdUeXBlIHNoYXBlMikgY29uc3QK KyAgICB7CisgICAgICAgIEFycmF5TW9kZXMgYXJyYXlNb2RlMSA9IGFycmF5TW9kZXNXaXRoSW5k ZXhpbmdTaGFwZShzaGFwZTEpOworICAgICAgICBBcnJheU1vZGVzIGFycmF5TW9kZTIgPSBhcnJh eU1vZGVzV2l0aEluZGV4aW5nU2hhcGUoc2hhcGUyKTsKKyAgICAgICAgcmV0dXJuIGFycmF5TW9k ZTEgfCBhcnJheU1vZGUyOworICAgIH0KKwogICAgIGJvb2wgYWxyZWFkeUNoZWNrZWQoR3JhcGgm LCBOb2RlKiwgQWJzdHJhY3RWYWx1ZSYsIEluZGV4aW5nVHlwZSBzaGFwZSkgY29uc3Q7CiAgICAg CiAgICAgdW5pb24gewpJbmRleDogTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0t IExheW91dFRlc3RzL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2OTY4KQorKysgTGF5b3V0VGVzdHMv Q2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTQtMTItMDggIE1h cmsgTGFtICA8bWFyay5sYW1AYXBwbGUuY29tPgorCisgICAgICAgIENGQSB3cm9uZ2x5IGFzc3Vt ZXMgdGhhdCBhIHNwZWN1bGF0aW9uIGZvciBTbG93UHV0QXJyYXlTdG9yYWdlU2hhcGUgZGlzYWxs b3dzIEFycmF5U3RvcmFnZVNoYXBlIGFycmF5cy4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9y Zy9iLzEzOTMyNz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAg ICAgICAqIGpzL2RmZy1zbG93LXB1dC1hcnJheS1zdG9yYWdlLXNwZWMtc2hvdWxkLWFsbG93LWZh c3QtYXJyYXktc3RvcmFnZS1leHBlY3RlZC50eHQ6IEFkZGVkLgorICAgICAgICAqIGpzL2RmZy1z bG93LXB1dC1hcnJheS1zdG9yYWdlLXNwZWMtc2hvdWxkLWFsbG93LWZhc3QtYXJyYXktc3RvcmFn ZS5odG1sOiBBZGRlZC4KKyAgICAgICAgKiBqcy9zY3JpcHQtdGVzdHMvZGZnLXNsb3ctcHV0LWFy cmF5LXN0b3JhZ2Utc3BlYy1zaG91bGQtYWxsb3ctZmFzdC1hcnJheS1zdG9yYWdlLmpzOiBBZGRl ZC4KKyAgICAgICAgKGZvbyk6CisgICAgICAgICh0ZXN0KToKKwogMjAxNC0xMi0wOCAgSmF2aWVy IEZlcm5hbmRleiAgPGpmZXJuYW5kZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBbQ1NTIEdyaWQg TGF5b3V0XSBHcmlkIGl0ZW1zIG11c3Qgc2V0IGEgbmV3IGZvcm1hdHRpbmcgY29udGV4dC4KSW5k ZXg6IExheW91dFRlc3RzL2pzL2RmZy1zbG93LXB1dC1hcnJheS1zdG9yYWdlLXNwZWMtc2hvdWxk LWFsbG93LWZhc3QtYXJyYXktc3RvcmFnZS1leHBlY3RlZC50eHQKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5 b3V0VGVzdHMvanMvZGZnLXNsb3ctcHV0LWFycmF5LXN0b3JhZ2Utc3BlYy1zaG91bGQtYWxsb3ct ZmFzdC1hcnJheS1zdG9yYWdlLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gMCkKKysrIExheW91dFRl c3RzL2pzL2RmZy1zbG93LXB1dC1hcnJheS1zdG9yYWdlLXNwZWMtc2hvdWxkLWFsbG93LWZhc3Qt YXJyYXktc3RvcmFnZS1leHBlY3RlZC50eHQJKHdvcmtpbmcgY29weSkKQEAgLTAsMCArMSw5IEBA CitUaGlzIHRlc3RzIHRoYXQgREZHIGdlbmVyYXRlZCBjb2RlIHNwZWN1bGF0aW5nIFNsb3dQdXRB cnJheVN0b3JhZ2VTaGFwZSBkb2Vzbid0IGNyYXNoIHdoZW4gc2VlaW5nIGZhc3QgQXJyYXlTdG9y YWdlU2hhcGVzLgorCitPbiBzdWNjZXNzLCB5b3Ugd2lsbCBzZWUgYSBzZXJpZXMgb2YgIlBBU1Mi IG1lc3NhZ2VzLCBmb2xsb3dlZCBieSAiVEVTVCBDT01QTEVURSIuCisKKworUEFTUyBzdWNjZXNz ZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBMRVRFCisKSW5kZXg6IExheW91dFRlc3Rz L2pzL2RmZy1zbG93LXB1dC1hcnJheS1zdG9yYWdlLXNwZWMtc2hvdWxkLWFsbG93LWZhc3QtYXJy YXktc3RvcmFnZS5odG1sCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL2pzL2RmZy1zbG93LXB1 dC1hcnJheS1zdG9yYWdlLXNwZWMtc2hvdWxkLWFsbG93LWZhc3QtYXJyYXktc3RvcmFnZS5odG1s CShyZXZpc2lvbiAwKQorKysgTGF5b3V0VGVzdHMvanMvZGZnLXNsb3ctcHV0LWFycmF5LXN0b3Jh Z2Utc3BlYy1zaG91bGQtYWxsb3ctZmFzdC1hcnJheS1zdG9yYWdlLmh0bWwJKHdvcmtpbmcgY29w eSkKQEAgLTAsMCArMSwxMCBAQAorPCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9JRVRGLy9EVEQg SFRNTC8vRU4iPgorPGh0bWw+Cis8aGVhZD4KKzxzY3JpcHQgc3JjPSIuLi9yZXNvdXJjZXMvanMt dGVzdC1wcmUuanMiPjwvc2NyaXB0PgorPC9oZWFkPgorPGJvZHk+Cis8c2NyaXB0IHNyYz0ic2Ny aXB0LXRlc3RzL2RmZy1zbG93LXB1dC1hcnJheS1zdG9yYWdlLXNwZWMtc2hvdWxkLWFsbG93LWZh c3QtYXJyYXktc3RvcmFnZS5qcyI+PC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vcmVzb3VyY2Vz L2pzLXRlc3QtcG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+Cis8L2h0bWw+CkluZGV4OiBMYXlv dXRUZXN0cy9qcy9zY3JpcHQtdGVzdHMvZGZnLXNsb3ctcHV0LWFycmF5LXN0b3JhZ2Utc3BlYy1z aG91bGQtYWxsb3ctZmFzdC1hcnJheS1zdG9yYWdlLmpzCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRl c3RzL2pzL3NjcmlwdC10ZXN0cy9kZmctc2xvdy1wdXQtYXJyYXktc3RvcmFnZS1zcGVjLXNob3Vs ZC1hbGxvdy1mYXN0LWFycmF5LXN0b3JhZ2UuanMJKHJldmlzaW9uIDApCisrKyBMYXlvdXRUZXN0 cy9qcy9zY3JpcHQtdGVzdHMvZGZnLXNsb3ctcHV0LWFycmF5LXN0b3JhZ2Utc3BlYy1zaG91bGQt YWxsb3ctZmFzdC1hcnJheS1zdG9yYWdlLmpzCSh3b3JraW5nIGNvcHkpCkBAIC0wLDAgKzEsMzgg QEAKK2Rlc2NyaXB0aW9uKAorIlRoaXMgdGVzdHMgdGhhdCBERkcgZ2VuZXJhdGVkIGNvZGUgc3Bl Y3VsYXRpbmcgU2xvd1B1dEFycmF5U3RvcmFnZVNoYXBlIGRvZXNuJ3QgY3Jhc2ggd2hlbiBzZWVp bmcgZmFzdCBBcnJheVN0b3JhZ2VTaGFwZXMuIgorKTsKKwordmFyIHNsb3dQdXRBcnJheVN0b3Jh Z2VBcnJheSA9IFsgInNsb3ciIF07Cit2YXIgZmFzdEFycmF5U3RvcmFnZUFycmF5ID0gWyAiZmFz dCIgXTsKK2Zhc3RBcnJheVN0b3JhZ2VBcnJheVsxMDAwXSA9IDUwOworCit2YXIgbyA9IHsgYTog MTAgfTsKK09iamVjdC5kZWZpbmVQcm9wZXJ0aWVzKG8sIHsKKyAgICAiMCI6IHsKKyAgICAgICAg c2V0OiBmdW5jdGlvbih4KSB7IHRoaXMuYSA9IHg7IH0sCisgICAgfSwKK30pOyAgICAKKworc2xv d1B1dEFycmF5U3RvcmFnZUFycmF5Ll9fcHJvdG9fXyA9IG87CisKK2Z1bmN0aW9uIGZvbyhhLCBp c0Zhc3QpIHsKKyAgICB2YXIgcmVzdWx0ID0gMTA7CisgICAgaWYgKCFhKQorICAgICAgICByZXR1 cm4gcmVzdWx0OworCisgICAgdmFyIGRvU3R1ZmYgPSBhWzBdICYmIGlzRmFzdDsKKyAgICBpZiAo ZG9TdHVmZikKKyAgICAgICAgcmVzdWx0ID0gYVswXSArIDEwOworICAgIHJldHVybiByZXN1bHQ7 Cit9CisKK2Z1bmN0aW9uIHRlc3QoKSB7CisgICAgZm9yICh2YXIgayA9IDA7IGsgPCA1MDAwOyBr KyspIHsKKyAgICAgICAgZm9vKHNsb3dQdXRBcnJheVN0b3JhZ2VBcnJheSwgZmFsc2UpOworICAg ICAgICBmb28oZmFzdEFycmF5U3RvcmFnZUFycmF5LCB0cnVlKTsKKyAgICB9Cit9CisKK3Rlc3Qo KTsKKwordmFyIHN1Y2Nlc3NmdWxseVBhcnNlZCA9IHRydWU7Cg==