139309 2014-12-05 13:06:30 -0800 PassRef should deref on destruction if pointee was not moved. 2014-12-05 14:20:21 -0800 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 kling kling benjamin cmarcelo commit-queue esprehn+autocc glenn kling kondapallykalyan oldest_to_newest 1052815 0 kling 2014-12-05 13:06:30 -0800 Instead of having PassRef be a footgun, let's just make it deref() the pointee in ~PassRef if the object was not WTF::move()'d. This will make PassRef usable for all ::create style functions and enable idioms like Foo::create().get().doStuff(); 1052817 1 242652 kling 2014-12-05 13:11:58 -0800 Created attachment 242652 Patch 1052820 2 242652 koivisto 2014-12-05 13:15:25 -0800 Comment on attachment 242652 Patch Seems like a good idea 1052847 3 242652 kling 2014-12-05 14:20:16 -0800 Comment on attachment 242652 Patch Clearing flags on attachment: 242652 Committed r176873: <http://trac.webkit.org/changeset/176873> 1052848 4 kling 2014-12-05 14:20:21 -0800 All reviewed patches have been landed. Closing bug. 242652 2014-12-05 13:11:58 -0800 2014-12-05 14:20:16 -0800 Patch bug-139309.diff text/plain 6695 kling ZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvQ2hhbmdlTG9nIGIvU291cmNlL1dURi9DaGFuZ2VMb2cK aW5kZXggY2EzMzkxMi4uMzAyOTNlZCAxMDA2NDQKLS0tIGEvU291cmNlL1dURi9DaGFuZ2VMb2cK KysrIGIvU291cmNlL1dURi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwyNSBAQAorMjAxNC0xMi0wNSAg QW5kcmVhcyBLbGluZyAgPGFrbGluZ0BhcHBsZS5jb20+CisKKyAgICAgICAgUGFzc1JlZiBzaG91 bGQgZGVyZWYgb24gZGVzdHJ1Y3Rpb24gaWYgcG9pbnRlZSB3YXMgbm90IG1vdmVkLgorICAgICAg ICA8aHR0cHM6Ly93ZWJraXQub3JnL2IvMTM5MzA5PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgorCisgICAgICAgIExldCBQYXNzUmVmIGJlY29tZSBudWxscHRyIGludGVy bmFsbHkgYWZ0ZXIgaGF2aW5nIFdURjo6bW92ZSgpJ2QgdGhlIHBvaW50ZWUuCisgICAgICAgIFRo aXMgbWVhbnMgdGhhdCBQYXNzUmVmIGlzIG5vdyBlc3NlbnRpYWxseSBhIFBhc3NSZWZQdHIgdGhh dCBjYW4gb25seSBiZQorICAgICAgICBjb25zdHJ1Y3RlZCB3aXRoIGEgbm9uLW51bGwgcG9pbnRl ZS4KKworICAgICAgICBUaGlzIHNob3VsZCBtYWtlIGl0IHBvc3NpYmxlIGZvciBhbGwgOjpjcmVh dGUoKS1zdHlsZSBjb25zdHJ1Y3Rpb24gaGVscGVycyB0bworICAgICAgICByZXR1cm4gUGFzc1Jl ZiwgcmVtb3ZpbmcgYSBicmFuY2ggaW4gZWFjaCBjYXNlLgorCisgICAgICAgICogd3RmL1Bhc3NS ZWYuaDoKKyAgICAgICAgKFdURjo6UGFzc1JlZjxUPjo6UGFzc1JlZik6CisgICAgICAgIChXVEY6 OlBhc3NSZWY8VD46On5QYXNzUmVmKToKKyAgICAgICAgKFdURjo6UGFzc1JlZjxUPjo6Z2V0KToK KyAgICAgICAgKFdURjo6UGFzc1JlZjxUPjo6cHRyKToKKyAgICAgICAgKFdURjo6UGFzc1JlZjxU Pjo6bGVha1JlZik6CisgICAgICAgIChXVEY6OlBhc3NSZWY8VD46OmRyb3BSZWYpOiBEZWxldGVk LgorCiAyMDE0LTEyLTA1ICBwZWF2b0BvdXRsb29rLmNvbSAgPHBlYXZvQG91dGxvb2suY29tPgog CiAgICAgICAgIFtXaW5DYWlyb10gV1RGIHByb2plY3QgaXMgbWlzc2luZyBhIEdTdHJlYW1lciBz b3VyY2UgZmlsZS4KZGlmZiAtLWdpdCBhL1NvdXJjZS9XVEYvd3RmL1Bhc3NSZWYuaCBiL1NvdXJj ZS9XVEYvd3RmL1Bhc3NSZWYuaAppbmRleCBiYzA5YjExLi4yNmQxNGQ0IDEwMDY0NAotLS0gYS9T b3VyY2UvV1RGL3d0Zi9QYXNzUmVmLmgKKysrIGIvU291cmNlL1dURi93dGYvUGFzc1JlZi5oCkBA IC0xLDUgKzEsNSBAQAogLyoKLSAqICBDb3B5cmlnaHQgKEMpIDIwMTMgQXBwbGUgSW5jLiBBbGwg cmlnaHRzIHJlc2VydmVkLgorICogIENvcHlyaWdodCAoQykgMjAxMy0yMDE0IEFwcGxlIEluYy4g QWxsIHJpZ2h0cyByZXNlcnZlZC4KICAqCiAgKiAgVGhpcyBsaWJyYXJ5IGlzIGZyZWUgc29mdHdh cmU7IHlvdSBjYW4gcmVkaXN0cmlidXRlIGl0IGFuZC9vcgogICogIG1vZGlmeSBpdCB1bmRlciB0 aGUgdGVybXMgb2YgdGhlIEdOVSBMaWJyYXJ5IEdlbmVyYWwgUHVibGljCkBAIC00OSwxMiArNDks OSBAQCBwdWJsaWM6CiAgICAgY29uc3QgVCogcHRyKCkgY29uc3Q7CiAgICAgVCogcHRyKCk7CiAK LSAgICB2b2lkIGRyb3BSZWYoKTsKICAgICBUJiBsZWFrUmVmKCkgV0FSTl9VTlVTRURfUkVUVVJO OwogCi0jaWZuZGVmIE5ERUJVRwogICAgIH5QYXNzUmVmKCk7Ci0jZW5kaWYKIAogcHJpdmF0ZToK ICAgICBmcmllbmQgUGFzc1JlZiBhZG9wdFJlZjxUPihUJik7CkBAIC02NywxMDMgKzY0LDczIEBA IHByaXZhdGU6CiAgICAgZW51bSBBZG9wdFRhZyB7IEFkb3B0IH07CiAgICAgUGFzc1JlZihUJiwg QWRvcHRUYWcpOwogCi0gICAgVCYgbV9yZWZlcmVuY2U7Ci0KLSNpZm5kZWYgTkRFQlVHCisgICAg VCogbV9wdHI7CiAgICAgYm9vbCBtX2dhdmVVcFJlZmVyZW5jZTsKLSNlbmRpZgogfTsKIAogdGVt cGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFBhc3NSZWY8VD46OlBhc3NSZWYoVCYgcmVmZXJlbmNl KQotICAgIDogbV9yZWZlcmVuY2UocmVmZXJlbmNlKQotI2lmbmRlZiBOREVCVUcKLSAgICAsIG1f Z2F2ZVVwUmVmZXJlbmNlKGZhbHNlKQotI2VuZGlmCisgICAgOiBtX3B0cigmcmVmZXJlbmNlKQog ewotICAgIHJlZmVyZW5jZS5yZWYoKTsKKyAgICBtX3B0ci0+cmVmKCk7CiB9CiAKIHRlbXBsYXRl PHR5cGVuYW1lIFQ+IGlubGluZSBQYXNzUmVmPFQ+OjpQYXNzUmVmKFBhc3NSZWYmJiBvdGhlcikK LSAgICA6IG1fcmVmZXJlbmNlKG90aGVyLmxlYWtSZWYoKSkKLSNpZm5kZWYgTkRFQlVHCi0gICAg LCBtX2dhdmVVcFJlZmVyZW5jZShmYWxzZSkKLSNlbmRpZgorICAgIDogbV9wdHIoJm90aGVyLmxl YWtSZWYoKSkKIHsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gdGVtcGxhdGU8dHlwZW5hbWUg VT4gaW5saW5lIFBhc3NSZWY8VD46OlBhc3NSZWYoUGFzc1JlZjxVPiBvdGhlcikKLSAgICA6IG1f cmVmZXJlbmNlKG90aGVyLmxlYWtSZWYoKSkKLSNpZm5kZWYgTkRFQlVHCi0gICAgLCBtX2dhdmVV cFJlZmVyZW5jZShmYWxzZSkKLSNlbmRpZgorICAgIDogbV9wdHIoJm90aGVyLmxlYWtSZWYoKSkK IHsKIH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gdGVtcGxhdGU8dHlwZW5hbWUgVT4gaW5saW5l IFBhc3NSZWY8VD46OlBhc3NSZWYoY29uc3QgUmVmPFU+JiBvdGhlcikKLSAgICA6IG1fcmVmZXJl bmNlKHN0YXRpY19jYXN0PFQmPihjb25zdF9jYXN0PFUmPihvdGhlci5nZXQoKSkpKQotI2lmbmRl ZiBOREVCVUcKLSAgICAsIG1fZ2F2ZVVwUmVmZXJlbmNlKGZhbHNlKQotI2VuZGlmCisgICAgOiBt X3B0cihzdGF0aWNfY2FzdDxUKj4oY29uc3RfY2FzdDxVKj4ob3RoZXIucHRyKCkpKSkKIHsKLSAg ICBtX3JlZmVyZW5jZS5yZWYoKTsKKyAgICBBU1NFUlQobV9wdHIpOworICAgIG1fcHRyLT5yZWYo KTsKIH0KIAotI2lmbmRlZiBOREVCVUcKLQogdGVtcGxhdGU8dHlwZW5hbWUgVD4gUGFzc1JlZjxU Pjo6flBhc3NSZWYoKQogewotICAgIEFTU0VSVChtX2dhdmVVcFJlZmVyZW5jZSk7Ci19Ci0KLSNl bmRpZgotCi10ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgdm9pZCBQYXNzUmVmPFQ+Ojpkcm9w UmVmKCkKLXsKLSAgICBBU1NFUlQoIW1fZ2F2ZVVwUmVmZXJlbmNlKTsKLSAgICBtX3JlZmVyZW5j ZS5kZXJlZigpOwotI2lmbmRlZiBOREVCVUcKLSAgICBtX2dhdmVVcFJlZmVyZW5jZSA9IHRydWU7 Ci0jZW5kaWYKKyAgICBpZiAobV9wdHIpCisgICAgICAgIG1fcHRyLT5kZXJlZigpOwogfQogCiB0 ZW1wbGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgY29uc3QgVCYgUGFzc1JlZjxUPjo6Z2V0KCkgY29u c3QKIHsKLSAgICBBU1NFUlQoIW1fZ2F2ZVVwUmVmZXJlbmNlKTsKLSAgICByZXR1cm4gbV9yZWZl cmVuY2U7CisgICAgQVNTRVJUKG1fcHRyKTsKKyAgICByZXR1cm4gKm1fcHRyOwogfQogCiB0ZW1w bGF0ZTx0eXBlbmFtZSBUPiBpbmxpbmUgVCYgUGFzc1JlZjxUPjo6Z2V0KCkKIHsKLSAgICBBU1NF UlQoIW1fZ2F2ZVVwUmVmZXJlbmNlKTsKLSAgICByZXR1cm4gbV9yZWZlcmVuY2U7CisgICAgQVNT RVJUKG1fcHRyKTsKKyAgICByZXR1cm4gKm1fcHRyOwogfQogCiB0ZW1wbGF0ZTx0eXBlbmFtZSBU PiBjb25zdCBUKiBQYXNzUmVmPFQ+OjpwdHIoKSBjb25zdAogewotICAgIEFTU0VSVCghbV9nYXZl VXBSZWZlcmVuY2UpOwotICAgIHJldHVybiAmbV9yZWZlcmVuY2U7CisgICAgQVNTRVJUKG1fcHRy KTsKKyAgICByZXR1cm4gbV9wdHI7CiB9CiAKIHRlbXBsYXRlPHR5cGVuYW1lIFQ+IFQqIFBhc3NS ZWY8VD46OnB0cigpCiB7Ci0gICAgQVNTRVJUKCFtX2dhdmVVcFJlZmVyZW5jZSk7Ci0gICAgcmV0 dXJuICZtX3JlZmVyZW5jZTsKKyAgICBBU1NFUlQobV9wdHIpOworICAgIHJldHVybiBtX3B0cjsK IH0KIAogdGVtcGxhdGU8dHlwZW5hbWUgVD4gaW5saW5lIFQmIFBhc3NSZWY8VD46OmxlYWtSZWYo KQogewotI2lmbmRlZiBOREVCVUcKLSAgICBBU1NFUlQoIW1fZ2F2ZVVwUmVmZXJlbmNlKTsKLSAg ICBtX2dhdmVVcFJlZmVyZW5jZSA9IHRydWU7Ci0jZW5kaWYKLSAgICByZXR1cm4gbV9yZWZlcmVu Y2U7CisgICAgQVNTRVJUKG1fcHRyKTsKKyAgICBUKiBsZWFrZWRQdHIgPSBtX3B0cjsKKyAgICBt X3B0ciA9IG51bGxwdHI7CisgICAgcmV0dXJuICpsZWFrZWRQdHI7CiB9CiAKIHRlbXBsYXRlPHR5 cGVuYW1lIFQ+IGlubGluZSBQYXNzUmVmPFQ+OjpQYXNzUmVmKFQmIHJlZmVyZW5jZSwgQWRvcHRU YWcpCi0gICAgOiBtX3JlZmVyZW5jZShyZWZlcmVuY2UpCi0jaWZuZGVmIE5ERUJVRwotICAgICwg bV9nYXZlVXBSZWZlcmVuY2UoZmFsc2UpCi0jZW5kaWYKKyAgICA6IG1fcHRyKCZyZWZlcmVuY2Up CiB7CiB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL0NoYW5nZUxvZyBiL1NvdXJjZS9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCBmMDUwY2Y5Li40MTM0YTQwIDEwMDY0NAotLS0gYS9Tb3Vy Y2UvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTkgQEAKKzIwMTQtMTItMDUgIEFuZHJlYXMgS2xpbmcgIDxha2xpbmdAYXBwbGUuY29t PgorCisgICAgICAgIFBhc3NSZWYgc2hvdWxkIGRlcmVmIG9uIGRlc3RydWN0aW9uIGlmIHBvaW50 ZWUgd2FzIG5vdCBtb3ZlZC4KKyAgICAgICAgPGh0dHBzOi8vd2Via2l0Lm9yZy9iLzEzOTMwOT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZW1vdmUg Y2FsbHMgdG8gUGFzc1JlZjo6ZHJvcFJlZigpIHNpbmNlIGl0J3Mgbm8gbG9uZ2VyIG5lY2Vzc2Fy eSB0byBtYW51YWxseQorICAgICAgICBub3RpZnkgUGFzc1JlZiB0aGF0IHlvdSBkaWRuJ3QgbW92 ZSB0aGUgcG9pbnRlZS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcDoK KyAgICAgICAgKFdlYkNvcmU6OlJlbmRlckVsZW1lbnQ6OmNyZWF0ZUZvcik6CisgICAgICAgIChX ZWJDb3JlOjpSZW5kZXJFbGVtZW50OjpzZXRTdHlsZSk6CisgICAgICAgICogc3R5bGUvU3R5bGVS ZXNvbHZlVHJlZS5jcHA6CisgICAgICAgIChXZWJDb3JlOjpTdHlsZTo6cmVzb2x2ZVRyZWUpOgor CiAyMDE0LTEyLTA1ICBEYXZpZCBLaWx6ZXIgIDxkZGtpbHplckBhcHBsZS5jb20+CiAKICAgICAg ICAgRmVhdHVyZURlZmluZXMueGNjb25maWc6IFdvcmthcm91bmQgYnVnIGluIFhjb2RlIDUuMS4x IHdoZW4gZGVmaW5pbmcgRU5BQkxFX1dFQl9SRVBMQVkKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJD b3JlL3JlbmRlcmluZy9SZW5kZXJFbGVtZW50LmNwcCBiL1NvdXJjZS9XZWJDb3JlL3JlbmRlcmlu Zy9SZW5kZXJFbGVtZW50LmNwcAppbmRleCAyMmRjZTBkLi44M2VmYTA1IDEwMDY0NAotLS0gYS9T b3VyY2UvV2ViQ29yZS9yZW5kZXJpbmcvUmVuZGVyRWxlbWVudC5jcHAKKysrIGIvU291cmNlL1dl YkNvcmUvcmVuZGVyaW5nL1JlbmRlckVsZW1lbnQuY3BwCkBAIC0xNTksNyArMTU5LDYgQEAgUmVu ZGVyUHRyPFJlbmRlckVsZW1lbnQ+IFJlbmRlckVsZW1lbnQ6OmNyZWF0ZUZvcihFbGVtZW50JiBl bGVtZW50LCBQYXNzUmVmPFJlbmQKICAgICAgICAgcmV0dXJuIGNyZWF0ZVJlbmRlcmVyPFJlbmRl clJ1YnlUZXh0PihlbGVtZW50LCBXVEY6Om1vdmUoc3R5bGUpKTsKICAgICBzd2l0Y2ggKHN0eWxl LmdldCgpLmRpc3BsYXkoKSkgewogICAgIGNhc2UgTk9ORToKLSAgICAgICAgc3R5bGUuZHJvcFJl ZigpOwogICAgICAgICByZXR1cm4gbnVsbHB0cjsKICAgICBjYXNlIElOTElORToKICAgICAgICAg cmV0dXJuIGNyZWF0ZVJlbmRlcmVyPFJlbmRlcklubGluZT4oZWxlbWVudCwgV1RGOjptb3ZlKHN0 eWxlKSk7CkBAIC0zOTksNyArMzk4LDYgQEAgdm9pZCBSZW5kZXJFbGVtZW50OjpzZXRTdHlsZShQ YXNzUmVmPFJlbmRlclN0eWxlPiBzdHlsZSkKICAgICAgICAgQVNTRVJUKCFpc1JlbmRlcklGcmFt ZSgpKTsKICAgICAgICAgQVNTRVJUKCFpc0VtYmVkZGVkT2JqZWN0KCkpOwogICAgICAgICBBU1NF UlQoIWlzQ2FudmFzKCkpOwotICAgICAgICBzdHlsZS5kcm9wUmVmKCk7CiAgICAgICAgIHJldHVy bjsKICAgICB9CiAKZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJDb3JlL3N0eWxlL1N0eWxlUmVzb2x2 ZVRyZWUuY3BwIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZlVHJlZS5jcHAKaW5k ZXggY2U1NTE0MS4uZDU4ODY5YSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5 bGVSZXNvbHZlVHJlZS5jcHAKKysrIGIvU291cmNlL1dlYkNvcmUvc3R5bGUvU3R5bGVSZXNvbHZl VHJlZS5jcHAKQEAgLTk4NCw4ICs5ODQsNiBAQCB2b2lkIHJlc29sdmVUcmVlKERvY3VtZW50JiBk b2N1bWVudCwgQ2hhbmdlIGNoYW5nZSkKICAgICAgICAgU3R5bGU6OkNoYW5nZSBkb2N1bWVudENo YW5nZSA9IGRldGVybWluZUNoYW5nZShkb2N1bWVudFN0eWxlLmdldCgpLCBkb2N1bWVudC5yZW5k ZXJWaWV3KCktPnN0eWxlKCkpOwogICAgICAgICBpZiAoZG9jdW1lbnRDaGFuZ2UgIT0gTm9DaGFu Z2UpCiAgICAgICAgICAgICBkb2N1bWVudC5yZW5kZXJWaWV3KCktPnNldFN0eWxlKFdURjo6bW92 ZShkb2N1bWVudFN0eWxlKSk7Ci0gICAgICAgIGVsc2UKLSAgICAgICAgICAgIGRvY3VtZW50U3R5 bGUuZHJvcFJlZigpOwogICAgIH0KIAogICAgIEVsZW1lbnQqIGRvY3VtZW50RWxlbWVudCA9IGRv Y3VtZW50LmRvY3VtZW50RWxlbWVudCgpOwo=