139307 2014-12-05 12:13:44 -0800 Web Inspector: Hide Compositing Borders Button if backend returns an error that it is unsupported 2014-12-10 15:30:54 -0800 1 1 1 Unclassified WebKit Web Inspector 528+ (Nightly build) All All RESOLVED FIXED InRadar P2 Normal --- 1 joepeck joepeck graouts joepeck timothy webkit-bug-importer oldest_to_newest 1052796 0 joepeck 2014-12-05 12:13:44 -0800 * SUMMARY Hide Compositing Borders Button if backend returns an error that it is unsupported. With augmentative agents, some protocol methods exist in the BackendCommands but may be unsupported by the backend. For now, somethings can just respond as "unsupported" and we can update the UI appropriately. Things like CompositingBorders where we always send a request. We may need to look into an alternative solution since we don't want an "isSupported" for every operation. This is just easy since we always make the request. 1052797 1 webkit-bug-importer 2014-12-05 12:14:19 -0800 <rdar://problem/19159939> 1052825 2 242655 joepeck 2014-12-05 13:25:14 -0800 Created attachment 242655 [PATCH] Proposed Fix 1053953 3 242655 darin 2014-12-09 14:44:02 -0800 Comment on attachment 242655 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=242655&action=review > Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:450 > + if (error === "unsupported") > + button.enabled = false; Is this really a one-shot? I would have expected this to say: button.enabled = error !== "unsupported"; 1053965 4 242655 joepeck 2014-12-09 15:12:22 -0800 Comment on attachment 242655 [PATCH] Proposed Fix View in context: https://bugs.webkit.org/attachment.cgi?id=242655&action=review >> Source/WebInspectorUI/UserInterface/Views/DOMTreeContentView.js:450 >> + button.enabled = false; > > Is this really a one-shot? I would have expected this to say: > > button.enabled = error !== "unsupported"; You're right, it isn't exactly a one-shot. It would happen each time the DOMTreeContentView is shown. I'll take your suggestion, this is not performance sensitive. 1054324 5 joepeck 2014-12-10 15:30:54 -0800 http://trac.webkit.org/changeset/177108 242655 2014-12-05 13:25:14 -0800 2014-12-09 15:12:22 -0800 [PATCH] Proposed Fix unsuported-1.patch text/plain 1481 joepeck ZGlmZiAtLWdpdCBhL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cgYi9Tb3VyY2UvV2Vi SW5zcGVjdG9yVUkvQ2hhbmdlTG9nCmluZGV4IDIyYTQ4OTMuLmE4Y2ExMzQgMTAwNjQ0Ci0tLSBh L1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9DaGFuZ2VMb2cKKysrIGIvU291cmNlL1dlYkluc3BlY3Rv clVJL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDE0LTEyLTA1ICBKb3NlcGggUGVjb3Jh cm8gIDxwZWNvcmFyb0BhcHBsZS5jb20+CisKKyAgICAgICAgV2ViIEluc3BlY3RvcjogSGlkZSBD b21wb3NpdGluZyBCb3JkZXJzIEJ1dHRvbiBpZiBiYWNrZW5kIHJldHVybnMgYW4gZXJyb3IgdGhh dCBpdCBpcyB1bnN1cHBvcnRlZAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MTM5MzA3CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISku CisKKyAgICAgICAgKiBVc2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5qczoK KyAgICAgICAgKFdlYkluc3BlY3Rvci5ET01UcmVlQ29udGVudFZpZXcucHJvdG90eXBlLl91cGRh dGVDb21wb3NpdGluZ0JvcmRlcnNCdXR0b25Ub01hdGNoUGFnZVNldHRpbmdzKToKKwogMjAxNC0x Mi0wNCAgSm9zZXBoIFBlY29yYXJvICA8cGVjb3Jhcm9AYXBwbGUuY29tPgogCiAgICAgICAgIFdl YiBJbnNwZWN0b3I6IFVuY2F1Z2h0IEV4Y2VwdGlvbnMgd2hlbiBhdHRlbXB0aW5nIHRvIHNob3cg Q29udGVudCBGbG93CmRpZmYgLS1naXQgYS9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkvVXNlckludGVy ZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMgYi9Tb3VyY2UvV2ViSW5zcGVjdG9yVUkv VXNlckludGVyZmFjZS9WaWV3cy9ET01UcmVlQ29udGVudFZpZXcuanMKaW5kZXggM2JkMzA3Mi4u NzE2YTBiMSAxMDA2NDQKLS0tIGEvU291cmNlL1dlYkluc3BlY3RvclVJL1VzZXJJbnRlcmZhY2Uv Vmlld3MvRE9NVHJlZUNvbnRlbnRWaWV3LmpzCisrKyBiL1NvdXJjZS9XZWJJbnNwZWN0b3JVSS9V c2VySW50ZXJmYWNlL1ZpZXdzL0RPTVRyZWVDb250ZW50Vmlldy5qcwpAQCAtNDQ2LDYgKzQ0Niw4 IEBAIFdlYkluc3BlY3Rvci5ET01UcmVlQ29udGVudFZpZXcucHJvdG90eXBlID0gewogICAgICAg ICAvLyBpbiBhIGRpZmZlcmVudCB3YXkgdGhhbiBqdXN0IHVzaW5nIHRoZSBuYXZpZ2F0aW9uIGJh ciBidXR0b24uCiAgICAgICAgIFBhZ2VBZ2VudC5nZXRDb21wb3NpdGluZ0JvcmRlcnNWaXNpYmxl KGZ1bmN0aW9uKGVycm9yLCBjb21wb3NpdGluZ0JvcmRlcnNWaXNpYmxlKSB7CiAgICAgICAgICAg ICBidXR0b24uYWN0aXZhdGVkID0gZXJyb3IgPyBmYWxzZSA6IGNvbXBvc2l0aW5nQm9yZGVyc1Zp c2libGU7CisgICAgICAgICAgICBpZiAoZXJyb3IgPT09ICJ1bnN1cHBvcnRlZCIpCisgICAgICAg ICAgICAgICAgYnV0dG9uLmVuYWJsZWQgPSBmYWxzZTsKICAgICAgICAgfSk7CiAgICAgfSwKIAo=