139305 2014-12-05 10:29:23 -0800 Removed the custom allocator for ParserArena 2014-12-05 14:12:06 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Unspecified Unspecified RESOLVED FIXED P2 Normal --- 1 ggaren ggaren oldest_to_newest 1052759 0 ggaren 2014-12-05 10:29:23 -0800 Removed the custom allocator for ParserArena 1052763 1 242642 ggaren 2014-12-05 10:33:52 -0800 Created attachment 242642 Patch 1052765 2 242642 msaboff 2014-12-05 10:42:17 -0800 Comment on attachment 242642 Patch View in context: https://bugs.webkit.org/attachment.cgi?id=242642&action=review r=me > Source/JavaScriptCore/ChangeLog:24 > + pools anymore, since wej ust call malloc/free directly. Typo "wej ust" should be "we just" 1052841 3 242642 ggaren 2014-12-05 14:08:44 -0800 Comment on attachment 242642 Patch Actually, it looks like I started with an incorrect baseline. This patch is a 1% regression on JSBench if you run with the parsing cache disabled, and a 2% regression on Octane2-CodeLoad. So, there is a slight advantage to an explicit arena in this case. 1052842 4 ggaren 2014-12-05 14:12:06 -0800 I landed the removal of reset() in <https://trac.webkit.org/changeset/176871>. 242642 2014-12-05 10:33:52 -0800 2014-12-05 14:08:44 -0800 Patch bug-139305-20141205103427.patch text/plain 6520 ggaren SW5kZXg6IFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gU291 cmNlL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkocmV2aXNpb24gMTc2ODQ4KQorKysgU291cmNl L0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDM5IEBA CisyMDE0LTEyLTA1ICBHZW9mZnJleSBHYXJlbiAgPGdnYXJlbkBhcHBsZS5jb20+CisKKyAgICAg ICAgUmVtb3ZlZCB0aGUgY3VzdG9tIGFsbG9jYXRvciBmb3IgUGFyc2VyQXJlbmEKKyAgICAgICAg aHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTEzOTMwNQorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFRoaXMgaXMgYW4gMTglIHNw ZWVkdXAgb24gSlNCZW5jaCBpZiB5b3UgcnVuIHdpdGggdGhlIHBhcnNpbmcgY2FjaGUKKyAgICAg ICAgZGlzYWJsZWQuCisKKyAgICAgICAgKiBwYXJzZXIvUGFyc2VyQXJlbmEuY3BwOgorICAgICAg ICAoSlNDOjpQYXJzZXJBcmVuYTo6UGFyc2VyQXJlbmEpOgorICAgICAgICAoSlNDOjpQYXJzZXJB cmVuYTo6flBhcnNlckFyZW5hKToKKyAgICAgICAgKEpTQzo6UGFyc2VyQXJlbmE6OmZyZWVhYmxl UG9vbCk6IERlbGV0ZWQuIFdlIGRvbid0IGtlZXAgYW55IHBvb2xzCisgICAgICAgIGFueW1vcmUs IHNpbmNlIHdlIGp1c3QgY2FsbCBtYWxsb2MvZnJlZSBkaXJlY3RseS4KKworICAgICAgICAoSlND OjpQYXJzZXJBcmVuYTo6ZGVhbGxvY2F0ZU9iamVjdHMpOiBEZWxldGVkLiBGb2xkZWQgaW50byB0 aGUgZGVzdHJ1Y3RvciwKKyAgICAgICAgc2luY2Ugd2UgZG9uJ3QgbmVlZCB0byBjYWxsIHRoaXMg ZXhwbGljaXRseSBhbnltb3JlLgorCisgICAgICAgIChKU0M6OlBhcnNlckFyZW5hOjpyZXNldCk6 IERlbGV0ZWQuIEEgcHJldmlvdXMgcGF0Y2ggZGVsZXRlZCBhbGwgY2FsbGVycworICAgICAgICBv ZiB0aGlzIEFQSS4KKworICAgICAgICAoSlNDOjpQYXJzZXJBcmVuYTo6YWxsb2NhdGVGcmVlYWJs ZVBvb2wpOiBEZWxldGVkLiBXZSBkb24ndCBrZWVwIGFueQorICAgICAgICBwb29scyBhbnltb3Jl LCBzaW5jZSB3ZWogdXN0IGNhbGwgbWFsbG9jL2ZyZWUgZGlyZWN0bHkuCisKKyAgICAgICAgKiBw YXJzZXIvUGFyc2VyQXJlbmEuaDoKKyAgICAgICAgKEpTQzo6UGFyc2VyQXJlbmE6OnN3YXApOiBO byBtb3JlIHBvb2xzLgorCisgICAgICAgIChKU0M6OlBhcnNlckFyZW5hOjphbGxvY2F0ZUZyZWVh YmxlKTogRG8ga2VlcCB0cmFjayBvZiB0aGUgc2V0IG9mIGZyZWVhYmxlCisgICAgICAgIG9iamVj dHMsIHNpbmNlIHdlIG5lZWQgdG8gZnJlZSB0aGVtIGV4cGxpY2l0bHkgbm93IHRoYXQgd2UgYWxs b2NhdGUgdGhlbQorICAgICAgICB1c2luZyBtYWxsb2MgYW5kIG5vdCBhbiBpbnRlcm5hbCBwb29s LgorCisgICAgICAgIChKU0M6OlBhcnNlckFyZW5hOjphbGxvY2F0ZURlbGV0YWJsZSk6IFVzZSBt YWxsb2MsIGxpa2UgUml0Y2hpZSBpbnRlbmRlZC4KKworICAgICAgICAoSlNDOjpQYXJzZXJBcmVu YTo6YWxpZ25TaXplKTogRGVsZXRlZC4KKwogMjAxNC0xMi0wNSAgRGF2aWQgS2lsemVyICA8ZGRr aWx6ZXJAYXBwbGUuY29tPgogCiAgICAgICAgIEZlYXR1cmVEZWZpbmVzLnhjY29uZmlnOiBXb3Jr YXJvdW5kIGJ1ZyBpbiBYY29kZSA1LjEuMSB3aGVuIGRlZmluaW5nIEVOQUJMRV9XRUJfUkVQTEFZ CkluZGV4OiBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlckFyZW5hLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBTb3VyY2UvSmF2YVNjcmlwdENvcmUvcGFyc2VyL1BhcnNlckFyZW5hLmNwcAko cmV2aXNpb24gMTc2ODQ3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXJB cmVuYS5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTMzLDYxICszMywxOCBAQAogbmFtZXNwYWNlIEpT QyB7CiAKIFBhcnNlckFyZW5hOjpQYXJzZXJBcmVuYSgpCi0gICAgOiBtX2ZyZWVhYmxlTWVtb3J5 KDApCi0gICAgLCBtX2ZyZWVhYmxlUG9vbEVuZCgwKQogewogfQogCi1pbmxpbmUgdm9pZCogUGFy c2VyQXJlbmE6OmZyZWVhYmxlUG9vbCgpCi17Ci0gICAgQVNTRVJUKG1fZnJlZWFibGVQb29sRW5k KTsKLSAgICByZXR1cm4gbV9mcmVlYWJsZVBvb2xFbmQgLSBmcmVlYWJsZVBvb2xTaXplOwotfQot Ci1pbmxpbmUgdm9pZCBQYXJzZXJBcmVuYTo6ZGVhbGxvY2F0ZU9iamVjdHMoKQotewotICAgIHNp emVfdCBzaXplID0gbV9kZWxldGFibGVPYmplY3RzLnNpemUoKTsKLSAgICBmb3IgKHNpemVfdCBp ID0gMDsgaSA8IHNpemU7ICsraSkKLSAgICAgICAgbV9kZWxldGFibGVPYmplY3RzW2ldLT5+UGFy c2VyQXJlbmFEZWxldGFibGUoKTsKLQotICAgIGlmIChtX2ZyZWVhYmxlUG9vbEVuZCkKLSAgICAg ICAgZmFzdEZyZWUoZnJlZWFibGVQb29sKCkpOwotCi0gICAgc2l6ZSA9IG1fZnJlZWFibGVQb29s cy5zaXplKCk7Ci0gICAgZm9yIChzaXplX3QgaSA9IDA7IGkgPCBzaXplOyArK2kpCi0gICAgICAg IGZhc3RGcmVlKG1fZnJlZWFibGVQb29sc1tpXSk7Ci19Ci0KIFBhcnNlckFyZW5hOjp+UGFyc2Vy QXJlbmEoKQogewotICAgIGRlYWxsb2NhdGVPYmplY3RzKCk7Ci19Ci0KLXZvaWQgUGFyc2VyQXJl bmE6OnJlc2V0KCkKLXsKLSAgICAvLyBTaW5jZSB0aGlzIGNvZGUgcGF0aCBpcyB1c2VkIG9ubHkg d2hlbiBwYXJzaW5nIGZhaWxzLCBpdCdzIG5vdCBib3RoZXJpbmcgdG8gcmV1c2UKLSAgICAvLyBh bnkgb2YgdGhlIG1lbW9yeSB0aGUgYXJlbmEgYWxsb2NhdGVkLiBXZSBjb3VsZCBpbXByb3ZlIHRo YXQgbGF0ZXIgaWYgd2Ugd2FudCB0bwotICAgIC8vIGVmZmljaWVudGx5IHJldXNlIHRoZSBzYW1l IGFyZW5hLgotCi0gICAgZGVhbGxvY2F0ZU9iamVjdHMoKTsKLQotICAgIG1fZnJlZWFibGVNZW1v cnkgPSAwOwotICAgIG1fZnJlZWFibGVQb29sRW5kID0gMDsKLSAgICBpZiAobV9pZGVudGlmaWVy QXJlbmEpCi0gICAgICAgIG1faWRlbnRpZmllckFyZW5hLT5jbGVhcigpOwotICAgIG1fZnJlZWFi bGVQb29scy5jbGVhcigpOwotICAgIG1fZGVsZXRhYmxlT2JqZWN0cy5jbGVhcigpOwotfQotCi12 b2lkIFBhcnNlckFyZW5hOjphbGxvY2F0ZUZyZWVhYmxlUG9vbCgpCi17Ci0gICAgaWYgKG1fZnJl ZWFibGVQb29sRW5kKQotICAgICAgICBtX2ZyZWVhYmxlUG9vbHMuYXBwZW5kKGZyZWVhYmxlUG9v bCgpKTsKKyAgICBmb3IgKGF1dG8qIG9iamVjdCA6IG1fZGVsZXRhYmxlT2JqZWN0cykgeworICAg ICAgICBvYmplY3QtPn5QYXJzZXJBcmVuYURlbGV0YWJsZSgpOworICAgICAgICBmYXN0RnJlZShv YmplY3QpOworICAgIH0KIAotICAgIGNoYXIqIHBvb2wgPSBzdGF0aWNfY2FzdDxjaGFyKj4oZmFz dE1hbGxvYyhmcmVlYWJsZVBvb2xTaXplKSk7Ci0gICAgbV9mcmVlYWJsZU1lbW9yeSA9IHBvb2w7 Ci0gICAgbV9mcmVlYWJsZVBvb2xFbmQgPSBwb29sICsgZnJlZWFibGVQb29sU2l6ZTsKLSAgICBB U1NFUlQoZnJlZWFibGVQb29sKCkgPT0gcG9vbCk7CisgICAgZm9yIChhdXRvKiBvYmplY3QgOiBt X2ZyZWVhYmxlT2JqZWN0cykKKyAgICAgICAgZmFzdEZyZWUob2JqZWN0KTsKIH0KIAogfQpJbmRl eDogU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXJBcmVuYS5oCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFNvdXJjZS9KYXZhU2NyaXB0Q29yZS9wYXJzZXIvUGFyc2VyQXJlbmEuaAkocmV2aXNpb24g MTc2ODQ3KQorKysgU291cmNlL0phdmFTY3JpcHRDb3JlL3BhcnNlci9QYXJzZXJBcmVuYS5oCSh3 b3JraW5nIGNvcHkpCkBAIC0zMyw2ICszMyw3IEBACiBuYW1lc3BhY2UgSlNDIHsKIAogICAgIGNs YXNzIFBhcnNlckFyZW5hRGVsZXRhYmxlOworICAgIGNsYXNzIFBhcnNlckFyZW5hRnJlZWFibGU7 CiAKICAgICBjbGFzcyBJZGVudGlmaWVyQXJlbmEgewogICAgICAgICBXVEZfTUFLRV9GQVNUX0FM TE9DQVRFRDsKQEAgLTEyMywzNSArMTI0LDI1IEBAIG5hbWVzcGFjZSBKU0MgewogCiAgICAgICAg IHZvaWQgc3dhcChQYXJzZXJBcmVuYSYgb3RoZXJBcmVuYSkKICAgICAgICAgewotICAgICAgICAg ICAgc3RkOjpzd2FwKG1fZnJlZWFibGVNZW1vcnksIG90aGVyQXJlbmEubV9mcmVlYWJsZU1lbW9y eSk7Ci0gICAgICAgICAgICBzdGQ6OnN3YXAobV9mcmVlYWJsZVBvb2xFbmQsIG90aGVyQXJlbmEu bV9mcmVlYWJsZVBvb2xFbmQpOwogICAgICAgICAgICAgbV9pZGVudGlmaWVyQXJlbmEuc3dhcChv dGhlckFyZW5hLm1faWRlbnRpZmllckFyZW5hKTsKLSAgICAgICAgICAgIG1fZnJlZWFibGVQb29s cy5zd2FwKG90aGVyQXJlbmEubV9mcmVlYWJsZVBvb2xzKTsKICAgICAgICAgICAgIG1fZGVsZXRh YmxlT2JqZWN0cy5zd2FwKG90aGVyQXJlbmEubV9kZWxldGFibGVPYmplY3RzKTsKKyAgICAgICAg ICAgIG1fZnJlZWFibGVPYmplY3RzLnN3YXAob3RoZXJBcmVuYS5tX2ZyZWVhYmxlT2JqZWN0cyk7 CiAgICAgICAgIH0KIAogICAgICAgICB2b2lkKiBhbGxvY2F0ZUZyZWVhYmxlKHNpemVfdCBzaXpl KQogICAgICAgICB7Ci0gICAgICAgICAgICBBU1NFUlQoc2l6ZSk7Ci0gICAgICAgICAgICBBU1NF UlQoc2l6ZSA8PSBmcmVlYWJsZVBvb2xTaXplKTsKLSAgICAgICAgICAgIHNpemVfdCBhbGlnbmVk U2l6ZSA9IGFsaWduU2l6ZShzaXplKTsKLSAgICAgICAgICAgIEFTU0VSVChhbGlnbmVkU2l6ZSA8 PSBmcmVlYWJsZVBvb2xTaXplKTsKLSAgICAgICAgICAgIGlmIChVTkxJS0VMWShzdGF0aWNfY2Fz dDxzaXplX3Q+KG1fZnJlZWFibGVQb29sRW5kIC0gbV9mcmVlYWJsZU1lbW9yeSkgPCBhbGlnbmVk U2l6ZSkpCi0gICAgICAgICAgICAgICAgYWxsb2NhdGVGcmVlYWJsZVBvb2woKTsKLSAgICAgICAg ICAgIHZvaWQqIGJsb2NrID0gbV9mcmVlYWJsZU1lbW9yeTsKLSAgICAgICAgICAgIG1fZnJlZWFi bGVNZW1vcnkgKz0gYWxpZ25lZFNpemU7Ci0gICAgICAgICAgICByZXR1cm4gYmxvY2s7CisgICAg ICAgICAgICBQYXJzZXJBcmVuYUZyZWVhYmxlKiBmcmVlYWJsZSA9IHN0YXRpY19jYXN0PFBhcnNl ckFyZW5hRnJlZWFibGUqPihmYXN0TWFsbG9jKHNpemUpKTsKKyAgICAgICAgICAgIG1fZnJlZWFi bGVPYmplY3RzLmFwcGVuZChmcmVlYWJsZSk7CisgICAgICAgICAgICByZXR1cm4gZnJlZWFibGU7 CiAgICAgICAgIH0KIAogICAgICAgICB2b2lkKiBhbGxvY2F0ZURlbGV0YWJsZShzaXplX3Qgc2l6 ZSkKICAgICAgICAgewotICAgICAgICAgICAgUGFyc2VyQXJlbmFEZWxldGFibGUqIGRlbGV0YWJs ZSA9IHN0YXRpY19jYXN0PFBhcnNlckFyZW5hRGVsZXRhYmxlKj4oYWxsb2NhdGVGcmVlYWJsZShz aXplKSk7CisgICAgICAgICAgICBQYXJzZXJBcmVuYURlbGV0YWJsZSogZGVsZXRhYmxlID0gc3Rh dGljX2Nhc3Q8UGFyc2VyQXJlbmFEZWxldGFibGUqPihmYXN0TWFsbG9jKHNpemUpKTsKICAgICAg ICAgICAgIG1fZGVsZXRhYmxlT2JqZWN0cy5hcHBlbmQoZGVsZXRhYmxlKTsKICAgICAgICAgICAg IHJldHVybiBkZWxldGFibGU7CiAgICAgICAgIH0KIAotICAgICAgICBKU19FWFBPUlRfUFJJVkFU RSB2b2lkIHJlc2V0KCk7Ci0KICAgICAgICAgSWRlbnRpZmllckFyZW5hJiBpZGVudGlmaWVyQXJl bmEoKQogICAgICAgICB7CiAgICAgICAgICAgICBpZiAoVU5MSUtFTFkgKCFtX2lkZW50aWZpZXJB cmVuYSkpCkBAIC0xNjAsMjMgKzE1MSw5IEBAIG5hbWVzcGFjZSBKU0MgewogICAgICAgICB9CiAK ICAgICBwcml2YXRlOgotICAgICAgICBzdGF0aWMgY29uc3Qgc2l6ZV90IGZyZWVhYmxlUG9vbFNp emUgPSA4MDAwOwotCi0gICAgICAgIHN0YXRpYyBzaXplX3QgYWxpZ25TaXplKHNpemVfdCBzaXpl KQotICAgICAgICB7Ci0gICAgICAgICAgICByZXR1cm4gKHNpemUgKyBzaXplb2YoV1RGOjpBbGxv Y0FsaWdubWVudEludGVnZXIpIC0gMSkgJiB+KHNpemVvZihXVEY6OkFsbG9jQWxpZ25tZW50SW50 ZWdlcikgLSAxKTsKLSAgICAgICAgfQotCi0gICAgICAgIHZvaWQqIGZyZWVhYmxlUG9vbCgpOwot ICAgICAgICB2b2lkIGFsbG9jYXRlRnJlZWFibGVQb29sKCk7Ci0gICAgICAgIHZvaWQgZGVhbGxv Y2F0ZU9iamVjdHMoKTsKLQotICAgICAgICBjaGFyKiBtX2ZyZWVhYmxlTWVtb3J5OwotICAgICAg ICBjaGFyKiBtX2ZyZWVhYmxlUG9vbEVuZDsKLQogICAgICAgICBPd25QdHI8SWRlbnRpZmllckFy ZW5hPiBtX2lkZW50aWZpZXJBcmVuYTsKLSAgICAgICAgVmVjdG9yPHZvaWQqPiBtX2ZyZWVhYmxl UG9vbHM7CiAgICAgICAgIFZlY3RvcjxQYXJzZXJBcmVuYURlbGV0YWJsZSo+IG1fZGVsZXRhYmxl T2JqZWN0czsKKyAgICAgICAgVmVjdG9yPFBhcnNlckFyZW5hRnJlZWFibGUqPiBtX2ZyZWVhYmxl T2JqZWN0czsKICAgICB9OwogCiB9Cg==